@lde/search-api-graphql 0.22.0 → 0.23.1

package/dist/build-schema.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"build-schema.d.ts","sourceRoot":"","sources":["../src/build-schema.ts"],"names":[],"mappings":"AAAA,OAAO,EAWL,aAAa,EAQd,MAAM,SAAS,CAAC;AACjB,OAAO,EAKL,KAAK,YAAY,EAEjB,KAAK,WAAW,EAChB,KAAK,YAAY,EAElB,MAAM,aAAa,CAAC;AAqBrB,OAAO,EAGL,KAAK,aAAa,EACnB,MAAM,eAAe,CAAC;AAGvB,8EAA8E;AAC9E,MAAM,WAAW,aAAa;IAC5B;;sDAEkD;IAClD,QAAQ,CAAC,MAAM,EAAE,YAAY,CAAC;IAC9B,mFAAmF;IACnF,QAAQ,CAAC,cAAc,EAAE,SAAS,MAAM,EAAE,CAAC;IAC3C;;;;;;OAMG;IACH,QAAQ,CAAC,YAAY,CAAC,EAAE,CAAC,KAAK,EAAE,MAAM,EAAE,KAAK,EAAE,OAAO,KAAK,IAAI,CAAC;CACjE;AAED;2EAC2E;AAC3E,MAAM,WAAW,iBAAiB;IAChC;yCACqC;IACrC,QAAQ,CAAC,UAAU,CAAC,EAAE,MAAM,CAAC;IAC7B;uBACmB;IACnB,QAAQ,CAAC,aAAa,CAAC,EAAE,CACvB,KAAK,EAAE,WAAW,EAClB,OAAO,EAAE,aAAa,KACnB,WAAW,CAAC;CAClB;AAED,MAAM,WAAW,yBAAyB;IACxC;;kEAE8D;IAC9D,QAAQ,CAAC,KAAK,CAAC,EAAE,QAAQ,CAAC,MAAM,CAAC,MAAM,EAAE,iBAAiB,CAAC,CAAC,CAAC;IAC7D,+EAA+E;IAC/E,QAAQ,CAAC,aAAa,CAAC,EAAE,aAAa,CAAC;IACvC;;gDAE4C;IAC5C,QAAQ,CAAC,UAAU,CAAC,EAAE,MAAM,CAAC;CAC9B;AAqGD;;;;;;;;;GASG;AACH,wBAAgB,kBAAkB,CAChC,MAAM,EAAE,YAAY,EACpB,OAAO,GAAE,yBAA8B,GACtC,aAAa,CA6uBf;AAED;;;;;GAKG;AACH,wBAAgB,kBAAkB,CAChC,MAAM,EAAE,YAAY,EACpB,OAAO,GAAE,yBAA8B,GACtC,MAAM,CAER"}
+{"version":3,"file":"build-schema.d.ts","sourceRoot":"","sources":["../src/build-schema.ts"],"names":[],"mappings":"AAAA,OAAO,EAWL,aAAa,EAQd,MAAM,SAAS,CAAC;AACjB,OAAO,EAKL,KAAK,YAAY,EAEjB,KAAK,WAAW,EAChB,KAAK,YAAY,EAElB,MAAM,aAAa,CAAC;AAqBrB,OAAO,EAGL,KAAK,aAAa,EACnB,MAAM,eAAe,CAAC;AAGvB,8EAA8E;AAC9E,MAAM,WAAW,aAAa;IAC5B;;sDAEkD;IAClD,QAAQ,CAAC,MAAM,EAAE,YAAY,CAAC;IAC9B,mFAAmF;IACnF,QAAQ,CAAC,cAAc,EAAE,SAAS,MAAM,EAAE,CAAC;IAC3C;;;;;;OAMG;IACH,QAAQ,CAAC,YAAY,CAAC,EAAE,CAAC,KAAK,EAAE,MAAM,EAAE,KAAK,EAAE,OAAO,KAAK,IAAI,CAAC;CACjE;AAED;2EAC2E;AAC3E,MAAM,WAAW,iBAAiB;IAChC;yCACqC;IACrC,QAAQ,CAAC,UAAU,CAAC,EAAE,MAAM,CAAC;IAC7B;uBACmB;IACnB,QAAQ,CAAC,aAAa,CAAC,EAAE,CACvB,KAAK,EAAE,WAAW,EAClB,OAAO,EAAE,aAAa,KACnB,WAAW,CAAC;CAClB;AAED,MAAM,WAAW,yBAAyB;IACxC;;kEAE8D;IAC9D,QAAQ,CAAC,KAAK,CAAC,EAAE,QAAQ,CAAC,MAAM,CAAC,MAAM,EAAE,iBAAiB,CAAC,CAAC,CAAC;IAC7D,+EAA+E;IAC/E,QAAQ,CAAC,aAAa,CAAC,EAAE,aAAa,CAAC;IACvC;;gDAE4C;IAC5C,QAAQ,CAAC,UAAU,CAAC,EAAE,MAAM,CAAC;CAC9B;AA4GD;;;;;;;;;GASG;AACH,wBAAgB,kBAAkB,CAChC,MAAM,EAAE,YAAY,EACpB,OAAO,GAAE,yBAA8B,GACtC,aAAa,CAsxBf;AAED;;;;;GAKG;AACH,wBAAgB,kBAAkB,CAChC,MAAM,EAAE,YAAY,EACpB,OAAO,GAAE,yBAA8B,GACtC,MAAM,CAER"}

package/dist/build-schema.js

@@ -15,21 +15,28 @@ const scalarOutput = (scalar, field) => field.required === true ? new GraphQLNon
  * distinguishable. Consequence for consumers: a variable must be declared
  * `[IRI!]`, not `[String!]`, because GraphQL checks variable usage nominally.
  *
- * **Input coercion validates; output serialization does not.** Rejecting a bare
- * token on the way in is what turns `where: { material: { in: ["boerenbont"] } }`
- * from a silent empty result into an error saying why – the same job
- * `argsToQuery` already does for an out-of-range `perPage`.
+ * **It validates in both directions.** Rejecting a bare token on the way in is
+ * what turns `where: { material: { in: ["boerenbont"] } }` from a silent empty
+ * result into an error saying why – the same job `argsToQuery` already does for
+ * an out-of-range `perPage`. Outbound matters for the same reason: a type
+ * enforced in one direction only is not one a consumer can rely on, and the
+ * coarse discovery strategy reads `IRI` as the promise that a value is a
+ * selection key.
  *
- * It validates on the way **out** too, and deliberately: a type that is enforced
- * in one direction only is not a type a consumer can rely on, and the coarse
- * discovery strategy reads `IRI` as the promise that a value is a selection key.
- * Serving a non-IRI under it would make the promise false exactly where a
- * consumer acts on it. The projection applies the same rule at the source, so
- * the only way to reach this error is an index written before it existed – which
- * a reindex fixes, and which failing names instead of hiding.
+ * **Where a bad value is dropped rather than raised.** Raising is right where
+ * the value IS the document’s identity (`id`, a reference’s `id`): such a
+ * document cannot be selected, so serving it would hand back something
+ * unusable. It is wrong for a facet bucket – `value: IRI!` sits inside a chain
+ * of non-nulls up to the root field, so raising there nulls the WHOLE response
+ * and discards `items`, which is precisely what facet-batch.ts’s degradation
+ * contract forbids a supplementary sidebar count from doing. The facet
+ * resolvers therefore filter unselectable buckets out instead.
  *
  * What counts as an IRI is {@link isAbsoluteIri} – shared with the projection,
- * so the surface cannot promise something the index contradicts.
+ * which applies it on every route a reference value can take (graph path,
+ * `derive`, `from`, `transform`), so the surface cannot promise something the
+ * index contradicts and the outbound error is reachable only from an index
+ * written before that rule existed.
  */
 const iriScalar = new GraphQLScalarType({
     name: 'IRI',
@@ -133,7 +140,7 @@ export function buildGraphQLSchema(schema, options = {}) {
     // that selects it, with no `String`-to-`IRI` boundary in between – the
     // contract BooleanBucket already keeps for `is`.
     const iriBucket = new GraphQLObjectType({
-        name: 'IriBucket',
+        name: 'IRIBucket',
         fields: valueBucketFields(iriScalar),
     });
     // A numeric range-facet bin: half-open `[min, max)` bounds (max null on an
@@ -254,7 +261,28 @@ export function buildGraphQLSchema(schema, options = {}) {
     // collide: searchSchema resolves its typeName to a declared Reference Type
     // and rejects duplicate names schema-wide.
     const referenceTypes = new Map();
-    const takenTypeNames = new Set(rootTypeNames);
+    // Seeded with the shared types every schema carries, not just the root type
+    // names: a declaration is free to name a type `IRI` or `ValueBucket`, and
+    // without this it would pass both collision checks and fail at
+    // `new GraphQLSchema` with graphql-js’s “Schema must contain uniquely named
+    // types” – naming neither the declaration nor the field, which is the opaque
+    // failure these checks exist to replace.
+    const takenTypeNames = new Set([
+        ...rootTypeNames,
+        iriScalar.name,
+        keywordFilter.name,
+        iriFilter.name,
+        languageString.name,
+        valueBucket.name,
+        iriBucket.name,
+        rangeBucket.name,
+        booleanBucket.name,
+        paginationType.name,
+        sortDirection.name,
+        intRange.name,
+        floatRange.name,
+        dateRange.name,
+    ]);
     /** The label key each id-plus-label reference type was registered with; no
      *  entry for a surfaced inline one, which carries fields instead of a label. */
     const labelKeys = new Map();
@@ -611,7 +639,7 @@ export function buildGraphQLSchema(schema, options = {}) {
         });
         // Keyed facets object: one field per facetable field, typed by its kind
         // (range fields → [RangeBucket!], boolean fields → [BooleanBucket!],
-        // reference fields → [IriBucket!], else [ValueBucket!]). Only the selected
+        // reference fields → [IRIBucket!], else [ValueBucket!]). Only the selected
         // fields are resolved (GraphQL prunes the rest), so the selection IS the
         // request; how they are computed – skip-own-filter, batched into one
         // engine dispatch – lives in facet-batch.ts.
@@ -705,12 +733,28 @@ export function buildGraphQLSchema(schema, options = {}) {
             fields: () => {
                 const fields = {};
                 for (const field of facetable) {
+                    const bucketType = bucketTypeFor(field);
                     fields[field.name] = {
-                        type: nonNullListOf(bucketTypeFor(field)),
+                        type: nonNullListOf(bucketType),
                         // The skip-own-filter query building, the batching into one
                         // engine dispatch and the degrade-to-[] error handling all live
                         // in the loader (facet-batch.ts).
-                        resolve: (source) => source.loadFacet(field.name),
+                        resolve: async (source) => {
+                            const buckets = await source.loadFacet(field.name);
+                            if (bucketType !== iriBucket) {
+                                return buckets;
+                            }
+                            // A bucket keyed on something that is not an IRI is not a
+                            // selection key – it cannot be sent back as the filter that
+                            // selects it – so it is dropped rather than served under `IRI`.
+                            // Dropping, not throwing: `value: IRI!` sits inside a chain of
+                            // non-nulls up to the root field, so a raising coercion here
+                            // would null the WHOLE response and take `items` with it, which
+                            // is exactly what facet-batch.ts’s degradation contract forbids
+                            // a supplementary sidebar count from doing.
+                            return buckets.filter((bucket) => typeof bucket.value === 'string' &&
+                                isAbsoluteIri(bucket.value));
+                        },
                     };
                 }
                 return fields;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lde/search-api-graphql",
-  "version": "0.22.0",
+  "version": "0.23.1",
   "description": "Engine- and domain-agnostic GraphQL surface for @lde/search: builds an executable GraphQLSchema from a whole SearchSchema at runtime (no codegen) – one root query field per SearchType – served by generic resolvers over any SearchEngine – and serves it as a framework-agnostic fetch handler with a self-contained playground, SDL endpoint, CORS and depth/cost limits. You supply the schema and per-type typeNames; it names neither your domain nor your engine.",
   "repository": {
     "url": "git+https://github.com/ldelements/lde.git",
@@ -37,7 +37,7 @@
     "@escape.tech/graphql-armor-cost-limit": "^2.4.3",
     "@escape.tech/graphql-armor-max-depth": "^2.4.2",
     "@graphql-yoga/render-graphiql": "^5.21.2",
-    "@lde/search": "^0.20.0",
+    "@lde/search": "^0.21.1",
     "commander": "^15.0.0",
     "dataloader": "^2.2.3",
     "graphql": "^16.9.0",