@lcv-ideas-software/cross-review 4.2.4 → 4.3.0

package/dist/src/core/config.d.ts

@@ -1,5 +1,5 @@
 import type { AppConfig, PeerId } from "./types.js";
-export declare const VERSION = "4.2.4";
+export declare const VERSION = "4.3.0";
 export declare const RELEASE_DATE = "2026-06-05";
 export declare const DEFAULT_MAX_OUTPUT_TOKENS = 20000;
 export declare function getLastFileConfigResult(): import("./file-config.js").ApplyFileConfigResult | undefined;

package/dist/src/core/config.js

@@ -17,7 +17,7 @@ function expandHome(rawPath) {
     }
     return rawPath;
 }
-export const VERSION = "4.2.4";
+export const VERSION = "4.3.0";
 export const RELEASE_DATE = "2026-06-05";
 export const DEFAULT_MAX_OUTPUT_TOKENS = 20_000;
 const COST_RATE_ENV_PREFIX = {

package/dist/src/core/orchestrator.js

@@ -7,7 +7,7 @@ import { missingFinancialControlVars, RELEASE_DATE } from "./config.js";
 import { checkConvergence, isSkippableFailure } from "./convergence.js";
 import { estimateCacheSavings } from "./cost.js";
 import { assertLeadPeerNotCaller, resolveLeadPeer } from "./relator-lottery.js";
-import { sessionReportMarkdown } from "./reports.js";
+import { sessionReportMarkdown, unresolvedEvidenceItems } from "./reports.js";
 import { SessionStore } from "./session-store.js";
 import { decisionQualityFromStatus } from "./status.js";
 import { PEERS } from "./types.js";
@@ -323,6 +323,14 @@ const FABRICATED_ASSERTION_PATTERNS = [
     { pattern: /cargo\s+test\b/g, label: "cargo_test_assertion" },
     { pattern: /npm\s+run\s+(?:build|test|typecheck)\b/g, label: "npm_run_assertion" },
     { pattern: /index\s+[a-f0-9]{6,}\.{2}[a-f0-9]{6,}/g, label: "git_diff_index_hash" },
+    {
+        pattern: /\b[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}\b/gi,
+        label: "session_id_reference",
+    },
+    {
+        pattern: /https:\/\/github\.com\/[^\s)\]}>"']+/gi,
+        label: "github_url_reference",
+    },
     {
         pattern: /\b(?:workflow\s+(?:launched|started|dispatched|created)|(?:launched|started|dispatched)\s+(?:a\s+)?workflow)\b/gi,
         label: "workflow_dispatch_claim",
@@ -588,7 +596,9 @@ export function truthfulnessPreflight(params) {
     const pass = contradictions.length === 0 && unsupportedClaims.length === 0;
     const detail = [...contradictions, ...unsupportedClaims].join("; ");
     const evidenceState = `attachments_present=${params.attachmentsPresent}; ` +
-        `structured_evidence_supplied=${structuredEvidenceSupplied}`;
+        `structured_evidence_supplied=${structuredEvidenceSupplied}; ` +
+        `source_marker_found=${sourceMarkerFound}; ` +
+        `runtime_facts_available=${runtimeFactsAvailable}`;
     const remediation = "attach raw snapshot evidence with session_attach_evidence or pass a structured evidence field, then retry the truthfulness preflight";
     return {
         pass,
@@ -632,7 +642,7 @@ function leadShipModeDirective() {
         // relator is free to synthesize ANALYSIS (interpretation, design
         // rationale, prose) but MUST refuse to invent operational facts.
         "## Evidence Provenance Lock (HARD)",
-        "Operational evidence — git SHAs, content hashes, build outputs, test counts (e.g. `147 passed`), diff hunks, `git diff --check passed` style assertions, vite asset filenames with hex suffixes, `cargo test`/`npm run build`/`npm run typecheck` result lines, `git rev-parse HEAD` output, timestamps, file paths — has a PROVENANCE level. Two levels exist:",
+        "Operational evidence — git SHAs, content hashes, build outputs, test counts (e.g. `147 passed`), diff hunks, `git diff --check passed` style assertions, vite asset filenames with hex suffixes, `cargo test`/`npm run build`/`npm run typecheck` result lines, `git rev-parse HEAD` output, session IDs, GitHub URLs, timestamps, file paths — has a PROVENANCE level. Two levels exist:",
         "  - PROVENANCE-GRADE: raw command/tool output persisted via `session_attach_evidence` (visible to you below as `## Attached Evidence`), or a verbatim file slice with explicit path:line refs.",
         "  - NARRATIVE: the caller's natural-language summary in the task or in a prior draft (e.g. `I ran cargo test, 147 passed`).",
         "NARRATIVE is NOT evidence. The caller's claim that a command produced a specific result is unverified until the raw output is attached. You MUST NOT quote NARRATIVE operational claims as if they were verified evidence. You MAY summarize that the caller claims X; you MUST NOT assert that X happened.",
@@ -2635,7 +2645,32 @@ export class CrossReviewOrchestrator {
         let updated = this.store.read(session.session_id);
         if (convergence.converged) {
             this.store.saveFinal(session.session_id, input.draft);
-            updated = await this.store.finalize(session.session_id, "converged", convergence.recovery_converged ? "recovered_unanimity" : "unanimous_ready");
+            const unresolvedEvidence = unresolvedEvidenceItems(updated);
+            const baseReason = convergence.recovery_converged ? "recovered_unanimity" : "unanimous_ready";
+            const outcomeReason = unresolvedEvidence.length > 0 ? `${baseReason}_with_unresolved_evidence` : baseReason;
+            if (unresolvedEvidence.length > 0) {
+                this.emit({
+                    type: "session.evidence_checklist_unresolved_on_finalize",
+                    session_id: session.session_id,
+                    round: round.round,
+                    message: `${unresolvedEvidence.length} unresolved evidence item(s) remain at convergence; finalizing with explicit unresolved-evidence reason.`,
+                    data: {
+                        outcome_reason: outcomeReason,
+                        unresolved_count: unresolvedEvidence.length,
+                        open_count: unresolvedEvidence.filter((item) => (item.status ?? "open") === "open")
+                            .length,
+                        not_resurfaced_count: unresolvedEvidence.filter((item) => item.status === "not_resurfaced").length,
+                        items: unresolvedEvidence.slice(0, 20).map((item) => ({
+                            id: item.id,
+                            peer: item.peer,
+                            status: item.status ?? "open",
+                            ask: item.ask,
+                            round_count: item.round_count,
+                        })),
+                    },
+                });
+            }
+            updated = await this.store.finalize(session.session_id, "converged", outcomeReason);
         }
         this.store.saveReport(session.session_id, sessionReportMarkdown(this.store.read(session.session_id), this.store.readEvents(session.session_id)));
         this.emit({