@lcv-ideas-software/cross-review 4.0.3 → 4.0.4

package/CHANGELOG.md

@@ -7,7 +7,40 @@ standard `v00.00.00`; npm package versions remain SemVer.
 
 ## [Unreleased]
 
-## [v04.00.03] — 2026-05-15
+## [v04.00.04] — 2026-05-15
+
+**Patch — restore prettier coverage of `src/` and `scripts/` (close audit
+finding on v4.0.3 hard-gate gap).** The v4.0.3 ship added biome but also
+moved `src/**/*.ts`, `src/**/*.js`, `scripts/**/*.ts`, `scripts/**/*.js`
+into `.prettierignore` to dodge a biome↔prettier disagreement on the
+dynamic-import call-style. Net effect: prettier ran against zero JS/TS
+under `src/` and `scripts/`, silently turning one of the four hard-gate
+checks into a no-op there. v4.0.4 restores full prettier coverage and
+keeps both formatters green simultaneously.
+
+### Changed
+
+- `.prettierignore` no longer excludes `src/**/*.ts`, `src/**/*.js`,
+  `scripts/**/*.ts`, `scripts/**/*.js`. Prettier and biome now both
+  check the full JS/TS surface.
+- `scripts/smoke.ts` — the 7 dynamic-import sites that triggered the
+  biome↔prettier wrap disagreement were rewritten from the
+  destructure-from-call form to a 2-statement form (`const mod = await
+import("..."); const { A, B, C } = mod;`). Functionally identical;
+  static type inference preserved because the import argument remains a
+  string literal in 6 of 7 sites and a template literal in 1.
+
+### Why a 2-statement refactor instead of a config tweak
+
+Biome 2.x and Prettier 3.x disagree on where to wrap when
+`const { ... } = await import("...")` exceeds `lineWidth`/`printWidth`:
+prettier breaks after `=`, biome breaks inside the call parens. Neither
+tool exposes a per-rule config knob for this specific case. Aligning
+`lineWidth` (already 100 in both) doesn't help because the disagreement
+is about which axis to break on, not the threshold. Refactoring to a
+form short enough to keep on one line each removes the disagreement at
+the source — durable across future biome/prettier releases without
+relying on tool-internal heuristics matching.
 
 **Patch — biome integration to satisfy the 4-gate quality directive
 (operator 2026-05-15: eslint + biome + prettier + cross-review).** The

package/README.md

@@ -21,7 +21,7 @@ npm install -g @lcv-ideas-software/cross-review
 npm install -g @lcv-ideas-software/cross-review --registry=https://npm.pkg.github.com
 ```
 
-**Status.** Stable. Current release: **v04.00.00** (npm package `4.0.0`). See
+**Status.** Stable. Current release: **v04.00.04** (npm package `4.0.4`). See
 [CHANGELOG.md](./CHANGELOG.md) for the release history.
 
 > **Project renamed 2026-05-15.** This project was previously published as
@@ -36,6 +36,7 @@ The version history at a glance:
 
 | Release | Scope |
 |---|---|
+| **`v04.00.04`** | **Patch — restore prettier coverage of `src/` and `scripts/` (close audit on v4.0.3 hard-gate gap).** v4.0.3 added biome but also moved `src/**/*.ts`, `src/**/*.js`, `scripts/**/*.ts`, `scripts/**/*.js` into `.prettierignore` to dodge a biome↔prettier disagreement on dynamic-import call-style. Net effect: prettier ran against zero JS/TS under `src/`/`scripts/`, silently turning one of the four hard-gate checks into a no-op there. v4.0.4 restores full coverage and resolves the disagreement at the source — the 7 `scripts/smoke.ts` dynamic-import sites that triggered the wrap conflict were rewritten from destructure-from-call form to a 2-statement form (`const mod = await import("..."); const { A, B, C } = mod;`). Functionally identical; static type inference preserved. Both formatters now check the full JS/TS surface and pass simultaneously. |
 | **`v04.00.00`** | **Major — project renamed to `cross-review`** (drops the `-v2` suffix after the companion `cross-review-v1` project was discontinued and archived 2026-05-15). Breaking: npm package `@lcv-ideas-software/cross-review-v2` → `@lcv-ideas-software/cross-review` (old name stays on npm at `3.7.5` for historical installs); binaries `cross-review-v2` / `cross-review-v2-dashboard` → `cross-review` / `cross-review-dashboard`; env-var prefix `CROSS_REVIEW_V2_*` → `CROSS_REVIEW_*` across all config knobs that previously carried the `V2` infix (e.g. `CROSS_REVIEW_DATA_DIR`, `CROSS_REVIEW_DISABLE_CACHE_ANTHROPIC`); API-key env vars unchanged; per-host identity env vars (`CROSS_REVIEW_CALLER_TOKEN`, `CROSS_REVIEW_REQUIRE_TOKEN`) unchanged. GitHub repo URL: `LCV-Ideas-Software/cross-review-v2` → `LCV-Ideas-Software/cross-review` (auto-redirected). GitHub Pages: `cross-review-v2.lcv.dev` → `cross-review.lcv.dev`. MCP server key in host configs: operators who declared `cross-review-v2` rename to `cross-review`; after reload, MCP tool prefix becomes `mcp__cross-review__*`. Data dir migration is manual: operators copy `${HOME}/.cross-review/data_v2/*` into the new default `${HOME}/.cross-review/data/` (or set `CROSS_REVIEW_DATA_DIR` to the legacy path) — the v4.0.0 runtime reads only `CROSS_REVIEW_DATA_DIR` and does not fall back to the `_v2` suffix automatically. Preserved when copied: persisted session data, `config.json`, `host-tokens.json`, `cache_manifest.json`, archived/corrupt session dirs. Wire shape of all MCP tools, event types, convergence semantics is unchanged; all capabilities, peers, models, security defenses carry over from v3.7.5 verbatim. 504 source/script/doc text substitutions across 26 files. |
 | **`v03.07.05`** | **Patch — logs+sessions study 2026-05-15 close-out (4 surgical fixes from 244-session/429-round corpus).** **A1** — `session_doctor` classified cancelled sessions as `stale` (22 of 244 false positives); doctor now treats any terminal outcome (`aborted`/`converged`/`max-rounds`) as NOT-stale regardless of the persisted `convergence_health.state`. Source-layer state untouched (backward-compat with existing sessions). **A2** — `lockCallerPeerSelection` emitted false-positive `session.caller_peer_selection_ignored` events when callers passed a panel identical to the enabled set (13 of 106 recent events); the lock now accepts an optional `enabledPeers` snapshot in its context and short-circuits the emit when the caller-supplied list set-equals the enabled set (sorted comparison). **A3** — per-provider cache disable env vars (`CROSS_REVIEW_DISABLE_CACHE_ANTHROPIC|OPENAI|GEMINI|DEEPSEEK|GROK|PERPLEXITY`; provider names match v2.21.0 `_CACHE_TTL_*` convention; same parsing as `peer_enabled`); Anthropic default flipped to disabled based on empirical 0.3% hit-rate ($1.18 wasted to save $0.0035 over 244 sessions). Global `CROSS_REVIEW_DISABLE_CACHE` kill-switch unchanged; per-provider is an additive layer. Anthropic adapter `buildSystemBlock` + short-prefix warning gated on the per-provider flag; central `config.json` `cache` block accepts the new disable keys. **B1** — `session_sweep` gains opt-in `prune_corrupt: boolean.default(false)` + `corrupt_min_age_days: number.int.default(30)` to clean `<data_dir>/corrupt_sessions/` (no prior automated cleanup; 1 stale entry from 2026-05-08 v2.25.1 redact bug still on disk at study time). New `store.pruneCorruptSessions(minAgeMs)` returns `{scanned, removed, kept}`. Response shape stays `SessionMeta[]` when `prune_corrupt: false` (default); wraps to `{ swept, pruned_corrupt }` when true. **Patch bump** (3.7.4 → 3.7.5). |
 | **`v03.07.04`** | **Patch — Codex v3.7.3 parecer close-out + two cross-review-gate root-cause fixes** (APROVADO-COM-RESSALVAS; 2 parecer findings + 2 operator-directed fixes; no public-surface or tool-schema change). **`model_match` `-latest`-alias false positive (operator-directed)** — `BasePeerAdapter.modelMatches()` matched the reported model with `reported === requested` or `reported.startsWith(`${requested}-`)`. That works for a base id resolving to a dated id (`gpt-5.5` → `gpt-5.5-2026-04-23`) but FAILS for a `-latest` alias: xAI returns `grok-4-0709` for the pinned `grok-4-latest`, which does not start with the literal `grok-4-latest-`. Every grok response was flagged `model_match: false` → `status` forced `null` → `silent_model_downgrade` rejection → format-recovery skipped, so grok was dead-on-arrival in every cross-review session and no panel including grok could reach unanimity. Fix: `modelMatches` strips a `-latest` suffix to the family stem and matches the reported id against it (`grok-4-latest` → `grok-4` → `grok-4-0709` matches); a genuine cross-family downgrade (`grok-3-*`) is still flagged. New smoke marker `model_match_latest_alias_test`. **`detectFabricatedEvidence` false positive (operator-directed)** — the detector validated operational assertions (`npm run build`, `index <hash>..<hash>`, `cargo test`, …) against the `provenanceCorpus` (attached evidence) ONLY; the prior draft was lumped into `narrativeCorpus` and never consulted for assertions. The documented process REQUIRES embedding the verbatim diff + raw gate output in `initial_draft`, so when R1 didn't converge and a relator generated an R2 revision, the relator faithfully PRESERVING that embedded evidence was flagged as "fabricating" it → `lead_fabrication_repeated` abort (misread as "perplexity keeps fabricating"; in fact it hit any relator and was a detector self-contradiction). Fix: a **three-tier corpus** — `FabricationDetectionCorpus` gains a `priorDraftCorpus` field; operational assertions are flagged only when **net-new** vs `{provenanceCorpus ∪ priorDraftCorpus}` (symmetric with the hex-token check). Preserved evidence is not fabrication; the task `narrativeCorpus` stays excluded so the v2.24.0 eee886d3 protection holds exactly. Signature unchanged; interface gains one field. **AUDIT-1 (MEDIUM)** — `scripts/runtime-smoke.ts` injected cost rate cards for only 4 peers (codex/claude/gemini/deepseek), but the public MCP path strips a caller's `peers` list (the v3.3.0 `lockCallerPeerSelection` lock), so every round runs the full 6-peer panel; grok + perplexity had no rate cards → `missingFinancialControlVars` tripped → the round finalized `outcome=max-rounds`/`financial_controls_missing` while runtime-smoke still printed `ok: true` with no assert. Fix: inject grok + perplexity rate cards (+ `CROSS_REVIEW_PERPLEXITY_DISABLE_SEARCH` and per-size request-fee defaults), and add explicit `assert` calls on every async flow's durable terminal `outcome` (review round + unanimity flow → `converged`, cancellation flow → `aborted`) placed before the `ok: true` print so a non-converging round fails the smoke loudly. **AUDIT-2 (LOW)** — `src/core/convergence.ts` comment imprecision: the skip was framed only as "the user declared no fallback models", but `fallback_exhausted` is in the skippable set and arises AFTER a declared fallback chain is drained; both comment blocks now split the skip into its two paths (no fallback declared → retry-same exhausted → skip; fallback declared, tried, and drained → also skip). Comment-only, zero logic change. New smoke marker `runtime_smoke_outcome_assert_test` + 2 new `relator_evidence_provenance_lock_test` cases source-pin the fixes. **Patch bump** (3.7.3 → 3.7.4). |

package/dist/scripts/smoke.js

@@ -1165,7 +1165,8 @@ assert.equal(Object.hasOwn(metrics.decision_quality, "undefined"), false);
 // (c) does NOT scan the accumulated buffer per delta — the contract is
 // `append measures only delta`.
 {
-    const { StreamBuffer, StreamBufferOverflowError, STREAM_TEXT_MAX_BYTES } = await import("../src/peers/base.js");
+    const baseMod = await import("../src/peers/base.js");
+    const { StreamBuffer, StreamBufferOverflowError, STREAM_TEXT_MAX_BYTES } = baseMod;
     const buffer = new StreamBuffer("smoke-peer");
     buffer.append("hello world");
     assert.equal(buffer.text(), "hello world");
@@ -2530,7 +2531,8 @@ assert.equal(Object.hasOwn(metrics.decision_quality, "undefined"), false);
 // Chamada explícita com caller=claude e lead_peer=claude DEVE lançar
 // CallerCannotBeLeadPeerError. Sem fallback silencioso pra sorteio.
 {
-    const { assertLeadPeerNotCaller, CallerCannotBeLeadPeerError } = await import("../src/core/relator-lottery.js");
+    const lotteryMod1 = await import("../src/core/relator-lottery.js");
+    const { assertLeadPeerNotCaller, CallerCannotBeLeadPeerError } = lotteryMod1;
     let threw = false;
     try {
         assertLeadPeerNotCaller("claude", "claude");
@@ -2598,7 +2600,8 @@ assert.equal(Object.hasOwn(metrics.decision_quality, "undefined"), false);
 // (não PEERS global). Sem isso, caller=claude com peers=["codex","gemini"]
 // poderia atribuir deepseek (não-participante) como lead_peer.
 {
-    const { assignRelator, resolveLeadPeer, LeadPeerNotInSessionError } = await import("../src/core/relator-lottery.js");
+    const lotteryMod2 = await import("../src/core/relator-lottery.js");
+    const { assignRelator, resolveLeadPeer, LeadPeerNotInSessionError } = lotteryMod2;
     // (1) Subset com 2 peers + caller=claude → assigned ∈ subset.
     for (let i = 0; i < 50; i++) {
         const a = assignRelator("claude", ["codex", "gemini"]);
@@ -3677,7 +3680,8 @@ assert.equal(Object.hasOwn(metrics.decision_quality, "undefined"), false);
 // none/low/medium/high). Other Grok models (per xAI docs) reject the
 // param OR auto-apply reasoning internally, so we omit it.
 {
-    const { modelAcceptsReasoningEffort, GROK_REASONING_EFFORT_MODELS } = await import("../src/peers/grok.js");
+    const grokMod = await import("../src/peers/grok.js");
+    const { modelAcceptsReasoningEffort, GROK_REASONING_EFFORT_MODELS } = grokMod;
     // Allowlist contract: grok-4.20-multi-agent + grok-4.3.
     assert.equal(modelAcceptsReasoningEffort("grok-4.20-multi-agent"), true);
     assert.equal(modelAcceptsReasoningEffort("grok-4.3"), true);
@@ -4771,7 +4775,8 @@ assert.equal(Object.hasOwn(metrics.decision_quality, "undefined"), false);
     assert.ok(!/CROSS_REVIEW_EVIDENCE_JUDGE_MAX_ITEMS_PER_PASS\s*\?\?\s*"8"/.test(configSrc), 'v2.18.5 / P1.4: legacy `?? "8"` default is gone (would silently double the worst-case judge call budget)');
     // (4) Behavioral: loadConfig() with env unset returns max_items_per_pass = 4.
     delete process.env.CROSS_REVIEW_EVIDENCE_JUDGE_MAX_ITEMS_PER_PASS;
-    const { loadConfig: loadConfigFresh } = await import(`../src/core/config.js?max_items_4=${Date.now()}`);
+    const freshConfigMod = await import(`../src/core/config.js?max_items_4=${Date.now()}`);
+    const { loadConfig: loadConfigFresh } = freshConfigMod;
     const cfg4 = loadConfigFresh();
     assert.equal(cfg4.evidence_judge_autowire.max_items_per_pass, 4, `v2.18.5 / P1.4: loadConfig() with env unset returns max_items_per_pass=4 (got ${cfg4.evidence_judge_autowire.max_items_per_pass})`);
     console.log("[smoke] max_items_per_pass_default_anti_drift_test: PASS");
@@ -4855,7 +4860,8 @@ assert.equal(Object.hasOwn(metrics.decision_quality, "undefined"), false);
 // the new prompt caching surface. Pure-function tests (no API keys
 // required); they pin the structural invariants the runtime depends on.
 {
-    const { buildPromptParts, hashStablePrefix, assertHashInvariant, pairScopedCacheKey } = await import("../src/core/prompt-parts.js");
+    const promptPartsMod = await import("../src/core/prompt-parts.js");
+    const { buildPromptParts, hashStablePrefix, assertHashInvariant, pairScopedCacheKey } = promptPartsMod;
     const baseInput = {
         cacheSchemaVersion: "v1",
         systemRole: "You are a peer reviewer.",
@@ -4903,7 +4909,8 @@ assert.equal(Object.hasOwn(metrics.decision_quality, "undefined"), false);
     console.log("[smoke] cache_rates_no_runtime_import_test: PASS");
     // (4) cache_manifest_atomic_write_test — write + multiple appends
     //     preserve every entry.
-    const { writeCacheManifest, appendCacheManifestEntry, readCacheManifest } = await import("../src/core/cache-manifest.js");
+    const cacheManifestMod = await import("../src/core/cache-manifest.js");
+    const { writeCacheManifest, appendCacheManifestEntry, readCacheManifest } = cacheManifestMod;
     const manifestSession = "550e8400-e29b-41d4-a716-446655440099";
     const manifestData = {
         session_id: manifestSession,