@lchase/yak 0.4.0 → 0.4.1

package/dist/index.js

@@ -488,6 +488,7 @@ async function validateWorkflow(workflow, cwd = process.cwd(), runIsolation = "n
   checkReservedArtifactNames(flatSteps);
   checkNeedsSatisfied(workflow.steps, producerOf);
   checkNoCycles(workflow.steps, producerOf);
+  checkExprArtifactIdentifiers(workflow.steps, producerOf);
   checkExitCodeReads(workflow.steps, producerOf);
   checkAgentToolNames(flatSteps);
   await checkAgentSchemaKeys(flatSteps, cwd);
@@ -621,6 +622,42 @@ function checkNoCycles(steps, producerOf) {
   }
   for (const step of steps) visit(step, []);
 }
+var JEXL_IDENTIFIER = /^[A-Za-z_$][A-Za-z0-9_$]*$/;
+function checkExprArtifactIdentifiers(steps, producerOf) {
+  for (const step of steps) {
+    if (step.skipIf !== void 0) checkExprRefs(step.id, "skipIf", step.skipIf, producerOf);
+    if (step.kind === "loop") {
+      const localProducerOf = new Map([...producerOf, ...buildProducerMap(step.body)]);
+      checkExprRefs(step.id, "until", step.until, localProducerOf);
+      if (step.budget.noProgress) {
+        checkExprRefs(step.id, "noProgress.signal", step.budget.noProgress.signal, localProducerOf);
+      }
+      checkExprArtifactIdentifiers(step.body, localProducerOf);
+    }
+    if (step.kind === "map") checkExprArtifactIdentifiers([step.step], producerOf);
+  }
+}
+function checkExprRefs(stepId, field, expr, producerOf) {
+  if (typeof expr !== "string") return;
+  for (const name of producerOf.keys()) {
+    if (JEXL_IDENTIFIER.test(name)) continue;
+    const bounded = new RegExp(`(?<![A-Za-z0-9_$])${escapeRegExp(name)}(?![A-Za-z0-9_$])`);
+    if (!bounded.test(expr)) continue;
+    throw new WorkflowValidationError(
+      `step "${stepId}": ${field} references artifact "${name}", but "${name}" is not a valid jexl identifier \u2014 jexl reads it as an expression ("a-b" parses as "a minus b"), not a name, so the artifact is invisible to ${field}. Rename it to an identifier (e.g. "${toIdentifier(name)}").`
+    );
+  }
+}
+function escapeRegExp(s) {
+  return s.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
+}
+function toIdentifier(name) {
+  const camel = name.replace(
+    /[^A-Za-z0-9]+([A-Za-z0-9])?/g,
+    (_, c) => c ? c.toUpperCase() : ""
+  );
+  return JEXL_IDENTIFIER.test(camel) ? camel : `a${camel}`;
+}
 function checkExitCodeReads(steps, producerOf) {
   const stepsById = new Map(steps.map((s) => [s.id, s]));
   for (const step of steps) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lchase/yak",
-  "version": "0.4.0",
+  "version": "0.4.1",
   "description": "An agentic workflow engine",
   "license": "MIT",
   "type": "module",