@lblod/ember-rdfa-editor-lblod-plugins 37.0.2 → 37.0.3-dev.062a3f92528e0db450aaa51853197759650d85ed

package/.changeset/hot-ducks-sniff.md

@@ -0,0 +1,5 @@
+---
+'@lblod/ember-rdfa-editor-lblod-plugins': patch
+---
+
+Fetch document content before passing it up on the document template component in order to solve race condition on GN

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @lblod/ember-rdfa-editor-lblod-plugins
 
+## 37.0.3
+
+### Patch Changes
+
+- [`edc47f2`](https://github.com/lblod/ember-rdfa-editor-lblod-plugins/commit/edc47f296f8a525bde907a88d047de49441c37da) Thanks [@abeforgit](https://github.com/abeforgit)! - Fix location command signature, again
+
 ## 37.0.2
 
 ### Patch Changes

package/addon/components/common/documents/preview.gts

@@ -14,6 +14,7 @@ import t from 'ember-intl/helpers/t';
 import { SayController } from '@lblod/ember-rdfa-editor';
 import { PreviewableDocument } from './types';
 import { VoteStarUnfilledIcon } from '../vote-star-unfilled-icon';
+import perform from 'ember-concurrency/helpers/perform';
 
 interface Signature<Doc extends PreviewableDocument> {
   Args: {
@@ -31,10 +32,10 @@ export default class DocumentPreview<
   @tracked controller?: SayController;
   @tracked isExpanded = false;
 
-  @action
-  onInsert() {
+  onInsert = task(async () => {
+    await this.contentTask.perform();
     this.args.onInsert(this.args.doc);
-  }
+  });
 
   @action
   togglePreview() {
@@ -101,7 +102,7 @@ export default class DocumentPreview<
         <div
           role='button'
           title={{t 'common.preview-list.select-button.title'}}
-          {{on 'click' this.onInsert}}
+          {{on 'click' (perform this.onInsert)}}
           {{! template-lint-disable require-presentational-children}}
         >
           <AuButton class='snippet-preview__insert-button' @skin='naked'>

package/addon/plugins/location-plugin/index.ts

@@ -4,6 +4,7 @@ import {
   EditorState,
   EditorView,
   Transaction,
+  Command,
 } from '@lblod/ember-rdfa-editor';
 import { LocationType } from '@lblod/ember-rdfa-editor-lblod-plugins/components/location-plugin/map';
 
@@ -44,11 +45,8 @@ export function openLocationModal(
   view.dispatch(tr);
 }
 
-export function openLocationModalCommand(locationType: LocationType) {
-  return function (
-    state: EditorState,
-    dispatch?: (tr: Transaction) => boolean,
-  ) {
+export function openLocationModalCommand(locationType: LocationType): Command {
+  return function (state, dispatch) {
     if (!dispatch) {
       return false;
     }

package/declarations/addon/components/common/documents/preview.d.ts

@@ -13,7 +13,7 @@ interface Signature<Doc extends PreviewableDocument> {
 export default class DocumentPreview<Doc extends PreviewableDocument> extends Component<Signature<Doc>> {
     controller?: SayController;
     isExpanded: boolean;
-    onInsert(): void;
+    onInsert: import("ember-concurrency").TaskForAsyncTaskFunction<unknown, () => Promise<void>>;
     togglePreview(): void;
     get isFavourite(): boolean | undefined;
     toggleFavourite: (event: MouseEvent) => void;

package/declarations/addon/plugins/location-plugin/contextual-actions/index.d.ts

@@ -3,7 +3,7 @@ import { LocationType } from '@lblod/ember-rdfa-editor-lblod-plugins/components/
 export declare function getContextualActions(): (state: EditorState, searchQuery?: string) => {
     id: string;
     group: string;
-    command: (state: EditorState, dispatch?: (tr: import("@lblod/ember-rdfa-editor").Transaction) => boolean) => boolean;
+    command: import("@lblod/ember-rdfa-editor").Command;
     label: string;
     locationType: LocationType;
     icon: string;

package/declarations/addon/plugins/location-plugin/index.d.ts

@@ -1,4 +1,4 @@
-import { ProsePlugin, PluginKey, EditorState, EditorView, Transaction } from '@lblod/ember-rdfa-editor';
+import { ProsePlugin, PluginKey, EditorState, EditorView, Command } from '@lblod/ember-rdfa-editor';
 import { LocationType } from '@lblod/ember-rdfa-editor-lblod-plugins/components/location-plugin/map';
 type PluginState = {
     modalOpen: boolean;
@@ -7,7 +7,7 @@ type PluginState = {
 export declare const locationModalsPluginKey: PluginKey<PluginState>;
 export declare function closeLocationModal(view: EditorView): void;
 export declare function openLocationModal(view: EditorView, locationType?: LocationType): void;
-export declare function openLocationModalCommand(locationType: LocationType): (state: EditorState, dispatch?: (tr: Transaction) => boolean) => boolean;
+export declare function openLocationModalCommand(locationType: LocationType): Command;
 export declare function locationModalsPlugin(): ProsePlugin<PluginState>;
 export declare function getLocationModalsPluginState(state: EditorState): PluginState | undefined;
 export {};

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lblod/ember-rdfa-editor-lblod-plugins",
-  "version": "37.0.2",
+  "version": "37.0.3-dev.062a3f92528e0db450aaa51853197759650d85ed",
   "description": "Ember addon providing lblod specific plugins for the ember-rdfa-editor",
   "keywords": [
     "ember-addon",