@lblod/ember-rdfa-editor-lblod-plugins 26.3.1 → 26.4.0-dev.ae426a2acd3ec657d4380017c754b70741a26e95

package/.changeset/pretty-bags-occur.md

@@ -0,0 +1,5 @@
+---
+'@lblod/ember-rdfa-editor-lblod-plugins': patch
+---
+
+Fix dutch translation of location-plugin insert button

package/.changeset/tough-queens-hide.md

@@ -0,0 +1,5 @@
+---
+'@lblod/ember-rdfa-editor-lblod-plugins': patch
+---
+
+Removed the need of specify the type in the citaten plugin config

package/CHANGELOG.md

@@ -1,5 +1,21 @@
 # @lblod/ember-rdfa-editor-lblod-plugins
 
+## 26.4.0
+
+### Minor Changes
+
+- [#528](https://github.com/lblod/ember-rdfa-editor-lblod-plugins/pull/528) [`0a70aed`](https://github.com/lblod/ember-rdfa-editor-lblod-plugins/commit/0a70aedf1d656d7bf85b0c528317f6bbcac62f37) Thanks [@piemonkey](https://github.com/piemonkey)! - Add support for Ember 5.4+
+
+- [#528](https://github.com/lblod/ember-rdfa-editor-lblod-plugins/pull/528) [`b7f426f`](https://github.com/lblod/ember-rdfa-editor-lblod-plugins/commit/b7f426f3bd174320ee2a4963d1f103d6ab60459f) Thanks [@piemonkey](https://github.com/piemonkey)! - Update test-app to use ember-source 5.12
+
+### Patch Changes
+
+- [#525](https://github.com/lblod/ember-rdfa-editor-lblod-plugins/pull/525) [`f7eb06c`](https://github.com/lblod/ember-rdfa-editor-lblod-plugins/commit/f7eb06c3e134f2b044c6ee73f3652cefc2e7d286) Thanks [@lagartoverde](https://github.com/lagartoverde)! - Convert snippet plugin to use uri instead of id
+
+- [#528](https://github.com/lblod/ember-rdfa-editor-lblod-plugins/pull/528) [`7373171`](https://github.com/lblod/ember-rdfa-editor-lblod-plugins/commit/73731715f3ebf2dc949ca361e80e935a85534a9b) Thanks [@piemonkey](https://github.com/piemonkey)! - Add support for ember-concurrency 4 and ember-power-select 8
+
+- [#530](https://github.com/lblod/ember-rdfa-editor-lblod-plugins/pull/530) [`3bf983c`](https://github.com/lblod/ember-rdfa-editor-lblod-plugins/commit/3bf983cc910dfe96a88a669f6da2861bf5891bc2) Thanks [@elpoelma](https://github.com/elpoelma)! - Move to builtin ember.js types
+
 ## 26.3.1
 
 ### Patch Changes

package/README.md

@@ -326,7 +326,6 @@ Make `this.citationPlugin` a tracked reference to the plugin created with the fu
   import { citationPlugin } from '@lblod/ember-rdfa-editor-lblod-plugins/plugins/citation-plugin';
 
   @tracked citationPlugin = citationPlugin({
-    type: 'nodes',
     activeInNodeTypes(schema) {
       return new Set([schema.nodes.motivering]);
     },
@@ -335,10 +334,10 @@ Make `this.citationPlugin` a tracked reference to the plugin created with the fu
 
 Configuration:
 
-- type (optional): it can either be 'nodes', or 'ranges'
-  * if 'nodes' is selected, you are expected to pass the `activeInNode` function. It's a function which expects an instance of a prosemirror node and returns whether it should be active in that node. The previously expected `activeInNodeTypes` is marked as deprecated and will be removed in a future release.
-  * if 'ranges' is selected, you are expected to pass the `activeInRanges` function. It's a function that gets the state of the actual instance of the editor and returns an array of ranges for the plugin to be active in, for example `[[0,50], [70,100]]`
-  * if no type is provided, the citation plugin will be activated document-wide
+- You are expected to set one of two functions
+  * `activeInNode` function. It's a function which expects an instance of a prosemirror node and returns whether it should be active in that node.
+  * `activeInRanges` function. It's a function that gets the state of the actual instance of the editor and returns an array of ranges for the plugin to be active in, for example `[[0,50], [70,100]]`.
+  * If no function is provided, the citation plugin will be activated document-wide, if both are provided, it will use the range function first and then narrow it down using the node functions given the ranges but this is not encouraged.
 
 - regex: you can provide your custom regex to detect citations, if not the default one will be used
 
@@ -348,14 +347,12 @@ A common usecase is to have the plugin active in the entire document. Here's how
 import { citationPlugin } from '@lblod/ember-rdfa-editor-lblod-plugins/plugins/citation-plugin';
 
 const configA = {
-  type: 'nodes',
   activeInNode(node, state) {
     return node.type === state.schema.nodes.doc;
   },
 };
 
 const configB = {
-  type: 'ranges',
   activeInRanges(state) {
     // a node's nodeSize follows the Prosemirror definition
     // a non-leaf node's size is the sum of its children's sizes + 2

package/addon/components/citation-plugin/citation-card.hbs

@@ -78,10 +78,9 @@
     </c.content>
     <c.footer class='au-u-background-gray-100 au-u-padding-none'>
       {{#if this.legalDocumentsResource.isRunning}}
-        <AuLoader />
-        <span class='au-u-hidden-visually'>{{t
+        <AuLoader @hideMessage={{true}}>{{t
             'citaten-plugin.alert.loading'
-          }}</span>
+          }}</AuLoader>
       {{else}}
         {{#if this.error}}
           <Common::Search::AlertLoadError

package/addon/components/citation-plugin/citation-insert.ts

@@ -64,35 +64,43 @@ export default class EditorPluginsCitationInsertComponent extends Component<Args
     }
     const { selection } = this.controller.mainEditorState;
     const config = this.config;
-    if (!('type' in config)) {
-      // Enable plugin document wide
-      return false;
-    }
-    if (config.type === 'ranges') {
+    if (config.activeInRanges) {
+      let activeInRange;
       const ranges = config.activeInRanges(this.controller.mainEditorState);
       for (const range of ranges) {
         if (selection.from > range[0] && selection.from < range[1]) {
-          return false;
+          activeInRange = true;
         }
       }
-      return true;
-    } else {
-      let condition: (node: PNode) => boolean;
-      if ('activeInNodeTypes' in config) {
-        const nodeTypes = config.activeInNodeTypes(
-          this.controller.schema,
-          this.controller.mainEditorState,
-        );
-        condition = (node) => nodeTypes.has(node.type);
-      } else {
-        condition = (node) =>
-          config.activeInNode(node, this.controller.mainEditorState);
-      }
+      if (!activeInRange) return true;
+    }
+    let condition: ((node: PNode) => boolean) | undefined;
+    const { activeInNode, activeInNodeTypes } = config;
+    if (activeInNodeTypes && activeInNode) {
+      const nodeTypes = activeInNodeTypes(
+        this.controller.schema,
+        this.controller.mainEditorState,
+      );
+      condition = (node) =>
+        nodeTypes.has(node.type) &&
+        activeInNode(node, this.controller.mainEditorState);
+    } else if (activeInNodeTypes) {
+      const nodeTypes = activeInNodeTypes(
+        this.controller.schema,
+        this.controller.mainEditorState,
+      );
+      condition = (node) => nodeTypes.has(node.type);
+    } else if (activeInNode) {
+      condition = (node) => activeInNode(node, this.controller.mainEditorState);
+    }
 
+    if (condition) {
       if (condition(this.controller.mainEditorState.doc)) {
         return false;
       }
       return !findParentNode(condition)(selection);
+    } else {
+      return false;
     }
   }
 

package/addon/components/citation-plugin/citations/legal-document-detail.hbs

@@ -61,7 +61,9 @@
     <div>
       {{#if this.articleResource.isRunning}}
         <div class='au-o-box'>
-          <AuLoader @padding='large' />
+          <AuLoader @hideMessage={{true}}>{{t
+              'common.search.loading'
+            }}</AuLoader>
           <span class='au-u-hidden-visually'>{{t
               'citaten-plugin.alert.loading'
             }}</span>

package/addon/components/location-plugin/edit.gts

@@ -6,7 +6,6 @@ import { trackedReset } from 'tracked-toolbox';
 import { trackedTask } from 'reactiveweb/ember-concurrency';
 import { service } from '@ember/service';
 import { on } from '@ember/modifier';
-import type { SafeString } from '@ember/template/-private/handlebars';
 import not from 'ember-truth-helpers/helpers/not';
 import eq from 'ember-truth-helpers/helpers/eq';
 import IntlService from 'ember-intl/services/intl';
@@ -35,6 +34,7 @@ import {
 import { type Point } from '@lblod/ember-rdfa-editor-lblod-plugins/plugins/location-plugin/utils/geo-helpers';
 import { type NodeContentsUtils } from '@lblod/ember-rdfa-editor-lblod-plugins/plugins/location-plugin/node-contents';
 import { type LocationType } from './map';
+import { type SafeString } from '@ember/template';
 
 interface Message {
   skin: AuAlertSignature['Args']['skin'];

package/addon/components/location-plugin/insert.gts

@@ -245,12 +245,12 @@ export default class LocationPluginInsertComponent extends Component<Signature>
       });
     }
     if (toInsert) {
+      this.modalOpen = false;
       replaceSelectionWithLocation(
         this.controller,
         toInsert,
         this.args.config.subjectTypesToLinkTo,
       );
-      this.modalOpen = false;
     }
   }
 

package/addon/components/location-plugin/map.gts

@@ -283,7 +283,7 @@ export default class LocationPluginMapComponent extends Component<Signature> {
           {{#each this.vertices as |vertex index|}}
             <layers.marker
               @location={{vertex}}
-              @onClick={{(fn this.onVertexClick index)}}
+              @onClick={{fn this.onVertexClick index}}
               as |marker|
             >
               {{#if (eq index 0)}}
@@ -300,7 +300,7 @@ export default class LocationPluginMapComponent extends Component<Signature> {
         {{/if}}
         {{#if (areaLocations @locationType @existingArea)}}
           <layers.polygon
-            @locations={{(areaLocations @locationType @existingArea)}}
+            @locations={{areaLocations @locationType @existingArea}}
           />
         {{/if}}
       </MapWrapper>

package/addon/components/roadsign-regulation-plugin/roadsigns-table.hbs

@@ -21,8 +21,9 @@
         {{#if @isLoading}}
           <tr>
             <td colspan='100%' class='is-loading-data'>
-              <AuLoader />
-              <AuHelpText>{{t 'editor-plugins.utils.loading'}}</AuHelpText>
+              <AuLoader>
+                {{t 'editor-plugins.utils.loading'}}
+              </AuLoader>
             </td>
           </tr>
         {{else}}

package/addon/components/snippet-plugin/nodes/snippet.gts

@@ -32,7 +32,7 @@ import { recalculateNumbers } from '@lblod/ember-rdfa-editor-lblod-plugins/plugi
 import { createSnippetPlaceholder } from '@lblod/ember-rdfa-editor-lblod-plugins/plugins/snippet-plugin/nodes/snippet-placeholder';
 import { hasDecendant } from '@lblod/ember-rdfa-editor-lblod-plugins/utils/has-descendant';
 import SnippetPlaceholder from '@lblod/ember-rdfa-editor-lblod-plugins/components/snippet-plugin/nodes/placeholder';
-import { getSnippetListIdsFromNode } from '@lblod/ember-rdfa-editor-lblod-plugins/plugins/snippet-plugin/utils/rdfa-predicate';
+import { getSnippetListUrisFromNode } from '@lblod/ember-rdfa-editor-lblod-plugins/plugins/snippet-plugin/utils/rdfa-predicate';
 
 interface ButtonSig {
   Args: {
@@ -129,7 +129,7 @@ export default class SnippetNode extends Component<Signature> {
         const node = createSnippetPlaceholder({
           listProperties: {
             placeholderId: this.node.attrs.placeholderId,
-            listIds: getSnippetListIdsFromNode(this.node),
+            listUris: getSnippetListUrisFromNode(this.node),
             names: this.node.attrs.snippetListNames,
             importedResources: this.node.attrs.importedResources,
           },
@@ -200,7 +200,7 @@ export default class SnippetNode extends Component<Signature> {
         title,
         listProperties: {
           placeholderId: this.node.attrs.placeholderId,
-          listIds: getSnippetListIdsFromNode(this.node),
+          listUris: getSnippetListUrisFromNode(this.node),
           names: this.node.attrs.snippetListNames,
           importedResources: this.node.attrs.importedResources,
         },
@@ -259,7 +259,7 @@ export default class SnippetNode extends Component<Signature> {
       @closeModal={{this.closeModal}}
       @config={{this.node.attrs.config}}
       @onInsert={{this.onInsert}}
-      @snippetListIds={{getSnippetListIdsFromNode this.node}}
+      @snippetListUris={{getSnippetListUrisFromNode this.node}}
       @snippetListNames={{this.node.attrs.snippetListNames}}
     />
   </template>

package/addon/components/snippet-plugin/search-modal.ts

@@ -11,7 +11,7 @@ import { SnippetPluginConfig } from '@lblod/ember-rdfa-editor-lblod-plugins/plug
 
 interface Args {
   config: SnippetPluginConfig;
-  snippetListIds: string[] | undefined;
+  snippetListUris: string[] | undefined;
   snippetListNames: string[] | undefined;
   closeModal: () => void;
   open: boolean;
@@ -69,7 +69,7 @@ export default class SnippetPluginSearchModalComponent extends Component<Args> {
         abortSignal: abortController.signal,
         filter: {
           name: this.inputSearchText ?? undefined,
-          snippetListIds: this.args.snippetListIds ?? undefined,
+          snippetListUris: this.args.snippetListUris ?? undefined,
         },
         pagination: {
           pageNumber: this.pageNumber,
@@ -92,7 +92,7 @@ export default class SnippetPluginSearchModalComponent extends Component<Args> {
     this.inputSearchText,
     this.pageNumber,
     this.pageSize,
-    this.args.snippetListIds,
+    this.args.snippetListUris,
   ]);
 
   @action

package/addon/components/snippet-plugin/snippet-insert-placeholder.gts

@@ -64,7 +64,7 @@ export default class SnippetPluginSnippetInsertPlaceholder extends Component<Sig
         @icon={{AddIcon}}
         @iconAlignment='left'
         @skin='link'
-        @disabled={{(not this.placeholderNode)}}
+        @disabled={{not this.placeholderNode}}
         {{on 'click' this.openModal}}
       >
         {{t 'snippet-plugin.insert.placeholder'}}
@@ -72,7 +72,7 @@ export default class SnippetPluginSnippetInsertPlaceholder extends Component<Sig
     </li>
     <SnippetListModal
       @config={{@config}}
-      @snippetListIds={{empty}}
+      @snippetListUris={{empty}}
       @allowMultipleSnippets={{false}}
       @onSaveSnippetLists={{this.insertPlaceholder}}
       @open={{this.isModalOpen}}

package/addon/components/snippet-plugin/snippet-insert-rdfa.gts

@@ -7,7 +7,7 @@ import {
   type SnippetPluginConfig,
 } from '@lblod/ember-rdfa-editor-lblod-plugins/plugins/snippet-plugin';
 import { findParentNodeClosestToPos } from '@curvenote/prosemirror-utils';
-import { getSnippetListIdsFromNode } from '@lblod/ember-rdfa-editor-lblod-plugins/plugins/snippet-plugin/utils/rdfa-predicate';
+import { getSnippetListUrisFromNode } from '@lblod/ember-rdfa-editor-lblod-plugins/plugins/snippet-plugin/utils/rdfa-predicate';
 import { ResolvedPNode } from '@lblod/ember-rdfa-editor/utils/_private/types';
 import SnippetInsert from './snippet-insert';
 
@@ -22,11 +22,11 @@ interface Sig {
 export default class SnippetInsertRdfaComponent extends Component<Sig> {
   get listProperties(): SnippetListProperties | undefined {
     const activeNode = this.args.node.value;
-    const listIds = getSnippetListIdsFromNode(activeNode);
+    const listUris = getSnippetListUrisFromNode(activeNode);
 
-    if (listIds.length > 0) {
+    if (listUris.length > 0) {
       return {
-        listIds,
+        listUris,
         placeholderId: activeNode.attrs.placeholderId,
         names: activeNode.attrs.snippetListNames,
         importedResources: activeNode.attrs.importedResources,
@@ -44,11 +44,11 @@ export default class SnippetInsertRdfaComponent extends Component<Sig> {
       isResourceNode(node),
     );
     while (parentNode) {
-      const listIds = getSnippetListIdsFromNode(parentNode.node);
+      const listUris = getSnippetListUrisFromNode(parentNode.node);
 
-      if (listIds.length > 0) {
+      if (listUris.length > 0) {
         return {
-          listIds,
+          listUris,
           placeholderId: parentNode.node.attrs.placeholderId,
           names: parentNode.node.attrs.snippetListNames,
           importedResources: parentNode.node.attrs.importedResources,

package/addon/components/snippet-plugin/snippet-insert.gts

@@ -31,7 +31,7 @@ export default class SnippetInsertComponent extends Component<Sig> {
     return this.args.controller;
   }
   get disabled() {
-    return (this.args.listProperties?.listIds.length ?? 0) === 0;
+    return (this.args.listProperties?.listUris.length ?? 0) === 0;
   }
 
   @action
@@ -88,7 +88,7 @@ export default class SnippetInsertComponent extends Component<Sig> {
       @closeModal={{this.closeModal}}
       @config={{@config}}
       @onInsert={{this.onInsert}}
-      @snippetListIds={{@listProperties.listIds}}
+      @snippetListUris={{@listProperties.listUris}}
       @snippetListNames={{@listProperties.names}}
     />
   </template>

package/addon/components/snippet-plugin/snippet-list/snippet-list-modal.hbs

@@ -19,7 +19,7 @@
           {{else}}
             <SnippetPlugin::SnippetList::SnippetListView
               @snippetLists={{this.snippetListResource.value}}
-              @snippetListIds={{this.snippetListIds}}
+              @snippetListUris={{this.snippetListUris}}
               @listNameFilter={{this.nameFilterText}}
               @sort={{this.sort}}
               @onChange={{this.onChange}}

package/addon/components/snippet-plugin/snippet-list/snippet-list-modal.ts

@@ -23,7 +23,7 @@ interface Signature {
       lists: SnippetList[],
       allowMultipleSnippets: boolean,
     ) => void;
-    snippetListIds: string[] | undefined;
+    snippetListUris: string[] | undefined;
     closeModal: () => void;
     open: boolean;
     allowMultipleSnippets?: boolean;
@@ -40,8 +40,8 @@ export default class SnippetListModalComponent extends Component<Signature> {
   // Display
   @tracked error: unknown;
 
-  @trackedReset('args.snippetListIds')
-  snippetListIds: string[] = [...(this.args.snippetListIds ?? [])];
+  @trackedReset('args.snippetListUris')
+  snippetListUris: string[] = [...(this.args.snippetListUris ?? [])];
 
   @localCopy('args.allowMultipleSnippets') allowMultipleSnippets = false;
 
@@ -63,7 +63,7 @@ export default class SnippetListModalComponent extends Component<Signature> {
   @action
   saveAndClose() {
     const snippetLists = this.snippetListResource.value?.filter((snippetList) =>
-      this.snippetListIds.includes(snippetList.id),
+      this.snippetListUris.includes(snippetList.uri),
     );
     this.args.onSaveSnippetLists(
       snippetLists || [],
@@ -71,7 +71,7 @@ export default class SnippetListModalComponent extends Component<Signature> {
     );
     this.args.closeModal();
     // Clear selection for next time
-    this.snippetListIds = [];
+    this.snippetListUris = [];
   }
 
   snippetListSearch = restartableTask(async () => {
@@ -105,7 +105,7 @@ export default class SnippetListModalComponent extends Component<Signature> {
   );
 
   @action
-  onChange(snippetListIds: string[]) {
-    this.snippetListIds = snippetListIds;
+  onChange(snippetListUris: string[]) {
+    this.snippetListUris = snippetListUris;
   }
 }

package/addon/components/snippet-plugin/snippet-list/snippet-list-view.hbs

@@ -52,8 +52,8 @@
           <td class='snippet-list-table-select-column'>
             <AuCheckbox
               id={{row.label}}
-              @onChange={{fn this.onChange row.id}}
-              @checked={{in-array @snippetListIds row.id}}
+              @onChange={{fn this.onChange row.uri}}
+              @checked={{in-array @snippetListUris row.uri}}
             />
           </td>
           <td>{{row.label}}</td>

package/addon/components/snippet-plugin/snippet-list/snippet-list-view.ts

@@ -4,26 +4,26 @@ import { SnippetList } from '@lblod/ember-rdfa-editor-lblod-plugins/plugins/snip
 
 interface Args {
   snippetLists: SnippetList[];
-  snippetListIds: string[];
+  snippetListUris: string[];
   listNameFilter: string | null;
   isLoading: boolean;
-  onChange: (snippetListIds: string[]) => void;
+  onChange: (snippetListUris: string[]) => void;
 }
 
 export default class SnippetListViewComponent extends Component<Args> {
   @action
-  onChange(snippetId: string, isSelected: boolean) {
+  onChange(snippetUri: string, isSelected: boolean) {
     if (isSelected) {
-      const newSnippetListIds = [...this.args.snippetListIds, snippetId];
+      const newSnippetListUris = [...this.args.snippetListUris, snippetUri];
 
-      return this.args.onChange(newSnippetListIds);
+      return this.args.onChange(newSnippetListUris);
     }
 
-    const newSnippetListIds = this.args.snippetListIds.filter(
-      (id) => id !== snippetId,
+    const newSnippetListUris = this.args.snippetListUris.filter(
+      (uri) => uri !== snippetUri,
     );
 
-    return this.args.onChange(newSnippetListIds);
+    return this.args.onChange(newSnippetListUris);
   }
 
   @action
@@ -40,15 +40,15 @@ export default class SnippetListViewComponent extends Component<Args> {
       return;
     }
 
-    const snippetListId = snippetList.id;
+    const snippetListUri = snippetList.uri;
 
-    if (!snippetListId) {
+    if (!snippetListUri) {
       return;
     }
 
-    const isSelected = this.args.snippetListIds.includes(snippetListId);
+    const isSelected = this.args.snippetListUris.includes(snippetListUri);
 
-    this.onChange(snippetListId, !isSelected);
+    this.onChange(snippetListUri, !isSelected);
   }
 
   get snippetLists() {

package/addon/components/snippet-plugin/snippet-list-select.gts

@@ -16,8 +16,8 @@ import {
   type SnippetList,
 } from '@lblod/ember-rdfa-editor-lblod-plugins/plugins/snippet-plugin';
 import {
-  getAssignedSnippetListsIdsFromProperties,
-  getSnippetListIdsProperties,
+  getAssignedSnippetListsUrisFromProperties,
+  getSnippetListUrisProperties,
 } from '@lblod/ember-rdfa-editor-lblod-plugins/plugins/snippet-plugin/utils/rdfa-predicate';
 import { updateSnippetPlaceholder } from '@lblod/ember-rdfa-editor-lblod-plugins/plugins/snippet-plugin/commands';
 
@@ -49,13 +49,13 @@ export default class SnippetListSelect extends Component<Signature> {
     return isResourceNode(this.args.node.value);
   }
 
-  get snippetListIdsProperties(): OutgoingTriple[] {
-    return getSnippetListIdsProperties(this.args.node.value);
+  get snippetListUrisProperties(): OutgoingTriple[] {
+    return getSnippetListUrisProperties(this.args.node.value);
   }
 
-  get snippetListIds(): string[] {
-    return getAssignedSnippetListsIdsFromProperties(
-      this.snippetListIdsProperties,
+  get snippetListUris(): string[] {
+    return getAssignedSnippetListsUrisFromProperties(
+      this.snippetListUrisProperties,
     );
   }
 
@@ -73,7 +73,7 @@ export default class SnippetListSelect extends Component<Signature> {
       this.args.controller?.doCommand(
         updateSnippetPlaceholder({
           resource: this.currentResource,
-          oldSnippetProperties: this.snippetListIdsProperties ?? [],
+          oldSnippetProperties: this.snippetListUrisProperties ?? [],
           newSnippetLists: lists,
           oldImportedResources: this.imported,
           node: this.args.node,
@@ -99,7 +99,7 @@ export default class SnippetListSelect extends Component<Signature> {
 
       <SnippetListModal
         @config={{@config}}
-        @snippetListIds={{this.snippetListIds}}
+        @snippetListUris={{this.snippetListUris}}
         @onSaveSnippetLists={{this.onSaveSnippetLists}}
         @allowMultipleSnippets={{this.allowMultipleSnippets}}
         @open={{this.showModal}}

package/addon/components/table-of-contents-plugin/ember-nodes/outline.hbs

@@ -6,7 +6,7 @@
         {{! template-lint-disable no-capital-arguments }}
         @block={{true}}
         @skin='link-secondary'
-        onclick={{(fn @onEntryClick outlineEntry.pos)}}
+        onclick={{fn @onEntryClick outlineEntry.pos}}
       >
         {{outlineEntry.content}}
       </AuButton>

package/addon/components/variable-plugin/date/date-time-picker.ts

@@ -34,7 +34,6 @@ export default class DateTimePickerComponent extends Component<Args> {
       monthSelectLabel: this.intl.t('au-date-picker.month-select-label'),
       yearSelectLabel: this.intl.t('au-date-picker.year-select-label'),
       closeLabel: this.intl.t('au-date-picker.close-label'),
-      keyboardInstruction: this.intl.t('au-date-picker.keyboard-instruction'),
       calendarHeading: this.intl.t('au-date-picker.calendar-heading'),
       dayNames: getLocalizedDays(this.intl),
       monthNames: getLocalizedMonths(this.intl),