@lblod/ember-rdfa-editor-lblod-plugins 22.2.1 → 22.2.2-dev.2311682f4b02518af23dda3885b2e2aeedc5c9e8

package/.changeset/cold-schools-heal.md

@@ -0,0 +1,5 @@
+---
+'@lblod/ember-rdfa-editor-lblod-plugins': patch
+---
+
+Remove constraint on mandatee table insertion. Mandatee table can now be inserted everywhere in a document.

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # @lblod/ember-rdfa-editor-lblod-plugins
 
+## 22.2.2
+
+### Patch Changes
+
+- [#465](https://github.com/lblod/ember-rdfa-editor-lblod-plugins/pull/465) [`83b95db`](https://github.com/lblod/ember-rdfa-editor-lblod-plugins/commit/83b95db9991f6b5ef090cd77765d8c09eac90db7) Thanks [@lagartoverde](https://github.com/lagartoverde)! - Correctly export empty person nodes
+
+- [#465](https://github.com/lblod/ember-rdfa-editor-lblod-plugins/pull/465) [`be233e8`](https://github.com/lblod/ember-rdfa-editor-lblod-plugins/commit/be233e8bc70aee1db00644ad6f956157da8d3a20) Thanks [@lagartoverde](https://github.com/lagartoverde)! - Correctly export empty person node
+
 ## 22.2.1
 
 ### Patch Changes

package/addon/components/mandatee-table-plugin/insert.gts

@@ -3,8 +3,6 @@ import { AddIcon } from '@appuniversum/ember-appuniversum/components/icons/add';
 import { on } from '@ember/modifier';
 import Component from '@glimmer/component';
 import { SayController } from '@lblod/ember-rdfa-editor';
-import { not } from 'ember-truth-helpers';
-import { getCurrentBesluitRange } from '@lblod/ember-rdfa-editor-lblod-plugins/plugins/besluit-topic-plugin/utils/helpers';
 import { action } from '@ember/object';
 import { unwrap } from '@lblod/ember-rdfa-editor/utils/_private/option';
 import t from 'ember-intl/helpers/t';
@@ -17,9 +15,6 @@ export default class InsertMandateeTableComponent extends Component<Sig> {
   get controller() {
     return this.args.controller;
   }
-  get decisionRange() {
-    return getCurrentBesluitRange(this.controller);
-  }
 
   @action
   insert() {
@@ -33,10 +28,6 @@ export default class InsertMandateeTableComponent extends Component<Sig> {
     });
   }
 
-  get canInsert() {
-    return Boolean(this.decisionRange);
-  }
-
   <template>
     <li class='au-c-list__item'>
       <AuButton
@@ -44,7 +35,6 @@ export default class InsertMandateeTableComponent extends Component<Sig> {
         @icon={{AddIcon}}
         @iconAlignment='left'
         @skin='link'
-        @disabled={{not this.canInsert}}
       >
         {{t 'mandatee-table-plugin.insert.title'}}
       </AuButton>

package/addon/plugins/variable-plugin/variables/person.ts

@@ -9,6 +9,7 @@ import {
 } from '@lblod/ember-rdfa-editor/utils/ember-node';
 import {
   DOMOutputSpec,
+  EditorState,
   getRdfaAttrs,
   PNode,
   rdfaAttrSpec,
@@ -19,6 +20,11 @@ import type { ComponentLike } from '@glint/template';
 import { hasOutgoingNamedNodeTriple } from '@lblod/ember-rdfa-editor-lblod-plugins/utils/namespace';
 import { renderRdfaAware } from '@lblod/ember-rdfa-editor/core/schema';
 import Mandatee from '@lblod/ember-rdfa-editor-lblod-plugins/models/mandatee';
+import { getTranslationFunction } from '@lblod/ember-rdfa-editor-lblod-plugins/utils/translation';
+
+const TRANSLATION_FALLBACKS = {
+  nodeview_placeholder: 'persoon',
+};
 
 const rdfaAware = true;
 const parseDOM = [
@@ -50,7 +56,8 @@ const parseDOM = [
   },
 ];
 
-const toDOM = (node: PNode): DOMOutputSpec => {
+const serialize = (node: PNode, state: EditorState): DOMOutputSpec => {
+  const t = getTranslationFunction(state);
   const mandatee = node.attrs.mandatee as Mandatee;
   return renderRdfaAware({
     renderable: node,
@@ -59,7 +66,12 @@ const toDOM = (node: PNode): DOMOutputSpec => {
       ...node.attrs,
       'data-mandatee': JSON.stringify(mandatee),
     },
-    content: mandatee ? `${mandatee.fullName}` : '',
+    content: mandatee
+      ? `${mandatee.fullName}`
+      : t(
+          'variable-plugin.person.nodeview-placeholder',
+          TRANSLATION_FALLBACKS.nodeview_placeholder,
+        ),
   });
 };
 
@@ -85,7 +97,7 @@ const emberNodeConfig: EmberNodeConfig = {
       default: null,
     },
   },
-  toDOM,
+  serialize,
   parseDOM,
 };
 

package/declarations/addon/components/mandatee-table-plugin/insert.d.ts

@@ -8,8 +8,6 @@ interface Sig {
 }
 export default class InsertMandateeTableComponent extends Component<Sig> {
     get controller(): SayController;
-    get decisionRange(): import("@lblod/ember-rdfa-editor/plugins/datastore").ElementPNode | undefined;
     insert(): void;
-    get canInsert(): boolean;
 }
 export {};

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lblod/ember-rdfa-editor-lblod-plugins",
-  "version": "22.2.1",
+  "version": "22.2.2-dev.2311682f4b02518af23dda3885b2e2aeedc5c9e8",
   "description": "Ember addon providing lblod specific plugins for the ember-rdfa-editor",
   "keywords": [
     "ember-addon",

package/translations/en-US.yaml

@@ -268,7 +268,7 @@ variable-plugin:
     to: to
   person:
     card-title: Insert person
-    nodeview-placeholder: person
+    nodeview-placeholder: Insert person
 
 table-of-contents-plugin:
   title: Table of Contents

package/translations/nl-BE.yaml

@@ -272,7 +272,7 @@ variable-plugin:
     to: tot
   person:
     card-title: Persoon invoegen
-    nodeview-placeholder: persoon
+    nodeview-placeholder: Voeg persoon in
 dummy:
   validation-card:
     title: Documentvalidatie