@lblod/ember-rdfa-editor-lblod-plugins 18.1.1 → 19.0.0-dev.876c0a65199576300bbc5fa00be3013e6793fcf5

package/.changeset/brown-carpets-cry.md

@@ -0,0 +1,5 @@
+---
+"@lblod/ember-rdfa-editor-lblod-plugins": patch
+---
+
+Styling fixes

package/.changeset/strong-weeks-invent.md

@@ -0,0 +1,5 @@
+---
+"@lblod/ember-rdfa-editor-lblod-plugins": patch
+---
+
+Apply Prettier to the codebase

package/.release-it.json

@@ -10,4 +10,4 @@
     "ignoreVersion": true,
     "allowSameVersion": true
   }
-}
+}

package/.woodpecker/.verify-pr.yml

@@ -16,6 +16,12 @@ steps:
     commands:
       - corepack enable
       - pnpm lint:hbs
+  lint-prettier:
+    image: node:20-slim
+    group: lint
+    commands:
+      - corepack enable
+      - pnpm lint:prettier
   test:
     image: danlynn/ember-cli:4.12.1
     commands:

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # @lblod/ember-rdfa-editor-lblod-plugins
 
+## 19.0.0
+
+### Major Changes
+
+- [`b9f7f56a469a18adbd75951e5ddd2a2f1cda7e45`](https://github.com/lblod/ember-rdfa-editor-lblod-plugins/commit/b9f7f56a469a18adbd75951e5ddd2a2f1cda7e45) Thanks [@abeforgit](https://github.com/abeforgit)! - Use the selectNode argument instead of the helper
+
+  The select-on-click helper was removed in 9.8.0 of the editor, and was arguably never really public API.
+
+  This uses the replacement, a selectNode argument all ember-nodes receive.
+
+  This is breaking cause it restricts the peerdep to at least 9.8.0.
+
 ## 18.1.1
 
 ### Patch Changes

package/addon/components/article-structure-plugin/article-structure-card.hbs

@@ -1,11 +1,16 @@
 {{! @glint-nocheck: not typesafe yet }}
 <div>
   {{#each this.structureTypes as |structureType|}}
-  <li class="au-c-list__item">
-    <AuButton @icon={{this.AddIcon}} @iconAlignment="left" @skin="link" @disabled={{not (this.canInsertStructure structureType)}}
-      {{on 'click' (fn this.insertStructure structureType)}}>
-      {{t structureType.translations.insert}}
-    </AuButton>
-  </li>
+    <li class='au-c-list__item'>
+      <AuButton
+        @icon={{this.AddIcon}}
+        @iconAlignment='left'
+        @skin='link'
+        @disabled={{not (this.canInsertStructure structureType)}}
+        {{on 'click' (fn this.insertStructure structureType)}}
+      >
+        {{t structureType.translations.insert}}
+      </AuButton>
+    </li>
   {{/each}}
 </div>

package/addon/components/article-structure-plugin/structure-card.hbs

@@ -1,28 +1,43 @@
 {{! @glint-nocheck: not typesafe yet }}
 {{#unless this.isOutsideStructure}}
-  <AuCard @flex={{true}} @divided={{true}} @expandable={{false}} @shadow={{true}} @size="flush" as |c|>
-    <c.header class="au-u-hidden-visually">
-      <AuHeading @level="3" @skin="6">{{t "article-structure-plugin.title.structure-card"}}</AuHeading>
+  <AuCard
+    @flex={{true}}
+    @divided={{true}}
+    @expandable={{false}}
+    @shadow={{true}}
+    @size='flush'
+    as |c|
+  >
+    <c.header class='au-u-hidden-visually'>
+      <AuHeading @level='3' @skin='6'>{{t
+          'article-structure-plugin.title.structure-card'
+        }}</AuHeading>
     </c.header>
-    <c.content class="au-c-content--small">
-      <AuList @divider={{true}} class="au-u-padding-top-tiny au-u-padding-bottom-tiny" as |Item|>
+    <c.content class='au-c-content--small'>
+      <AuList
+        @divider={{true}}
+        class='au-u-padding-top-tiny au-u-padding-bottom-tiny'
+        as |Item|
+      >
         <Item>
           <AuButton
             @icon={{this.ChevronUpIcon}}
-            @iconAlignment="left"
-            @skin="link"
+            @iconAlignment='left'
+            @skin='link'
             @disabled={{not this.canMoveUp}}
-            {{on 'click' (fn this.moveStructure 'up')}}>
+            {{on 'click' (fn this.moveStructure 'up')}}
+          >
             {{t this.currentStructureType.translations.move.up}}
           </AuButton>
         </Item>
         <Item>
           <AuButton
             @icon={{this.ChevronDownIcon}}
-            @iconAlignment="left"
-            @skin="link"
+            @iconAlignment='left'
+            @skin='link'
             @disabled={{not this.canMoveDown}}
-            {{on 'click' (fn this.moveStructure 'down')}}>
+            {{on 'click' (fn this.moveStructure 'down')}}
+          >
             {{t this.currentStructureType.translations.move.down}}
           </AuButton>
         </Item>
@@ -32,23 +47,20 @@
               <:hover as |hover|>
                 <AuButton
                   @icon={{this.BinIcon}}
-                  @iconAlignment="left"
-                  @skin="link"
+                  @iconAlignment='left'
+                  @skin='link'
                   @alert={{true}}
                   @disabled={{not this.canRemoveStructure}}
-                  aria-describedby="remove-tooltip"
+                  aria-describedby='remove-tooltip'
                   {{hover.velcroHook}}
                   {{hover.handleHover}}
-                  {{on 'click' (fn this.removeStructure false)}}>
+                  {{on 'click' (fn this.removeStructure false)}}
+                >
                   {{this.remove}}
                 </AuButton>
               </:hover>
               <:tooltip as |tooltip|>
-                <AuPill
-                  id="remove-tooltip"
-                  role="tooltip"
-                  {{tooltip}}
-                >
+                <AuPill id='remove-tooltip' role='tooltip' {{tooltip}}>
                   {{t 'article-structure-plugin.remove.help-text'}}
                 </AuPill>
               </:tooltip>
@@ -57,22 +69,19 @@
               <:hover as |hover|>
                 <AuButton
                   @icon={{this.BinIcon}}
-                  @iconAlignment="left"
-                  @skin="link"
-                  aria-describedby="remove-content-tooltip"
+                  @iconAlignment='left'
+                  @skin='link'
+                  aria-describedby='remove-content-tooltip'
                   @alert={{true}}
                   {{hover.velcroHook}}
                   {{hover.handleHover}}
-                  {{on 'click' (fn this.removeStructure true)}}>
+                  {{on 'click' (fn this.removeStructure true)}}
+                >
                   {{this.removeWithContent}}
                 </AuButton>
               </:hover>
               <:tooltip as |tooltip|>
-                <AuPill
-                  id="remove-content-tooltip"
-                  role="tooltip"
-                  {{tooltip}}
-                >
+                <AuPill id='remove-content-tooltip' role='tooltip' {{tooltip}}>
                   {{t 'article-structure-plugin.remove-with-content.help-text'}}
                 </AuPill>
               </:tooltip>
@@ -81,7 +90,7 @@
           </AuButtonGroup>
         </Item>
         {{#if this.currentStructureType.getStartNumber}}
-          <Item class="au-u-padding-left-small">
+          <Item class='au-u-padding-left-small'>
             <AuFormRow>
               {{#let (unique-id) as |id|}}
                 <AuLabel for={{id}}>
@@ -90,25 +99,27 @@
                 <AuInput
                   id={{id}}
                   value={{this.startNumberInputValue}}
-                  {{on "change" this.onStartNumberChange}}
-                  placeholder={{t 'article-structure-plugin.start-number.start-number'}}
-                  type="number"
-                  min="1"
+                  {{on 'change' this.onStartNumberChange}}
+                  placeholder={{t
+                    'article-structure-plugin.start-number.start-number'
+                  }}
+                  type='number'
+                  min='1'
                 />
               {{/let}}
             </AuFormRow>
             <AuButton
-              @iconAlignment="left"
-              class="au-u-margin-top-tiny"
+              @iconAlignment='left'
+              class='au-u-margin-top-tiny'
               {{on 'click' this.setStructureStartNumber}}
             >
               {{t 'article-structure-plugin.start-number.set'}}
             </AuButton>
             <AuButton
-              @iconAlignment="left"
-              @skin="secondary"
+              @iconAlignment='left'
+              @skin='secondary'
               @disabled={{not this.structureStartNumber}}
-              class="au-u-margin-top-tiny"
+              class='au-u-margin-top-tiny'
               {{on 'click' this.resetStructureStartNumber}}
             >
               {{t 'article-structure-plugin.start-number.reset'}}

package/addon/components/besluit-type-plugin/besluit-type-select.hbs

@@ -3,12 +3,14 @@
   <PowerSelect
     @renderInPlace={{true}}
     @searchEnabled={{true}}
-    @searchMessage={{t "besluit-type-plugin.search-message"}}
-    @noMatchesMessage={{t "besluit-type-plugin.no-matches-message"}}
+    @searchMessage={{t 'besluit-type-plugin.search-message'}}
+    @noMatchesMessage={{t 'besluit-type-plugin.no-matches-message'}}
     @search={{this.search}}
     @options={{this.besluitTypes}}
     @selected={{@selected}}
-    @onChange={{@onchange}} as |besluitType|>
+    @onChange={{@onchange}}
+    as |besluitType|
+  >
     {{besluitType.label}}
   </PowerSelect>
   <p class='au-u-muted au-u-margin-tiny au-u-margin-bottom-small'>
@@ -18,11 +20,12 @@
     {{#unless @selected}}
       <AuAlert
         @icon={{this.AlertTriangleIcon}}
-        @title={{t "besluit-type-plugin.alert-title"}}
-        @skin="warning"
-        @size="small"
-        class="au-u-margin-bottom-none au-u-margin-top-small">
-      <p>{{t "besluit-type-plugin.alert-body"}}</p>
+        @title={{t 'besluit-type-plugin.alert-title'}}
+        @skin='warning'
+        @size='small'
+        class='au-u-margin-bottom-none au-u-margin-top-small'
+      >
+        <p>{{t 'besluit-type-plugin.alert-body'}}</p>
       </AuAlert>
     {{/unless}}
   {{/if}}

package/addon/components/citation-plugin/citation-card.hbs

@@ -12,10 +12,7 @@
       this.documentText
       this.documentLegislationType
     }}
-    {{did-update
-      this.update
-      this.activeDecoration
-    }}
+    {{did-update this.update this.activeDecoration}}
     as |c|
   >
     <c.header>

package/addon/components/citation-plugin/citation-insert.hbs

@@ -1,5 +1,5 @@
 {{! @glint-nocheck: not typesafe yet }}
-<li class="au-c-list__item">
+<li class='au-c-list__item'>
   <AuButton
     @icon={{this.AddIcon}}
     @iconAlignment='left'

package/addon/components/citation-plugin/citations/article-list.hbs

@@ -1,13 +1,17 @@
 {{#if @articles.length}}
-  <AuList @direction="vertical" @divider={{true}} as |Item|>
+  <AuList @direction='vertical' @divider={{true}} as |Item|>
     {{#each @articles as |article|}}
       <Item>
         <CitationPlugin::Citations::ArticlePreview
           @insertArticleCitation={{fn @insertArticleCitation article}}
-          @article={{article}} />
+          @article={{article}}
+        />
       </Item>
     {{/each}}
   </AuList>
 {{else}}
-  <Common::Search::AlertNoItems @fullSize={{@fullSize}} class={{if @fullSize "au-u-margin"}}/>
+  <Common::Search::AlertNoItems
+    @fullSize={{@fullSize}}
+    class={{if @fullSize 'au-u-margin'}}
+  />
 {{/if}}

package/addon/components/citation-plugin/citations/article-preview.hbs

@@ -1,17 +1,21 @@
 {{! @glint-nocheck: not typesafe yet }}
-<div class="au-u-margin" ...attributes>
-  <AuHeading @level="3" @skin="5" class="au-u-margin-bottom-small">
-  {{@article.number}} ({{@article.dateInForce}} - {{if @article.dateNoLongerInForce @article.dateNoLongerInForce "…"}})
+<div class='au-u-margin' ...attributes>
+  <AuHeading @level='3' @skin='5' class='au-u-margin-bottom-small'>
+    {{@article.number}}
+    ({{@article.dateInForce}}
+    -
+    {{if @article.dateNoLongerInForce @article.dateNoLongerInForce '…'}})
   </AuHeading>
   <p>
     {{this.content}}
   </p>
   <AuButton
-    @skin="primary"
+    @skin='primary'
     @icon={{this.PlusTextIcon}}
-    @iconAlignment="left"
-    class="au-u-margin-top-small"
-    {{on "click" @insertArticleCitation}}>
-    {{t "citaten-plugin.references.refer-article"}}
+    @iconAlignment='left'
+    class='au-u-margin-top-small'
+    {{on 'click' @insertArticleCitation}}
+  >
+    {{t 'citaten-plugin.references.refer-article'}}
   </AuButton>
 </div>

package/addon/components/citation-plugin/citations/legal-document-detail.hbs

@@ -1,115 +1,137 @@
 {{! @glint-nocheck: not typesafe yet }}
-<div class="citaten--main-container au-u-flex au-u-flex--column au-u-flex--between">
-  <div class="citaten--container-content">
+<div
+  class='citaten--main-container au-u-flex au-u-flex--column au-u-flex--between'
+>
+  <div class='citaten--container-content'>
     {{! Heading with title and actions }}
-    <div class="citaten--container-header au-u-background-gray-100 au-o-box">
-      <AuHeading @level="2" @skin="4">
+    <div class='citaten--container-header au-u-background-gray-100 au-o-box'>
+      <AuHeading @level='2' @skin='4'>
         {{capitalize @legalDocument.fullTitle}}
       </AuHeading>
       {{#if @legalDocument.publicationDate}}
         <AuPill
-          class="au-u-margin-top-small au-u-margin-bottom-small"
-          @skin="border"
+          class='au-u-margin-top-small au-u-margin-bottom-small'
+          @skin='border'
           @icon={{this.CalendarIcon}}
-          @iconAlignment="left">
+          @iconAlignment='left'
+        >
           {{@legalDocument.publicationDate}}
         </AuPill>
       {{/if}}
-      <br/>
+      <br />
       <AuButton
-        @skin="primary"
+        @skin='primary'
         @icon={{this.PlusTextIcon}}
-        @iconAlignment="left"
-        class="au-u-margin-right"
-        {{on "click" (fn @insertLegalDocumentCitation @legalDocument)}}>
-        {{t "citaten-plugin.references.refer-whole"}}
+        @iconAlignment='left'
+        class='au-u-margin-right'
+        {{on 'click' (fn @insertLegalDocumentCitation @legalDocument)}}
+      >
+        {{t 'citaten-plugin.references.refer-whole'}}
       </AuButton>
       <AuLinkExternal
-        @skin="primary"
+        @skin='primary'
         @icon={{this.LinkExternalIcon}}
-        @iconAlignment="left"
+        @iconAlignment='left'
         href={{@legalDocument.uri}}
-        rel="noreferrer noopener">
-        {{t "citaten-plugin.references.lookup-codex"}}
+        rel='noreferrer noopener'
+      >
+        {{t 'citaten-plugin.references.lookup-codex'}}
       </AuLinkExternal>
       {{! Search field }}
-      <AuLabel class="au-u-margin-top-small au-margin-bottom-small" for="searchCodex" @inline={{true}}
-               @required={{false}} @error={{false}} @warning={{false}}>{{t "citaten-plugin.search.article"}}</AuLabel>
+      <AuLabel
+        class='au-u-margin-top-small au-margin-bottom-small'
+        for='searchCodex'
+        @inline={{true}}
+        @required={{false}}
+        @error={{false}}
+        @warning={{false}}
+      >{{t 'citaten-plugin.search.article'}}</AuLabel>
       <AuInput
-        id="searchCodex"
-        placeholder="{{t "citaten-plugin.search.article-placeholder"}}"
-        type="text"
-        @width="default"
+        id='searchCodex'
+        placeholder='{{t "citaten-plugin.search.article-placeholder"}}'
+        type='text'
+        @width='default'
         @icon={{this.SearchIcon}}
-        @iconAlignment="right"
+        @iconAlignment='right'
         value={{this.articleFilter}}
-        {{on "input" (perform this.updateArticleFilter)}}
+        {{on 'input' (perform this.updateArticleFilter)}}
       />
     </div>
     {{! Search results }}
     <div>
       {{#if this.articleResource.isRunning}}
-        <div class="au-o-box">
-          <AuLoader @padding="large"/>
-          <span class="au-u-hidden-visually">{{t "citaten-plugin.alert.loading"}}</span>
+        <div class='au-o-box'>
+          <AuLoader @padding='large' />
+          <span class='au-u-hidden-visually'>{{t
+              'citaten-plugin.alert.loading'
+            }}</span>
         </div>
       {{else}}
         {{#if this.error}}
-          <Common::Search::AlertLoadError @fullSize={{true}} @error={{this.error}} class="au-o-box"/>
+          <Common::Search::AlertLoadError
+            @fullSize={{true}}
+            @error={{this.error}}
+            class='au-o-box'
+          />
         {{else}}
           <CitationPlugin::Citations::ArticleList
             @insertArticleCitation={{fn @insertArticleCitation @legalDocument}}
             @articles={{this.articleResource.value}}
-            @fullSize={{true}}/>
+            @fullSize={{true}}
+          />
         {{/if}}
       {{/if}}
     </div>
   </div>
   {{! Footer }}
   <div>
-    <div class="citaten--container-footer au-u-background-gray-100">
-      <AuToolbar
-        @border="top"
-        @size="large"
-        @nowrap={{true}}>
-        <div class="au-c-pagination">
+    <div class='citaten--container-footer au-u-background-gray-100'>
+      <AuToolbar @border='top' @size='large' @nowrap={{true}}>
+        <div class='au-c-pagination'>
           {{! Always shown, back to main dialog }}
-          <div class="au-c-pagination__list-item">
+          <div class='au-c-pagination__list-item'>
             <AuButton
-              @skin="link"
+              @skin='link'
               @icon={{this.HierarchicalBackIcon}}
-              @iconAlignment="left"
-              {{on "click" this.close}}>
-              {{t "citaten-plugin.search.back"}}
+              @iconAlignment='left'
+              {{on 'click' this.close}}
+            >
+              {{t 'citaten-plugin.search.back'}}
             </AuButton>
           </div>
           {{! Pagination of articles }}
           {{#if this.articleResource.value.length}}
             <p>
-              <span class="au-u-hidden-visually">{{t "citaten-plugin.search.results"}}</span>
+              <span class='au-u-hidden-visually'>{{t
+                  'citaten-plugin.search.results'
+                }}</span>
               <strong>
-                {{this.rangeStart}} - {{this.rangeEnd}}
+                {{this.rangeStart}}
+                -
+                {{this.rangeEnd}}
               </strong>
-              {{t "citaten-plugin.pagination.of"}}
+              {{t 'citaten-plugin.pagination.of'}}
               {{this.totalCount}}
             </p>
-            <div class="au-c-pagination__list-item">
+            <div class='au-c-pagination__list-item'>
               {{#unless this.isFirstPage}}
                 <AuButton
-                  @skin="link"
+                  @skin='link'
                   @icon={{this.NavLeftIcon}}
-                  @iconAlignment="left"
-                  {{on "click" this.previousPage}}>
-                  {{t "citaten-plugin.pagination.previous"}}
+                  @iconAlignment='left'
+                  {{on 'click' this.previousPage}}
+                >
+                  {{t 'citaten-plugin.pagination.previous'}}
                 </AuButton>
               {{/unless}}
               {{#unless this.isLastPage}}
                 <AuButton
-                  @skin="link"
+                  @skin='link'
                   @icon={{this.NavRightIcon}}
-                  @iconAlignment="right"
-                  {{on "click" this.nextPage}}>
-                  {{t "citaten-plugin.pagination.next"}}
+                  @iconAlignment='right'
+                  {{on 'click' this.nextPage}}
+                >
+                  {{t 'citaten-plugin.pagination.next'}}
                 </AuButton>
               {{/unless}}
             </div>

package/addon/components/citation-plugin/citations/legal-document-list.hbs

@@ -1,15 +1,19 @@
 {{#if @legalDocuments.length}}
-  <AuList @direction="vertical" @divider={{true}} as |Item|>
+  <AuList @direction='vertical' @divider={{true}} as |Item|>
     {{#each @legalDocuments as |legalDocument|}}
-      <Item class="au-u-padding-left-small au-u-padding-right-small">
+      <Item class='au-u-padding-left-small au-u-padding-right-small'>
         <CitationPlugin::Citations::LegalDocumentPreview
           @legalDocument={{legalDocument}}
           @onCitationInsert={{fn @onCitationInsert legalDocument}}
           @onCitationDetails={{fn @onCitationDetails legalDocument}}
-          @fullSize={{@fullSize}} />
+          @fullSize={{@fullSize}}
+        />
       </Item>
     {{/each}}
   </AuList>
 {{else}}
-  <Common::Search::AlertNoItems @fullSize={{@fullSize}} class={{if @fullSize "au-u-margin"}}/>
+  <Common::Search::AlertNoItems
+    @fullSize={{@fullSize}}
+    class={{if @fullSize 'au-u-margin'}}
+  />
 {{/if}}