@lazyingart/agintiflow 0.20.221 → 0.20.223

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lazyingart/agintiflow",
-  "version": "0.20.221",
+  "version": "0.20.223",
   "type": "module",
   "description": "AgInTiFlow is a project-aware agent workspace for hybrid wet-dry R&D, hardware-aware intelligence, software automation, and industrial workflows.",
   "license": "Apache-2.0",

package/scripts/smoke-coding-tools.js

@@ -658,6 +658,21 @@ try {
       exactCompoundReadOnlyAuditPolicy.writesWorkspace === false,
     "a finite read-only prelude and conditional directory audit incorrectly required destructive host permission"
   );
+  const exactReadOnlyExistenceLoopWithSuffix =
+    'for f in scripts/xyq_cdp_browser.py scripts/xyq_chrome/launch_chrome.sh scripts/xyq_chrome/watch_thread_dom_download.py scripts/musia_mv_finalize.sh; do test -e "/home/lachlan/ProjectsLFS/LALACHAN/$f" && echo "OK   $f" || echo "MISS $f"; done; echo "---mv_packs---"; ls -1 /home/lachlan/ProjectsLFS/Musia/data/mv_packs 2>&1; echo "---creative_projects---"; ls -1 /home/lachlan/ProjectsLFS/Musia/data/creative_projects 2>&1 | head -20';
+  const exactReadOnlyExistenceLoopWithSuffixPolicy = evaluateCommandPolicy(
+    exactReadOnlyExistenceLoopWithSuffix,
+    hostReadRootPolicy
+  );
+  assert(
+    exactReadOnlyExistenceLoopWithSuffixPolicy.allowed &&
+      exactReadOnlyExistenceLoopWithSuffixPolicy.category === "read-only" &&
+      exactReadOnlyExistenceLoopWithSuffixPolicy.boundedForLoop === true &&
+      exactReadOnlyExistenceLoopWithSuffixPolicy.boundedCompoundSequence === true &&
+      exactReadOnlyExistenceLoopWithSuffixPolicy.needsNetwork === false &&
+      exactReadOnlyExistenceLoopWithSuffixPolicy.writesWorkspace === false,
+    "a finite read-only existence loop with bounded list suffix incorrectly required destructive host permission"
+  );
   const exactReadOnlyGitIdentityProbe =
     'git status --short && echo "TOPLEVEL=$(git rev-parse --show-toplevel 2>&1)" && echo "BRANCH=$(git rev-parse --abbrev-ref HEAD 2>&1)"';
   const exactReadOnlyGitIdentityProbePolicy = evaluateCommandPolicy(
@@ -685,6 +700,20 @@ try {
       exactReadOnlyGitIdentityLoopPolicy.writesWorkspace === false,
     "bounded per-repository Git identity/status audit incorrectly required destructive host permission"
   );
+  const exactReadOnlyGitRepositoryAudit =
+    'for d in /home/lachlan/ProjectsLFS/AgenticApp /home/lachlan/ProjectsLFS/Musia /home/lachlan/ProjectsLFS/LALACHAN /home/lachlan/DiskMech/Projects/lazyedit; do echo "=== $d ==="; git -C "$d" config --get user.name; git -C "$d" config --get user.email; git -C "$d" status --porcelain=v1 --branch; echo "--- remotes ---"; git -C "$d" remote -v; echo; done';
+  const exactReadOnlyGitRepositoryAuditPolicy = evaluateCommandPolicy(
+    exactReadOnlyGitRepositoryAudit,
+    hostReadRootPolicy
+  );
+  assert(
+    exactReadOnlyGitRepositoryAuditPolicy.allowed &&
+      exactReadOnlyGitRepositoryAuditPolicy.category === "read-only" &&
+      exactReadOnlyGitRepositoryAuditPolicy.boundedForLoop === true &&
+      exactReadOnlyGitRepositoryAuditPolicy.needsNetwork === false &&
+      exactReadOnlyGitRepositoryAuditPolicy.writesWorkspace === false,
+    "bounded per-repository Git identity/status/remote audit incorrectly required destructive host permission"
+  );
   for (const unsafeEchoSubstitution of [
     'echo "VALUE=$(rm -rf report.md)"',
     'echo "VALUE=$(cp README.md report.md)"',
@@ -716,6 +745,8 @@ try {
     'for d in /tmp; do echo "VALUE=$(git -C "$d" config --global user.name)"; done',
     'for d in /tmp; do echo "VALUE=$(git -C "$d" status; rm -rf report.md)"; done',
     'for d in /tmp; do git -C "$d" status --short > report.md; done',
+    'for d in /tmp; do git -C "$d" remote add origin https://example.com/repo.git; done',
+    'for d in /tmp; do git -C "$d" remote set-url origin https://example.com/repo.git; done',
   ]) {
     const unsafeLoopSubstitutionPolicy = evaluateCommandPolicy(
       unsafeLoopSubstitution,
@@ -738,6 +769,9 @@ try {
     'echo start; for d in /tmp; do if [ -d "$d" ]; then if [ -f "$d/x" ]; then cat "$d/x"; else echo missing; fi; else echo absent; fi; done',
     'echo start; for d in $ROOTS; do if [ -d "$d" ]; then ls "$d"; else echo missing; fi; done',
     'echo start; for d in /tmp; do if [ -d "$d" ]; then ls "$d"; else echo missing; fi; done; rm -rf report.md',
+    'for f in README.md; do test -e "$f" && echo ok || echo missing; done; cp README.md copied.md',
+    'for f in README.md; do test -e "$f" && echo ok || echo missing; done; curl https://example.com',
+    'for f in README.md; do test -e "$f" && echo ok || echo missing; done; echo done > report.md',
   ]) {
     const unsafeCompoundAuditPolicy = evaluateCommandPolicy(unsafeCompoundAudit, hostReadRootPolicy);
     assert(

package/src/command-policy.js

@@ -1158,7 +1158,8 @@ function classifyScopedReadOnlyGitProbe(normalized = "") {
     (args.length === 1 && ["user.name", "user.email"].includes(args[0])) ||
     (args.length === 2 && args[0] === "--get" && ["user.name", "user.email"].includes(args[1]))
   );
-  if (!safeStatus && !safeIdentityConfig) return null;
+  const safeRemoteList = operation === "remote" && args.length === 1 && args[0] === "-v";
+  if (!safeStatus && !safeIdentityConfig && !safeRemoteList) return null;
 
   return {
     category: "read-only",
@@ -1356,7 +1357,11 @@ function classifySimpleCommand(normalized) {
     };
   }
 
-  if (matchAny(READ_ONLY_PATTERNS, commandForPatternMatching) || isReadOnlyFindCommand(normalized)) {
+  if (
+    matchAny(READ_ONLY_PATTERNS, commandForPatternMatching) ||
+    isReadOnlyFindCommand(normalized) ||
+    (!hasActiveShellExpansion(benignRedirectCommand) && isReadOnlyShellCondition(benignRedirectCommand))
+  ) {
     return {
       category: "read-only",
       needsNetwork: false,
@@ -1766,7 +1771,7 @@ function classifyReadOnlyForLoop(normalized) {
 
 function classifyReadOnlyCompoundSequence(normalized) {
   const text = String(normalized || "").trim();
-  if (!text || /^for\s+/.test(text) || hasActiveShellCommandSubstitution(text)) return null;
+  if (!text || hasActiveShellCommandSubstitution(text)) return null;
 
   let forIndex = findUnquotedShellWord(text, "for");
   const startsAtCommandBoundary = (index) => {
@@ -1777,16 +1782,24 @@ function classifyReadOnlyCompoundSequence(normalized) {
   while (forIndex > 0 && !startsAtCommandBoundary(forIndex)) {
     forIndex = findUnquotedShellWord(text, "for", forIndex + 3);
   }
-  if (forIndex <= 0) return null;
+  if (forIndex < 0) return null;
 
   const prefixSource = trimShellListBoundary(text.slice(0, forIndex));
-  const loopSource = text.slice(forIndex).trim();
-  const prefixClassification = classifyReadOnlyCommandList(prefixSource);
-  if (prefixClassification.category === "blocked" || prefixClassification.category === "destructive") {
-    return { ...prefixClassification, gitOnly: false };
-  }
-  if (prefixClassification.category !== "read-only" || prefixClassification.writesWorkspace) {
-    return broadForLoopClassification(text, "the command prelude is not read-only");
+  const doneIndex = findUnquotedShellWord(text, "done", forIndex + 3);
+  if (doneIndex < 0) return null;
+  const loopSource = text.slice(forIndex, doneIndex + 4).trim();
+  const suffixSource = trimShellListBoundary(text.slice(doneIndex + 4));
+  if (!prefixSource && !suffixSource) return null;
+
+  for (const [label, source] of [["prelude", prefixSource], ["suffix", suffixSource]]) {
+    if (!source) continue;
+    const classification = classifyReadOnlyCommandList(source);
+    if (classification.category === "blocked" || classification.category === "destructive") {
+      return { ...classification, gitOnly: false };
+    }
+    if (classification.category !== "read-only" || classification.writesWorkspace) {
+      return broadForLoopClassification(text, `the command ${label} is not read-only`);
+    }
   }
   const loopClassification = classifyReadOnlyForLoop(loopSource);
   if (!loopClassification) return null;
@@ -1800,7 +1813,7 @@ function classifyReadOnlyCompoundSequence(normalized) {
     gitOnly: false,
     boundedForLoop: true,
     boundedCompoundSequence: true,
-    reason: "Finite read-only command prelude followed by a bounded read-only shell loop.",
+    reason: "A bounded read-only shell loop has only finite read-only command context.",
   };
 }