@layerzerolabs/protocol-stellar-v2 0.2.40 → 0.2.43

package/contracts/macro-integration-tests/tests/runtime/oapp/options_type3.rs

@@ -1,6 +1,6 @@
 // Runtime tests: OAppOptionsType3 defaults generated by `#[oapp]`.
 
-use super::{TestOApp, TestOAppClient};
+use super::{grant_oapp_admin, TestOApp, TestOAppClient};
 use oapp::oapp_options_type3::{EnforcedOptionParam, EnforcedOptionSet};
 use oapp::OAppError;
 use soroban_sdk::{
@@ -28,6 +28,7 @@ fn enforced_options_lifecycle_and_auth() {
 
     let owner = Address::generate(&env);
     client.init(&owner, &Address::generate(&env));
+    grant_oapp_admin(&env, &contract_id, &owner);
 
     // Unset returns None (storage default).
     assert_eq!(client.enforced_options(&999, &999), None);
@@ -41,7 +42,7 @@ fn enforced_options_lifecycle_and_auth() {
     ];
 
     // Unauthorized set should fail (only_auth).
-    assert!(client.try_set_enforced_options(&params).is_err());
+    assert!(client.try_set_enforced_options(&params, &owner).is_err());
 
     // Non-owner authorized should also fail.
     let non_owner = Address::generate(&env);
@@ -50,11 +51,11 @@ fn enforced_options_lifecycle_and_auth() {
         invoke: &MockAuthInvoke {
             contract: &contract_id,
             fn_name: "set_enforced_options",
-            args: (&params,).into_val(&env),
+            args: (&params, &non_owner).into_val(&env),
             sub_invokes: &[],
         },
     }]);
-    assert!(client.try_set_enforced_options(&params).is_err());
+    assert!(client.try_set_enforced_options(&params, &non_owner).is_err());
 
     // Owner-authorized set should succeed.
     env.mock_auths(&[MockAuth {
@@ -62,11 +63,11 @@ fn enforced_options_lifecycle_and_auth() {
         invoke: &MockAuthInvoke {
             contract: &contract_id,
             fn_name: "set_enforced_options",
-            args: (&params,).into_val(&env),
+            args: (&params, &owner).into_val(&env),
             sub_invokes: &[],
         },
     }]);
-    client.set_enforced_options(&params);
+    client.set_enforced_options(&params, &owner);
 
     assert_contains_event(&env, &contract_id, EnforcedOptionSet { enforced_options: params.clone() });
 
@@ -82,6 +83,7 @@ fn set_enforced_options_rejects_invalid_option_type() {
 
     let owner = Address::generate(&env);
     client.init(&owner, &Address::generate(&env));
+    grant_oapp_admin(&env, &contract_id, &owner);
 
     // wrong type header (not 3)
     let mut invalid = Bytes::from_array(&env, &(4u16).to_be_bytes());
@@ -94,11 +96,11 @@ fn set_enforced_options_rejects_invalid_option_type() {
         invoke: &MockAuthInvoke {
             contract: &contract_id,
             fn_name: "set_enforced_options",
-            args: (&params,).into_val(&env),
+            args: (&params, &owner).into_val(&env),
             sub_invokes: &[],
         },
     }]);
-    let result = client.try_set_enforced_options(&params);
+    let result = client.try_set_enforced_options(&params, &owner);
     assert_eq!(result.err().unwrap().ok().unwrap(), OAppError::InvalidOptions.into());
 }
 
@@ -110,6 +112,7 @@ fn combine_options_behavior_and_validation() {
 
     let owner = Address::generate(&env);
     client.init(&owner, &Address::generate(&env));
+    grant_oapp_admin(&env, &contract_id, &owner);
 
     // No enforced => returns extra (including empty).
     let extra_only = create_valid_options(&env, &[9, 10, 11]);
@@ -126,11 +129,11 @@ fn combine_options_behavior_and_validation() {
         invoke: &MockAuthInvoke {
             contract: &contract_id,
             fn_name: "set_enforced_options",
-            args: (&params,).into_val(&env),
+            args: (&params, &owner).into_val(&env),
             sub_invokes: &[],
         },
     }]);
-    client.set_enforced_options(&params);
+    client.set_enforced_options(&params, &owner);
 
     // Enforced present: empty extra => enforced.
     assert_eq!(client.combine_options(&REMOTE_EID_1, &MSG_TYPE_SEND, &Bytes::new(&env)), enforced.clone());

package/contracts/macro-integration-tests/tests/runtime/oapp/receiver.rs

@@ -1,6 +1,6 @@
 // Runtime tests: OAppReceiver defaults generated by `#[oapp]`.
 
-use super::{TestOApp, TestOAppClient};
+use super::{grant_oapp_admin, TestOApp, TestOAppClient};
 use endpoint_v2::Origin;
 use oapp::OAppError;
 use soroban_sdk::{
@@ -87,6 +87,7 @@ fn allow_initialize_path_follows_peer_configuration() {
     let owner = Address::generate(&env);
     let endpoint = Address::generate(&env);
     client.init(&owner, &endpoint);
+    grant_oapp_admin(&env, &contract_id, &owner);
 
     let eid: u32 = REMOTE_EID_FOR_ALLOW_INIT;
     let sender = BytesN::<32>::from_array(&env, &[3u8; 32]);
@@ -103,11 +104,11 @@ fn allow_initialize_path_follows_peer_configuration() {
         invoke: &MockAuthInvoke {
             contract: &contract_id,
             fn_name: "set_peer",
-            args: (&eid, &other_peer).into_val(&env),
+            args: (&eid, &other_peer, &owner).into_val(&env),
             sub_invokes: &[],
         },
     }]);
-    client.set_peer(&eid, &other_peer);
+    client.set_peer(&eid, &other_peer, &owner);
     assert_eq!(client.allow_initialize_path(&origin), false);
 
     // Set matching peer => true.
@@ -117,11 +118,11 @@ fn allow_initialize_path_follows_peer_configuration() {
         invoke: &MockAuthInvoke {
             contract: &contract_id,
             fn_name: "set_peer",
-            args: (&eid, &matching_peer).into_val(&env),
+            args: (&eid, &matching_peer, &owner).into_val(&env),
             sub_invokes: &[],
         },
     }]);
-    client.set_peer(&eid, &matching_peer);
+    client.set_peer(&eid, &matching_peer, &owner);
 
     assert_eq!(client.allow_initialize_path(&origin), true);
 }
@@ -140,6 +141,7 @@ fn lz_receive_clears_payload_transfers_value_and_calls_internal_handler() {
     let oapp = env.register(TestOApp, ());
     let oapp_client = TestOAppClient::new(&env, &oapp);
     oapp_client.init(&owner, &endpoint);
+    grant_oapp_admin(&env, &oapp, &owner);
 
     // Configure peer so peer check passes.
     let peer = BytesN::<32>::from_array(&env, &[9u8; 32]);
@@ -149,11 +151,11 @@ fn lz_receive_clears_payload_transfers_value_and_calls_internal_handler() {
         invoke: &MockAuthInvoke {
             contract: &oapp,
             fn_name: "set_peer",
-            args: (&REMOTE_EID, &peer_opt).into_val(&env),
+            args: (&REMOTE_EID, &peer_opt, &owner).into_val(&env),
             sub_invokes: &[],
         },
     }]);
-    oapp_client.set_peer(&REMOTE_EID, &peer_opt);
+    oapp_client.set_peer(&REMOTE_EID, &peer_opt, &owner);
 
     // Before any lz_receive call, internal handler should not have been invoked.
     assert_eq!(oapp_client.lz_receive_called(), false);
@@ -226,6 +228,7 @@ fn lz_receive_wrong_peer_returns_only_peer() {
     let oapp = env.register(TestOApp, ());
     let oapp_client = TestOAppClient::new(&env, &oapp);
     oapp_client.init(&owner, &endpoint);
+    grant_oapp_admin(&env, &oapp, &owner);
 
     // Set peer to some value...
     let configured_peer = BytesN::<32>::from_array(&env, &[7u8; 32]);
@@ -235,11 +238,11 @@ fn lz_receive_wrong_peer_returns_only_peer() {
         invoke: &MockAuthInvoke {
             contract: &oapp,
             fn_name: "set_peer",
-            args: (&REMOTE_EID, &peer_opt).into_val(&env),
+            args: (&REMOTE_EID, &peer_opt, &owner).into_val(&env),
             sub_invokes: &[],
         },
     }]);
-    oapp_client.set_peer(&REMOTE_EID, &peer_opt);
+    oapp_client.set_peer(&REMOTE_EID, &peer_opt, &owner);
 
     // ...but call lz_receive with a different sender.
     let executor = Address::generate(&env);
@@ -312,6 +315,7 @@ fn lz_receive_requires_executor_auth() {
     let oapp = env.register(TestOApp, ());
     let oapp_client = TestOAppClient::new(&env, &oapp);
     oapp_client.init(&owner, &endpoint);
+    grant_oapp_admin(&env, &oapp, &owner);
 
     // Configure peer so we fail specifically at executor.require_auth().
     let peer = BytesN::<32>::from_array(&env, &[7u8; 32]);
@@ -321,11 +325,11 @@ fn lz_receive_requires_executor_auth() {
         invoke: &MockAuthInvoke {
             contract: &oapp,
             fn_name: "set_peer",
-            args: (&REMOTE_EID, &peer_opt).into_val(&env),
+            args: (&REMOTE_EID, &peer_opt, &owner).into_val(&env),
             sub_invokes: &[],
         },
     }]);
-    oapp_client.set_peer(&REMOTE_EID, &peer_opt);
+    oapp_client.set_peer(&REMOTE_EID, &peer_opt, &owner);
 
     let executor = Address::generate(&env);
     let origin = Origin { src_eid: REMOTE_EID, sender: peer, nonce: 1 };

package/contracts/macro-integration-tests/tests/runtime/oapp/sender.rs

@@ -76,6 +76,7 @@ impl MockEndpoint {
 }
 
 #[oapp]
+#[common_macros::lz_contract]
 pub struct TestOAppSender;
 
 impl LzReceiveInternal for TestOAppSender {
@@ -94,7 +95,7 @@ impl LzReceiveInternal for TestOAppSender {
 #[contractimpl]
 impl TestOAppSender {
     pub fn init(env: Env, owner: Address, endpoint: Address) {
-        oapp::oapp_core::initialize_oapp::<Self>(&env, &owner, &endpoint, &owner);
+        oapp::oapp_core::init_ownable_oapp::<Self>(&env, &owner, &endpoint, &owner);
     }
 
     pub fn quote(env: &Env, dst_eid: u32, message: &Bytes, options: &Bytes, pay_in_zro: bool) -> MessagingFee {
@@ -129,11 +130,11 @@ fn set_peer(
         invoke: &MockAuthInvoke {
             contract: oapp,
             fn_name: "set_peer",
-            args: (&eid, &peer_opt).into_val(env),
+            args: (&eid, &peer_opt, owner).into_val(env),
             sub_invokes: &[],
         },
     }]);
-    client.set_peer(&eid, &peer_opt);
+    client.set_peer(&eid, &peer_opt, owner);
 }
 
 fn mint_to(
@@ -210,6 +211,7 @@ fn setup() -> Setup {
     let oapp = env.register(TestOAppSender, ());
     let client = TestOAppSenderClient::new(&env, &oapp);
     client.init(&owner, &endpoint);
+    super::grant_oapp_admin(&env, &oapp, &owner);
 
     Setup { env, owner, token_admin, native_token, zro_token, endpoint, oapp }
 }

package/contracts/macro-integration-tests/tests/runtime/ownable/mod.rs

@@ -2,8 +2,8 @@ use soroban_sdk::{contract, contractimpl, Address, Env};
 
 mod initialization;
 mod only_auth_guard;
-mod two_step_transfer;
 mod ownership_transfer;
+mod two_step_transfer;
 
 /// Shared contract used by ownable runtime tests.
 #[contract]

package/contracts/macro-integration-tests/tests/runtime/ownable/two_step_transfer.rs

@@ -1,4 +1,4 @@
-// Runtime tests: 2-step ownership transfer behavior (`propose_ownership_transfer` + `accept_ownership`).
+// Runtime tests: 2-step ownership transfer behavior (`begin_ownership_transfer` + `accept_ownership`).
 //
 // Ownable supports a safer two-step flow using temporary storage with TTL. These tests ensure
 // the macro-exported contract entrypoints are wired and behave correctly at runtime.
@@ -24,10 +24,13 @@ fn propose_requires_owner_auth() {
 
     // No auth provided -> should fail at require_auth.
     let ttl = 10u32;
-    let res = client.try_propose_ownership_transfer(&new_owner, &ttl);
+    let res = client.try_begin_ownership_transfer(&new_owner, &ttl);
     assert_eq!(
         res.err().unwrap().ok().unwrap(),
-        soroban_sdk::Error::from_type_and_code(soroban_sdk::xdr::ScErrorType::Context, soroban_sdk::xdr::ScErrorCode::InvalidAction)
+        soroban_sdk::Error::from_type_and_code(
+            soroban_sdk::xdr::ScErrorType::Context,
+            soroban_sdk::xdr::ScErrorCode::InvalidAction
+        )
     );
 }
 
@@ -47,12 +50,12 @@ fn propose_rejects_invalid_ttl() {
             address: &owner,
             invoke: &MockAuthInvoke {
                 contract: &contract_id,
-                fn_name: "propose_ownership_transfer",
+                fn_name: "begin_ownership_transfer",
                 args: (&new_owner, &ttl).into_val(&env),
                 sub_invokes: &[],
             },
         }])
-        .try_propose_ownership_transfer(&new_owner, &ttl);
+        .try_begin_ownership_transfer(&new_owner, &ttl);
     assert_eq!(res.err().unwrap().ok().unwrap(), OwnableError::InvalidTtl.into());
     assert_eq!(client.pending_owner(), None);
 }
@@ -74,12 +77,12 @@ fn propose_and_accept_transfers_ownership() {
             address: &owner,
             invoke: &MockAuthInvoke {
                 contract: &contract_id,
-                fn_name: "propose_ownership_transfer",
+                fn_name: "begin_ownership_transfer",
                 args: (&new_owner, &ttl).into_val(&env),
                 sub_invokes: &[],
             },
         }])
-        .propose_ownership_transfer(&new_owner, &ttl);
+        .begin_ownership_transfer(&new_owner, &ttl);
 
     assert_eq_event(
         &env,
@@ -128,12 +131,12 @@ fn pending_transfer_blocks_single_step_transfer_and_renounce() {
             address: &owner,
             invoke: &MockAuthInvoke {
                 contract: &contract_id,
-                fn_name: "propose_ownership_transfer",
+                fn_name: "begin_ownership_transfer",
                 args: (&pending, &ttl).into_val(&env),
                 sub_invokes: &[],
             },
         }])
-        .propose_ownership_transfer(&pending, &ttl);
+        .begin_ownership_transfer(&pending, &ttl);
 
     // With owner auth, immediate transfer should fail due to TransferInProgress.
     let transfer = client
@@ -180,12 +183,12 @@ fn pending_transfer_expires_and_cannot_be_accepted() {
             address: &owner,
             invoke: &MockAuthInvoke {
                 contract: &contract_id,
-                fn_name: "propose_ownership_transfer",
+                fn_name: "begin_ownership_transfer",
                 args: (&pending, &ttl).into_val(&env),
                 sub_invokes: &[],
             },
         }])
-        .propose_ownership_transfer(&pending, &ttl);
+        .begin_ownership_transfer(&pending, &ttl);
 
     assert_eq!(client.pending_owner(), Some(pending.clone()));
 
@@ -216,4 +219,3 @@ fn pending_transfer_expires_and_cannot_be_accepted() {
     // Owner should remain unchanged.
     assert_eq!(client.owner(), Some(owner));
 }
-

package/contracts/macro-integration-tests/tests/runtime/upgradeable/migrate_guard_and_state.rs

@@ -13,8 +13,8 @@ use soroban_sdk::{
     xdr::{ScErrorCode, ScErrorType},
     Address, Bytes, BytesN, Env, Error, IntoVal, Val,
 };
-use utils::upgradeable::{UpgradeableInternal, UpgradeableStorage};
 use utils::errors::AuthError;
+use utils::upgradeable::{UpgradeableInternal, UpgradeableStorage};
 
 // A small, known-good contract WASM used for upgrade() testing.
 // Sourced from the `upgrader` crate test fixtures.
@@ -202,10 +202,7 @@ fn upgrade_and_migrate_fail_before_owner_init() {
         UpgradeableStorage::set_migrating(&env, &true);
     });
     let migration_data = 1u32.to_xdr(&env);
-    assert_eq!(
-        client.try_migrate(&migration_data).unwrap_err().unwrap(),
-        AuthError::AuthorizerNotFound.into()
-    );
+    assert_eq!(client.try_migrate(&migration_data).unwrap_err().unwrap(), AuthError::AuthorizerNotFound.into());
 }
 
 #[test]
@@ -237,10 +234,7 @@ fn migrate_rejects_invalid_migration_data_and_does_not_clear_flag() {
         }])
         .try_migrate(&bad_bytes);
 
-    assert_eq!(
-        res.err().unwrap().ok().unwrap(),
-        utils::errors::UpgradeableError::InvalidMigrationData.into()
-    );
+    assert_eq!(res.err().unwrap().ok().unwrap(), utils::errors::UpgradeableError::InvalidMigrationData.into());
 
     // Since migration failed before reaching the "clear flag" line, migrating should still be true.
     env.as_contract(&contract_id, || {

package/contracts/macro-integration-tests/tests/ui/lz_contract/fail/upgradeable_invalid_inner_option.stderr

@@ -4,4 +4,27 @@ error: custom attribute panicked
 7 | #[common_macros::lz_contract(upgradeable(bad_inner))]
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
-  = help: message: failed to parse lz_contract config: expected `no_migration`
+  = help: message: failed to parse upgradeable config: expected `no_migration` or `rbac`
+  = note: this error originates in the attribute macro `common_macros::lz_contract` (in Nightly builds, run with -Z macro-backtrace for more info)
+
+error[E0433]: failed to resolve: could not find `MyContract` in the crate root
+ --> tests/ui/lz_contract/fail/upgradeable_invalid_inner_option.rs:7:1
+  |
+7 | #[common_macros::lz_contract(upgradeable(bad_inner))]
+  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ could not find `MyContract` in the crate root
+  |
+  = note: this error originates in the attribute macro `soroban_sdk::contractimpl` (in Nightly builds, run with -Z macro-backtrace for more info)
+
+error[E0412]: cannot find type `MyContract` in this scope
+ --> tests/ui/lz_contract/fail/upgradeable_invalid_inner_option.rs:8:12
+  |
+8 | pub struct MyContract;
+  |            ^^^^^^^^^^ not found in this scope
+
+error[E0412]: cannot find type `MyContract` in this scope
+ --> tests/ui/lz_contract/fail/upgradeable_invalid_inner_option.rs:7:1
+  |
+7 | #[common_macros::lz_contract(upgradeable(bad_inner))]
+  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not found in this scope
+  |
+  = note: this error originates in the attribute macro `soroban_sdk::contractimpl` (in Nightly builds, run with -Z macro-backtrace for more info)

package/contracts/macro-integration-tests/tests/ui/lz_contract/fail/upgradeable_missing_internal.stderr

@@ -16,7 +16,7 @@ error[E0277]: the trait bound `MyContract: UpgradeableInternal` is not satisfied
 12 | pub struct MyContract;
    |            ^^^^^^^^^^ the trait `UpgradeableInternal` is not implemented for `MyContract`
    |
-note: required by a bound in `upgrade`
+note: required by a bound in `utils::upgradeable::Upgradeable::upgrade`
   --> $WORKSPACE/contracts/utils/src/upgradeable.rs
    |
    | pub trait Upgradeable: UpgradeableInternal + Auth {
@@ -31,7 +31,7 @@ error[E0277]: the trait bound `MyContract: UpgradeableInternal` is not satisfied
 12 | pub struct MyContract;
    |            ^^^^^^^^^^ the trait `UpgradeableInternal` is not implemented for `MyContract`
    |
-note: required by a bound in `migrate`
+note: required by a bound in `utils::upgradeable::Upgradeable::migrate`
   --> $WORKSPACE/contracts/utils/src/upgradeable.rs
    |
    | pub trait Upgradeable: UpgradeableInternal + Auth {
@@ -46,7 +46,7 @@ error[E0277]: the trait bound `MyContract: UpgradeableInternal` is not satisfied
 17 |     MyContract::upgrade(env, &hash);
    |     ^^^^^^^^^^ the trait `UpgradeableInternal` is not implemented for `MyContract`
    |
-note: required by a bound in `upgrade`
+note: required by a bound in `utils::upgradeable::Upgradeable::upgrade`
   --> $WORKSPACE/contracts/utils/src/upgradeable.rs
    |
    | pub trait Upgradeable: UpgradeableInternal + Auth {

package/contracts/macro-integration-tests/tests/ui/lz_contract/pass/upgradeable_rbac.rs

@@ -0,0 +1,44 @@
+// UI (trybuild) test: `#[lz_contract(upgradeable)]` compiles with RBAC.
+//
+// Purpose:
+// - Ensures lz_contract upgradeable wrapper can coexist with RoleBasedAccessControl.
+
+use soroban_sdk::{contractimpl, Address, Bytes, BytesN, Env};
+use utils::rbac::{grant_role_no_auth, RoleBasedAccessControl};
+use utils::ttl_configurable::TtlConfig;
+use utils::upgradeable::UpgradeableInternal;
+
+#[common_macros::lz_contract(upgradeable)]
+pub struct MyContract;
+
+impl UpgradeableInternal for MyContract {
+    type MigrationData = ();
+
+    fn __migrate(_env: &Env, _migration_data: &Self::MigrationData) {}
+}
+
+#[contractimpl(contracttrait)]
+impl RoleBasedAccessControl for MyContract {}
+
+#[contractimpl]
+impl MyContract {
+    pub fn init(env: Env, owner: Address) {
+        Self::init_owner(&env, &owner);
+    }
+
+    pub fn smoke(env: Env, operator: Address) {
+        // Smoke-use RBAC helper (doesn't execute in trybuild).
+        let role = soroban_sdk::Symbol::new(&env, "SOME_ROLE");
+        grant_role_no_auth(&env, &operator, &role, &env.current_contract_address());
+
+        let _cfg: (Option<TtlConfig>, Option<TtlConfig>) = Self::ttl_configs(&env);
+        Self::extend_instance_ttl(&env, 1, 2);
+
+        let hash = BytesN::<32>::from_array(&env, &[0u8; 32]);
+        let migration_data = Bytes::new(&env);
+        Self::upgrade(&env, &hash);
+        Self::migrate(&env, &migration_data);
+    }
+}
+
+fn main() {}

package/contracts/macro-integration-tests/tests/ui/oapp/fail/missing_auth_trait.rs

@@ -0,0 +1,28 @@
+// UI (trybuild) negative test: `#[oapp]` requires a contract macro such as `#[lz_contract]`.
+//
+// Purpose:
+// - Ensures we fail compilation when a struct uses `#[oapp]` without applying
+//   `#[common_macros::lz_contract]` or `#[soroban_sdk::contract]` (or similar).
+
+use endpoint_v2::Origin;
+use oapp::oapp_receiver::LzReceiveInternal;
+use oapp_macros::oapp;
+use soroban_sdk::{Address, Bytes, BytesN, Env};
+
+#[oapp]
+pub struct MyOApp;
+
+impl LzReceiveInternal for MyOApp {
+    fn __lz_receive(
+        _env: &Env,
+        _origin: &Origin,
+        _guid: &BytesN<32>,
+        _message: &Bytes,
+        _extra_data: &Bytes,
+        _executor: &Address,
+        _value: i128,
+    ) {
+    }
+}
+
+fn main() {}