@layerzerolabs/protocol-stellar-v2 0.2.122 → 0.2.124

package/workers/price-feed/src/tests/price_feed.rs

@@ -13,7 +13,7 @@ fn test_constructor_sets_owner_and_price_updater() {
     let setup = TestSetup::new();
 
     assert_eq!(setup.client.owner(), Some(setup.owner.clone()));
-    assert_eq!(setup.client.is_price_updater(&setup.price_updater), true);
+    assert!(setup.client.is_price_updater(&setup.price_updater));
 }
 
 #[test]
@@ -91,7 +91,7 @@ fn test_estimate_fee_by_eid_default_model() {
     //     = (16_500_000_000_000 * 1e20) / 1e20
     //     = 16_500_000_000_000
 
-    assert_eq!(estimate.total_gas_fee, 16_500_000_000_000 as i128);
+    assert_eq!(estimate.total_gas_fee, 16_500_000_000_000_i128);
     assert_eq!(estimate.price_ratio, price.price_ratio);
     assert_eq!(estimate.price_ratio_denominator, 10u128.pow(20));
     assert_eq!(estimate.native_price_usd, 0);
@@ -214,7 +214,7 @@ fn test_estimate_fee_by_eid_arbitrum_model_hardcoded_eid() {
     //     = 34_306 * 10_000_000
     //     = 343_060_000_000
 
-    assert_eq!(estimate.total_gas_fee, 343_060_000_000 as i128);
+    assert_eq!(estimate.total_gas_fee, 343_060_000_000_i128);
 
     assert_eq!(estimate.price_ratio, arb_price.price_ratio);
 }
@@ -237,7 +237,7 @@ fn test_estimate_fee_by_eid_arbitrum_model_hardcoded_eid_10143() {
     setup.mock_auth(&fee_lib, "estimate_fee_by_eid", (&fee_lib, 10143u32, 1000u32, 500u128));
     let estimate = setup.client.estimate_fee_by_eid(&fee_lib, &10143, &1000, &500);
 
-    assert_eq!(estimate.total_gas_fee, 343_060_000_000 as i128);
+    assert_eq!(estimate.total_gas_fee, 343_060_000_000_i128);
     assert_eq!(estimate.price_ratio, arb_price.price_ratio);
 }
 
@@ -299,7 +299,7 @@ fn test_estimate_fee_by_eid_arbitrum_model_configured_eid() {
     let estimate = setup.client.estimate_fee_by_eid(&fee_lib, &200, &1000, &500);
 
     // Should use Arbitrum model (same expected fee as the hardcoded Arbitrum test)
-    assert_eq!(estimate.total_gas_fee, 343_060_000_000 as i128);
+    assert_eq!(estimate.total_gas_fee, 343_060_000_000_i128);
     assert_eq!(estimate.price_ratio, arb_price.price_ratio);
 }
 
@@ -342,7 +342,7 @@ fn test_estimate_fee_by_eid_optimism_model_hardcoded_eid() {
     //          = 7_235_492_071_308 + 36_813_447_000
     //          = 7_272_305_518_308
 
-    assert_eq!(estimate.total_gas_fee, 7_272_305_518_308 as i128);
+    assert_eq!(estimate.total_gas_fee, 7_272_305_518_308_i128);
     assert_eq!(estimate.price_ratio, op_price.price_ratio);
 }
 
@@ -368,7 +368,7 @@ fn test_estimate_fee_by_eid_optimism_model_goerli() {
 
     // Deterministic expected fee (Optimism model):
     // L1 uses Ethereum Goerli (10121) with +3188 overhead, L2 uses Optimism Goerli (10132).
-    assert_eq!(estimate.total_gas_fee, 7_272_305_518_308 as i128);
+    assert_eq!(estimate.total_gas_fee, 7_272_305_518_308_i128);
     assert_eq!(estimate.price_ratio, op_price.price_ratio);
 }
 #[test]
@@ -402,7 +402,7 @@ fn test_estimate_fee_by_eid_optimism_model_configured_eid() {
     assert_eq!(estimate_300.total_gas_fee, estimate_111.total_gas_fee);
     assert_eq!(estimate_300.price_ratio, estimate_111.price_ratio);
     assert_eq!(estimate_300.price_ratio, op_price.price_ratio);
-    assert_eq!(estimate_300.total_gas_fee, 7_272_305_518_308 as i128);
+    assert_eq!(estimate_300.total_gas_fee, 7_272_305_518_308_i128);
 }
 
 #[test]
@@ -511,12 +511,12 @@ fn test_set_price_updater_add_and_remove() {
     // Add new price updater
     setup.mock_owner_auth("set_price_updater", (&new_updater, true));
     setup.client.set_price_updater(&new_updater, &true);
-    assert_eq!(setup.client.is_price_updater(&new_updater), true);
+    assert!(setup.client.is_price_updater(&new_updater));
 
     // Remove price updater
     setup.mock_owner_auth("set_price_updater", (&new_updater, false));
     setup.client.set_price_updater(&new_updater, &false);
-    assert_eq!(setup.client.is_price_updater(&new_updater), false);
+    assert!(!setup.client.is_price_updater(&new_updater));
 }
 
 #[test]
@@ -806,7 +806,7 @@ fn test_is_price_updater_returns_false_for_unknown_address() {
     let setup = TestSetup::new();
     let unknown = Address::generate(&setup.env);
 
-    assert_eq!(setup.client.is_price_updater(&unknown), false);
+    assert!(!setup.client.is_price_updater(&unknown));
 }
 
 // =============================================================================

package/workers/worker/src/tests/worker.rs

@@ -27,12 +27,12 @@ fn test_set_paused_toggles_state() {
     setup.mock_owner_auth("set_paused", (true,));
     setup.client.set_paused(&true);
     assert_eq_event(&setup.env, &setup.contract_id, Paused { pauser: setup.owner.clone() });
-    assert_eq!(setup.client.paused(), true);
+    assert!(setup.client.paused());
 
     setup.mock_owner_auth("set_paused", (false,));
     setup.client.set_paused(&false);
     assert_eq_event(&setup.env, &setup.contract_id, Unpaused { unpauser: setup.owner.clone() });
-    assert_eq!(setup.client.paused(), false);
+    assert!(!setup.client.paused());
 }
 
 // allowlist
@@ -68,22 +68,22 @@ fn test_allowlist_remove_decrements_size_and_restores_default_acl() {
     let oapp_b = Address::generate(&setup.env);
 
     // Add allowlist entry => allowlist becomes non-empty; non-allowlisted is denied
-    assert_eq!(setup.client.is_on_allowlist(&oapp_a), false);
+    assert!(!setup.client.is_on_allowlist(&oapp_a));
     setup.mock_owner_auth("set_allowlist", (&oapp_a, true));
     setup.client.set_allowlist(&oapp_a, &true);
     assert_eq_event(&setup.env, &setup.contract_id, SetAllowlist { oapp: oapp_a.clone(), allowed: true });
-    assert_eq!(setup.client.is_on_allowlist(&oapp_a), true);
+    assert!(setup.client.is_on_allowlist(&oapp_a));
     assert_eq!(setup.client.allowlist_size(), 1);
-    assert_eq!(setup.client.has_acl(&oapp_a), true);
-    assert_eq!(setup.client.has_acl(&oapp_b), false);
+    assert!(setup.client.has_acl(&oapp_a));
+    assert!(!setup.client.has_acl(&oapp_b));
 
     // Remove last allowlist entry => allowlist empty; default allows all (unless denylisted)
     setup.mock_owner_auth("set_allowlist", (&oapp_a, false));
     setup.client.set_allowlist(&oapp_a, &false);
     assert_eq_event(&setup.env, &setup.contract_id, SetAllowlist { oapp: oapp_a.clone(), allowed: false });
-    assert_eq!(setup.client.is_on_allowlist(&oapp_a), false);
+    assert!(!setup.client.is_on_allowlist(&oapp_a));
     assert_eq!(setup.client.allowlist_size(), 0);
-    assert_eq!(setup.client.has_acl(&oapp_b), true);
+    assert!(setup.client.has_acl(&oapp_b));
 }
 
 // denylist
@@ -129,7 +129,7 @@ fn test_message_lib_add_remove_and_errors() {
         &setup.contract_id,
         SetSupportedMessageLib { message_lib: new_lib.clone(), supported: true },
     );
-    assert_eq!(setup.client.is_supported_message_lib(&new_lib), true);
+    assert!(setup.client.is_supported_message_lib(&new_lib));
 
     // Remove it
     setup.mock_owner_auth("set_supported_message_lib", (&new_lib, false));
@@ -139,10 +139,10 @@ fn test_message_lib_add_remove_and_errors() {
         &setup.contract_id,
         SetSupportedMessageLib { message_lib: new_lib.clone(), supported: false },
     );
-    assert_eq!(setup.client.is_supported_message_lib(&new_lib), false);
+    assert!(!setup.client.is_supported_message_lib(&new_lib));
 
     // Existing is still supported
-    assert_eq!(setup.client.is_supported_message_lib(&existing), true);
+    assert!(setup.client.is_supported_message_lib(&existing));
 }
 
 #[test]
@@ -245,41 +245,41 @@ fn test_acl_allowlist_denylist_precedence() {
     let oapp_b = Address::generate(&setup.env);
 
     // Empty allowlist => allowed unless denylisted
-    assert_eq!(setup.client.has_acl(&oapp_a), true);
+    assert!(setup.client.has_acl(&oapp_a));
 
     // Denylist overrides everything
-    assert_eq!(setup.client.is_on_denylist(&oapp_a), false);
+    assert!(!setup.client.is_on_denylist(&oapp_a));
     setup.mock_owner_auth("set_denylist", (&oapp_a, true));
     setup.client.set_denylist(&oapp_a, &true);
     assert_eq_event(&setup.env, &setup.contract_id, SetDenylist { oapp: oapp_a.clone(), denied: true });
-    assert_eq!(setup.client.is_on_denylist(&oapp_a), true);
-    assert_eq!(setup.client.has_acl(&oapp_a), false);
+    assert!(setup.client.is_on_denylist(&oapp_a));
+    assert!(!setup.client.has_acl(&oapp_a));
 
     // Remove from denylist => allowed again (since allowlist is empty)
     setup.mock_owner_auth("set_denylist", (&oapp_a, false));
     setup.client.set_denylist(&oapp_a, &false);
     assert_eq_event(&setup.env, &setup.contract_id, SetDenylist { oapp: oapp_a.clone(), denied: false });
-    assert_eq!(setup.client.is_on_denylist(&oapp_a), false);
-    assert_eq!(setup.client.has_acl(&oapp_a), true);
+    assert!(!setup.client.is_on_denylist(&oapp_a));
+    assert!(setup.client.has_acl(&oapp_a));
 
     // Add allowlist entry => allowlist becomes non-empty; non-allowlisted is denied
     setup.mock_owner_auth("set_allowlist", (&oapp_a, true));
     setup.client.set_allowlist(&oapp_a, &true);
     assert_eq!(setup.client.allowlist_size(), 1);
-    assert_eq!(setup.client.has_acl(&oapp_a), true);
-    assert_eq!(setup.client.has_acl(&oapp_b), false);
+    assert!(setup.client.has_acl(&oapp_a));
+    assert!(!setup.client.has_acl(&oapp_b));
 
     // Denylist must override allowlist even for the same OApp.
     setup.mock_owner_auth("set_denylist", (&oapp_a, true));
     setup.client.set_denylist(&oapp_a, &true);
     assert_eq_event(&setup.env, &setup.contract_id, SetDenylist { oapp: oapp_a.clone(), denied: true });
-    assert_eq!(setup.client.has_acl(&oapp_a), false);
+    assert!(!setup.client.has_acl(&oapp_a));
 
     // Removing from denylist should restore allowlist effect.
     setup.mock_owner_auth("set_denylist", (&oapp_a, false));
     setup.client.set_denylist(&oapp_a, &false);
     assert_eq_event(&setup.env, &setup.contract_id, SetDenylist { oapp: oapp_a.clone(), denied: false });
-    assert_eq!(setup.client.has_acl(&oapp_a), true);
+    assert!(setup.client.has_acl(&oapp_a));
 }
 
 // uninitialized getters (BareWorker)
@@ -369,7 +369,7 @@ fn test_init_worker_can_reinitialize() {
 fn test_init_worker_sets_config_and_defaults() {
     let setup = TestSetup::new();
 
-    assert_eq!(setup.client.paused(), false);
+    assert!(!setup.client.paused());
     assert_eq!(setup.client.admins(), setup.admins);
     assert_eq!(setup.client.message_libs(), setup.message_libs);
     assert_eq!(setup.client.price_feed(), Some(setup.price_feed));
@@ -379,7 +379,7 @@ fn test_init_worker_sets_config_and_defaults() {
     assert_eq!(setup.client.allowlist_size(), 0);
 
     let lib = setup.message_libs.get(0).unwrap();
-    assert_eq!(setup.client.is_supported_message_lib(&lib), true);
+    assert!(setup.client.is_supported_message_lib(&lib));
 }
 
 // admin management (admins list)
@@ -392,12 +392,12 @@ fn test_admin_management_by_owner_adds_and_removes_admin() {
     setup.mock_owner_auth("set_admin", (&new_admin, true));
     setup.client.set_admin(&new_admin, &true);
     assert_eq_event(&setup.env, &setup.contract_id, SetAdmin { admin: new_admin.clone(), active: true });
-    assert_eq!(setup.client.is_admin(&new_admin), true);
+    assert!(setup.client.is_admin(&new_admin));
 
     setup.mock_owner_auth("set_admin", (&new_admin, false));
     setup.client.set_admin(&new_admin, &false);
     assert_eq_event(&setup.env, &setup.contract_id, SetAdmin { admin: new_admin.clone(), active: false });
-    assert_eq!(setup.client.is_admin(&new_admin), false);
+    assert!(!setup.client.is_admin(&new_admin));
 }
 
 #[test]
@@ -454,7 +454,7 @@ fn test_admin_management_can_remove_last_admin() {
 
     // Removing the last admin is now allowed
     client.set_admin(&only_admin, &false);
-    assert_eq!(client.is_admin(&only_admin), false);
+    assert!(!client.is_admin(&only_admin));
     assert_eq!(client.admins().len(), 0);
 }
 
@@ -467,7 +467,7 @@ fn test_admin_management_by_admin_can_add_admin() {
     setup.mock_auth(&caller, "set_admin_by_admin_for_test", (&caller, &new_admin, true));
     setup.client.set_admin_by_admin_for_test(&caller, &new_admin, &true);
     assert_eq_event(&setup.env, &setup.contract_id, SetAdmin { admin: new_admin.clone(), active: true });
-    assert_eq!(setup.client.is_admin(&new_admin), true);
+    assert!(setup.client.is_admin(&new_admin));
 }
 
 #[test]

package/docs/error-spec.md

@@ -1,55 +0,0 @@
-# Stellar LayerZero Protocol - Error Code Specification
-
-This document defines the error code allocation strategy for the Stellar LayerZero contracts.
-
-## Purpose
-
-Each library has a unique error code range to:
-
-- **Prevent collisions**: Avoid error code conflicts between different libraries
-- **Enable traceability**: Quickly identify which library an error originated from based on its code
-- **Simplify debugging**: Error codes are globally unique, making it easier to track and diagnose issues
-
-## Allocation Rules
-
-- **Contract-specific errors**: Each contract uses auto-incrementing error codes starting from 1. These are local to the contract and do not need global uniqueness since the contract address provides context.
-- **Library errors**: Libraries that are shared across multiple contracts use reserved ranges (1000+) to ensure global uniqueness.
-- **Library allocation**: Each library is allocated a 100-unit block (e.g., 1000-1099, 1100-1199). Total errors in one library should not exceed 100.
-- **Sub-range allocation**: Each error type within a library is allocated a 10-unit block. If an error type exceeds 10 errors, it extends into the next block but the following error type should start at the next 10-unit boundary.
-- **Auto-increment**: Within each error enum, values auto-increment from the starting value.
-
-## Error Code Ranges
-
-### Contract-Specific Errors (1-999)
-
-Contract-specific errors auto-increment from 1 and are scoped to each contract.
-
-| Contract          | Location                                                              |
-| ----------------- | --------------------------------------------------------------------- |
-| EndpointV2        | `endpoint-v2/src/errors.rs`                                           |
-| ULN302            | `message-libs/uln-302/src/errors.rs`                                  |
-| Treasury          | `message-libs/treasury/src/errors.rs`                                 |
-| SimpleMessageLib  | `message-libs/simple-message-lib/src/errors.rs`                       |
-| DVN               | `workers/dvn/src/errors.rs`                                           |
-| Executor          | `workers/executor/src/errors.rs`                                      |
-| DVN Fee Lib       | `workers/dvn-fee-lib/src/errors.rs`                                   |
-| Executor Fee Lib  | `workers/executor-fee-lib/src/errors.rs`                              |
-| Price Feed        | `workers/price-feed/src/errors.rs`                                    |
-| LayerZero Views   | `layerzero-views/src/errors.rs`                                       |
-| Counter (example) | `apps/project-types/omni-counter-app/contracts/stellar/src/errors.rs` |
-
-### Library Errors (1000+)
-
-Libraries shared across contracts use reserved ranges for global uniqueness.
-
-| Range     | Category     | Library            | Location                                                    |
-| --------- | ------------ | ------------------ | ----------------------------------------------------------- |
-| 1000-1099 | Protocol Lib | utils              | `contracts/common/utils/stellar/common-utils/src/errors.rs` |
-| 1100-1199 | Protocol Lib | message-lib-common | `message-libs/message-lib-common/src/errors.rs`             |
-| 1200-1299 | Protocol Lib | worker             | `workers/worker/src/errors.rs`                              |
-| 1300-1999 | Protocol Lib | (reserved)         | Future protocol libs                                        |
-| 2000-2099 | OApp Lib     | oapp               | `apps/oapp-app/contracts/stellar/contracts/src/errors.rs`   |
-| 2100-2999 | OApp Lib     | (reserved)         | Future OApp libs                                            |
-| 3000-3099 | OFT Lib      | oft-core           | `apps/oft-app/contracts/stellar/oft-core/src/errors.rs`     |
-| 3100-3199 | OFT Lib      | oft (extensions)   | `apps/oft-app/contracts/stellar/oft/src/extensions/`        |
-| 3200-3999 | OFT Lib      | (reserved)         | Future OFT libs                                             |