@lavalogic/scoria 0.38.1 → 0.38.3

package/dist/Components/Table/Misc/TableConfigurationModal.svelte

@@ -14,7 +14,7 @@
 	import { Size } from '../../../Types/Internal/Size.js';
 	import type { TabOption } from '../../../Types/Internal/TabOption.js';
 	import { Variant } from '../../../Types/Internal/Variant.js';
-	import { getContext } from 'svelte';
+	import { getContext, onMount } from 'svelte';
 	import { TableContext } from '../Types/Context/TableContext.svelte.js';
 	import type { Primitive } from '../Types/Context/TableInitOptions.js';
 	import type { DatatableView } from '../Types/Persistence/DatatableView.js';
@@ -48,6 +48,10 @@
 	// errors inline in its own body.
 	let errorMessage = $state<string | null>(null);
 
+	// True while the open-time fetch of saved views is in flight, so the
+	// My-tab shows "Loading…" rather than the "nothing saved yet" message.
+	let loadingViews = $state(false);
+
 	// Whether remote saved views are available at all. A table created
 	// without `datatableUuid` / `remoteLayouts` opts out of remote views;
 	// the modal then renders a graceful "unavailable" empty state and
@@ -93,6 +97,24 @@
 		}
 	}
 
+	// Fetch the saved views fresh every time the modal opens. The boot-time
+	// fetch can miss (it races table construction / auth readiness), so the
+	// modal cannot rely on `_viewState.savedViews` already being populated -
+	// it pulls `GET /datatable-state` itself on open. A failure surfaces in
+	// the inline error banner via `guard` rather than being swallowed.
+	onMount(() => {
+		if (!remoteAvailable) {
+			return;
+		}
+		loadingViews = true;
+		void guard(
+			() => tableContext.refreshSavedViews(),
+			'Could not load saved layouts and filters. Please try again.'
+		).finally(() => {
+			loadingViews = false;
+		});
+	});
+
 	/** Apply a saved view to the live table. Pure local call - no await. */
 	function applyView(view: DatatableView): void {
 		errorMessage = null;
@@ -111,7 +133,14 @@
 		}, `Could not delete "${view.name}". Please try again.`);
 	}
 
-	/** Save the live state of the active section as a brand-new view. */
+	/**
+	 * Save the live state of the active section as a brand-new view.
+	 * `saveCurrentAsNewView` re-fetches the saved views and makes the new
+	 * one active; the `My …` list and the panel dropdowns are all driven
+	 * off the reactive `_viewState.savedViews(section)` so they update
+	 * without a reopen. On success we also switch to the `My …` tab so
+	 * the user immediately sees the view they just saved.
+	 */
 	function saveNewView(): void {
 		const trimmed = newViewName.trim();
 		if (!trimmed) {
@@ -120,6 +149,7 @@
 		void guard(async () => {
 			await tableContext.saveCurrentAsNewView(trimmed, section);
 			newViewName = '';
+			selectTab('mine');
 		}, `Could not save the new ${sectionNoun.toLowerCase()}. Please try again.`);
 	}
 
@@ -293,7 +323,9 @@
 		{/if}
 
 		{#if args.tab === 'mine'}
-			{#if myViews.length === 0}
+			{#if loadingViews}
+				<p class="muted">Loading saved {sectionNounPlural.toLowerCase()}…</p>
+			{:else if myViews.length === 0}
 				<p class="muted">
 					You have not saved any {sectionNounPlural.toLowerCase()} yet. Use the "Save a new {sectionNoun}"
 					tab to create one.
@@ -450,10 +482,6 @@
 					}}
 				/>
 				<Button
-					type="submit"
-					variant={Variant.Primary}
-					size={Size.MediumSmall}
-					nowrap
 					disabled={!newViewName.trim()}
 					onclick={saveNewView}>Save Current</Button
 				>
@@ -537,14 +565,17 @@
   color: #aa1414;
 }
 
-/* The body of a single top tab. Scrolls within the fixed modal
-   frame rather than growing the dialog. */
+/* The body of a single top tab. A `min-height` floor keeps the modal
+   frame visually stable across every section/tab combination (short
+   tabs no longer shrink the dialog); the `max-height` + `overflow-y`
+   keep taller content scrolling within that fixed frame rather than
+   growing the dialog. */
 .tab-body {
   display: flex;
   flex-flow: column nowrap;
   gap: 0.75rem;
   padding: 1rem;
-  min-height: 0;
+  min-height: 30vh;
   max-height: 60vh;
   overflow-y: auto;
 }

package/dist/Components/Table/Types/Context/TableContext.svelte.d.ts

@@ -892,10 +892,18 @@ export declare class TableContext<T extends object, RowIdType extends Primitive>
      *    `{ kind:'filter', filter: _captureFilter() }`, plus the
      *    host-supplied `datatableUuid` and the owning user;
      * 2. `await remoteLayouts.createView(...)`;
-     * 3. push the returned `DatatableView` into the matching kind's
-     *    saved-views list;
-     * 4. apply it via `applyDatatableView`, which re-points that kind's
-     *    baseline and clears that kind's dirty flag.
+     * 3. `await refreshSavedViews()` so the matching kind's saved-views
+     *    list is re-fetched from the backend - the new view then appears
+     *    in the Table Configuration modal's My-Layouts / My-Filters list
+     *    (and the panel quick-switch dropdowns) immediately, without a
+     *    reopen, because both read reactively off `_viewState`;
+     * 4. set the newly-saved view as that kind's active view via
+     *    `applyDatatableView`, which re-points that kind's baseline and
+     *    clears that kind's dirty flag - so the quick-switch dropdown
+     *    shows the new view's name straight away rather than
+     *    `'Custom (unsaved)'`. The authoritative refreshed copy (matched
+     *    by id) is preferred over the raw `createView` return so the
+     *    baseline reflects exactly what the backend persisted.
      *
      * Only the named kind's state is touched. No-op (dev-logged via
      * `devCatch`) when remote saved views are disabled (`datatableUuid` /
@@ -932,8 +940,10 @@ export declare class TableContext<T extends object, RowIdType extends Primitive>
      * against the now-known body of any persisted saved-view ref.
      *
      * No-op when remote saved views are disabled (`datatableUuid` /
-     * `remoteLayouts` absent). An adapter rejection is routed to
-     * `devCatch` and never breaks the table.
+     * `remoteLayouts` absent). An adapter rejection is propagated to the
+     * caller: the boot-time call site catches it with `devCatch`, while
+     * the Table Configuration modal routes it to its inline error banner
+     * so a failed fetch is visible rather than silently swallowed.
      */
     readonly refreshSavedViews: () => Promise<void>;
     /**

package/dist/Components/Table/Types/Context/TableContext.svelte.js

@@ -2309,10 +2309,18 @@ export class TableContext {
      *    `{ kind:'filter', filter: _captureFilter() }`, plus the
      *    host-supplied `datatableUuid` and the owning user;
      * 2. `await remoteLayouts.createView(...)`;
-     * 3. push the returned `DatatableView` into the matching kind's
-     *    saved-views list;
-     * 4. apply it via `applyDatatableView`, which re-points that kind's
-     *    baseline and clears that kind's dirty flag.
+     * 3. `await refreshSavedViews()` so the matching kind's saved-views
+     *    list is re-fetched from the backend - the new view then appears
+     *    in the Table Configuration modal's My-Layouts / My-Filters list
+     *    (and the panel quick-switch dropdowns) immediately, without a
+     *    reopen, because both read reactively off `_viewState`;
+     * 4. set the newly-saved view as that kind's active view via
+     *    `applyDatatableView`, which re-points that kind's baseline and
+     *    clears that kind's dirty flag - so the quick-switch dropdown
+     *    shows the new view's name straight away rather than
+     *    `'Custom (unsaved)'`. The authoritative refreshed copy (matched
+     *    by id) is preferred over the raw `createView` return so the
+     *    baseline reflects exactly what the backend persisted.
      *
      * Only the named kind's state is touched. No-op (dev-logged via
      * `devCatch`) when remote saved views are disabled (`datatableUuid` /
@@ -2342,8 +2350,15 @@ export class TableContext {
                 ownerUserId,
             };
             const created = await adapter.createView(request);
-            this._viewState.setSavedViews(kind, [...this._viewState.savedViews(kind), created]);
-            this.applyDatatableView(created);
+            // Re-fetch the authoritative saved-views lists so the new view
+            // shows up in the modal and the panel dropdowns immediately.
+            await this.refreshSavedViews();
+            // Prefer the refreshed copy (matched by id); fall back to the
+            // raw create return if the refresh did not surface it.
+            const authoritative = this._viewState.savedViews(kind).find((view) => view.id === created.id) ?? created;
+            // Make the just-saved view active so the quick-switch dropdown
+            // shows its name (not "Custom (unsaved)") and dirty is cleared.
+            this.applyDatatableView(authoritative);
         }
         catch (e) {
             devCatch(e);
@@ -2424,8 +2439,10 @@ export class TableContext {
      * against the now-known body of any persisted saved-view ref.
      *
      * No-op when remote saved views are disabled (`datatableUuid` /
-     * `remoteLayouts` absent). An adapter rejection is routed to
-     * `devCatch` and never breaks the table.
+     * `remoteLayouts` absent). An adapter rejection is propagated to the
+     * caller: the boot-time call site catches it with `devCatch`, while
+     * the Table Configuration modal routes it to its inline error banner
+     * so a failed fetch is visible rather than silently swallowed.
      */
     refreshSavedViews = async () => {
         const adapter = this.remoteLayouts;
@@ -2433,18 +2450,13 @@ export class TableContext {
         if (!adapter || !datatableUuid) {
             return;
         }
-        try {
-            const views = await adapter.listViews(datatableUuid);
-            this._viewState.setSavedViews('layout', views.filter((view) => view.kind === 'layout'));
-            this._viewState.setSavedViews('filter', views.filter((view) => view.kind === 'filter'));
-            // A persisted saved-view ref restored at boot may have had an
-            // unknown body until now; reconcile both baselines against it.
-            this._reconcileBaselineForActiveView();
-            this._reconcileBaselineForActiveFilterView();
-        }
-        catch (e) {
-            devCatch(e);
-        }
+        const views = await adapter.listViews(datatableUuid);
+        this._viewState.setSavedViews('layout', views.filter((view) => view.kind === 'layout'));
+        this._viewState.setSavedViews('filter', views.filter((view) => view.kind === 'filter'));
+        // A persisted saved-view ref restored at boot may have had an
+        // unknown body until now; reconcile both baselines against it.
+        this._reconcileBaselineForActiveView();
+        this._reconcileBaselineForActiveFilterView();
     };
     /**
      * Drop the persisted live-layout snapshot for this table. The next

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@lavalogic/scoria",
   "description": "Svelte components used for the FloWMS Web Frontend",
-  "version": "0.38.1",
+  "version": "0.38.3",
   "publishConfig": {
     "access": "restricted"
   },