@lavalogic/scoria 0.35.0 → 0.37.0

package/dist/Components/Table/Body/Rows/Columns/FocusableImmutableCellProps.d.ts

@@ -1,6 +1,13 @@
 import type { TableCell } from '../../../Types/Columns/TableCell.js';
 import type { Snippet } from 'svelte';
+/**
+ * Props for {@link FocusableImmutableCell}. Either the cell renders its own
+ * (possibly async) display value, or, if the value is absent (`undefined`),
+ * the consumer's `children` snippet is rendered inside a focus-styled wrapper.
+ */
 export interface FocusableImmutableCellProps<T extends object, FilterValueType> {
+    /** Cell whose value should be rendered read-only. */
     cell: TableCell<T, FilterValueType>;
+    /** Optional snippet rendered when `cell.getValue()` is `undefined`. */
     children?: Snippet;
 }

package/dist/Components/Table/Body/Rows/Columns/ProgressCell.svelte

@@ -1,99 +1,112 @@
-<svelte:options runes />
-
-<script
-	lang="ts"
-	module
->
-	import ProgressBubble from '../../../../ProgressBubble.svelte';
-	import type { ProgressBarTableCell } from '../../../Types/Columns/ProgressBarTableCell.js';
-	import { TableContext } from '../../../Types/Context/TableContext.svelte.js';
-	import { TableFocusDetails } from '../../../Types/Focus/TableFocusDetails.svelte.js';
-	import { devCatch, isValidityTuple } from '../../../../../Helpers/Helpers.svelte.js';
-	import { Validity } from '../../../../../Types/Internal/Validity.js';
-	import { getContext } from 'svelte';
-
-	export interface ProgressCellProps<T extends object, FilterValueType> {
-		cell: ProgressBarTableCell<T, FilterValueType>;
-	}
-</script>
-
-<!-- TODO editable version of this should contain a multi select -->
-<script
-	lang="ts"
-	generics="T extends object, FilterValueType"
->
-	const { cell }: ProgressCellProps<T, FilterValueType> = $props();
-
-	const value: [number, number] = $derived(cell.getValue()) as [number, number];
-
-	const tableContext = getContext<TableContext<T, never>>(TableContext.identifier);
-	// const previousRowIndex: number | undefined = $state(undefined);
-
-	const focusDetails = $derived(new TableFocusDetails<T, never>(cell, tableContext));
-
-	let validity: Validity = $state(Validity.Valid);
-	$effect(() => {
-		const validityPromise = focusDetails.validity;
-
-		validityPromise
-			.then((v) => {
-				if (!v) {
-					validity = Validity.Neutral;
-				} else if (isValidityTuple(v)) {
-					validity = v.value;
-				} else {
-					validity = v;
-				}
-			})
-			.catch(devCatch);
-	});
-
-	const colours = $derived(
-		cell.column.columnDef.getColour(cell.row.original, cell.row.originalIndex, value)
-	);
-</script>
-
-<!-- svelte-ignore a11y_mouse_events_have_key_events -->
-<td
-	id={`${tableContext.tableName}-cell-${cell.row.visibleIndex}-${cell.column.id}`}
-	tabIndex={0}
-	class="focusable"
-	class:multifocus={focusDetails.isMultiFocused}
-	class:multifocus-start={focusDetails.isMultiFocusStart}
-	style={focusDetails.outline}
-	class:info={validity == Validity.Info}
-	class:success={validity == Validity.Valid}
-	class:warning={validity == Validity.Warning}
-	class:error={validity == Validity.Invalid}
-	onmousedown={(e) => {
-		// start focus only on left click
-		if (e.button === 0) {
-			if (e.shiftKey) {
-				e.preventDefault();
-				tableContext.setFocusEnd(focusDetails.coordinates);
-			} else {
-				tableContext.startFocus(focusDetails.coordinates);
-			}
-		}
-	}}
-	onmouseover={() => {
-		if (tableContext.isMousingDown) {
-			tableContext.setFocusEnd(focusDetails.coordinates);
-		}
-	}}
-	onmouseup={() => {
-		tableContext.endFocus(focusDetails.coordinates);
-	}}
->
-	<div class="bubble-parent">
-		<ProgressBubble
-			{value}
-			{colours}
-		/>
-	</div>
-</td>
-
-<style>td {
+<svelte:options runes />
+
+<script
+	lang="ts"
+	module
+>
+	import ProgressBubble from '../../../../ProgressBubble.svelte';
+	import type { ProgressBarTableCell } from '../../../Types/Columns/ProgressBarTableCell.js';
+	import { TableContext } from '../../../Types/Context/TableContext.svelte.js';
+	import { type Primitive } from '../../../Types/Context/TableInitOptions.js';
+	import { devCatch, isValidityTuple } from '../../../../../Helpers/Helpers.svelte.js';
+	import { Validity } from '../../../../../Types/Internal/Validity.js';
+	import { getContext } from 'svelte';
+
+	/**
+	 * Props for {@link ProgressCell}. The cell renders a single `<ProgressBubble>`
+	 * whose `[done, total]` tuple comes from `cell.getValue()`.
+	 */
+	export interface ProgressCellProps<T extends object, FilterValueType> {
+		/** Progress-bar table cell whose `[done, total]` value should be rendered. */
+		cell: ProgressBarTableCell<T, FilterValueType>;
+	}
+</script>
+
+<script
+	lang="ts"
+	generics="T extends object, FilterValueType, RowIdType extends Primitive"
+>
+	const { cell }: ProgressCellProps<T, FilterValueType> = $props();
+
+	/**
+	 * Tuple of `[done, total]`. The cast is unavoidable until `ProgressBarDef`
+	 * carries a narrowed `TValue = [number, number]` generic; tracked under
+	 * the cross-cutting RowGenericThreading + ProgressBarDef.value follow-up.
+	 */
+	const value: [number, number] = $derived(cell.getValue()) as [number, number];
+
+	const tableContext = getContext<TableContext<T, RowIdType>>(TableContext.identifier);
+
+	const focusDetails = $derived(tableContext._focus.getFocusDetailsFor(cell));
+
+	let validity: Validity = $state(Validity.Valid);
+	$effect(() => {
+		const validityPromise = focusDetails.validity;
+
+		validityPromise
+			.then((v) => {
+				if (!v) {
+					validity = Validity.Neutral;
+				} else if (isValidityTuple(v)) {
+					validity = v.value;
+				} else {
+					validity = v;
+				}
+			})
+			.catch(devCatch);
+	});
+
+	const colours = $derived(
+		cell.column.columnDef.getColour(cell.row.original, cell.row.originalIndex, value)
+	);
+</script>
+
+<!-- svelte-ignore a11y_mouse_events_have_key_events -->
+<!-- svelte-ignore a11y_no_static_element_interactions -->
+<div
+	id={`${tableContext.tableName}-cell-${cell.row.visibleIndex}-${cell.column.id}`}
+	tabIndex={0}
+	class="focusable"
+	class:multifocus={focusDetails.isMultiFocused}
+	class:multifocus-start={focusDetails.isMultiFocusStart}
+	style={focusDetails.outline}
+	class:info={validity == Validity.Info}
+	class:success={validity == Validity.Valid}
+	class:warning={validity == Validity.Warning}
+	class:error={validity == Validity.Invalid}
+	onmousedown={(e) => {
+		// start focus only on left click
+		if (e.button === 0) {
+			if (e.shiftKey) {
+				e.preventDefault();
+				tableContext.setFocusEnd(focusDetails.coordinates);
+			} else {
+				tableContext.startFocus(focusDetails.coordinates);
+			}
+		}
+	}}
+	onmouseover={() => {
+		if (tableContext.isMousingDown) {
+			tableContext.setFocusEnd(focusDetails.coordinates);
+		}
+	}}
+	onmouseup={() => {
+		tableContext.endFocus(focusDetails.coordinates);
+	}}
+>
+	<div class="bubble-parent">
+		<ProgressBubble
+			{value}
+			{colours}
+		/>
+	</div>
+</div>
+
+<style>.focusable,
+.checkbox-cell,
+.input-cell,
+.select-cell,
+.datepicker-cell {
   transition: line-height 0.2s ease, height 0.2s ease;
   --input-border: none;
   --input-height: var(--height);
@@ -103,40 +116,61 @@
   position: relative;
   padding-left: 0.75rem;
   padding-right: 0.75rem;
-  border: solid 1px #cbd4da;
-  border-left: none;
+  border-right: solid 1px #cbd4da;
+  border-bottom: solid 1px #cbd4da;
+  box-sizing: border-box;
+  width: 100%;
+  height: var(--height);
 }
 
-td.multifocus {
+.focusable.multifocus,
+.checkbox-cell.multifocus,
+.input-cell.multifocus,
+.select-cell.multifocus {
   background-color: var(--multifocus-colour, #e6f8fd);
 }
-td.multifocus.multifocus-start {
+.focusable.multifocus.multifocus-start,
+.checkbox-cell.multifocus.multifocus-start,
+.input-cell.multifocus.multifocus-start,
+.select-cell.multifocus.multifocus-start {
   background-color: #ffffff;
 }
 
-td.focusable {
+.focusable {
   user-select: none;
   cursor: default;
   outline: none;
 }
-td.focusable.editable {
+.focusable.editable {
   cursor: pointer;
 }
 
-td.info {
+.focusable.info,
+.checkbox-cell.info,
+.input-cell.info,
+.select-cell.info {
   background-color: #1f81a0;
 }
-td.warning {
+.focusable.warning,
+.checkbox-cell.warning,
+.input-cell.warning,
+.select-cell.warning {
   background-color: #f8eab8;
 }
-td.error {
+.focusable.error,
+.checkbox-cell.error,
+.input-cell.error,
+.select-cell.error {
   background-color: #f9e9e9;
 }
 
-td {
+.focusable,
+.checkbox-cell,
+.input-cell,
+.select-cell {
   max-height: var(--max-height);
   height: var(--height);
-  box-sizing: content-box;
+  box-sizing: border-box;
   overflow-x: clip;
   --td-padding-left: 0;
   --td-padding-right: 0;
@@ -153,4 +187,4 @@ div.bubble-parent {
   align-items: center;
   gap: 0.75rem;
   --line-height: 1;
-}</style>
+}</style>

package/dist/Components/Table/Body/Rows/Columns/ProgressCell.svelte.d.ts

@@ -1,28 +1,34 @@
 import type { ProgressBarTableCell } from '../../../Types/Columns/ProgressBarTableCell.js';
+import { type Primitive } from '../../../Types/Context/TableInitOptions.js';
+/**
+ * Props for {@link ProgressCell}. The cell renders a single `<ProgressBubble>`
+ * whose `[done, total]` tuple comes from `cell.getValue()`.
+ */
 export interface ProgressCellProps<T extends object, FilterValueType> {
+    /** Progress-bar table cell whose `[done, total]` value should be rendered. */
     cell: ProgressBarTableCell<T, FilterValueType>;
 }
-declare function $$render<T extends object, FilterValueType>(): {
+declare function $$render<T extends object, FilterValueType, RowIdType extends Primitive>(): {
     props: ProgressCellProps<T, FilterValueType>;
     exports: {};
     bindings: "";
     slots: {};
     events: {};
 };
-declare class __sveltets_Render<T extends object, FilterValueType> {
-    props(): ReturnType<typeof $$render<T, FilterValueType>>['props'];
-    events(): ReturnType<typeof $$render<T, FilterValueType>>['events'];
-    slots(): ReturnType<typeof $$render<T, FilterValueType>>['slots'];
+declare class __sveltets_Render<T extends object, FilterValueType, RowIdType extends Primitive> {
+    props(): ReturnType<typeof $$render<T, FilterValueType, RowIdType>>['props'];
+    events(): ReturnType<typeof $$render<T, FilterValueType, RowIdType>>['events'];
+    slots(): ReturnType<typeof $$render<T, FilterValueType, RowIdType>>['slots'];
     bindings(): "";
     exports(): {};
 }
 interface $$IsomorphicComponent {
-    new <T extends object, FilterValueType>(options: import('svelte').ComponentConstructorOptions<ReturnType<__sveltets_Render<T, FilterValueType>['props']>>): import('svelte').SvelteComponent<ReturnType<__sveltets_Render<T, FilterValueType>['props']>, ReturnType<__sveltets_Render<T, FilterValueType>['events']>, ReturnType<__sveltets_Render<T, FilterValueType>['slots']>> & {
-        $$bindings?: ReturnType<__sveltets_Render<T, FilterValueType>['bindings']>;
-    } & ReturnType<__sveltets_Render<T, FilterValueType>['exports']>;
-    <T extends object, FilterValueType>(internal: unknown, props: ReturnType<__sveltets_Render<T, FilterValueType>['props']> & {}): ReturnType<__sveltets_Render<T, FilterValueType>['exports']>;
-    z_$$bindings?: ReturnType<__sveltets_Render<any, any>['bindings']>;
+    new <T extends object, FilterValueType, RowIdType extends Primitive>(options: import('svelte').ComponentConstructorOptions<ReturnType<__sveltets_Render<T, FilterValueType, RowIdType>['props']>>): import('svelte').SvelteComponent<ReturnType<__sveltets_Render<T, FilterValueType, RowIdType>['props']>, ReturnType<__sveltets_Render<T, FilterValueType, RowIdType>['events']>, ReturnType<__sveltets_Render<T, FilterValueType, RowIdType>['slots']>> & {
+        $$bindings?: ReturnType<__sveltets_Render<T, FilterValueType, RowIdType>['bindings']>;
+    } & ReturnType<__sveltets_Render<T, FilterValueType, RowIdType>['exports']>;
+    <T extends object, FilterValueType, RowIdType extends Primitive>(internal: unknown, props: ReturnType<__sveltets_Render<T, FilterValueType, RowIdType>['props']> & {}): ReturnType<__sveltets_Render<T, FilterValueType, RowIdType>['exports']>;
+    z_$$bindings?: ReturnType<__sveltets_Render<any, any, any>['bindings']>;
 }
 declare const ProgressCell: $$IsomorphicComponent;
-type ProgressCell<T extends object, FilterValueType> = InstanceType<typeof ProgressCell<T, FilterValueType>>;
+type ProgressCell<T extends object, FilterValueType, RowIdType extends Primitive> = InstanceType<typeof ProgressCell<T, FilterValueType, RowIdType>>;
 export default ProgressCell;

package/dist/Components/Table/Body/Rows/Columns/RowSelectionColumn.d.ts

@@ -1,6 +1,14 @@
 import type { Column } from '../../../Types/Columns/Column.js';
 import type { RowSelectionDef } from '../../../Types/Columns/Definitions/RowSelection/RowSelectionDef.svelte.js';
 import type { BoolFilterValueType } from '../../../Types/Filtering/FilterFn.js';
+/**
+ * Narrowed `Column<T>` whose `columnDef` is a `RowSelectionDef`.
+ *
+ * The filter value type is fixed to `BoolFilterValueType` (selected /
+ * not-selected / tri-state null) because row-selection is the only filter
+ * value space this column supports; consumers therefore do not need to thread
+ * a second generic.
+ */
 export interface RowSelectionColumn<T extends object> extends Column<T, BoolFilterValueType> {
     columnDef: RowSelectionDef<T>;
 }

package/dist/Components/Table/Body/Rows/Columns/RowSelectionTableCell.d.ts

@@ -1,6 +1,11 @@
 import type { TableCell } from '../../../Types/Columns/TableCell.js';
 import type { BoolFilterValueType } from '../../../Types/Filtering/FilterFn.js';
 import type { RowSelectionColumn } from './RowSelectionColumn.js';
+/**
+ * Narrowed `TableCell<T>` whose `column` is a `RowSelectionColumn`. Paired
+ * with `RowSelectionColumn` so the row-selection checkbox component receives a
+ * cell handle that has already been narrowed away from the generic union.
+ */
 export interface RowSelectionTableCell<T extends object> extends TableCell<T, BoolFilterValueType> {
     column: RowSelectionColumn<T>;
 }

package/dist/Components/Table/Body/Rows/Columns/SelectColumn.d.ts

@@ -1,5 +1,16 @@
 import type { Column } from '../../../Types/Columns/Column.js';
 import type { SelectDef } from '../../../Types/Columns/Definitions/Accessors/SelectDef.svelte.js';
+/**
+ * Narrowed `Column<T>` whose `columnDef` is a `SelectDef`.
+ *
+ * The variance markers (`in FilterValueType`, `out SelectValueType`) mirror
+ * the underlying `SelectDef` declaration and let TypeScript co-/contra-variance
+ * follow the assignability of select-typed columns. The historical defaults
+ * (`FilterValueType = T`, `SelectValueType = T`) are intentionally retained
+ * to avoid mass-breakage of the eight `SelectColumn<T>` consumers; the
+ * type-strictness review proposed tightening these to `unknown`. Tightening
+ * is deferred (see workorder Cell Glue Types finding 2).
+ */
 export interface SelectColumn<T extends object, in FilterValueType = T, out SelectValueType = T> extends Column<T, FilterValueType> {
     columnDef: SelectDef<T, FilterValueType, SelectValueType>;
 }

package/dist/Components/Table/Body/Rows/Columns/SelectTableCell.d.ts

@@ -1,5 +1,16 @@
 import type { TableCell } from '../../../Types/Columns/TableCell.js';
 import type { SelectColumn } from './SelectColumn.js';
+/**
+ * Narrowed `TableCell<T>` whose `column` is a `SelectColumn`. `TableSelect`
+ * and `MultiSelect` cell hosts consume this so that `cell.column.columnDef`
+ * resolves directly to a `SelectDef` without runtime casts.
+ *
+ * The third generic on `SelectColumn` (`SelectValueType`) is not threaded
+ * through here for consistency with the rest of the cell-glue group; the
+ * underlying `SelectColumn<T, FilterValueType>` defaults `SelectValueType` to
+ * `T` so the cell still compiles. Threading that third generic through is
+ * deferred (see workorder Cell Glue Types finding 4).
+ */
 export interface SelectTableCell<T extends object, FilterValueType> extends TableCell<T, FilterValueType> {
     column: SelectColumn<T, FilterValueType>;
 }

package/dist/Components/Table/Body/Rows/Columns/TableAction.svelte

@@ -1,72 +1,87 @@
-<svelte:options runes />
-
-<script
-	lang="ts"
-	module
->
-	import Button from '../../../../Button.svelte';
-	import type { TableActionButton } from '../../../Types/Columns/TableActionButton.js';
-	import { getErrorMessage } from '../../../../../Helpers/Helpers.svelte.js';
-	import { ColourSet } from '../../../../../scss/colours.js';
-	import { Size } from '../../../../../Types/Internal/Size.js';
-	import type { ActionsTableCell } from './ActionsTableCell.js';
-
-	export interface TableActionProps<T extends object, FilterValueType> {
-		action: TableActionButton<T>;
-		cell: ActionsTableCell<T, FilterValueType>;
-	}
-</script>
-
-<script
-	lang="ts"
-	generics="T extends object,FilterValueType"
->
-	const { action, cell }: TableActionProps<T, FilterValueType> = $props();
-
-	const isEnabledPromise: boolean | Promise<boolean> = $derived.by(() => {
-		const disabled = action.isDisabled?.(cell.row.original, cell.row.originalIndex);
-
-		if (disabled != null) {
-			if (typeof disabled == 'boolean') {
-				return !disabled;
-			} else {
-				return disabled.then((it) => !it);
-			}
-		}
-		return (
-			cell.column.columnDef.isEnabled?.(cell.row.original, cell.row.originalIndex, action) ?? true
-		);
-	});
-
-	const labelPromise: Promise<string> = $derived.by(() => {
-		const result = action.getLabel(cell.row.original, cell.row.originalIndex);
-
-		if (typeof result == 'object') {
-			return result.then((it) => it);
-		} else {
-			return Promise.resolve(result);
-		}
-	});
-</script>
-
-{#await labelPromise then label}
-	{#await isEnabledPromise then isEnabled}
-		<Button
-			fullWidth
-			size={Size.Medium}
-			colourSet={cell.column.columnDef.getColourSet?.(
-				cell.row.original,
-				cell.row.originalIndex,
-				action
-			) ?? ColourSet.Secondary}
-			disabled={!isEnabled}
-			onclick={() => {
-				action.callback(cell.row.original, cell.row.originalIndex);
-			}}>{label}</Button
-		>
-	{:catch e}
-		Error Loading Button: {getErrorMessage(e)}
-	{/await}
-{:catch e}
-	Error Loading Button: {getErrorMessage(e)}
-{/await}
+<svelte:options runes />
+
+<script
+	lang="ts"
+	module
+>
+	import Button from '../../../../Button.svelte';
+	import type { TableActionButton } from '../../../Types/Columns/TableActionButton.js';
+	import { getErrorMessage } from '../../../../../Helpers/Helpers.svelte.js';
+	import { ColourSet } from '../../../../../scss/colours.js';
+	import { Size } from '../../../../../Types/Internal/Size.js';
+	import type { ActionsTableCell } from './ActionsTableCell.js';
+
+	/**
+	 * Props for {@link TableAction}. Renders a single row-action `<Button>`
+	 * inside the actions popover; resolves the per-row label and enabled flag
+	 * from the `action` callbacks (each may be sync or async).
+	 *
+	 * Kept inline because extracting it would change the public import path
+	 * for the `TableActionProps` type (breaking); the sibling-Props file
+	 * extraction is deferred to the cross-cutting Props-extraction sweep.
+	 */
+	export interface TableActionProps<T extends object, FilterValueType> {
+		/** The action button to render (one button per `cell.column.columnDef.actions[*]`). */
+		action: TableActionButton<T>;
+		/** The host actions-cell instance, used to resolve per-row state. */
+		cell: ActionsTableCell<T, FilterValueType>;
+	}
+</script>
+
+<script
+	lang="ts"
+	generics="T extends object, FilterValueType"
+>
+	import { dev } from '$app/environment';
+
+	const { action, cell }: TableActionProps<T, FilterValueType> = $props();
+
+	/**
+	 * Resolved [label, isEnabled] tuple. Both sources are awaited in parallel
+	 * via Promise.all so an async `getLabel` does not serialise behind an
+	 * async `isDisabled`.
+	 */
+	const buttonStatePromise: Promise<[string, boolean]> = $derived.by(() => {
+		const disabledResult = action.isDisabled?.(cell.row.original, cell.row.originalIndex);
+
+		const isEnabledPromise: Promise<boolean> =
+			disabledResult == null
+				? Promise.resolve(
+						cell.column.columnDef.isEnabled?.(cell.row.original, cell.row.originalIndex, action) ??
+							true
+					)
+				: typeof disabledResult === 'boolean'
+					? Promise.resolve(!disabledResult)
+					: disabledResult.then((it) => !it);
+
+		const labelPromise: Promise<string> = Promise.resolve(
+			action.getLabel(cell.row.original, cell.row.originalIndex)
+		);
+
+		return Promise.all([labelPromise, isEnabledPromise]);
+	});
+</script>
+
+{#await buttonStatePromise}
+	<!-- intentionally empty: the actions popover frame already conveys the loading state -->
+{:then [label, isEnabled]}
+	<Button
+		fullWidth
+		size={Size.Medium}
+		colourSet={cell.column.columnDef.getColourSet?.(
+			cell.row.original,
+			cell.row.originalIndex,
+			action
+		) ?? ColourSet.Secondary}
+		disabled={!isEnabled}
+		onclick={() => {
+			action.callback(cell.row.original, cell.row.originalIndex);
+		}}>{label}</Button
+	>
+{:catch e}
+	{#if dev}
+		Error Loading Button: {getErrorMessage(e)}
+	{:else}
+		Error Loading Button
+	{/if}
+{/await}

package/dist/Components/Table/Body/Rows/Columns/TableAction.svelte.d.ts

@@ -1,7 +1,18 @@
 import type { TableActionButton } from '../../../Types/Columns/TableActionButton.js';
 import type { ActionsTableCell } from './ActionsTableCell.js';
+/**
+ * Props for {@link TableAction}. Renders a single row-action `<Button>`
+ * inside the actions popover; resolves the per-row label and enabled flag
+ * from the `action` callbacks (each may be sync or async).
+ *
+ * Kept inline because extracting it would change the public import path
+ * for the `TableActionProps` type (breaking); the sibling-Props file
+ * extraction is deferred to the cross-cutting Props-extraction sweep.
+ */
 export interface TableActionProps<T extends object, FilterValueType> {
+    /** The action button to render (one button per `cell.column.columnDef.actions[*]`). */
     action: TableActionButton<T>;
+    /** The host actions-cell instance, used to resolve per-row state. */
     cell: ActionsTableCell<T, FilterValueType>;
 }
 declare function $$render<T extends object, FilterValueType>(): {