@lark-codem/codem-core 0.8.5 → 0.8.6-windows-input-diagnostics.202608191130.0.g715d8fa

package/bin/lib/launch.js

@@ -44,6 +44,41 @@ function hintsFor(code, platform, binary) {
   }
 }
 
+/// Should the platform binary be spawned with `windowsHide`?
+///
+/// `windowsHide` is not just cosmetic on Windows: libuv translates it into
+/// `CREATE_NO_WINDOW`, and per MSDN "Creation of a Console" a process created
+/// with that flag gets a **brand new console** (merely one without a window)
+/// instead of inheriting the parent's.
+///
+/// For an ordinary child that is harmless — stdout/stdin still reach the
+/// parent's console through the explicitly inherited handles. linco is not an
+/// ordinary child: it is a full-screen TUI, and crossterm does NOT read the
+/// keyboard from inherited fd 0. It opens `CONIN$` (crossterm_winapi
+/// `Handle::current_in_handle`), i.e. the input buffer of **the console this
+/// process is attached to**. Hide the window and the two diverge: the frame
+/// renders fine over the inherited output handle while keystrokes are read
+/// from the freshly allocated, forever-empty buffer.
+///
+/// So: when the parent is already attached to a console, never hide — there is
+/// no window to suppress in that case anyway, which is the only thing the flag
+/// was ever wanted for. When it is not (spawned from a GUI app, a service, or
+/// any other windowless context), keep hiding so no console box flashes up.
+///
+/// Non-Windows platforms ignore the option entirely; keep passing `true` there
+/// so this stays a Windows-only behaviour change.
+function shouldHideWindow({ platform, stdinIsTTY, stdoutIsTTY, stderrIsTTY }) {
+  if (platform !== "win32") {
+    return true;
+  }
+  // Any std stream being a TTY proves a console is attached. Checking all three
+  // (rather than just stdin) keeps redirection from producing a false negative:
+  // `codem < input.txt` still has a console, and hiding it there would break
+  // the keyboard for exactly the same reason.
+  const attachedToConsole = Boolean(stdinIsTTY || stdoutIsTTY || stderrIsTTY);
+  return !attachedToConsole;
+}
+
 function reportFatal({ error, binary, platform, stderr, exit }) {
   stderr(`linco: failed to launch ${binary}`);
   stderr(`  ${error && error.message ? error.message : String(error)}`);
@@ -68,12 +103,21 @@ function launch({
   args,
   stdio,
   platform = process.platform,
+  stdinIsTTY = process.stdin.isTTY,
+  stdoutIsTTY = process.stdout.isTTY,
+  stderrIsTTY = process.stderr.isTTY,
   spawnImpl = require("node:child_process").spawn,
   stderr = (line) => console.error(line),
   exit = (code) => process.exit(code),
 }) {
+  const windowsHide = shouldHideWindow({
+    platform,
+    stdinIsTTY,
+    stdoutIsTTY,
+    stderrIsTTY,
+  });
   const attempt = (stdioForAttempt) =>
-    spawnImpl(binary, args, { stdio: stdioForAttempt, windowsHide: true });
+    spawnImpl(binary, args, { stdio: stdioForAttempt, windowsHide });
 
   let child;
   try {
@@ -103,4 +147,4 @@ function launch({
   return child;
 }
 
-module.exports = { launch, hintsFor };
+module.exports = { launch, hintsFor, shouldHideWindow };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lark-codem/codem-core",
-  "version": "0.8.5",
+  "version": "0.8.6-windows-input-diagnostics.202608191130.0.g715d8fa",
   "description": "CodeM CLI.",
   "license": "SEE LICENSE IN LICENSE",
   "bin": {
@@ -11,15 +11,11 @@
     "LICENSE"
   ],
   "optionalDependencies": {
-    "@lark-codem/codem-core-darwin-arm64": "0.8.5",
-    "@lark-codem/codem-core-darwin-x64": "0.8.5",
-    "@lark-codem/codem-core-linux-arm64-gnu": "0.8.5",
-    "@lark-codem/codem-core-linux-arm64-musl": "0.8.5",
-    "@lark-codem/codem-core-linux-x64-gnu": "0.8.5",
-    "@lark-codem/codem-core-linux-x64-musl": "0.8.5",
-    "@lark-codem/codem-core-win32-arm64-gnu": "0.8.5",
-    "@lark-codem/codem-core-win32-ia32-gnu": "0.8.5",
-    "@lark-codem/codem-core-win32-x64-gnu": "0.8.5"
+    "@lark-codem/codem-core-darwin-arm64": "0.8.6-windows-input-diagnostics.202608191130.0.g715d8fa",
+    "@lark-codem/codem-core-linux-arm64-gnu": "0.8.6-windows-input-diagnostics.202608191130.0.g715d8fa",
+    "@lark-codem/codem-core-linux-x64-gnu": "0.8.6-windows-input-diagnostics.202608191130.0.g715d8fa",
+    "@lark-codem/codem-core-win32-arm64-gnu": "0.8.6-windows-input-diagnostics.202608191130.0.g715d8fa",
+    "@lark-codem/codem-core-win32-x64-gnu": "0.8.6-windows-input-diagnostics.202608191130.0.g715d8fa"
   },
   "engines": {
     "node": ">=18"