@lark-apaas/fullstack-presets 1.1.7 → 1.1.8

package/lib/recommend/eslint/eslint-client.js

@@ -56,6 +56,8 @@ exports.default = {
         'no-undef': 'off', // 禁止使用未声明的变量
         'no-console': 'off', // 允许使用 console
         'prefer-const': 'off', // 不强制使用 const
+        'no-case-declarations': 'off', // 允许在 case 块中使用词法声明
+        'no-empty': 'off', // 允许空的 catch 块
         // Import 规则
         'import/no-unresolved': 'error', // 检查导入路径是否存在
         // 其他规则
@@ -112,35 +114,36 @@ exports.default = {
                 selector: 'AssignmentExpression[left.object.name="location"][left.property.name="href"]',
                 message: "Please don't use `location.href` to navigate. Use `useNavigate` hook from 'react-router-dom' instead.",
             },
-            // SelectItem组件的value属性值不能为空字符串
-            {
-                message: 'The `value` attribute of the `SelectItem` component cannot be an empty string.',
-                selector: 'JSXOpeningElement[name.name="SelectItem"]:has(JSXAttribute[name.name="value"][value.value=""]), JSXOpeningElement[name.name="SelectItem"]:has(JSXAttribute[name.name="value"][value.expression.value=""])',
-            },
             // 禁止a标签href使用相对路径
             {
                 selector: "JSXOpeningElement[name.name='a']:has(JSXAttribute[name.name='href'][value.value=/^(?!https?:|\\u002F\\u002F|mailto:|tel:|#).+/])",
                 message: "Please don't use relative paths in <a> tags. Use NavLink from 'react-router-dom' instead.",
             },
             // 禁止 variant 为 outline|link|ghost 的 Button 使用 text-white
-            {
-                selector: 'JSXElement[openingElement.name.name="Button"]' +
-                    ':has(JSXAttribute[name.name="variant"][value.value=/^(outline|link|ghost)$/])' +
-                    ':has(JSXAttribute[name.name="className"][value.value=/text-white/])',
-                message: 'Button with variant="outline|link|ghost" should not use "text-white" className. This causes visibility issues. Consider using proper semantic color tokens from `client/src/tailwind-theme.css`',
-            },
-            // 禁止在 Button 上组合 text-primary-foreground 与 bg-background 并用的情况
-            {
-                selector: 'JSXElement[openingElement.name.name="Button"]' +
-                    ':has(JSXAttribute[name.name="className"][value.value=/text-primary-foreground/])' +
-                    ':has(JSXAttribute[name.name="className"][value.value=/bg-background/])',
-                message: 'Button should not use "text-primary-foreground" and "bg-background" className. This causes visibility issues. Consider using proper semantic color tokens from `client/src/tailwind-theme.css`',
-            },
-            // 禁止使用 text-accent
-            {
-                selector: 'JSXAttribute[name.name="className"][value.value=/(^|\\s)text-accent(\\s|$)/]',
-                message: 'Classname "text-accent" would cause visibility issues. Consider using proper semantic color tokens from `client/src/tailwind-theme.css`',
-            },
+            // {
+            //   selector: 
+            //     'JSXElement[openingElement.name.name="Button"]' +
+            //     ':has(JSXAttribute[name.name="variant"][value.value=/^(outline|link|ghost)$/])' +
+            //     ':has(JSXAttribute[name.name="className"][value.value=/text-white/])',
+            //   message: 
+            //     'Button with variant="outline|link|ghost" should not use "text-white" className. This causes visibility issues. Consider using proper semantic color tokens from `client/src/tailwind-theme.css`',
+            // },
+            // // 禁止在 Button 上组合 text-primary-foreground 与 bg-background 并用的情况
+            // {
+            //   selector: 
+            //     'JSXElement[openingElement.name.name="Button"]' +
+            //     ':has(JSXAttribute[name.name="className"][value.value=/text-primary-foreground/])' + 
+            //     ':has(JSXAttribute[name.name="className"][value.value=/bg-background/])',
+            //   message: 
+            //     'Button should not use "text-primary-foreground" and "bg-background" className. This causes visibility issues. Consider using proper semantic color tokens from `client/src/tailwind-theme.css`',
+            // },
+            // // 禁止使用 text-accent
+            // {
+            //   selector:
+            //     'JSXAttribute[name.name="className"][value.value=/(^|\\s)text-accent(\\s|$)/]',
+            //   message:
+            //     'Classname "text-accent" would cause visibility issues. Consider using proper semantic color tokens from `client/src/tailwind-theme.css`',
+            // },
             // 禁止在 Tailwind 任意值语法中使用包含空格的 hsl/rgb 值
             {
                 selector: 'JSXAttribute[name.name="className"][value.value=/\\[hsl\\([^\\]]*\\s[^\\]]*\\)/]',

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lark-apaas/fullstack-presets",
-  "version": "1.1.7",
+  "version": "1.1.8",
   "files": [
     "lib"
   ],

package/lib/custom-eslint-rules/no-welcome-index-route.d.ts

@@ -1,12 +0,0 @@
-/**
- * ESLint rule to disallow Welcome or PagePlaceholder components as the default home page route.
- *
- * This rule enforces that the first-level index route (the actual home page at "/")
- * should use an actual page component rather than placeholder components from the framework.
- *
- * Only checks the first-level index route nested directly under a parent Route (typically Layout).
- * Only flags Welcome/PagePlaceholder if they are imported from @lark-apaas/client-toolkit.
- */
-import type { Rule } from 'eslint';
-declare const rule: Rule.RuleModule;
-export default rule;

package/lib/custom-eslint-rules/no-welcome-index-route.js

@@ -1,123 +0,0 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-const rule = {
-    meta: {
-        type: 'problem',
-        docs: {
-            description: 'Disallow Welcome or PagePlaceholder from @lark-apaas/client-toolkit as the default home page route element',
-            category: 'Best Practices',
-            recommended: true,
-        },
-        messages: {
-            noWelcomeIndex: 'Index route should not use {{componentName}} from @lark-apaas/client-toolkit as the element. Please create and use your own home page component (e.g., HomePage, Dashboard).',
-        },
-        schema: [],
-    },
-    create(context) {
-        // Track imports from @lark-apaas/client-toolkit
-        const toolkitImports = new Set();
-        return {
-            ImportDeclaration(node) {
-                const importNode = node;
-                const source = importNode.source?.value;
-                // Check if importing from @lark-apaas/client-toolkit (any subpath)
-                if (typeof source === 'string' &&
-                    source.startsWith('@lark-apaas/client-toolkit')) {
-                    // Collect all imported names
-                    importNode.specifiers?.forEach(specifier => {
-                        if (specifier.type === 'ImportSpecifier' &&
-                            specifier.imported?.name) {
-                            toolkitImports.add(specifier.imported.name);
-                        }
-                    });
-                }
-            },
-            JSXElement(node) {
-                const element = node;
-                const openingElement = element.openingElement;
-                if (!openingElement)
-                    return;
-                const elementName = openingElement.name;
-                // Check if this is a <Route> element
-                if (elementName.type !== 'JSXIdentifier' ||
-                    elementName.name !== 'Route') {
-                    return;
-                }
-                // Check if it has an index prop that is truthy
-                const indexAttr = openingElement.attributes.find(attr => attr.type === 'JSXAttribute' &&
-                    attr.name?.type === 'JSXIdentifier' &&
-                    attr.name?.name === 'index');
-                // If no index attribute, skip this route
-                if (!indexAttr) {
-                    return;
-                }
-                // Check if index={false} explicitly
-                const indexValue = indexAttr.value;
-                if (indexValue?.type === 'JSXExpressionContainer' &&
-                    indexValue.expression?.type === 'Literal' &&
-                    indexValue.expression.value === false) {
-                    return;
-                }
-                // Check if this is a first-level index route (nested under exactly one parent Route)
-                // The structure should be: <Routes> -> <Route element={<Layout />}> -> <Route index>
-                let routeParentCount = 0;
-                let current = element.parent;
-                while (current) {
-                    if (current.type === 'JSXElement') {
-                        const currentElement = current;
-                        const currentOpeningElement = currentElement.openingElement;
-                        const currentElementName = currentOpeningElement?.name;
-                        if (currentElementName?.type === 'JSXIdentifier' &&
-                            currentElementName.name === 'Route') {
-                            routeParentCount++;
-                        }
-                        else if (currentElementName?.type === 'JSXIdentifier' &&
-                            currentElementName.name === 'Routes') {
-                            // Stop when we reach Routes
-                            break;
-                        }
-                    }
-                    current = current.parent;
-                }
-                // Only check if this is a first-level route (exactly 1 parent Route)
-                // This corresponds to the default home page pattern:
-                // <Routes><Route element={<Layout />}><Route index /></Route></Routes>
-                if (routeParentCount !== 1) {
-                    return;
-                }
-                // Find the element prop
-                const elementProp = openingElement.attributes.find(attr => attr.type === 'JSXAttribute' &&
-                    attr.name?.type === 'JSXIdentifier' &&
-                    attr.name?.name === 'element');
-                if (!elementProp) {
-                    return;
-                }
-                // Check if the element prop value is a JSXExpressionContainer with a JSXElement
-                const propValue = elementProp.value;
-                if (propValue?.type === 'JSXExpressionContainer' &&
-                    propValue.expression?.type === 'JSXElement') {
-                    const jsxElement = propValue.expression;
-                    const jsxOpeningElement = jsxElement.openingElement;
-                    const jsxElementName = jsxOpeningElement?.name;
-                    // Check if the component name is Welcome or PagePlaceholder
-                    if (jsxElementName?.type === 'JSXIdentifier' &&
-                        (jsxElementName.name === 'Welcome' ||
-                            jsxElementName.name === 'PagePlaceholder')) {
-                        const componentName = jsxElementName.name;
-                        // Only report if this component was imported from @lark-apaas/client-toolkit
-                        if (toolkitImports.has(componentName)) {
-                            context.report({
-                                node: elementProp,
-                                messageId: 'noWelcomeIndex',
-                                data: {
-                                    componentName,
-                                },
-                            });
-                        }
-                    }
-                }
-            },
-        };
-    },
-};
-exports.default = rule;

package/lib/custom-eslint-rules/require-index-route.d.ts

@@ -1,14 +0,0 @@
-/**
- * ESLint rule to require a default index route in RoutesComponent.
- *
- * This rule enforces that the RoutesComponent must have a first-level index route
- * to handle the default "/" path. This ensures users don't see a 404 when visiting
- * the application root.
- *
- * Valid configurations:
- * 1. <Route index element={...} /> (first-level, nested under one parent Route)
- * 2. <Route path="/" element={...} /> (first-level or top-level)
- */
-import type { Rule } from 'eslint';
-declare const rule: Rule.RuleModule;
-export default rule;

package/lib/custom-eslint-rules/require-index-route.js

@@ -1,98 +0,0 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-const rule = {
-    meta: {
-        type: 'problem',
-        docs: {
-            description: 'Require a default index route in RoutesComponent to handle the root path',
-            category: 'Best Practices',
-            recommended: true,
-        },
-        messages: {
-            missingIndexRoute: 'RoutesComponent is missing a default home page route. Add either:\n  - <Route index element={<HomePage />} /> (nested under Layout)\n  - <Route path="/" element={<HomePage />} /> (at any level)',
-        },
-        schema: [],
-    },
-    create(context) {
-        let inRoutesComponent = false;
-        let hasDefaultRoute = false;
-        let routeDepth = 0;
-        return {
-            // eslint-disable-next-line @typescript-eslint/no-explicit-any
-            VariableDeclarator(node) {
-                // Check if this is RoutesComponent
-                if (node.id?.name === 'RoutesComponent') {
-                    inRoutesComponent = true;
-                    hasDefaultRoute = false;
-                    routeDepth = 0;
-                }
-            },
-            // eslint-disable-next-line @typescript-eslint/no-explicit-any
-            'VariableDeclarator:exit'(node) {
-                if (node.id?.name === 'RoutesComponent') {
-                    if (!hasDefaultRoute) {
-                        context.report({
-                            node,
-                            messageId: 'missingIndexRoute',
-                        });
-                    }
-                    inRoutesComponent = false;
-                }
-            },
-            // eslint-disable-next-line @typescript-eslint/no-explicit-any
-            JSXElement(node) {
-                if (!inRoutesComponent)
-                    return;
-                const elementName = node.openingElement?.name?.name;
-                // Track Route depth
-                if (elementName === 'Route') {
-                    routeDepth++;
-                    // Only check first-level routes (depth 1 or 2)
-                    // depth 1: <Routes><Route index /></Routes>
-                    // depth 2: <Routes><Route><Route index /></Route></Routes>
-                    if (routeDepth <= 2) {
-                        const attributes = node.openingElement?.attributes || [];
-                        // Check for index attribute
-                        // eslint-disable-next-line @typescript-eslint/no-explicit-any
-                        const indexAttr = attributes.find((attr) => attr.type === 'JSXAttribute' && attr.name?.name === 'index');
-                        if (indexAttr) {
-                            // Make sure it's not index={false}
-                            const isIndexFalse = indexAttr.value?.type === 'JSXExpressionContainer' &&
-                                indexAttr.value.expression?.type === 'Literal' &&
-                                indexAttr.value.expression.value === false;
-                            if (!isIndexFalse) {
-                                hasDefaultRoute = true;
-                            }
-                        }
-                        // Check for path="/"
-                        // eslint-disable-next-line @typescript-eslint/no-explicit-any
-                        const pathAttr = attributes.find((attr) => attr.type === 'JSXAttribute' && attr.name?.name === 'path');
-                        if (pathAttr) {
-                            const value = pathAttr.value;
-                            // Handle path="/"
-                            if (value?.type === 'Literal' && value.value === '/') {
-                                hasDefaultRoute = true;
-                            }
-                            // Handle path={"/"}
-                            if (value?.type === 'JSXExpressionContainer' &&
-                                value.expression?.type === 'Literal' &&
-                                value.expression.value === '/') {
-                                hasDefaultRoute = true;
-                            }
-                        }
-                    }
-                }
-            },
-            // eslint-disable-next-line @typescript-eslint/no-explicit-any
-            'JSXElement:exit'(node) {
-                if (!inRoutesComponent)
-                    return;
-                const elementName = node.openingElement?.name?.name;
-                if (elementName === 'Route') {
-                    routeDepth--;
-                }
-            },
-        };
-    },
-};
-exports.default = rule;