@lariocpt/flawless-react 0.0.0-stage → 0.3.1

package/src/analyse/resolveDepReturns.ts

@@ -0,0 +1,370 @@
+import ts from "typescript";
+import type { DataDepInfo, PropValue } from "../types.ts";
+import { extractFetchCalls } from "./extractFetchCalls.ts";
+import { resolveTypeNodeValue } from "./extractProps.ts";
+import { ownReturns } from "./ownReturns.ts";
+import type { ImportBinding } from "./parseFile.ts";
+import type { ModuleResolver } from "./resolveModule.ts";
+import { exportedFunctions } from "./serverActionReturns.ts";
+import { findExportedDecl, type SourceFileCache } from "./sourceCache.ts";
+
+/**
+ * Second-chance enrichment for data deps whose USAGE told us nothing: when
+ * the component only hands the awaited value onward, extractDataDeps lands
+ * on unknown/uncertain and the mock is an honest {} plus a TODO. This pass
+ * reads the dep function's own DECLARATION instead:
+ *
+ * - Path A: a `Promise<T>` return annotation — T resolved to one concrete
+ *   fixture value (resolveTypeNodeValue's bail-on-any-hole policy), stored
+ *   as `inferredReturn` with provenance "annotation".
+ * - Path B: an UNANNOTATED wrapper whose body performs exactly one
+ *   fetch() — recorded as `wrapsFetch` (method + path). The join to the
+ *   OpenAPI response example happens at emit time, where the route table
+ *   lives; provenance there is "openapi".
+ *
+ * Runs only for uncertain/unknown deps — a usage-derived shape is the
+ * component's own testimony and outranks any declaration. Dotted callees
+ * (`db.query.findMany`) stay TODOs: chasing member functions is FR-014,
+ * deliberately deferred.
+ */
+export function resolveDepReturns(
+  deps: DataDepInfo[],
+  imports: Map<string, ImportBinding>,
+  file: string,
+  resolver: ModuleResolver,
+  cache: SourceFileCache,
+): DataDepInfo[] {
+  return deps.map((dep) => {
+    if (!dep.uncertain && dep.shape.kind !== "unknown") return dep;
+    if (dep.callee !== dep.calleeRoot) return dep;
+    const binding = imports.get(dep.calleeRoot);
+    if (!binding || binding.isTypeOnly || binding.kind === "namespace") return dep;
+    const target = resolver.resolve(binding.specifier, file);
+    if (!target) return dep;
+    // A "use server" module's mock is serverActionMock's channel, and it
+    // never reads dataDeps — enriching a dep here would suppress the RSC
+    // skip escape for a fixture that is never emitted, turning the honest
+    // skip into a false RED that blames the application.
+    if (cache.hasPrologueDirective(target, "use server")) return dep;
+    const wanted =
+      binding.kind === "default" ? "default" : (binding.importedName ?? dep.calleeRoot);
+    // Barrel-aware: chase re-exports to the DECLARING file, so an annotation
+    // behind `export * from "./api"` still enriches the dep.
+    const located = findExportedDecl(
+      target,
+      wanted,
+      cache,
+      resolver,
+      // exportedFunctions already lists only exported names, so the root
+      // flag is moot here — passed for uniformity of the import-reached rule.
+      (sf, name) => new Map(exportedFunctions(sf)).get(name),
+      true,
+    );
+    if (!located) return dep;
+    const { sf, file: declFile, decl: fn } = located;
+    // The barrel itself rarely carries the directive — the declaring module
+    // is what decides whether this is serverActionMock's channel.
+    if (declFile !== target && cache.hasPrologueDirective(declFile, "use server")) return dep;
+
+    const promiseArg = promiseTypeArg(fn.type);
+    if (promiseArg) {
+      const value = resolveTypeNodeValue(promiseArg, sf, declFile, resolver, cache);
+      if (value === undefined) return dep;
+      return {
+        ...dep,
+        inferredReturn: {
+          provenance: "annotation" as const,
+          value,
+          ...annotationFlags(promiseArg),
+        },
+      };
+    }
+    // A sync annotation on an AWAITED dep is somebody's refactor in progress —
+    // not a thing to build a fixture on, and the original bail stands for it.
+    //
+    // On a dep that is NOT awaited, the same annotation is simply the truth.
+    // Refusing it mocked every such call as `async () => ({})`, and the dogfood
+    // web app shows both ways that goes wrong:
+    //
+    //   formatZAR(cents: number): string   every money value rendered as an
+    //                                      object, from a mock that was also
+    //                                      async for a synchronous function
+    //   isTrustee(roles): boolean          `{}` is truthy, so the trustee
+    //                                      branch was taken unconditionally and
+    //                                      the member branch never ran
+    //
+    // Recorded as sync so the emitter can write `vi.fn(() => …)` rather than
+    // wrapping a plain value in a promise nothing awaits.
+    if (fn.type) {
+      if (dep.awaited) return dep;
+      const value = resolveTypeNodeValue(fn.type, sf, declFile, resolver, cache);
+      if (value === undefined) return dep;
+      return {
+        ...dep,
+        inferredReturn: {
+          provenance: "annotation" as const,
+          value,
+          sync: true,
+          ...annotationFlags(fn.type),
+        },
+      };
+    }
+
+    if (!fn.body) return dep;
+    const fetches = extractFetchCalls(fn.body, sf);
+    const f = fetches[0];
+    if (!f || fetches.length !== 1) return dep;
+    // The wrapper must RETURN the fetched json — an envelope unwrapper
+    // (`return envelope.data`) or a side-effect fetch would join an OpenAPI
+    // example to a value the function never returns, false-pass capable for
+    // a shape-tolerant component.
+    if (!returnsFetchedJson(fn)) return dep;
+    return { ...dep, wrapsFetch: { method: f.method.toUpperCase(), path: f.urlTemplate } };
+  });
+}
+
+/**
+ * True iff the wrapper's single return IS the fetch response's json():
+ * `return res.json()` / `return await res.json()` where `res` was bound to
+ * (an awaited) fetch; `const data = await res.json(); return data;`; or the
+ * direct `return (await fetch(...)).json()`. Anything else — a second
+ * return, a transformed value, a different binding — is not a wrapper.
+ */
+function returnsFetchedJson(fn: { body?: ts.Node }): boolean {
+  const body = fn.body;
+  if (!body) return false;
+  // A concise arrow body IS the single return expression.
+  const returns = ts.isBlock(body)
+    ? ownReturns(body).map((r) => r.expression)
+    : [body as ts.Expression];
+  if (returns.length !== 1 || returns[0] === undefined) return false;
+
+  // Bindings: `const res = await fetch(...)` and `const data = await res.json()`.
+  const fetchVars = new Set<string>();
+  const jsonVars = new Set<string>();
+  if (ts.isBlock(body)) {
+    for (const stmt of body.statements) {
+      if (!ts.isVariableStatement(stmt)) continue;
+      for (const decl of stmt.declarationList.declarations) {
+        if (!ts.isIdentifier(decl.name) || !decl.initializer) continue;
+        const init = unwrapAwait(decl.initializer);
+        if (isFetchCall(init)) fetchVars.add(decl.name.text);
+        else if (isJsonCallOn(init, fetchVars)) jsonVars.add(decl.name.text);
+      }
+    }
+  }
+
+  const expr = unwrapAwait(returns[0]);
+  if (ts.isIdentifier(expr)) return jsonVars.has(expr.text);
+  return isJsonCallOn(expr, fetchVars);
+}
+
+function unwrapAwait(expr: ts.Expression): ts.Expression {
+  let e = expr;
+  for (;;) {
+    if (ts.isParenthesizedExpression(e)) e = e.expression;
+    else if (ts.isAwaitExpression(e)) e = e.expression;
+    else return e;
+  }
+}
+
+function isFetchCall(expr: ts.Expression): boolean {
+  return (
+    ts.isCallExpression(expr) &&
+    ts.isIdentifier(expr.expression) &&
+    expr.expression.text === "fetch"
+  );
+}
+
+/** `<receiver>.json()` where the receiver is a fetch binding or a fetch call. */
+function isJsonCallOn(expr: ts.Expression, fetchVars: Set<string>): boolean {
+  if (!ts.isCallExpression(expr) || expr.arguments.length !== 0) return false;
+  const callee = expr.expression;
+  if (!ts.isPropertyAccessExpression(callee) || callee.name.text !== "json") return false;
+  const receiver = unwrapAwait(callee.expression);
+  if (ts.isIdentifier(receiver)) return fetchVars.has(receiver.text);
+  return isFetchCall(receiver);
+}
+
+/**
+ * The fixture value an exported function's `Promise<T>` annotation describes, or
+ * undefined when it cannot be resolved to one concrete value.
+ *
+ * Extracted from Path A above so the native mock emitter reads the SAME
+ * annotation by the SAME rules. A second implementation of "what does this
+ * function return" would drift from this one, and the two would disagree about
+ * the fixture a spec is built on.
+ */
+export function annotatedReturnValue(
+  module: string,
+  exportName: string,
+  resolver: ModuleResolver,
+  cache: SourceFileCache,
+): PropValue | undefined {
+  const located = findExportedDecl(
+    module,
+    exportName,
+    cache,
+    resolver,
+    (sf, name) => new Map(exportedFunctions(sf)).get(name),
+    true,
+  );
+  if (!located) return undefined;
+  const { sf, file: declFile, decl: fn } = located;
+  const promiseArg = promiseTypeArg(fn.type);
+  if (!promiseArg) return undefined;
+  // `Promise<void>` resolves to nothing AND needs nothing: a mock returning
+  // undefined is exactly right, and the caller's "give this a realistic return
+  // value" marker was advice with no work behind it. Reported separately from
+  // "could not infer" so the caller can tell them apart.
+  if (
+    promiseArg.kind === ts.SyntaxKind.VoidKeyword ||
+    promiseArg.kind === ts.SyntaxKind.UndefinedKeyword
+  ) {
+    return VOID_RETURN;
+  }
+  return resolveTypeNodeValue(promiseArg, sf, declFile, resolver, cache);
+}
+
+/**
+ * The answer for a function annotated `Promise<void>`.
+ *
+ * A distinct object rather than `undefined`, because undefined already means
+ * "could not be inferred" and the two want different mock bodies and different
+ * markers. Compared by identity — never serialise it.
+ */
+export const VOID_RETURN = Object.freeze({ __flawlessVoid: true }) as unknown as PropValue;
+
+function promiseTypeArg(type: ts.TypeNode | undefined): ts.TypeNode | undefined {
+  if (
+    type !== undefined &&
+    ts.isTypeReferenceNode(type) &&
+    ts.isIdentifier(type.typeName) &&
+    type.typeName.text === "Promise"
+  ) {
+    return type.typeArguments?.[0];
+  }
+  return undefined;
+}
+
+/**
+ * Return annotations for the names one import declaration binds.
+ *
+ * The peer of `resolveDepReturns` for functions that never became a dataDep —
+ * a formatter called inside JSX, a predicate read straight into a condition.
+ * Those reached the emitter with no evidence at all and were stubbed
+ * `vi.fn(async () => ({}))`, which is wrong in three ways at once for
+ * `formatZAR(cents: number): string`: async, an object, and a value the page
+ * renders directly.
+ *
+ * Only names with a resolvable annotation appear. An absent name keeps the
+ * honest {} stub and the TODO that goes with it, exactly as before.
+ */
+/**
+ * What the return TypeNode itself admits — read at the declaration because
+ * the RESOLVED value cannot say: a `(): true` literal annotation and a
+ * `(): boolean` both store `true`, and only the second makes `false` a legal
+ * return a spec may flip to (B-19's provably-reachable rule). The nullable
+ * flag mirrors it for `T | null` unions, whose discounted arm is exactly the
+ * value that un-fires a truthy guard.
+ */
+function annotationFlags(node: ts.TypeNode): {
+  booleanAnnotated?: true;
+  nullableAnnotated?: true;
+} {
+  const flags: { booleanAnnotated?: true; nullableAnnotated?: true } = {};
+  if (node.kind === ts.SyntaxKind.BooleanKeyword) flags.booleanAnnotated = true;
+  if (ts.isUnionTypeNode(node)) {
+    if (
+      node.types.some(
+        (t) =>
+          t.kind === ts.SyntaxKind.UndefinedKeyword ||
+          (ts.isLiteralTypeNode(t) && t.literal.kind === ts.SyntaxKind.NullKeyword),
+      )
+    ) {
+      flags.nullableAnnotated = true;
+    }
+    if (node.types.some((t) => t.kind === ts.SyntaxKind.BooleanKeyword)) {
+      flags.booleanAnnotated = true;
+    }
+  }
+  return flags;
+}
+
+/**
+ * Which of this import's names declare ASYNC functions — the evidence the RSC
+ * emitter needs to stub an async server CHILD instead of mounting it: React's
+ * client renderer refuses an async function component, and the page that
+ * contains one renders an empty container. Returns module-side names
+ * ("default" for a default export), same convention as importedReturns.
+ */
+export function asyncComponentExports(
+  mi: { names: string[]; importedNames?: string[]; isTypeOnly: boolean; hasDefault: boolean },
+  resolvedPath: string,
+  resolver: ModuleResolver,
+  cache: SourceFileCache,
+): string[] {
+  const out: string[] = [];
+  if (mi.isTypeOnly) return out;
+  for (const [i, local] of mi.names.entries()) {
+    const exported = mi.hasDefault && i === 0 ? "default" : (mi.importedNames?.[i] ?? local);
+    if (!exported) continue;
+    const located = findExportedDecl(
+      resolvedPath,
+      exported,
+      cache,
+      resolver,
+      (sf, name) => new Map(exportedFunctions(sf)).get(name),
+      true,
+    );
+    if (!located) continue;
+    const decl = located.decl;
+    const mods = ts.canHaveModifiers(decl) ? ts.getModifiers(decl) : undefined;
+    if (mods?.some((m) => m.kind === ts.SyntaxKind.AsyncKeyword)) out.push(exported);
+  }
+  return out;
+}
+
+export function annotatedExportReturns(
+  mi: { names: string[]; importedNames?: string[]; isTypeOnly: boolean },
+  resolvedPath: string,
+  resolver: ModuleResolver,
+  cache: SourceFileCache,
+): Record<string, { value: PropValue; sync: boolean }> {
+  const out: Record<string, { value: PropValue; sync: boolean }> = {};
+  if (mi.isTypeOnly) return out;
+  for (const [i, local] of mi.names.entries()) {
+    const exported = mi.importedNames?.[i] ?? local;
+    if (!exported || exported === "default") continue;
+    const located = findExportedDecl(
+      resolvedPath,
+      exported,
+      cache,
+      resolver,
+      (sf, name) => new Map(exportedFunctions(sf)).get(name),
+      true,
+    );
+    if (!located) continue;
+    const { sf, file: declFile, decl: fn } = located;
+    if (!fn.type) continue;
+    const promiseArg = promiseTypeArg(fn.type);
+    if (promiseArg) {
+      // Void is a real answer, not a gap — see VOID_RETURN.
+      if (
+        promiseArg.kind === ts.SyntaxKind.VoidKeyword ||
+        promiseArg.kind === ts.SyntaxKind.UndefinedKeyword
+      ) {
+        continue;
+      }
+      const value = resolveTypeNodeValue(promiseArg, sf, declFile, resolver, cache);
+      if (value !== undefined) {
+        out[exported] = { value, sync: false, ...annotationFlags(promiseArg) };
+      }
+      continue;
+    }
+    if (fn.type.kind === ts.SyntaxKind.VoidKeyword) continue;
+    const value = resolveTypeNodeValue(fn.type, sf, declFile, resolver, cache);
+    if (value !== undefined) out[exported] = { value, sync: true, ...annotationFlags(fn.type) };
+  }
+  return out;
+}

package/src/analyse/resolveIndexKeys.ts

@@ -0,0 +1,98 @@
+import ts from "typescript";
+import type { PropValue } from "../types.ts";
+
+/**
+ * Values for props whose type could not be resolved, recovered from how the
+ * component indexes with them.
+ *
+ * `currentStatus: JobStatus` where `JobStatus = z.infer<typeof Schema>`
+ * resolves since B-9 when the schema is syntactic (zodSchema.ts); this module
+ * is the fallback for schemas that bail (.transform, unions, custom), where
+ * the prop arrives undefined and `ALLOWED_TRANSITIONS[currentStatus].length`
+ * throws before anything renders.
+ * But the same file usually declares a lookup keyed by exactly that union:
+ *
+ *   const STATUS_LABEL: Record<JobStatus, string> = { requested: "Requested", … };
+ *   …
+ *   STATUS_LABEL[currentStatus]
+ *
+ * Those keys ARE the union, written out literally. Taking the first is evidence,
+ * not inference — and the whole key list makes a real variant matrix.
+ *
+ * Deliberately narrow: the indexed object must be a top-level const in the same
+ * file with an object-literal initialiser and only literal keys. An imported
+ * table, a computed key, or a spread inside the literal gives up, because a
+ * partial key list would produce a default that is not actually in the union.
+ */
+export interface IndexKeyResolution {
+  /** Prop name → its first observed key. */
+  defaults: Record<string, PropValue>;
+  /** Prop name → every key, for the variant matrix. */
+  options: Record<string, PropValue[]>;
+}
+
+export function resolveIndexKeyProps(
+  bodyNode: ts.Node,
+  sourceFile: ts.SourceFile,
+  unresolvedProps: string[],
+): IndexKeyResolution {
+  const out: IndexKeyResolution = { defaults: {}, options: {} };
+  if (unresolvedProps.length === 0) return out;
+  const wanted = new Set(unresolvedProps);
+
+  const tables = topLevelObjectLiterals(sourceFile);
+  if (tables.size === 0) return out;
+
+  const visit = (n: ts.Node): void => {
+    if (
+      ts.isElementAccessExpression(n) &&
+      ts.isIdentifier(n.expression) &&
+      ts.isIdentifier(n.argumentExpression) &&
+      wanted.has(n.argumentExpression.text)
+    ) {
+      const keys = tables.get(n.expression.text);
+      const prop = n.argumentExpression.text;
+      if (keys && keys.length > 0 && out.defaults[prop] === undefined) {
+        out.defaults[prop] = keys[0] as PropValue;
+        out.options[prop] = [...keys];
+      }
+    }
+    ts.forEachChild(n, visit);
+  };
+  visit(bodyNode);
+
+  return out;
+}
+
+/** Top-level `const X = { a: …, b: … }` → its literal key list. */
+function topLevelObjectLiterals(sourceFile: ts.SourceFile): Map<string, string[]> {
+  const out = new Map<string, string[]>();
+  for (const stmt of sourceFile.statements) {
+    if (!ts.isVariableStatement(stmt)) continue;
+    for (const decl of stmt.declarationList.declarations) {
+      if (!ts.isIdentifier(decl.name)) continue;
+      const init = decl.initializer;
+      if (!init || !ts.isObjectLiteralExpression(init)) continue;
+      const keys = literalKeys(init);
+      if (keys) out.set(decl.name.text, keys);
+    }
+  }
+  return out;
+}
+
+/** Every key as written, or undefined when any of them is not a literal. */
+function literalKeys(obj: ts.ObjectLiteralExpression): string[] | undefined {
+  const keys: string[] = [];
+  for (const prop of obj.properties) {
+    // A spread means the real key set is larger than what is written here, so
+    // the first key might not be the first member of the union.
+    if (ts.isSpreadAssignment(prop)) return undefined;
+    if (!prop.name) return undefined;
+    if (ts.isIdentifier(prop.name) || ts.isStringLiteral(prop.name)) {
+      keys.push(prop.name.text);
+      continue;
+    }
+    return undefined;
+  }
+  return keys.length > 0 ? keys : undefined;
+}