@larc-iu/plaid-client 0.2.0-alpha.26 → 0.2.0-alpha.29

package/src/services.js

@@ -373,11 +373,25 @@ export function serve(client, projectId, serviceInfo, onServiceRequest, extras =
       // requester has stopped the request, so a service that reports progress
       // through its work is cancellable without doing anything else. Use
       // `critical()` around writes to hold it off.
+      //
+      // A request the server answers 404 for is one it no longer knows (it
+      // ended, or the server restarted and forgot it), so nobody is waiting
+      // for the work: it counts as a stop, and the next checkpoint throws.
+      // Any other failure to send is only logged.
       progress: (percent, msg, extra) => {
         scope.raiseIfCancelled();
-        return reportEvent(requestId, {
+        return reportRequestEvent(client, projectId, requestId, {
           status: 'progress',
           progress: { percent, message: msg, ...extra },
+        }).catch((error) => {
+          if (error?.status === 404) {
+            if (cancelled.get(requestId) === false) {
+              console.warn(`The server no longer knows request ${requestId}, so it is stopped`);
+              cancelled.set(requestId, true);
+            }
+            return;
+          }
+          console.warn('Failed to report request event:', error.message || error);
         });
       },
       complete: (data) => {

package/src/textEdits.js

@@ -53,9 +53,8 @@ export function bodyCodePoints(body) {
   return lastPoints;
 }
 
-function opName(op) {
-  return JSON.stringify(op);
-}
+// The op as a refusal names it.
+const opJson = (op) => String(JSON.stringify(op) ?? 'null');
 
 /**
  * The op's type after checking its shape and bounds against a body of `len`
@@ -71,11 +70,14 @@ function checkOp(op, len) {
     (type === 'replace' && int(index) && int(length) && typeof value === 'string');
   if (!wellFormed) {
     throw new Error(
-      `Malformed text edit operation: ${opName(op)}. Expected {type: "insert", index: int, ` +
+      `Malformed text edit operation: ${opJson(op)}. Expected {type: "insert", index: int, ` +
         `value: string}, {type: "delete", index: int, value: int} or {type: "replace", ` +
         `index: int, length: int, value: string}`,
     );
   }
+  if (!(op.side == null || op.side === 'before' || op.side === 'after')) {
+    throw new Error(`A text edit's side is "before" or "after": ${opJson(op)}`);
+  }
   const inBounds =
     type === 'insert'
       ? index >= 0 && index <= len
@@ -84,7 +86,7 @@ function checkOp(op, len) {
         : index >= 0 && length >= 0 && index + length <= len;
   if (!inBounds) {
     throw new Error(
-      `Text edit operation out of bounds: ${opName(op)} (text length is ${len} code points)`,
+      `Text edit operation out of bounds: ${opJson(op)} (text length is ${len} code points)`,
     );
   }
   return type;