@langwatch/mcp-server 2.2.0 → 3.0.0

package/src/tools/update-dashboard-widget.ts

@@ -1,20 +1,17 @@
 /**
- * The `update_dashboard_widget` MCP tool over the widget PATCH: a field left out keeps its
- * stored value. The widget must sit on the named dashboard, so an agent never edits one it
- * found somewhere else by mistake. Spec: modules/dashboard/specs/dashboard-widget-mcp.feature
+ * `update_dashboard_widget`: the widget must sit on the named dashboard, so an agent never edits
+ * one it found elsewhere by mistake.
+ * Spec: modules/dashboard/specs/dashboard-widget-mcp.feature
  */
 
-import {
-  type DashboardWidget,
-  getDashboardWidget,
-  updateDashboardWidget,
-} from "../langwatch-api-dashboard-widgets.js";
-import { getCurrentProject } from "../langwatch-api-projects.js";
+import type { DashboardWidget } from "../langwatch-api-dashboard-widgets.js";
+import { getWidgetOnDashboard, updateWidgetOnDashboard } from "../langwatch-api-dashboards.js";
 import { LangWatchApiError } from "../langwatch-api.js";
-import { assertDashboardExists } from "./dashboard-exists.js";
+import type { WidgetSource } from "../schemas/widget-sources.js";
 import {
   type DashboardWidgetQueriesInput,
   normalizeDashboardWidgetQueries,
+  withSources,
 } from "./dashboard-widget-queries.js";
 
 export interface UpdateDashboardWidgetParams {
@@ -24,37 +21,38 @@ export interface UpdateDashboardWidgetParams {
   code?: string;
   queries?: DashboardWidgetQueriesInput;
   description?: string;
+  /** Set on every query; alone, it is sent with the widget's stored queries. */
+  sources?: WidgetSource[] | null;
 }
 
 export async function handleUpdateDashboardWidget(
   params: UpdateDashboardWidgetParams,
 ): Promise<string> {
-  const { dashboardId, widgetId, name, code, description } = params;
-  if (
-    name === undefined &&
-    code === undefined &&
-    params.queries === undefined &&
-    description === undefined
-  ) {
-    throw new Error("Provide at least one of name, code, queries or description to change.");
+  const { dashboardId, widgetId, name, code, description, sources } = params;
+  const fields = [name, code, params.queries, description, sources];
+  if (fields.every((field) => field === undefined)) {
+    throw new Error(
+      "Provide at least one of name, code, queries, description or sources to change.",
+    );
   }
-  const queries =
+
+  const current = await widgetOnDashboardOrRefused({ widgetId, dashboardId });
+  const given =
     params.queries === undefined
       ? undefined
       : normalizeDashboardWidgetQueries({ queries: params.queries });
+  // Sources alone: the stored queries go back with the new list on each.
+  const base = given ?? (sources === undefined ? undefined : current.definition.queries);
+  const queries = base === undefined ? undefined : withSources({ queries: base, sources });
 
-  const project = await getCurrentProject();
-  await assertDashboardExists({ projectId: project.id, dashboardId });
-  const current = await getWidgetOnDashboard({ projectId: project.id, widgetId, dashboardId });
-
-  const widget = await updateDashboardWidget({
-    projectId: project.id,
-    widgetId: current.id,
+  const changes = {
     ...(name === undefined ? {} : { name }),
     ...(code === undefined ? {} : { code }),
     ...(queries === undefined ? {} : { queries }),
     ...(description === undefined ? {} : { description }),
-  });
+  };
+
+  const widget = await updateWidgetOnDashboard({ dashboardId, widgetId: current.id, ...changes });
 
   return [
     `Widget "${widget.name}" updated on dashboard "${dashboardId}".`,
@@ -67,31 +65,22 @@ export async function handleUpdateDashboardWidget(
   ].join("\n");
 }
 
-/** The widget, refused by id when it is not in this project or not on this dashboard. */
-async function getWidgetOnDashboard({
-  projectId,
+/** The widget, refused by id when it is not on this dashboard (the dashboard route answers 404). */
+async function widgetOnDashboardOrRefused({
   widgetId,
   dashboardId,
 }: {
-  projectId: string;
   widgetId: string;
   dashboardId: string;
 }): Promise<DashboardWidget> {
-  let widget: DashboardWidget;
   try {
-    widget = await getDashboardWidget({ projectId, widgetId });
+    return await getWidgetOnDashboard({ dashboardId, widgetId });
   } catch (error) {
     if (error instanceof LangWatchApiError && error.status === 404) {
       throw new Error(
-        `No widget with ID "${widgetId}" was found in this project. Use the widget ID add_dashboard_widget returned.`,
+        `No widget with ID "${widgetId}" was found on dashboard "${dashboardId}". Use the widget ID add_dashboard_widget returned, and the dashboard it was added to.`,
       );
     }
     throw error;
   }
-  if (widget.dashboardId !== dashboardId) {
-    throw new Error(
-      `Widget "${widgetId}" is not on dashboard "${dashboardId}". Pass the dashboard the widget was added to.`,
-    );
-  }
-  return widget;
 }