@lamentis/naome 1.3.14 → 1.3.16

package/crates/naome-core/src/task_state/proof_types.rs

@@ -0,0 +1,17 @@
+use serde_json::Value;
+
+#[derive(Debug, Clone)]
+pub(crate) struct CanonicalProof {
+    pub(crate) check_id: String,
+    pub(crate) command: String,
+    pub(crate) cwd: String,
+    pub(crate) exit_code: i64,
+    pub(crate) checked_at: String,
+    pub(crate) evidence: Vec<Value>,
+}
+
+#[derive(Debug, Clone)]
+pub(super) struct VerificationDefaults {
+    pub(super) command: String,
+    pub(super) cwd: String,
+}

package/crates/naome-core/src/task_state/shape.rs

@@ -1,6 +1,6 @@
 use serde_json::Value;
 
-use super::proof::validate_control_state_patterns;
+use super::evidence::validate_control_state_patterns;
 pub(super) use super::task_records::{
     format_blocker, validate_blocker, validate_human_review, validate_prompt_record,
     validate_revisions,

package/crates/naome-core/src/task_state/task_diff_api.rs

@@ -8,7 +8,7 @@ use crate::models::NaomeError;
 
 use super::completion::validate_complete_task_against_entries;
 use super::git_io::{read_git_changed_entries, read_git_changed_paths};
-use super::reconcile::{
+use super::repair::{
     is_packaged_machine_owned_path, is_repair_archive_path, is_safe_harness_refresh_path,
 };
 use super::shape::{

package/crates/naome-core/src/verification_contract_policy.rs

@@ -17,9 +17,7 @@ pub(crate) fn validate_semantic_quality_gate_policy(
     }
 
     for (index, change_type) in change_types.iter().enumerate() {
-        let Some(required_checks) = change_type
-            .get("requiredChecks")
-            .and_then(Value::as_array)
+        let Some(required_checks) = change_type.get("requiredChecks").and_then(Value::as_array)
         else {
             continue;
         };
@@ -46,7 +44,5 @@ pub(crate) fn validate_semantic_quality_gate_policy(
 }
 
 fn contains_string(values: &[Value], expected: &str) -> bool {
-    values
-        .iter()
-        .any(|value| value.as_str() == Some(expected))
+    values.iter().any(|value| value.as_str() == Some(expected))
 }

package/crates/naome-core/src/workflow/agent/proof.rs

@@ -4,7 +4,7 @@ use crate::models::NaomeError;
 
 use super::support::changed_paths;
 use crate::workflow::agent_types::ProofPlan;
-use crate::workflow::phases::{verification_phase_plan, CommandCheckResult};
+use crate::workflow::{verification_phase_plan, CommandCheckResult};
 
 pub fn proof_plan_for_task(
     root: &Path,

package/crates/naome-core/src/workflow/agent.rs

@@ -11,7 +11,7 @@ use std::path::Path;
 use crate::models::NaomeError;
 
 use super::agent_types::AgentRunPlan;
-use super::phases::CommandCheckResult;
+use super::phase_model::CommandCheckResult;
 
 pub use capability::repository_capability_graph;
 pub use context_delta::context_delta_report;

package/crates/naome-core/src/workflow/mod.rs

@@ -7,6 +7,7 @@ mod integrity_support;
 mod mutation;
 mod output;
 mod phase_inference;
+mod phase_model;
 mod phases;
 mod policy;
 mod processes;
@@ -25,7 +26,8 @@ pub use doctor::{doctor_report, DoctorReport, DoctorSection, RepositoryPolicySec
 pub use integrity::{refresh_integrity, IntegrityRefreshReport};
 pub use mutation::classify_mutations;
 pub use output::{summarize_command_output, CommandOutputSummary};
-pub use phases::{verification_phase_plan, CommandCheckResult, VerificationPhasePlan};
+pub use phase_model::CommandCheckResult;
+pub use phases::{verification_phase_plan, VerificationPhasePlan};
 pub use policy::{safe_rg_args, validate_read_boundaries, validate_search_command};
 pub use processes::{tracked_process_report, ProcessReport};
 pub use types::{MutationClassification, ReadActivity, WorkflowFinding};

package/crates/naome-core/src/workflow/phase_inference.rs

@@ -2,7 +2,7 @@ use std::collections::{HashMap, HashSet};
 
 use serde_json::Value;
 
-use super::phases::{CheckDefinition, PhaseDefinition};
+use super::phase_model::{CheckDefinition, PhaseDefinition};
 
 pub(super) fn infer_phases(
     verification: &Value,

package/crates/naome-core/src/workflow/phase_model.rs

@@ -0,0 +1,22 @@
+use serde::{Deserialize, Serialize};
+
+#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
+#[serde(rename_all = "camelCase")]
+pub struct CommandCheckResult {
+    pub check_id: String,
+    pub exit_code: i32,
+}
+
+#[derive(Debug, Clone)]
+pub(super) struct CheckDefinition {
+    pub(super) id: String,
+    pub(super) command: String,
+    pub(super) cost: String,
+}
+
+#[derive(Debug, Clone)]
+pub(super) struct PhaseDefinition {
+    pub(super) id: String,
+    pub(super) order: u32,
+    pub(super) check_ids: Vec<String>,
+}

package/crates/naome-core/src/workflow/phases.rs

@@ -8,13 +8,7 @@ use serde_json::Value;
 use crate::models::NaomeError;
 
 use super::phase_inference::infer_phases;
-
-#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
-#[serde(rename_all = "camelCase")]
-pub struct CommandCheckResult {
-    pub check_id: String,
-    pub exit_code: i32,
-}
+use super::phase_model::{CheckDefinition, CommandCheckResult, PhaseDefinition};
 
 #[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
 #[serde(rename_all = "camelCase")]
@@ -35,20 +29,6 @@ pub struct VerificationPhaseStatus {
     pub blocked_by: Vec<String>,
 }
 
-#[derive(Debug, Clone)]
-pub(super) struct CheckDefinition {
-    pub(super) id: String,
-    pub(super) command: String,
-    pub(super) cost: String,
-}
-
-#[derive(Debug, Clone)]
-pub(super) struct PhaseDefinition {
-    pub(super) id: String,
-    pub(super) order: u32,
-    pub(super) check_ids: Vec<String>,
-}
-
 pub fn verification_phase_plan(
     root: &Path,
     completed: &[CommandCheckResult],

package/crates/naome-core/tests/architecture_config.rs

@@ -0,0 +1,67 @@
+use naome_core::{format_architecture_validation, validate_architecture, ArchitectureScanOptions};
+
+mod architecture_support;
+
+use architecture_support::FixtureRepo;
+
+#[test]
+fn validation_reports_risky_broad_architecture_config_without_failing() {
+    let repo = FixtureRepo::new();
+    repo.write(
+        "naome.arch.yaml",
+        r#"
+layers:
+  application:
+    paths:
+      - "src/**"
+  domain:
+    paths:
+      - "src/domain/**"
+  infrastructure:
+    paths:
+      - "src/infrastructure/**"
+allowed_dependencies:
+  application:
+    - domain
+    - infrastructure
+  domain:
+  infrastructure:
+    - domain
+contexts:
+  default:
+    paths:
+      - "src/**"
+    public_api:
+      - "src/index.ts"
+  billing:
+    paths:
+      - "src/billing/**"
+    public_api:
+      - "src/billing/index.ts"
+rules:
+  no_forbidden_layer_dependencies:
+    enabled: true
+    severity: error
+"#,
+    );
+    repo.write("src/domain/event.ts", "export const event = 1;\n");
+    repo.write("src/infrastructure/db.ts", "export const db = 1;\n");
+    repo.write("src/billing/index.ts", "export const billing = 1;\n");
+
+    let report = validate_architecture(repo.path(), ArchitectureScanOptions::default()).unwrap();
+    let output = format_architecture_validation(&report);
+
+    assert_eq!(report.status, "pass");
+    assert_eq!(report.summary.warnings, 0);
+    assert!(report.config_findings.iter().any(|finding| {
+        finding.id == "arch.config.broad_layer_overlap"
+            && finding.subject == "layer:application"
+            && finding.severity == "warning"
+    }));
+    assert!(report.config_findings.iter().any(|finding| {
+        finding.id == "arch.config.catch_all_context_with_specific_contexts"
+            && finding.subject == "context:default"
+            && finding.severity == "warning"
+    }));
+    assert!(output.contains("configuration findings: 2"));
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lamentis/naome",
-  "version": "1.3.14",
+  "version": "1.3.16",
   "description": "Native-first CLI for the NAOME agent harness.",
   "license": "Apache-2.0",
   "type": "module",

package/crates/naome-core/src/task_state/reconcile.rs

@@ -1,7 +0,0 @@
-pub(super) use super::completed_refresh::add_completed_task_diff_notice;
-pub(super) use super::push_gate::{format_dirty_diff_admission_blocker, validate_push_gate};
-pub(super) use super::repair::{
-    is_deterministic_harness_refresh_diff, is_harness_repair_diff,
-    is_install_or_upgrade_baseline_diff, is_packaged_machine_owned_path, is_repair_archive_path,
-    is_safe_harness_refresh_path,
-};