@lamentis/naome 1.2.0 → 1.3.0

package/crates/naome-core/tests/semantic_legacy.rs

@@ -0,0 +1,140 @@
+mod repo_support;
+
+use naome_core::{check_semantic_legacy, semantic_route_for_finding, QualityMode};
+
+use repo_support::TestRepo;
+
+#[test]
+fn report_groups_repeated_config_fixture_shapes_across_repository() {
+    let repo = semantic_repo("semantic-report-groups");
+    repo.write_file("scripts/a.test.js", &fixture_object("qualityConfig"));
+    repo.write_file(
+        "scripts/b.test.js",
+        &fixture_object("repositoryQualityConfig"),
+    );
+    repo.commit_all("baseline");
+
+    let report = check_semantic_legacy(repo.path(), QualityMode::DeepReport).unwrap();
+
+    let finding = report
+        .findings
+        .iter()
+        .find(|finding| finding.kind == "copied-config-object")
+        .expect("expected copied config finding");
+    assert_eq!(finding.occurrences.len(), 2);
+    assert!(finding
+        .occurrences
+        .iter()
+        .any(|occurrence| occurrence.path == "scripts/a.test.js"));
+    assert!(finding
+        .cleanup_route
+        .agent_instructions
+        .iter()
+        .any(|instruction| instruction.contains("every occurrence")));
+}
+
+#[test]
+fn changed_check_blocks_new_inline_legacy_fixture_only() {
+    let repo = semantic_repo("semantic-changed-only");
+    repo.write_file("scripts/old.test.js", &fixture_object("oldQualityConfig"));
+    repo.commit_all("baseline");
+    repo.write_file("README.md", "# harmless change\n");
+
+    let unrelated = check_semantic_legacy(repo.path(), QualityMode::Changed).unwrap();
+    assert!(unrelated.ok, "{:#?}", unrelated.findings);
+
+    repo.write_file("scripts/new.test.js", &fixture_object("newQualityConfig"));
+
+    let changed = check_semantic_legacy(repo.path(), QualityMode::Changed).unwrap();
+    assert!(!changed.ok);
+    assert!(changed
+        .findings
+        .iter()
+        .any(|finding| finding.kind == "inline-legacy-fixture"));
+}
+
+#[test]
+fn changed_check_allows_shared_fixture_factory_objects() {
+    let repo = semantic_repo("semantic-shared-factory");
+    repo.commit_all("baseline");
+    repo.write_file(
+        "scripts/test-support.js",
+        &[
+            "function verificationContract() {",
+            "  return {",
+            "    schema: \"naome.verification.v1\",",
+            "    version: 1,",
+            "    status: \"ready\",",
+            "    checks: [],",
+            "    changeTypes: [],",
+            "    releaseGates: []",
+            "  };",
+            "}",
+            "",
+        ]
+        .join("\n"),
+    );
+
+    let report = check_semantic_legacy(repo.path(), QualityMode::Changed).unwrap();
+
+    assert!(report.ok, "{:#?}", report.findings);
+}
+
+#[test]
+fn semantic_route_returns_complete_agent_cleanup_task() {
+    let repo = semantic_repo("semantic-route");
+    repo.write_file("scripts/a.test.js", &fixture_object("qualityConfig"));
+    repo.write_file(
+        "scripts/b.test.js",
+        &fixture_object("repositoryQualityConfig"),
+    );
+    repo.commit_all("baseline");
+    let report = check_semantic_legacy(repo.path(), QualityMode::DeepReport).unwrap();
+    let finding_id = report.findings[0].id.clone();
+
+    let finding = semantic_route_for_finding(&report, &finding_id).unwrap();
+
+    assert_eq!(finding.id, finding_id);
+    assert!(!finding.cleanup_route.target_suggestion.is_empty());
+    assert!(finding
+        .cleanup_route
+        .required_checks
+        .contains(&"naome semantic check --changed".to_string()));
+}
+
+fn semantic_repo(name: &str) -> TestRepo {
+    let repo = TestRepo::new(name);
+    repo.init_git();
+    repo.write_file("README.md", "# Semantic fixture\n");
+    repo.write_naome_json(
+        "repository-quality.json",
+        serde_json::json!({"schema":"naome.repository-quality.v1","version":1,"status":"ready","limits":{"maxFileLines":450,"maxNewFileLines":300,"maxDiffAddedLines":180,"maxFunctionLines":100,"maxTopLevelSymbols":30,"duplicateBlockLines":10,"nearDuplicateSimilarity":0.9},"enabledAdapters":[],"disabledChecks":[],"ignoredPaths":[],"generatedPaths":[],"pathRules":[]}),
+    );
+    repo
+}
+
+fn fixture_object(name: &str) -> String {
+    [
+        format!("const {name} = {{"),
+        "  schema: \"naome.repository-quality.v1\",".to_string(),
+        "  version: 1,".to_string(),
+        "  status: \"ready\",".to_string(),
+        "  limits: {".to_string(),
+        "    maxFileLines: 450,".to_string(),
+        "    maxNewFileLines: 300,".to_string(),
+        "    maxDiffAddedLines: 180,".to_string(),
+        "    maxFunctionLines: 100,".to_string(),
+        "    maxTopLevelSymbols: 30,".to_string(),
+        "    duplicateBlockLines: 10,".to_string(),
+        "    nearDuplicateSimilarity: 0.9".to_string(),
+        "  },".to_string(),
+        "  enabledAdapters: [],".to_string(),
+        "  disabledChecks: [],".to_string(),
+        "  ignoredPaths: [],".to_string(),
+        "  generatedPaths: [],".to_string(),
+        "  pathRules: []".to_string(),
+        "};".to_string(),
+        String::new(),
+    ]
+    .join("\n")
+}