@lamentis/naome 1.2.0 → 1.2.1

package/crates/naome-core/src/verification.rs

@@ -243,6 +243,7 @@ fn builtin_checks() -> Vec<BuiltinCheck> {
             purpose: "Validate changed files against deterministic NAOME repository quality rules.",
             evidence: &[
                 ".naome/repository-quality.json",
+                ".naome/repository-structure.json",
                 ".naome/repository-quality-baseline.json",
             ],
         },

package/crates/naome-core/tests/decision.rs

@@ -1,12 +1,14 @@
 use std::fs;
-use std::path::{Path, PathBuf};
-use std::process::Command;
 use std::sync::Mutex;
 use std::time::{SystemTime, UNIX_EPOCH};
 
 use naome_core::{evaluate_decision, format_decision, EvaluationOptions};
 use serde_json::json;
 
+mod repo_support;
+
+use repo_support::TestRepo;
+
 static ENV_LOCK: Mutex<()> = Mutex::new(());
 
 #[test]
@@ -34,20 +36,7 @@ fn completed_task_diff_returns_baseline_choices() {
     let repo = TestRepo::new("completed-task");
     repo.init_git();
     repo.write_file("README.md", "# Baseline\n");
-    repo.write_naome_json("init-state.json", json!({ "initialized": true }));
-    repo.write_naome_json("upgrade-state.json", json!({ "status": "complete" }));
-    repo.write_naome_json(
-        "task-state.json",
-        json!({
-            "status": "complete",
-            "activeTask": {
-                "id": "readme-task",
-                "allowedPaths": ["README.md"],
-                "requiredCheckIds": ["diff-check"],
-                "proofResults": []
-            }
-        }),
-    );
+    repo.write_base_naome_state(completed_without_proof_state());
     repo.git(&["add", "."]);
     repo.git(&["commit", "-m", "baseline"]);
     repo.write_file("README.md", "# Changed\n");
@@ -71,17 +60,7 @@ fn completed_task_diff_returns_baseline_choices() {
 
 #[test]
 fn idle_unowned_diff_blocks_new_feature_work() {
-    let repo = TestRepo::new("unowned-diff");
-    repo.init_git();
-    repo.write_file("README.md", "# Baseline\n");
-    repo.write_naome_json("init-state.json", json!({ "initialized": true }));
-    repo.write_naome_json("upgrade-state.json", json!({ "status": "complete" }));
-    repo.write_naome_json(
-        "task-state.json",
-        json!({ "status": "idle", "activeTask": null }),
-    );
-    repo.git(&["add", "."]);
-    repo.git(&["commit", "-m", "baseline"]);
+    let repo = TestRepo::idle_readme("unowned-diff");
     repo.write_file("README.md", "# Manual change\n");
 
     let decision = evaluate_decision(repo.path(), EvaluationOptions::offline()).unwrap();
@@ -96,12 +75,7 @@ fn changed_paths_handle_worktree_renames_without_corrupting_old_path_tokens() {
     let repo = TestRepo::new("worktree-rename");
     repo.init_git();
     repo.write_file("packages/old/file.txt", "baseline\n");
-    repo.write_naome_json("init-state.json", json!({ "initialized": true }));
-    repo.write_naome_json("upgrade-state.json", json!({ "status": "complete" }));
-    repo.write_naome_json(
-        "task-state.json",
-        json!({ "status": "idle", "activeTask": null }),
-    );
+    repo.write_base_naome_state(json!({ "status": "idle", "activeTask": null }));
     repo.git(&["add", "."]);
     repo.git(&["commit", "-m", "baseline"]);
 
@@ -129,19 +103,10 @@ fn active_task_allows_control_state_and_untracked_files_inside_scope() {
     let repo = TestRepo::new("active-scope");
     repo.init_git();
     repo.write_file("README.md", "# Baseline\n");
-    repo.write_naome_json("init-state.json", json!({ "initialized": true }));
-    repo.write_naome_json("upgrade-state.json", json!({ "status": "complete" }));
-    repo.write_naome_json(
-        "task-state.json",
-        json!({
-            "status": "implementing",
-            "activeTask": {
-                "id": "rust-task",
-                "allowedPaths": ["packages/naome/crates/naome-core/src/lib.rs"],
-                "requiredCheckIds": ["decision-engine-tests"],
-                "proofResults": []
-            }
-        }),
+    repo.write_base_naome_state(json!({ "status": "idle", "activeTask": null }));
+    repo.write_implementing_task_state(
+        "packages/naome/crates/naome-core/src/lib.rs",
+        "decision-engine-tests",
     );
     repo.git(&["add", "."]);
     repo.git(&["commit", "-m", "baseline"]);
@@ -149,17 +114,9 @@ fn active_task_allows_control_state_and_untracked_files_inside_scope() {
         "packages/naome/crates/naome-core/src/lib.rs",
         "pub fn marker() {}\n",
     );
-    repo.write_naome_json(
-        "task-state.json",
-        json!({
-            "status": "implementing",
-            "activeTask": {
-                "id": "rust-task",
-                "allowedPaths": ["packages/naome/crates/naome-core/src/lib.rs"],
-                "requiredCheckIds": ["decision-engine-tests"],
-                "proofResults": []
-            }
-        }),
+    repo.write_implementing_task_state(
+        "packages/naome/crates/naome-core/src/lib.rs",
+        "decision-engine-tests",
     );
 
     let decision = evaluate_decision(repo.path(), EvaluationOptions::offline()).unwrap();
@@ -202,12 +159,7 @@ fn online_checks_use_explicit_node_binary_from_environment() {
     let _guard = ENV_LOCK.lock().unwrap();
     let repo = TestRepo::new("explicit-node-bin");
     repo.init_git();
-    repo.write_naome_json("init-state.json", json!({ "initialized": true }));
-    repo.write_naome_json("upgrade-state.json", json!({ "status": "complete" }));
-    repo.write_naome_json(
-        "task-state.json",
-        json!({ "status": "idle", "activeTask": null }),
-    );
+    repo.write_base_naome_state(json!({ "status": "idle", "activeTask": null }));
     repo.git(&["add", "."]);
     repo.git(&["commit", "-m", "baseline"]);
     let fake_node = std::env::temp_dir().join(format!(
@@ -240,60 +192,14 @@ fn online_checks_use_explicit_node_binary_from_environment() {
     );
 }
 
-struct TestRepo {
-    root: PathBuf,
-}
-
-impl TestRepo {
-    fn new(name: &str) -> Self {
-        let nonce = SystemTime::now()
-            .duration_since(UNIX_EPOCH)
-            .unwrap()
-            .as_nanos();
-        let root = std::env::temp_dir().join(format!("naome-core-{name}-{nonce}"));
-        fs::create_dir_all(root.join(".naome")).unwrap();
-        Self { root }
-    }
-
-    fn path(&self) -> &Path {
-        &self.root
-    }
-
-    fn write_file(&self, relative_path: &str, content: &str) {
-        let path = self.root.join(relative_path);
-        if let Some(parent) = path.parent() {
-            fs::create_dir_all(parent).unwrap();
+fn completed_without_proof_state() -> serde_json::Value {
+    json!({
+        "status": "complete",
+        "activeTask": {
+            "id": "readme-task",
+            "allowedPaths": ["README.md"],
+            "requiredCheckIds": ["diff-check"],
+            "proofResults": []
         }
-        fs::write(path, content).unwrap();
-    }
-
-    fn write_naome_json(&self, file_name: &str, value: serde_json::Value) {
-        let path = self.root.join(".naome").join(file_name);
-        fs::write(
-            path,
-            format!("{}\n", serde_json::to_string_pretty(&value).unwrap()),
-        )
-        .unwrap();
-    }
-
-    fn init_git(&self) {
-        self.git(&["init"]);
-        self.git(&["config", "user.email", "naome@example.com"]);
-        self.git(&["config", "user.name", "NAOME Test"]);
-    }
-
-    fn git(&self, args: &[&str]) {
-        let output = Command::new("git")
-            .args(args)
-            .current_dir(&self.root)
-            .output()
-            .unwrap();
-        assert!(
-            output.status.success(),
-            "git {:?} failed\nstdout:\n{}\nstderr:\n{}",
-            args,
-            String::from_utf8_lossy(&output.stdout),
-            String::from_utf8_lossy(&output.stderr)
-        );
-    }
+    })
 }

package/crates/naome-core/tests/harness_health.rs

@@ -30,11 +30,13 @@ const PROJECT_OWNED_PATHS: &[&str] = &[
     ".naome/upgrade-state.json",
     ".naome/verification.json",
     ".naome/repository-quality.json",
+    ".naome/repository-structure.json",
     ".naome/repository-quality-baseline.json",
     "docs/naome/architecture.md",
     "docs/naome/decisions.md",
     "docs/naome/repo-profile.md",
     "docs/naome/repository-quality.md",
+    "docs/naome/repository-structure.md",
     "docs/naome/security.md",
     "docs/naome/testing.md",
 ];

package/crates/naome-core/tests/quality.rs

@@ -1,20 +1,19 @@
 use std::fs;
-use std::path::{Path, PathBuf};
-use std::process::Command;
-use std::sync::atomic::{AtomicU64, Ordering};
 
 use naome_core::{
     check_repository_quality, init_repository_quality, plan_quality_cleanup, route_quality_cleanup,
     seed_builtin_verification_checks, QualityMode,
 };
-use serde_json::{json, Value};
+use serde_json::Value;
 
-static FIXTURE_COUNTER: AtomicU64 = AtomicU64::new(0);
+mod quality_structure_support;
+
+use quality_structure_support::StructureFixture as QualityFixture;
 
 #[test]
 fn changed_check_blocks_touched_legacy_file_until_it_conforms() {
     let repo = QualityFixture::new("quality-touched-legacy");
-    repo.write_quality_config(5, 40, 4);
+    repo.write_quality_limits(5, 40, 4);
     repo.write(
         "src/large.js",
         "export function legacy() {\n  one();\n  two();\n  three();\n  four();\n}\n",
@@ -38,7 +37,7 @@ fn changed_check_blocks_touched_legacy_file_until_it_conforms() {
 #[test]
 fn whole_repo_debt_is_visible_without_blocking_clean_changed_check() {
     let repo = QualityFixture::new("quality-clean-legacy-report");
-    repo.write_quality_config(5, 40, 4);
+    repo.write_quality_limits(5, 40, 4);
     repo.write(
         "src/large.js",
         "export function legacy() {\n  one();\n  two();\n  three();\n  four();\n}\n",
@@ -60,7 +59,7 @@ fn whole_repo_debt_is_visible_without_blocking_clean_changed_check() {
 #[test]
 fn changed_check_blocks_new_duplicate_blocks_against_existing_code() {
     let repo = QualityFixture::new("quality-duplicate-block");
-    repo.write_quality_config(200, 40, 4);
+    repo.write_quality_limits(200, 40, 4);
     repo.write(
         "src/existing.js",
         "export function existing() {\n  const alpha = input.alpha;\n  const beta = input.beta;\n  const total = alpha + beta;\n  return total;\n}\n",
@@ -87,7 +86,7 @@ fn changed_check_blocks_new_duplicate_blocks_against_existing_code() {
 #[test]
 fn duplicate_blocks_report_one_finding_per_overlapping_region() {
     let repo = QualityFixture::new("quality-duplicate-region");
-    repo.write_quality_config(200, 80, 4);
+    repo.write_quality_limits(200, 80, 4);
     repo.write(
         "src/existing.js",
         "export function existing() {\n  const alpha = input.alpha;\n  const beta = input.beta;\n  const gamma = input.gamma;\n  const total = alpha + beta + gamma;\n  return total;\n}\n",
@@ -114,7 +113,7 @@ fn duplicate_blocks_report_one_finding_per_overlapping_region() {
 #[test]
 fn duplicate_blocks_detect_repeated_regions_in_the_same_file() {
     let repo = QualityFixture::new("quality-same-file-duplicate-region");
-    repo.write_quality_config(200, 80, 4);
+    repo.write_quality_limits(200, 80, 4);
     repo.commit_all("empty baseline");
 
     repo.write(
@@ -150,7 +149,7 @@ fn duplicate_blocks_detect_repeated_regions_in_the_same_file() {
 #[test]
 fn duplicate_blocks_ignore_generated_sha256_maps() {
     let repo = QualityFixture::new("quality-generated-hash-map");
-    repo.write_quality_config(200, 80, 4);
+    repo.write_quality_limits(200, 80, 4);
     let generated_map = concat!(
         "const expected = Object.freeze({\n",
         "  \"one.js\": \"sha256:1111111111111111111111111111111111111111111111111111111111111111\",\n",
@@ -173,7 +172,7 @@ fn duplicate_blocks_ignore_generated_sha256_maps() {
 #[test]
 fn near_duplicate_functions_do_not_compare_containers_with_child_symbols() {
     let repo = QualityFixture::new("quality-container-child-similarity");
-    repo.write_quality_config(200, 120, 10);
+    repo.write_quality_limits(200, 120, 10);
     repo.write(
         "src/lib.rs",
         "pub struct Runner;\n\nimpl Runner {\n    pub fn execute(&self) {\n        alpha();\n        beta();\n        gamma();\n        delta();\n        epsilon();\n        zeta();\n        eta();\n        theta();\n        iota();\n        kappa();\n        lambda();\n        mu();\n        nu();\n        xi();\n        omicron();\n        pi();\n    }\n}\n",
@@ -300,7 +299,7 @@ fn seeding_builtin_verification_wires_repository_quality_into_change_types() {
 #[test]
 fn cleanup_plan_and_route_turn_debt_into_agent_work() {
     let repo = QualityFixture::new("quality-cleanup-plan");
-    repo.write_quality_config(5, 40, 4);
+    repo.write_quality_limits(5, 40, 4);
     repo.write(
         "src/large.js",
         "export function legacy() {\n  one();\n  two();\n  three();\n  four();\n}\n",
@@ -318,108 +317,3 @@ fn cleanup_plan_and_route_turn_debt_into_agent_work() {
         .required_checks
         .contains(&"naome quality check --changed".to_string()));
 }
-
-struct QualityFixture {
-    root: PathBuf,
-}
-
-impl QualityFixture {
-    fn new(name: &str) -> Self {
-        let root = std::env::temp_dir().join(format!(
-            "naome-{name}-{}-{}",
-            std::process::id(),
-            FIXTURE_COUNTER.fetch_add(1, Ordering::SeqCst)
-        ));
-        let _ = fs::remove_dir_all(&root);
-        fs::create_dir_all(root.join(".naome")).unwrap();
-        fs::write(root.join(".naomeignore"), ".naome/archive/\n").unwrap();
-        git(&root, &["init"]);
-        git(&root, &["config", "user.email", "test@example.com"]);
-        git(&root, &["config", "user.name", "Test User"]);
-        Self { root }
-    }
-
-    fn path(&self) -> &Path {
-        &self.root
-    }
-
-    fn write(&self, relative_path: &str, content: &str) {
-        let path = self.root.join(relative_path);
-        if let Some(parent) = path.parent() {
-            fs::create_dir_all(parent).unwrap();
-        }
-        fs::write(path, content).unwrap();
-    }
-
-    fn write_quality_config(
-        &self,
-        max_file_lines: usize,
-        max_function_lines: usize,
-        duplicate_block_lines: usize,
-    ) {
-        self.write_quality_config_with_adapters(
-            max_file_lines,
-            max_function_lines,
-            duplicate_block_lines,
-            &[],
-        );
-    }
-
-    fn write_quality_config_with_adapters(
-        &self,
-        max_file_lines: usize,
-        max_function_lines: usize,
-        duplicate_block_lines: usize,
-        enabled_adapters: &[&str],
-    ) {
-        let config = json!({
-            "schema": "naome.repository-quality.v1",
-            "version": 1,
-            "status": "ready",
-            "limits": {
-                "maxFileLines": max_file_lines,
-                "maxNewFileLines": max_file_lines,
-                "maxDiffAddedLines": 200,
-                "maxFunctionLines": max_function_lines,
-                "maxTopLevelSymbols": 30,
-                "duplicateBlockLines": duplicate_block_lines,
-                "nearDuplicateSimilarity": 0.9
-            },
-            "enabledAdapters": enabled_adapters,
-            "disabledChecks": [],
-            "ignoredPaths": [],
-            "generatedPaths": [],
-            "pathRules": []
-        });
-        self.write(
-            ".naome/repository-quality.json",
-            &format!("{}\n", serde_json::to_string_pretty(&config).unwrap()),
-        );
-    }
-
-    fn commit_all(&self, message: &str) {
-        git(&self.root, &["add", "."]);
-        git(&self.root, &["commit", "-m", message]);
-    }
-}
-
-impl Drop for QualityFixture {
-    fn drop(&mut self) {
-        let _ = fs::remove_dir_all(&self.root);
-    }
-}
-
-fn git(root: &Path, args: &[&str]) {
-    let output = Command::new("git")
-        .args(args)
-        .current_dir(root)
-        .output()
-        .unwrap();
-    assert!(
-        output.status.success(),
-        "git {} failed\nstdout: {}\nstderr: {}",
-        args.join(" "),
-        String::from_utf8_lossy(&output.stdout),
-        String::from_utf8_lossy(&output.stderr)
-    );
-}

package/crates/naome-core/tests/quality_structure.rs

@@ -0,0 +1,116 @@
+mod quality_structure_support;
+
+use naome_core::{check_repository_quality, QualityMode};
+use serde_json::json;
+
+use quality_structure_support::{assert_has, StructureFixture};
+
+#[test]
+fn source_and_test_files_in_known_roots_are_ok() {
+    let repo = StructureFixture::new("structure-good-roots");
+    repo.write_js_package();
+    repo.write(
+        "src/feature.js",
+        "export function feature() {\n  return 1;\n}\n",
+    );
+    repo.write("tests/feature.test.js", "import '../src/feature.js';\n");
+
+    let report = check_repository_quality(repo.path(), QualityMode::Changed).unwrap();
+
+    assert!(report.ok, "{:#?}", report.violations);
+}
+
+#[test]
+fn misplaced_test_file_creates_structure_finding() {
+    let repo = StructureFixture::new("structure-misplaced-test");
+    repo.write_js_package();
+    repo.write(
+        "src/feature.test.js",
+        "export function testFeature() {\n  return 1;\n}\n",
+    );
+
+    let report = check_repository_quality(repo.path(), QualityMode::Changed).unwrap();
+
+    assert_has(&report, "src/feature.test.js", "misplaced-file-role");
+}
+
+#[test]
+fn generated_or_artifact_file_in_source_folder_creates_finding() {
+    let repo = StructureFixture::new("structure-generated-source");
+    repo.write_js_package();
+    repo.write(
+        "src/generated/client.ts",
+        "export const generated = true;\n",
+    );
+
+    let report = check_repository_quality(repo.path(), QualityMode::Changed).unwrap();
+
+    assert_has(&report, "src/generated/client.ts", "directory-role-mixing");
+}
+
+#[test]
+fn unknown_root_files_create_root_sprawl_findings() {
+    let repo = StructureFixture::new("structure-root-sprawl");
+    repo.write("notes.tmp", "temporary notes\n");
+
+    let report = check_repository_quality(repo.path(), QualityMode::Changed).unwrap();
+
+    assert_has(&report, "notes.tmp", "root-file-sprawl");
+}
+
+#[test]
+fn dumping_ground_directory_flags_new_feature_logic() {
+    let repo = StructureFixture::new("structure-dumping-ground");
+    repo.write_js_package();
+    repo.write(
+        "src/payments/service.js",
+        "export function charge() {\n  return 1;\n}\n",
+    );
+    repo.commit_all("module baseline");
+    repo.write(
+        "src/utils/payment-flow.js",
+        "export function capturePayment() {\n  return charge();\n}\n",
+    );
+
+    let report = check_repository_quality(repo.path(), QualityMode::Changed).unwrap();
+
+    assert_has(
+        &report,
+        "src/utils/payment-flow.js",
+        "dumping-ground-directory",
+    );
+}
+
+#[test]
+fn excessive_path_depth_and_directory_size_are_reported() {
+    let repo = StructureFixture::new("structure-limits");
+    repo.write_structure_config(json!({
+        "limits": {
+            "maxDirectoryFiles": 2,
+            "maxPathDepth": 4,
+            "maxDirectoryRoles": 2,
+            "maxDumpingGroundFiles": 8
+        }
+    }));
+    repo.write("src/a/one.js", "export const one = 1;\n");
+    repo.write("src/a/two.js", "export const two = 2;\n");
+    repo.write("src/a/three.js", "export const three = 3;\n");
+    repo.write("src/a/b/c/d/e/deep.js", "export const deep = 1;\n");
+
+    let report = check_repository_quality(repo.path(), QualityMode::Changed).unwrap();
+
+    assert_has(&report, "src/a", "directory-size");
+    assert_has(&report, "src/a/b/c/d/e/deep.js", "path-depth");
+}
+
+#[test]
+fn case_insensitive_path_collisions_block_changed_paths() {
+    let repo = StructureFixture::new("structure-case-collision");
+    repo.add_index_only_path("src/User.ts", "export const upper = 1;\n");
+    repo.add_index_only_path("src/user.ts", "export const lower = 1;\n");
+
+    let report = check_repository_quality(repo.path(), QualityMode::Changed).unwrap();
+
+    assert_has(&report, "src/User.ts", "case-collision");
+    assert_has(&report, "src/user.ts", "case-collision");
+}

package/crates/naome-core/tests/quality_structure_adapters.rs

@@ -0,0 +1,98 @@
+mod quality_structure_support;
+
+use naome_core::{check_repository_quality, explain_repository_structure, QualityMode};
+
+use quality_structure_support::{assert_has, StructureFixture};
+
+#[test]
+fn rust_adapter_recognizes_cargo_source_and_test_structure() {
+    let repo = StructureFixture::new("structure-rust-adapter");
+    repo.write(
+        "Cargo.toml",
+        "[package]\nname = \"demo\"\nversion = \"0.1.0\"\n",
+    );
+    repo.write("src/lib.rs", "pub fn value() -> u8 {\n    1\n}\n");
+    repo.write(
+        "tests/lib_test.rs",
+        "#[test]\nfn value() {\n    assert_eq!(1, 1);\n}\n",
+    );
+
+    let report = check_repository_quality(repo.path(), QualityMode::Changed).unwrap();
+    let source = explain_repository_structure(repo.path(), "src/lib.rs").unwrap();
+
+    assert!(report.ok, "{:#?}", report.violations);
+    assert_eq!(source.role, "source");
+    assert_eq!(source.language.as_deref(), Some("rust"));
+}
+
+#[test]
+fn javascript_typescript_adapter_recognizes_package_source_and_tests() {
+    let repo = StructureFixture::new("structure-js-ts-adapter");
+    repo.write_js_package();
+    repo.write("src/app.ts", "export function app() {\n  return 1;\n}\n");
+    repo.write("src/app.test.ts", "import { app } from './app';\napp();\n");
+
+    let source = explain_repository_structure(repo.path(), "src/app.ts").unwrap();
+    let test = explain_repository_structure(repo.path(), "src/app.test.ts").unwrap();
+
+    assert_eq!(source.role, "source");
+    assert_eq!(source.language.as_deref(), Some("typescript"));
+    assert_eq!(test.role, "test");
+}
+
+#[test]
+fn unknown_repository_gets_generic_roles() {
+    let repo = StructureFixture::new("structure-generic-roles");
+    repo.write("docs/readme.md", "# Docs\n");
+    repo.write("scripts/build.sh", "echo build\n");
+    repo.write("src/main.go", "package main\nfunc main() {}\n");
+
+    assert_eq!(
+        explain_repository_structure(repo.path(), "docs/readme.md")
+            .unwrap()
+            .role,
+        "docs"
+    );
+    assert_eq!(
+        explain_repository_structure(repo.path(), "scripts/build.sh")
+            .unwrap()
+            .role,
+        "script"
+    );
+    assert_eq!(
+        explain_repository_structure(repo.path(), "src/main.go")
+            .unwrap()
+            .language
+            .as_deref(),
+        Some("go")
+    );
+}
+
+#[test]
+fn source_changes_without_nearby_tests_create_pairing_finding() {
+    let repo = StructureFixture::new("structure-missing-test-pair");
+    repo.write_js_package();
+    repo.write(
+        "src/billing/invoice.ts",
+        "export function invoice() {\n  return 1;\n}\n",
+    );
+
+    let report = check_repository_quality(repo.path(), QualityMode::Changed).unwrap();
+
+    assert_has(&report, "src/billing/invoice.ts", "test-source-pairing");
+}
+
+#[test]
+fn repositories_without_structure_config_remain_valid() {
+    let repo = StructureFixture::new("structure-config-backcompat");
+    repo.write_quality_config();
+    repo.write(
+        "src/index.js",
+        "export function index() {\n  return 1;\n}\n",
+    );
+    repo.write("tests/index.test.js", "import '../src/index.js';\n");
+
+    let report = check_repository_quality(repo.path(), QualityMode::Changed).unwrap();
+
+    assert!(report.ok, "{:#?}", report.violations);
+}