@lamentis/naome 1.1.2 → 1.2.1

package/crates/naome-core/src/workflow/types.rs

@@ -0,0 +1,42 @@
+use serde::{Deserialize, Serialize};
+
+#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
+#[serde(rename_all = "camelCase")]
+pub struct WorkflowFinding {
+    pub check_id: String,
+    pub severity: String,
+    pub message: String,
+    pub paths: Vec<String>,
+    pub command: Option<String>,
+}
+
+impl WorkflowFinding {
+    pub(crate) fn blocking(
+        check_id: &str,
+        message: impl Into<String>,
+        paths: Vec<String>,
+        command: Option<String>,
+    ) -> Self {
+        Self {
+            check_id: check_id.to_string(),
+            severity: "blocking".to_string(),
+            message: message.into(),
+            paths,
+            command,
+        }
+    }
+}
+
+#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
+#[serde(rename_all = "camelCase")]
+pub struct ReadActivity {
+    pub command: String,
+    pub paths: Vec<String>,
+}
+
+#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
+#[serde(rename_all = "camelCase")]
+pub struct MutationClassification {
+    pub path: String,
+    pub mutation_class: String,
+}

package/crates/naome-core/tests/decision.rs

@@ -1,12 +1,14 @@
 use std::fs;
-use std::path::{Path, PathBuf};
-use std::process::Command;
 use std::sync::Mutex;
 use std::time::{SystemTime, UNIX_EPOCH};
 
 use naome_core::{evaluate_decision, format_decision, EvaluationOptions};
 use serde_json::json;
 
+mod repo_support;
+
+use repo_support::TestRepo;
+
 static ENV_LOCK: Mutex<()> = Mutex::new(());
 
 #[test]
@@ -34,20 +36,7 @@ fn completed_task_diff_returns_baseline_choices() {
     let repo = TestRepo::new("completed-task");
     repo.init_git();
     repo.write_file("README.md", "# Baseline\n");
-    repo.write_naome_json("init-state.json", json!({ "initialized": true }));
-    repo.write_naome_json("upgrade-state.json", json!({ "status": "complete" }));
-    repo.write_naome_json(
-        "task-state.json",
-        json!({
-            "status": "complete",
-            "activeTask": {
-                "id": "readme-task",
-                "allowedPaths": ["README.md"],
-                "requiredCheckIds": ["diff-check"],
-                "proofResults": []
-            }
-        }),
-    );
+    repo.write_base_naome_state(completed_without_proof_state());
     repo.git(&["add", "."]);
     repo.git(&["commit", "-m", "baseline"]);
     repo.write_file("README.md", "# Changed\n");
@@ -71,17 +60,7 @@ fn completed_task_diff_returns_baseline_choices() {
 
 #[test]
 fn idle_unowned_diff_blocks_new_feature_work() {
-    let repo = TestRepo::new("unowned-diff");
-    repo.init_git();
-    repo.write_file("README.md", "# Baseline\n");
-    repo.write_naome_json("init-state.json", json!({ "initialized": true }));
-    repo.write_naome_json("upgrade-state.json", json!({ "status": "complete" }));
-    repo.write_naome_json(
-        "task-state.json",
-        json!({ "status": "idle", "activeTask": null }),
-    );
-    repo.git(&["add", "."]);
-    repo.git(&["commit", "-m", "baseline"]);
+    let repo = TestRepo::idle_readme("unowned-diff");
     repo.write_file("README.md", "# Manual change\n");
 
     let decision = evaluate_decision(repo.path(), EvaluationOptions::offline()).unwrap();
@@ -96,12 +75,7 @@ fn changed_paths_handle_worktree_renames_without_corrupting_old_path_tokens() {
     let repo = TestRepo::new("worktree-rename");
     repo.init_git();
     repo.write_file("packages/old/file.txt", "baseline\n");
-    repo.write_naome_json("init-state.json", json!({ "initialized": true }));
-    repo.write_naome_json("upgrade-state.json", json!({ "status": "complete" }));
-    repo.write_naome_json(
-        "task-state.json",
-        json!({ "status": "idle", "activeTask": null }),
-    );
+    repo.write_base_naome_state(json!({ "status": "idle", "activeTask": null }));
     repo.git(&["add", "."]);
     repo.git(&["commit", "-m", "baseline"]);
 
@@ -129,19 +103,10 @@ fn active_task_allows_control_state_and_untracked_files_inside_scope() {
     let repo = TestRepo::new("active-scope");
     repo.init_git();
     repo.write_file("README.md", "# Baseline\n");
-    repo.write_naome_json("init-state.json", json!({ "initialized": true }));
-    repo.write_naome_json("upgrade-state.json", json!({ "status": "complete" }));
-    repo.write_naome_json(
-        "task-state.json",
-        json!({
-            "status": "implementing",
-            "activeTask": {
-                "id": "rust-task",
-                "allowedPaths": ["packages/naome/crates/naome-core/src/lib.rs"],
-                "requiredCheckIds": ["decision-engine-tests"],
-                "proofResults": []
-            }
-        }),
+    repo.write_base_naome_state(json!({ "status": "idle", "activeTask": null }));
+    repo.write_implementing_task_state(
+        "packages/naome/crates/naome-core/src/lib.rs",
+        "decision-engine-tests",
     );
     repo.git(&["add", "."]);
     repo.git(&["commit", "-m", "baseline"]);
@@ -149,17 +114,9 @@ fn active_task_allows_control_state_and_untracked_files_inside_scope() {
         "packages/naome/crates/naome-core/src/lib.rs",
         "pub fn marker() {}\n",
     );
-    repo.write_naome_json(
-        "task-state.json",
-        json!({
-            "status": "implementing",
-            "activeTask": {
-                "id": "rust-task",
-                "allowedPaths": ["packages/naome/crates/naome-core/src/lib.rs"],
-                "requiredCheckIds": ["decision-engine-tests"],
-                "proofResults": []
-            }
-        }),
+    repo.write_implementing_task_state(
+        "packages/naome/crates/naome-core/src/lib.rs",
+        "decision-engine-tests",
     );
 
     let decision = evaluate_decision(repo.path(), EvaluationOptions::offline()).unwrap();
@@ -202,12 +159,7 @@ fn online_checks_use_explicit_node_binary_from_environment() {
     let _guard = ENV_LOCK.lock().unwrap();
     let repo = TestRepo::new("explicit-node-bin");
     repo.init_git();
-    repo.write_naome_json("init-state.json", json!({ "initialized": true }));
-    repo.write_naome_json("upgrade-state.json", json!({ "status": "complete" }));
-    repo.write_naome_json(
-        "task-state.json",
-        json!({ "status": "idle", "activeTask": null }),
-    );
+    repo.write_base_naome_state(json!({ "status": "idle", "activeTask": null }));
     repo.git(&["add", "."]);
     repo.git(&["commit", "-m", "baseline"]);
     let fake_node = std::env::temp_dir().join(format!(
@@ -240,60 +192,14 @@ fn online_checks_use_explicit_node_binary_from_environment() {
     );
 }
 
-struct TestRepo {
-    root: PathBuf,
-}
-
-impl TestRepo {
-    fn new(name: &str) -> Self {
-        let nonce = SystemTime::now()
-            .duration_since(UNIX_EPOCH)
-            .unwrap()
-            .as_nanos();
-        let root = std::env::temp_dir().join(format!("naome-core-{name}-{nonce}"));
-        fs::create_dir_all(root.join(".naome")).unwrap();
-        Self { root }
-    }
-
-    fn path(&self) -> &Path {
-        &self.root
-    }
-
-    fn write_file(&self, relative_path: &str, content: &str) {
-        let path = self.root.join(relative_path);
-        if let Some(parent) = path.parent() {
-            fs::create_dir_all(parent).unwrap();
+fn completed_without_proof_state() -> serde_json::Value {
+    json!({
+        "status": "complete",
+        "activeTask": {
+            "id": "readme-task",
+            "allowedPaths": ["README.md"],
+            "requiredCheckIds": ["diff-check"],
+            "proofResults": []
         }
-        fs::write(path, content).unwrap();
-    }
-
-    fn write_naome_json(&self, file_name: &str, value: serde_json::Value) {
-        let path = self.root.join(".naome").join(file_name);
-        fs::write(
-            path,
-            format!("{}\n", serde_json::to_string_pretty(&value).unwrap()),
-        )
-        .unwrap();
-    }
-
-    fn init_git(&self) {
-        self.git(&["init"]);
-        self.git(&["config", "user.email", "naome@example.com"]);
-        self.git(&["config", "user.name", "NAOME Test"]);
-    }
-
-    fn git(&self, args: &[&str]) {
-        let output = Command::new("git")
-            .args(args)
-            .current_dir(&self.root)
-            .output()
-            .unwrap();
-        assert!(
-            output.status.success(),
-            "git {:?} failed\nstdout:\n{}\nstderr:\n{}",
-            args,
-            String::from_utf8_lossy(&output.stdout),
-            String::from_utf8_lossy(&output.stderr)
-        );
-    }
+    })
 }

package/crates/naome-core/tests/harness_health.rs

@@ -29,9 +29,14 @@ const PROJECT_OWNED_PATHS: &[&str] = &[
     ".naome/task-state.json",
     ".naome/upgrade-state.json",
     ".naome/verification.json",
+    ".naome/repository-quality.json",
+    ".naome/repository-structure.json",
+    ".naome/repository-quality-baseline.json",
     "docs/naome/architecture.md",
     "docs/naome/decisions.md",
     "docs/naome/repo-profile.md",
+    "docs/naome/repository-quality.md",
+    "docs/naome/repository-structure.md",
     "docs/naome/security.md",
     "docs/naome/testing.md",
 ];