@lalalic/markcut 3.2.2 → 3.2.4

package/README.md

@@ -342,27 +342,3 @@ flowchart LR
 | `--show-prompts` | Print the prompts template file and exit |
 
 ## Architecture
-
-
-### Browser ChatGPT Vision backend
-
-Markcut can use the Neo `chatgpt-browser-worker` agent as the configurable ITT/VTT backend without changing the default local VLMs. Each invocation creates one unique durable file output plus unique Neo job/task correlation, then hands the complete one-shot request to the existing browser-worker agent runtime.
-
-For an installed package, select it with the existing CLI-template surface:
-
-```bash
-export MARKCUT_ITT_CLI='markcut vision-chatgpt --mode image --prompt "{prompt}" --input {input}'
-export MARKCUT_VTT_CLI='markcut vision-chatgpt --mode video --prompt "{prompt}" --input {input}'
-```
-
-For a source checkout, replace `markcut` above with `node src/render/cli.mjs`.
-
-The facade intentionally does not call `chatgpt-browser-worker/scripts/*` or automate Chrome itself. Set `MARKCUT_CHATGPT_BROWSER_WORKER_AGENT_CLI` to the local command that launches the Neo **browser-worker agent/runtime**. The older `MARKCUT_CHATGPT_BROWSER_WORKER_CLI` name remains as a compatibility fallback.
-
-- `MARKCUT_CHATGPT_PROMPT_FILE` — complete one-shot prompt, including the exact `Output: file` contract and worker-owned event IDs.
-- `MARKCUT_CHATGPT_MEDIA_FILES_JSON` — JSON array of attachments. Images are passed directly; video is deterministically reduced to a chronological contact sheet of representative frames plus timing context.
-- `MARKCUT_CHATGPT_OUTPUT_FILE` — authoritative result path that the delegated ChatGPT task must write.
-- `NEO_JOB_ID` / `NEO_TASK_ID` — unique correlation for the delegated worker's canonical `task.started` and terminal task event.
-- `MARKCUT_CHATGPT_TAB_CLOSE_POLICY=after-terminal` — requests that only the isolated worker-owned tab remain open until the exact task terminal event.
-
-The launcher may stay active through `after-terminal`; launcher/process exit is not treated as task completion. Markcut's only result is the declared durable output file, and it exits nonzero on launcher failure, timeout, preprocessing failure, or an empty/missing result. Carrier-only `task.process.launched`, `task.process.exited`, and `task.process.async_exited` events never substitute for worker-owned task lifecycle.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lalalic/markcut",
-  "version": "3.2.2",
+  "version": "3.2.4",
   "description": "Markdown-to-video engine. Describe scenes in markdown, get a rendered video.",
   "bin": {
     "markcut": "bin/markcut"

package/src/render/cli.mjs

@@ -81,11 +81,6 @@ Commands:
     --label                            Add interactive labeling step before AI pipeline
     --instruct "text"                   Background context about people/places (injected into prompts)
 
-  vision-chatgpt                       Browser ChatGPT ITT/VTT facade
-    --mode image|video|auto            Media mode (default: auto)
-    --prompt "text"                    Vision instructions
-    --input <path...>                  Local media input(s)
-
   spots --waypoints "lat,lng;..."      Discover POIs along a route (Directions + Places API)
     --travelMode DRIVING               DRIVING | WALKING | BICYCLING (default DRIVING)
     --limit 8                          Max spots after ranking
@@ -228,11 +223,6 @@ edit=${DEFAULT_EDIT_CLI}`);
     process.exit(0);
   }
 
-  if (args.command === "vision-chatgpt") {
-    const { main: visionChatGptMain } = await import("../vision/chatgpt-browser-cli.mjs");
-    process.exit(visionChatGptMain(process.argv.slice(3)));
-  }
-
   if (args.command === "spots") {
     await import("../spots/cli.mjs");  // self-executing top-level script
     process.exit(0);

package/src/vision/chatgpt-browser-cli.mjs

@@ -1,122 +0,0 @@
-#!/usr/bin/env node
-import { execFileSync, execSync } from "node:child_process";
-import { randomUUID } from "node:crypto";
-import { existsSync, mkdirSync, mkdtempSync, readFileSync, readdirSync, rmSync, writeFileSync } from "node:fs";
-import { tmpdir } from "node:os";
-import { basename, extname, join, resolve } from "node:path";
-
-const IMAGE_EXTS = new Set([".jpg", ".jpeg", ".png", ".webp", ".gif", ".bmp", ".tiff", ".heic", ".avif"]);
-const VIDEO_EXTS = new Set([".mp4", ".mov", ".avi", ".mkv", ".webm", ".m4v", ".wmv"]);
-
-function shellQuote(value) { return `'${String(value).replace(/'/g, `'\\''`)}'`; }
-
-export function parseArgs(argv) {
-  const out = { mode: "auto", inputs: [], prompt: "", timeoutMs: Number(process.env.MARKCUT_CHATGPT_VISION_TIMEOUT_MS) || 600_000, maxFrames: 8 };
-  for (let i = 0; i < argv.length; i++) {
-    const arg = argv[i];
-    if (arg === "--mode") out.mode = argv[++i] || "auto";
-    else if (arg === "--prompt") out.prompt = argv[++i] || "";
-    else if (arg === "--input") {
-      while (argv[i + 1] && !argv[i + 1].startsWith("--")) out.inputs.push(argv[++i]);
-    } else if (arg === "--timeout-ms") out.timeoutMs = Number(argv[++i]);
-    else if (arg === "--max-frames") out.maxFrames = Number(argv[++i]);
-    else if (!arg.startsWith("--")) out.inputs.push(arg);
-    else throw new Error(`Unknown argument: ${arg}`);
-  }
-  if (!out.prompt) throw new Error("--prompt is required");
-  if (out.inputs.length === 0) throw new Error("--input is required");
-  if (!Number.isFinite(out.timeoutMs) || out.timeoutMs <= 0) throw new Error("--timeout-ms must be > 0");
-  if (!Number.isFinite(out.maxFrames) || out.maxFrames < 1 || out.maxFrames > 16) throw new Error("--max-frames must be 1..16");
-  out.inputs = out.inputs.map((p) => resolve(p.replace(/^@/, "")));
-  for (const input of out.inputs) if (!existsSync(input)) throw new Error(`Input not found: ${input}`);
-  if (out.mode === "auto") out.mode = out.inputs.some((p) => VIDEO_EXTS.has(extname(p).toLowerCase())) ? "video" : "image";
-  if (!['image', 'video'].includes(out.mode)) throw new Error("--mode must be image, video, or auto");
-  return out;
-}
-
-function ffprobeDuration(videoPath) {
-  const raw = execFileSync("ffprobe", ["-v", "error", "-show_entries", "format=duration", "-of", "default=noprint_wrappers=1:nokey=1", videoPath], { encoding: "utf8" }).trim();
-  const value = Number(raw);
-  if (!Number.isFinite(value) || value <= 0) throw new Error(`Unable to read video duration: ${videoPath}`);
-  return value;
-}
-
-export function prepareMedia(mode, inputs, workDir, maxFrames = 8) {
-  if (mode === "image") return { files: inputs, context: inputs.map((p) => `Image: ${basename(p)}`).join("\n") };
-  if (inputs.length !== 1) throw new Error("video mode accepts exactly one input video");
-  const videoPath = inputs[0];
-  if (!VIDEO_EXTS.has(extname(videoPath).toLowerCase())) throw new Error(`Unsupported video input: ${videoPath}`);
-  const duration = ffprobeDuration(videoPath);
-  const count = Math.max(1, Math.min(maxFrames, Math.ceil(duration / 5)));
-  const framesDir = join(workDir, "frames");
-  mkdirSync(framesDir, { recursive: true });
-  const pattern = join(framesDir, "frame-%03d.jpg");
-  const fps = count / duration;
-  execFileSync("ffmpeg", ["-y", "-i", videoPath, "-vf", `fps=${fps},scale='min(640,iw)':-2`, "-frames:v", String(count), "-q:v", "3", pattern], { stdio: "ignore" });
-  const frames = readdirSync(framesDir).filter((f) => f.endsWith(".jpg")).sort().map((f) => join(framesDir, f));
-  if (frames.length === 0) throw new Error("No representative frames extracted from video");
-  const cols = Math.min(4, frames.length);
-  const contact = join(workDir, "contact-sheet.jpg");
-  if (frames.length === 1) {
-    execFileSync("ffmpeg", ["-y", "-i", frames[0], "-vf", "scale=320:-2", "-frames:v", "1", contact], { stdio: "ignore" });
-  } else {
-    execSync(`ffmpeg -y ${frames.map((p) => `-i ${shellQuote(p)}`).join(" ")} -filter_complex ${shellQuote(`xstack=inputs=${frames.length}:layout=${frames.map((_, i) => `${i % cols}*w0_${Math.floor(i / cols)}*h0`).join('|')},scale=${cols * 320}:-2`)} -frames:v 1 ${shellQuote(contact)}`, { stdio: "ignore" });
-  }
-  const timing = frames.map((p, i) => `${basename(p)} ≈ ${(i * duration / frames.length).toFixed(1)}s`).join(", ");
-  return { files: [contact], context: `Video: ${basename(videoPath)}\nDuration: ${duration.toFixed(2)}s\nRepresentative frames are chronological, left-to-right then top-to-bottom.\nTiming: ${timing}` };
-}
-
-function waitForResult(outputPath, timeoutMs) {
-  const deadline = Date.now() + timeoutMs;
-  while (Date.now() < deadline) {
-    if (existsSync(outputPath)) {
-      const text = readFileSync(outputPath, "utf8").trim();
-      if (text) return text;
-    }
-    Atomics.wait(new Int32Array(new SharedArrayBuffer(4)), 0, 0, 250);
-  }
-  throw new Error(`Timed out waiting for Browser ChatGPT result: ${outputPath}`);
-}
-
-export function runVision({ mode, inputs, prompt, timeoutMs, maxFrames }, env = process.env) {
-  const launcher = env.MARKCUT_CHATGPT_BROWSER_WORKER_AGENT_CLI || env.MARKCUT_CHATGPT_BROWSER_WORKER_CLI;
-  if (!launcher) {
-    throw new Error("MARKCUT_CHATGPT_BROWSER_WORKER_AGENT_CLI is required; it must launch the Neo browser-worker agent runtime");
-  }
-  const workDir = mkdtempSync(join(tmpdir(), "markcut-chatgpt-vision-"));
-  const outputPath = join(workDir, "result.txt");
-  try {
-    const media = prepareMedia(mode, inputs, workDir, maxFrames);
-    const jobId = `markcut-vision-${randomUUID()}`;
-    const taskId = `browser-vision-${randomUUID()}`;
-    const fullPrompt = `${prompt}\n\nMedia context:\n${media.context}\n\nAnalyze only the attached media. Preserve chronology for video. Write only the final answer to the declared file output.\n\nExecution event contract:\n- Job: ${jobId}\n- Task: ${taskId}\n- Publish exactly one worker-owned task.started before analysis.\n- Publish exactly one worker-owned task.completed only after the output file is durable; publish task.failed instead if execution cannot complete.\n- task.process.* events are carrier lifecycle only and never substitute for task lifecycle.\n\nOutput:\nfile\n${outputPath}`;
-    const promptPath = join(workDir, "prompt.txt");
-    writeFileSync(promptPath, fullPrompt, "utf8");
-    const childEnv = {
-      ...env,
-      MARKCUT_CHATGPT_PROMPT_FILE: promptPath,
-      MARKCUT_CHATGPT_MEDIA_FILES_JSON: JSON.stringify(media.files),
-      MARKCUT_CHATGPT_OUTPUT_FILE: outputPath,
-      MARKCUT_CHATGPT_TAB_CLOSE_POLICY: "after-terminal",
-      NEO_JOB_ID: jobId,
-      NEO_TASK_ID: taskId,
-    };
-    execSync(launcher, { env: childEnv, stdio: ["ignore", "pipe", "pipe"], timeout: timeoutMs });
-    return waitForResult(outputPath, timeoutMs);
-  } finally {
-    rmSync(workDir, { recursive: true, force: true });
-  }
-}
-
-export function main(argv = process.argv.slice(2), env = process.env) {
-  try {
-    const result = runVision(parseArgs(argv), env);
-    process.stdout.write(`${result}\n`);
-    return 0;
-  } catch (error) {
-    process.stderr.write(`markcut chatgpt vision: ${error instanceof Error ? error.message : String(error)}\n`);
-    return 1;
-  }
-}
-
-if (process.argv[1] && process.argv[1].endsWith("chatgpt-browser-cli.mjs")) process.exitCode = main();

package/tests/vision-chatgpt-browser.test.ts

@@ -1,50 +0,0 @@
-import { afterEach, describe, expect, it } from "vitest";
-import { existsSync, mkdtempSync, readFileSync, rmSync, writeFileSync } from "node:fs";
-import { tmpdir } from "node:os";
-import { join } from "node:path";
-import { execFileSync } from "node:child_process";
-import { parseArgs, prepareMedia, runVision } from "../src/vision/chatgpt-browser-cli.mjs";
-
-const roots: string[] = [];
-afterEach(() => { while (roots.length) rmSync(roots.pop()!, { recursive: true, force: true }); });
-function temp() { const p = mkdtempSync(join(tmpdir(), "markcut-browser-test-")); roots.push(p); return p; }
-function makeMock(root: string) {
-  const path = join(root, "mock-worker.mjs");
-  writeFileSync(path, `import {readFileSync,writeFileSync} from 'node:fs';\nconst p=readFileSync(process.env.MARKCUT_CHATGPT_PROMPT_FILE,'utf8');\nif(!p.includes('Output:\\nfile\\n'+process.env.MARKCUT_CHATGPT_OUTPUT_FILE)) process.exit(3);\nif(!process.env.NEO_JOB_ID?.startsWith('markcut-vision-')||!process.env.NEO_TASK_ID?.startsWith('browser-vision-')) process.exit(5);\nif(process.env.MARKCUT_CHATGPT_TAB_CLOSE_POLICY!=='after-terminal') process.exit(6);\nif(!p.includes('Publish exactly one worker-owned task.started')||!p.includes(process.env.NEO_JOB_ID)||!p.includes(process.env.NEO_TASK_ID)) process.exit(7);\nconst files=JSON.parse(process.env.MARKCUT_CHATGPT_MEDIA_FILES_JSON);\nif(!files.length||files.some(f=>!readFileSync(f))) process.exit(4);\nwriteFileSync(process.env.MARKCUT_CHATGPT_OUTPUT_FILE,'mock answer');\n`);
-  return `node ${JSON.stringify(path)}`;
-}
-
-it("parses Markcut template-style image arguments", () => {
-  const root = temp(); const a = join(root, "a.jpg"); const b = join(root, "b.jpg"); writeFileSync(a, "a"); writeFileSync(b, "b");
-  const args = parseArgs(["--mode", "image", "--prompt", "describe", "--input", `@${a}`, b]);
-  expect(args.mode).toBe("image"); expect(args.inputs).toEqual([a, b]);
-});
-
-it("uses a unique file output per invocation and propagates result", () => {
-  const root = temp(); const image = join(root, "a.jpg"); writeFileSync(image, "image"); const launcher = makeMock(root);
-  const env = { ...process.env, MARKCUT_CHATGPT_BROWSER_WORKER_AGENT_CLI: launcher } as NodeJS.ProcessEnv;
-  expect(runVision({ mode:"image", inputs:[image], prompt:"describe", timeoutMs:2000, maxFrames:8 }, env)).toBe("mock answer");
-  expect(runVision({ mode:"image", inputs:[image], prompt:"describe again", timeoutMs:2000, maxFrames:8 }, env)).toBe("mock answer");
-});
-
-it("extracts deterministic chronological video representation", () => {
-  const root = temp(); const video = join(root, "clip.mp4"); const work = join(root, "work");
-  execFileSync("ffmpeg", ["-y", "-f", "lavfi", "-i", "testsrc=s=64x64:d=2:r=4", "-c:v", "libx264", video], { stdio:"ignore" });
-  const prepared = prepareMedia("video", [video], work, 4);
-  expect(prepared.files).toHaveLength(1); expect(existsSync(prepared.files[0])).toBe(true);
-  expect(prepared.context).toContain("chronological"); expect(prepared.context).toContain("Duration:");
-});
-
-it("returns nonzero from CLI when launcher fails", () => {
-  const root = temp(); const image = join(root, "a.jpg"); writeFileSync(image, "image");
-  expect(() => execFileSync("node", ["src/vision/chatgpt-browser-cli.mjs", "--mode", "image", "--prompt", "x", "--input", image], { cwd: process.cwd(), env: { ...process.env, MARKCUT_CHATGPT_BROWSER_WORKER_CLI: "exit 7" }, stdio:"pipe" })).toThrow();
-});
-
-describe("concurrency", () => {
-  it("does not collide across simultaneous invocations", async () => {
-    const root = temp(); const image = join(root, "a.jpg"); writeFileSync(image, "image"); const launcher = makeMock(root);
-    const env = { ...process.env, MARKCUT_CHATGPT_BROWSER_WORKER_AGENT_CLI: launcher } as NodeJS.ProcessEnv;
-    const results = await Promise.all(Array.from({length:4}, (_, i) => Promise.resolve().then(() => runVision({ mode:"image", inputs:[image], prompt:`p${i}`, timeoutMs:2000, maxFrames:8 }, env))));
-    expect(results).toEqual(["mock answer", "mock answer", "mock answer", "mock answer"]);
-  });
-});