@lage-run/hasher 1.3.0 → 1.3.1

package/CHANGELOG.json

@@ -2,7 +2,22 @@
   "name": "@lage-run/hasher",
   "entries": [
     {
-      "date": "Fri, 30 Aug 2024 18:39:54 GMT",
+      "date": "Wed, 04 Sep 2024 23:24:50 GMT",
+      "version": "1.3.1",
+      "tag": "@lage-run/hasher_v1.3.1",
+      "comments": {
+        "patch": [
+          {
+            "author": "kchau@microsoft.com",
+            "package": "@lage-run/hasher",
+            "commit": "cbfd60ade539086a6a797c0674e06f26cfc06af3",
+            "comment": "Use file hashes instead of just the file names for env glob for targets\\"
+          }
+        ]
+      }
+    },
+    {
+      "date": "Fri, 30 Aug 2024 18:40:09 GMT",
       "version": "1.3.0",
       "tag": "@lage-run/hasher_v1.3.0",
       "comments": {

package/CHANGELOG.md

@@ -1,12 +1,20 @@
 # Change Log - @lage-run/hasher
 
-This log was last generated on Fri, 30 Aug 2024 18:39:54 GMT and should not be manually modified.
+This log was last generated on Wed, 04 Sep 2024 23:24:50 GMT and should not be manually modified.
 
 <!-- Start content -->
 
+## 1.3.1
+
+Wed, 04 Sep 2024 23:24:50 GMT
+
+### Patches
+
+- Use file hashes instead of just the file names for env glob for targets\ (kchau@microsoft.com)
+
 ## 1.3.0
 
-Fri, 30 Aug 2024 18:39:54 GMT
+Fri, 30 Aug 2024 18:40:09 GMT
 
 ### Minor changes
 

package/lib/TargetHasher.js

@@ -190,7 +190,7 @@ class TargetHasher {
         const fileHashes = this.fileHasher.hash(files) ?? {}; // this list is sorted by file name
         // get target hashes
         const targetDepHashes = target.dependencies?.sort().map((targetDep)=>this.targetHashes[targetDep]);
-        const envGlobFiles = target.environmentGlob ? await this.getMemorizedEnvGlobResults(target.environmentGlob) : Object.values(this.globalInputsHash ?? {});
+        const envGlobFiles = Object.values(target.environmentGlob ? this.fileHasher.hash(await this.getMemorizedEnvGlobResults(target.environmentGlob)) : this.globalInputsHash ?? {});
         const combinedHashes = [
             // Environmental hashes
             ...envGlobFiles,

package/lib/__fixtures__/monorepo-with-global-files/some-global2.config.d.ts

@@ -1 +1 @@
-export const global: boolean;
+export const global2: boolean;

package/lib/__fixtures__/monorepo-with-global-files-different-tasks/some-global.config.d.ts

@@ -0,0 +1 @@
+export const global: boolean;

package/lib/__tests__/TargetHasher.test.js

@@ -4,6 +4,7 @@ Object.defineProperty(exports, "__esModule", {
 });
 const _path = /*#__PURE__*/ _interop_require_default(require("path"));
 const _index = require("../index");
+const _fs = /*#__PURE__*/ _interop_require_default(require("fs"));
 const _monorepofixture = require("@lage-run/monorepo-fixture");
 function _interop_require_default(obj) {
     return obj && obj.__esModule ? obj : {
@@ -152,4 +153,42 @@ describe("The main Hasher class", ()=>{
         expect(hash).not.toEqual(hash2);
         monorepo1.cleanup();
     });
+    it("creates different hashes when the target has a different env glob for different task types", async ()=>{
+        const monorepo1 = await setupFixture("monorepo-with-global-files-different-tasks");
+        const hasher = new _index.TargetHasher({
+            root: monorepo1.root,
+            environmentGlob: []
+        });
+        const target = createTarget(monorepo1.root, "package-a", "test");
+        target.environmentGlob = [
+            "some-global*"
+        ];
+        target.inputs = [
+            "**/*",
+            "^**/*"
+        ];
+        const hash = await getHash(hasher, target);
+        const target2 = createTarget(monorepo1.root, "package-a", "lint");
+        target2.environmentGlob = [
+            ".eslintrc.js"
+        ];
+        target2.inputs = [
+            "**/*",
+            "^**/*"
+        ];
+        const hash2 = await getHash(hasher, target2);
+        const target3 = createTarget(monorepo1.root, "package-a", "lint");
+        _fs.default.writeFileSync(_path.default.join(monorepo1.root, ".eslintrc.js"), "module.exports = {/*somethingdifferent*/};");
+        target3.environmentGlob = [
+            ".eslintrc.js"
+        ];
+        target3.inputs = [
+            "**/*",
+            "^**/*"
+        ];
+        const hash3 = await getHash(hasher, target3);
+        expect(hash).not.toEqual(hash2);
+        expect(hash2).not.toEqual(hash3);
+        monorepo1.cleanup();
+    });
 });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lage-run/hasher",
-  "version": "1.3.0",
+  "version": "1.3.1",
   "description": "Hasher for Lage Targets",
   "repository": {
     "url": "https://github.com/microsoft/lage"