@lad-sapienza/scms-core 0.1.0-alpha.5 → 0.1.0-alpha.7

package/README.md

@@ -51,6 +51,7 @@ import { DataTb, Map, Gallery } from '@lad-sapienza/scms-core';
 | `MapComponent` (`Map`) | Interactive map with MapLibre GL JS |
 | `Gallery` | Responsive image gallery with lightbox |
 | `TableOfContents` | Auto-generated TOC from headings |
+| `RedirectPage` | Static client-side redirect stub (meta-refresh + JS fallback) for static hosts |
 | `ZoteroGeoViewer` | Zotero library visualised on a map |
 | `RecordProvider`, `Field`, `Image`, `RecordFetcher`, `useRecordFetcher` | Build single-record detail pages against Directus |
 | `SearchUI`, `SearchUISimple`, `SearchUIAdvanced` | Field/operator/value search UI (used by `Map`'s `searchInFields`) |
@@ -63,7 +64,7 @@ import BSNavbar from '@lad-sapienza/scms-core/components/BSNavbar';
 import { directusLoader } from '@lad-sapienza/scms-core/integrations/directusLoader';
 ```
 
-See each component folder's own `README.md` (`components/DataTb`, `components/Gallery`, `components/ZoteroGeoViewer`, `components/`) for detailed API docs and examples.
+See each component folder's own `README.md` (`components/DataTb`, `components/Gallery`, `components/RedirectPage`, `components/ZoteroGeoViewer`, `components/`) for detailed API docs and examples.
 
 ## Creating a new site
 

package/components/Gallery/Gallery.astro

@@ -31,35 +31,11 @@ if (explicitImages && explicitImages.length > 0) {
 }
 ---
 
-{finalImages.length > 0 ? (
+{finalImages.length > 0 && (
   <GalleryClient
     images={finalImages}
     columns={columns}
     className={className}
     client:idle
   />
-) : (
-  <p class="gallery-empty">
-    No images found{name && <> for gallery "<code>{name}</code>"</>}.
-    {!name && !explicitImages && (
-      <> Add images to a <code>gallery/</code> folder next to this page.</>
-    )}
-  </p>
 )}
-
-<style>
-  .gallery-empty {
-    padding: 2rem;
-    background: #f5f5f5;
-    border-radius: 8px;
-    text-align: center;
-    color: #666;
-  }
-
-  .gallery-empty code {
-    background: #e0e0e0;
-    padding: 2px 6px;
-    border-radius: 3px;
-    font-family: monospace;
-  }
-</style>

package/components/Map/Map.tsx

@@ -1,4 +1,4 @@
-import { useState, useMemo, useEffect, useRef } from 'react';
+import { useState, useMemo, useEffect, useRef, useCallback } from 'react';
 import MapLibreMap, {
   NavigationControl,
   FullscreenControl,
@@ -310,20 +310,34 @@ export function Map({
   }, [allVectorLayers]);
 
   // Handle vector layer visibility toggle
-  const handleVectorLayerToggle = (layerId: string) => {
+  //
+  // Wrapped in useCallback (both here and below) so its identity stays
+  // stable across renders — it's one of two functions passed into the
+  // "add LayerControl as an IControl" effect's dependency array. Left as a
+  // plain function, it got a new reference on *every* render (including
+  // the one triggered by clicking a basemap radio, since that sets
+  // activeBaseLayer state on this very component), which spuriously
+  // refired that effect on every click. Each refire tore down the old
+  // IControl and created a fresh one — and since the cleanup removed
+  // whatever layerControlRef.current happened to point to *at cleanup
+  // time* rather than the specific instance being torn down, the freshly
+  // created (correct) control was the one actually getting removed a tick
+  // later, leaving the stale first control (still showing the original
+  // basemap selected) as the only one left on the map.
+  const handleVectorLayerToggle = useCallback((layerId: string) => {
     setVectorLayerVisibility(prev => ({
       ...prev,
       [layerId]: !prev[layerId]
     }));
-  };
+  }, []);
 
-  // Handle search for vector layers
-  const handleLayerSearch = (layerId: string, query: SearchQuery) => {
+  // Handle search for vector layers — see handleVectorLayerToggle above.
+  const handleLayerSearch = useCallback((layerId: string, query: SearchQuery) => {
     setLayerSearchQueries(prev => ({
       ...prev,
       [layerId]: query
     }));
-  };
+  }, []);
 
   // Load data for all vector layers
   useEffect(() => {
@@ -467,13 +481,14 @@ export function Map({
     map.addControl(control, position);
 
     return () => {
-      if (layerControlRef.current && map) {
-        setTimeout(() => {
-          if (layerControlRef.current && map) {
-            map.removeControl(layerControlRef.current);
-          }
-        }, 0);
-      }
+      // Remove this specific control instance, not whatever
+      // layerControlRef.current happens to point to when the timeout
+      // fires — if this effect ever refires before the timeout runs, the
+      // ref will already point at the *new* control, and reading it here
+      // would remove that one instead of this (correct) cleanup target.
+      setTimeout(() => {
+        map.removeControl(control);
+      }, 0);
     };
   }, [mapLoaded, layerControl, resolvedBaseLayers, allVectorLayers.length, handleLayerSearch]);
 

package/components/RedirectPage/README.md

@@ -0,0 +1,119 @@
+# RedirectPage Component
+
+A static, client-side redirect stub for static hosts (GitHub Pages, S3, any
+CDN without server-side redirect support). Renders a page that redirects via
+`<meta http-equiv="refresh">`, a `<link rel="canonical">` for search engines,
+and a `window.location.replace()` fallback for browsers that ignore
+meta-refresh.
+
+## When to use this vs. Astro's native `redirects`
+
+Astro's [`redirects`](https://docs.astro.build/en/reference/configuration-reference/#redirects)
+config option generates the same kind of stub automatically for `output:
+'static'` sites, and should be preferred whenever it applies — it's zero
+extra code. Reach for `RedirectPage` only when `redirects` can't express the
+mapping.
+
+**Works fine with native `redirects`:** a static source path redirecting to
+a destination produced by a dynamic route, as long as the destination is
+given as a concrete, already-resolved path (not a bracketed route pattern).
+Astro only validates dynamic-parameter propagation when the *source* path
+itself has dynamic segments — a static source skips that check entirely.
+Confirmed empirically against Astro 7.2.4 (`output: 'static'`): a source
+route with no params, e.g. `/chi-siamo`, redirecting to `/it/chi-siamo`
+(itself generated by a `src/pages/[locale]/chi-siamo.astro` with
+`getStaticPaths`), builds and emits the expected redirect stub with no
+errors.
+
+```js
+// astro.config.mjs
+export default defineConfig({
+  redirects: {
+    '/chi-siamo': '/it/chi-siamo',
+    '/notizie': '/it/notizie',
+  },
+});
+```
+
+**Needs `RedirectPage` instead:** the source path itself is dynamic — e.g.
+one redirect per old article slug, `/notizie/<slug>` → `/it/notizie/<slug>`
+— *and* the destination route has a dynamic parameter the source doesn't
+carry (typically a locale prefix). Astro requires the destination's dynamic
+parameters to already be present in the source; `[locale]` isn't, since the
+old flat URL had no locale segment. Trying to force it fails at build time:
+
+```js
+redirects: {
+  '/notizie/[...slug]': '/it/notizie/[...slug]', // does NOT match the
+  // registered `/[locale]/notizie/[...slug]` route — this throws
+  // InvalidRedirectDestination: "The destination ... does not match any
+  // existing route in your project."
+}
+```
+
+There's no config-level way to say "always substitute `it` for `[locale]`
+here" — the list of old slugs to redirect, and the mapping to each new URL,
+has to come from actual code that knows about the content collection. That's
+what the recipe below does.
+
+## Basic usage — single static redirect
+
+For a handful of one-off redirects where you'd rather not touch
+`astro.config.mjs` (or where the source **is** dynamic but happens not to
+need a config-level `redirects` entry), drop a page using `RedirectPage`
+directly:
+
+```astro
+---
+// src/pages/chi-siamo.astro
+import { RedirectPage } from '@lad-sapienza/scms-core';
+export const prerender = true;
+---
+<RedirectPage target="/it/chi-siamo" />
+```
+
+## Recipe — redirecting every entry of a content collection
+
+The common case: a collection is moving from a flat URL (`/notizie/<slug>/`)
+to a locale-prefixed one (`/it/notizie/<slug>/`), and every existing entry
+needs its own redirect stub. Generate one page per old slug with
+`getStaticPaths`, reading the slug list straight from the collection so the
+redirect list can never drift out of sync with the content itself:
+
+```astro
+---
+// src/pages/notizie/[...slug].astro
+import { RedirectPage } from '@lad-sapienza/scms-core';
+import { getCollection } from 'astro:content';
+
+export const prerender = true;
+
+export async function getStaticPaths() {
+  const articles = await getCollection('notizie');
+  // Adapt this to however your entry IDs encode locale/slug — e.g. if
+  // content lives under src/content/notizie/it/<slug>/, split the id
+  // yourself and keep only the default-locale entries (each locale has the
+  // same slug, so the redirect only needs to be generated once).
+  return articles
+    .filter((a) => a.id.startsWith('it/'))
+    .map((a) => ({ params: { slug: a.id.slice('it/'.length) } }));
+}
+
+const { slug } = Astro.params;
+---
+<RedirectPage target={`/it/notizie/${slug}/`} />
+```
+
+Repeat one such `[...slug].astro` per collection that needs migrating
+(`blog`, `ricerca`, `didattica`, ...) — the body only changes in the
+collection name and the target prefix. A collection's own `index.astro`
+(the old flat listing page) is a single static redirect and can either use
+this same component directly or, per the section above, a plain
+`redirects` config entry.
+
+## Props
+
+| Prop | Type | Default | Description |
+|---|---|---|---|
+| `target` | `string` | — | Destination URL to redirect to (required) |
+| `title` | `string` | `"Redirecting…"` | Page `<title>`, shown briefly before the redirect fires |

package/components/RedirectPage/RedirectPage.astro

@@ -0,0 +1,34 @@
+---
+/**
+ * Static client-side redirect stub (meta-refresh + JS), for static hosts
+ * where server-side redirects aren't available (e.g. GitHub Pages). Render
+ * one of these at each old URL to send visitors/search engines/citations to
+ * a new location — typically after a URL scheme change (e.g. adding an
+ * i18n locale prefix) that Astro's own config-level `redirects` can't
+ * express. See `components/RedirectPage/README.md` for when to reach for
+ * this instead of `redirects`, and for the `getStaticPaths` recipe that
+ * generates one of these per entry of a content collection.
+ */
+interface Props {
+  /** Destination URL to redirect to */
+  target: string
+  /** Page title shown briefly before the redirect fires */
+  title?: string
+}
+const { target, title = "Redirecting…" } = Astro.props
+---
+<!doctype html>
+<html lang="en">
+  <head>
+    <meta charset="UTF-8" />
+    <meta http-equiv="refresh" content={`0; url=${target}`} />
+    <link rel="canonical" href={target} />
+    <title>{title}</title>
+  </head>
+  <body>
+    <p>Redirecting to <a href={target}>{target}</a>…</p>
+    <script is:inline define:vars={{ target }}>
+      window.location.replace(target);
+    </script>
+  </body>
+</html>

package/index.ts

@@ -1,6 +1,7 @@
 // Core package exports
 export { Gallery } from './components/Gallery';
 export { default as TableOfContents } from './components/TableOfContents/TableOfContents.astro';
+export { default as RedirectPage } from './components/RedirectPage/RedirectPage.astro';
 export { default as ThemeToggle } from './components/ThemeToggle';
 
 // DataTb (recommended table component)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lad-sapienza/scms-core",
-  "version": "0.1.0-alpha.5",
+  "version": "0.1.0-alpha.7",
   "description": "Framework components and Astro integrations for s:CMS — DataTb, Gallery, Map, ZoteroGeoViewer, Record.",
   "type": "module",
   "license": "BSD-0-Clause",