@labdigital/commercetools-mock 3.0.0-beta.3 → 3.0.0-beta.4

package/dist/storage/sqlite.d.mts

@@ -1,4 +1,4 @@
-import { a as QueryParams, c as ResourceType, n as AbstractStorage, o as PagedQueryResponseMap, r as GetParams, s as ResourceMap } from "../config-BGZiZhn4.mjs";
+import { a as QueryParams, c as ResourceType, n as AbstractStorage, o as PagedQueryResponseMap, r as GetParams, s as ResourceMap } from "../config-CN3DgmWu.mjs";
 import { CustomObject, Project } from "@commercetools/platform-sdk";
 
 //#region src/storage/sqlite.d.ts

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@labdigital/commercetools-mock",
-  "version": "3.0.0-beta.3",
+  "version": "3.0.0-beta.4",
   "license": "MIT",
   "author": "Michael van Tellingen",
   "type": "module",

package/src/lib/tax.test.ts

@@ -5,6 +5,7 @@ import type {
 } from "@commercetools/platform-sdk";
 import { describe, expect, test } from "vitest";
 import {
+	buildTaxedPriceFromExternalAmount,
 	calculateTaxedPrice,
 	calculateTaxedPriceFromRate,
 	calculateTaxTotals,
@@ -85,6 +86,58 @@ describe("tax helpers", () => {
 		expect(taxed.totalTax?.centAmount).toBe(250);
 	});
 
+	test("calculateTaxedPriceFromRate respects HalfEven rounding (banker's)", () => {
+		const rate: TaxRate = {
+			amount: 0.05,
+			includedInPrice: false,
+			name: "5%",
+			country: "NL",
+			id: "rate",
+			subRates: [],
+		};
+
+		// 250 * 0.05 = 12.5 — HalfEven rounds to 12 (toward even)
+		const halfEven = calculateTaxedPriceFromRate(250, "EUR", rate, "HalfEven")!;
+		expect(halfEven.totalTax?.centAmount).toBe(12);
+		expect(halfEven.totalGross.centAmount).toBe(262);
+
+		// HalfUp rounds 12.5 → 13
+		const halfUp = calculateTaxedPriceFromRate(250, "EUR", rate, "HalfUp")!;
+		expect(halfUp.totalTax?.centAmount).toBe(13);
+		expect(halfUp.totalGross.centAmount).toBe(263);
+
+		// HalfDown rounds 12.5 → 12
+		const halfDown = calculateTaxedPriceFromRate(250, "EUR", rate, "HalfDown")!;
+		expect(halfDown.totalTax?.centAmount).toBe(12);
+		expect(halfDown.totalGross.centAmount).toBe(262);
+	});
+
+	test("buildTaxedPriceFromExternalAmount respects rounding mode", () => {
+		const draft = {
+			totalGross: {
+				type: "centPrecision" as const,
+				currencyCode: "EUR",
+				centAmount: 525,
+				fractionDigits: 2,
+			},
+			taxRate: {
+				name: "5%",
+				amount: 0.05,
+				country: "NL",
+				includedInPrice: true,
+			},
+		};
+
+		// 525 * 0.05 / 1.05 = 25.0 — exact, no rounding ambiguity
+		// Use a case with .5 ambiguity: 315 * 0.05 / 1.05 = 15.0 — also exact
+		// 105 * 0.05 / 1.05 = 5.0
+		// Pick 11 * 0.5 / 1.5 = 3.666... not clean. Use 525 to confirm baseline
+		const halfEven = buildTaxedPriceFromExternalAmount(draft, "HalfEven");
+		expect(halfEven.totalGross.centAmount).toBe(525);
+		expect(halfEven.totalTax?.centAmount).toBe(25);
+		expect(halfEven.totalNet.centAmount).toBe(500);
+	});
+
 	test("calculateTaxedPrice selects matching tax rate from category", () => {
 		const taxCategory: TaxCategory = {
 			id: "tax-cat",

package/src/lib/tax.ts

@@ -1,12 +1,82 @@
 import type {
 	Cart,
+	ExternalTaxAmountDraft,
+	ExternalTaxRateDraft,
+	RoundingMode,
 	TaxCategory,
 	TaxedItemPrice,
 	TaxedPrice,
 	TaxPortion,
 	TaxRate,
 } from "@commercetools/platform-sdk";
-import { createCentPrecisionMoney } from "#src/repositories/helpers.ts";
+import { Decimal } from "decimal.js";
+import {
+	createCentPrecisionMoney,
+	roundDecimal,
+} from "#src/repositories/helpers.ts";
+
+const roundCents = (value: number, mode: RoundingMode = "HalfEven"): number =>
+	roundDecimal(new Decimal(value), mode).toNumber();
+
+export const buildTaxedPriceFromExternalAmount = (
+	draft: ExternalTaxAmountDraft,
+	roundingMode: RoundingMode = "HalfEven",
+): TaxedItemPrice => {
+	const taxRate = taxRateFromExternalDraft(draft.taxRate);
+	const totalGross = createCentPrecisionMoney(draft.totalGross);
+	const currencyCode = totalGross.currencyCode;
+	const toMoney = (centAmount: number) =>
+		createCentPrecisionMoney({ currencyCode, centAmount });
+
+	const grossAmount = totalGross.centAmount;
+	// totalGross is authoritative in ExternalAmount mode, so net is always
+	// gross / (1 + rate) regardless of taxRate.includedInPrice. The flag is kept
+	// on the stored taxRate for callers that read it back.
+	const taxAmount =
+		taxRate.amount > 0
+			? roundCents(
+					new Decimal(grossAmount)
+						.mul(taxRate.amount)
+						.div(1 + taxRate.amount)
+						.toNumber(),
+					roundingMode,
+				)
+			: 0;
+	const netAmount = grossAmount - taxAmount;
+
+	return {
+		totalNet: toMoney(netAmount),
+		totalGross,
+		totalTax: taxAmount > 0 ? toMoney(taxAmount) : undefined,
+		taxPortions:
+			taxAmount > 0
+				? [
+						{
+							rate: taxRate.amount,
+							name: taxRate.name,
+							amount: toMoney(taxAmount),
+						},
+					]
+				: [],
+	};
+};
+
+export const taxRateFromExternalDraft = (
+	draft: ExternalTaxRateDraft,
+): TaxRate => {
+	const amount =
+		draft.amount ??
+		draft.subRates?.reduce((acc, subRate) => acc + subRate.amount, 0) ??
+		0;
+	return {
+		name: draft.name,
+		amount,
+		includedInPrice: draft.includedInPrice ?? false,
+		country: draft.country,
+		state: draft.state,
+		subRates: draft.subRates,
+	};
+};
 
 type TaxableResource = Pick<
 	Cart,
@@ -101,10 +171,11 @@ export const calculateTaxTotals = (
 	};
 };
 
-export const buildTaxedPriceFromRate = (
+export const calculateTaxedPriceFromRate = (
 	amount: number,
 	currencyCode: string,
 	taxRate?: TaxRate,
+	roundingMode: RoundingMode = "HalfEven",
 ): TaxedItemPrice | undefined => {
 	if (!taxRate) {
 		return undefined;
@@ -123,13 +194,20 @@ export const buildTaxedPriceFromRate = (
 
 	if (taxRate.includedInPrice) {
 		grossAmount = amount;
-		taxAmount = Math.round(
-			(grossAmount * taxRate.amount) / (1 + taxRate.amount),
+		taxAmount = roundCents(
+			new Decimal(grossAmount)
+				.mul(taxRate.amount)
+				.div(1 + taxRate.amount)
+				.toNumber(),
+			roundingMode,
 		);
 		netAmount = grossAmount - taxAmount;
 	} else {
 		netAmount = amount;
-		taxAmount = Math.round(netAmount * taxRate.amount);
+		taxAmount = roundCents(
+			new Decimal(netAmount).mul(taxRate.amount).toNumber(),
+			roundingMode,
+		);
 		grossAmount = netAmount + taxAmount;
 	}
 
@@ -150,18 +228,12 @@ export const buildTaxedPriceFromRate = (
 	};
 };
 
-export const calculateTaxedPriceFromRate = (
-	amount: number,
-	currencyCode: string,
-	taxRate?: TaxRate,
-): TaxedItemPrice | undefined =>
-	buildTaxedPriceFromRate(amount, currencyCode, taxRate);
-
 export const calculateTaxedPrice = (
 	amount: number,
 	taxCategory: TaxCategory | undefined,
 	currency: string,
 	country: string | undefined,
+	roundingMode: RoundingMode = "HalfEven",
 ): TaxedPrice | undefined => {
 	if (!taxCategory || !taxCategory.rates.length) {
 		return undefined;
@@ -172,7 +244,12 @@ export const calculateTaxedPrice = (
 			(rate) => !rate.country || rate.country === country,
 		) || taxCategory.rates[0];
 
-	const taxedItemPrice = buildTaxedPriceFromRate(amount, currency, taxRate);
+	const taxedItemPrice = calculateTaxedPriceFromRate(
+		amount,
+		currency,
+		taxRate,
+		roundingMode,
+	);
 	if (!taxedItemPrice) {
 		return undefined;
 	}