@labdigital/commercetools-mock 2.66.0 → 3.0.0-beta.0

package/src/product-projection-search.ts

@@ -2,6 +2,7 @@ import type {
 	FacetResults,
 	FilteredFacetResult,
 	InvalidInputError,
+	InvalidOperationError,
 	Product,
 	ProductProjection,
 	ProductProjectionPagedSearchResponse,
@@ -59,19 +60,22 @@ export class ProductProjectionSearch {
 		this._reviewStatisticsService = new ReviewStatisticsService(config.storage);
 	}
 
-	search(
+	async search(
 		projectKey: string,
 		params: ProductProjectionSearchParams,
-	): ProductProjectionPagedSearchResponse {
-		let resources = this._storage
-			.all(projectKey, "product")
-			.map((r) => this.transform(r, params.staged ?? false, projectKey))
-			.filter((p) => {
-				if (!(params.staged ?? false)) {
-					return p.published;
-				}
-				return true;
-			});
+	): Promise<ProductProjectionPagedSearchResponse> {
+		const allProducts = await this._storage.all(projectKey, "product");
+		let resources = await Promise.all(
+			allProducts.map((r) =>
+				this.transform(r, params.staged ?? false, projectKey),
+			),
+		);
+		resources = resources.filter((p) => {
+			if (!(params.staged ?? false)) {
+				return p.published;
+			}
+			return true;
+		});
 
 		const markMatchingVariant = params.markMatchingVariants ?? false;
 
@@ -126,8 +130,10 @@ export class ProductProjectionSearch {
 
 		// Expand the resources
 		if (params.expand !== undefined) {
-			resources = resources.map((resource) =>
-				this._storage.expand(projectKey, resource, params.expand),
+			resources = await Promise.all(
+				resources.map((resource) =>
+					this._storage.expand(projectKey, resource, params.expand),
+				),
 			);
 		}
 
@@ -140,8 +146,8 @@ export class ProductProjectionSearch {
 		const results = resources.slice(offset, offset + limit);
 
 		return {
-			count: totalResults,
-			total: results.length,
+			count: results.length,
+			total: totalResults,
 			offset: offset,
 			limit: limit,
 			results: results,
@@ -149,18 +155,18 @@ export class ProductProjectionSearch {
 		};
 	}
 
-	transform(
+	async transform(
 		product: Product,
 		staged: boolean,
 		projectKey: string,
-	): ProductProjection {
+	): Promise<ProductProjection> {
 		const obj = !staged
 			? product.masterData.current
 			: product.masterData.staged;
 
 		// Calculate review statistics for this product
 		const reviewRatingStatistics =
-			this._reviewStatisticsService.calculateProductReviewStatistics(
+			await this._reviewStatisticsService.calculateProductReviewStatistics(
 				projectKey,
 				product.id,
 			);
@@ -311,7 +317,13 @@ export class ProductProjectionSearch {
 				}
 			}
 		} else {
-			throw new Error("not supported");
+			throw new CommercetoolsError<InvalidOperationError>(
+				{
+					code: "InvalidOperation",
+					message: "not supported",
+				},
+				400,
+			);
 		}
 
 		return {
@@ -358,7 +370,13 @@ export class ProductProjectionSearch {
 						mean: numValues > 0 ? mean(values) : 0,
 					};
 				}
-				throw new Error("not supported");
+				throw new CommercetoolsError<InvalidOperationError>(
+					{
+						code: "InvalidOperation",
+						message: "not supported",
+					},
+					400,
+				);
 			}) || [];
 		const data: RangeFacetResult = {
 			type: "range",

package/src/product-search-availability.test.ts

@@ -1,11 +1,12 @@
 import type {
-	InventoryEntryDraft,
-	ProductDraft,
 	ProductPagedSearchResponse,
 	ProductSearchRequest,
 } from "@commercetools/platform-sdk";
-import supertest from "supertest";
 import { afterEach, beforeEach, describe, expect, test } from "vitest";
+import { channelDraftFactory } from "#src/testing/channel.ts";
+import { inventoryEntryDraftFactory } from "#src/testing/inventory-entry.ts";
+import { productDraftFactory } from "#src/testing/product.ts";
+import { productTypeDraftFactory } from "#src/testing/product-type.ts";
 import { CommercetoolsMock } from "./index.ts";
 
 describe("Product Search - Availability Filtering", () => {
@@ -13,25 +14,13 @@ describe("Product Search - Availability Filtering", () => {
 	let productId: string;
 
 	beforeEach(async () => {
-		// Create a product type first
-		const productTypeDraft = {
-			name: "Test Product Type",
-			key: "test-type",
-			description: "Test Product Type",
-		};
-
-		await supertest(ctMock.app)
-			.post("/dummy/product-types")
-			.send(productTypeDraft);
+		const productType = await productTypeDraftFactory(ctMock).create();
 
-		// Create a test product
-		const productDraft: ProductDraft = {
-			name: { "en-US": "Test Product" },
+		const product = await productDraftFactory(ctMock).create({
 			productType: {
 				typeId: "product-type",
-				key: "test-type",
+				id: productType.id,
 			},
-			slug: { "en-US": "test-product" },
 			masterVariant: {
 				sku: "TEST-SKU-001",
 			},
@@ -40,25 +29,23 @@ describe("Product Search - Availability Filtering", () => {
 					sku: "TEST-SKU-002",
 				},
 			],
-		};
-
-		const productResponse = await supertest(ctMock.app)
-			.post("/dummy/products")
-			.send(productDraft);
+		});
 
-		productId = productResponse.body.id;
+		productId = product.id;
 
 		// Publish the product
-		await supertest(ctMock.app)
-			.post(`/dummy/products/${productId}`)
-			.send({
-				version: productResponse.body.version,
+		await ctMock.app.inject({
+			method: "POST",
+			url: `/dummy/products/${productId}`,
+			payload: {
+				version: product.version,
 				actions: [{ action: "publish" }],
-			});
+			},
+		});
 	});
 
-	afterEach(() => {
-		ctMock.clear();
+	afterEach(async () => {
+		await ctMock.clear();
 	});
 
 	async function createInventoryEntry(
@@ -66,7 +53,7 @@ describe("Product Search - Availability Filtering", () => {
 		quantityOnStock: number,
 		channelId?: string,
 	) {
-		const inventoryEntry: InventoryEntryDraft = {
+		await inventoryEntryDraftFactory(ctMock).create({
 			sku,
 			quantityOnStock,
 			...(channelId && {
@@ -75,9 +62,7 @@ describe("Product Search - Availability Filtering", () => {
 					id: channelId,
 				},
 			}),
-		};
-
-		await supertest(ctMock.app).post("/dummy/inventory").send(inventoryEntry);
+		});
 	}
 
 	async function searchProducts(
@@ -90,15 +75,16 @@ describe("Product Search - Availability Filtering", () => {
 			},
 		};
 
-		const response = await supertest(ctMock.app)
-			.post("/dummy/products/search")
-			.send(searchRequest);
+		const response = await ctMock.app.inject({
+			method: "POST",
+			url: "/dummy/products/search",
+			payload: searchRequest,
+		});
 
-		return response.body;
+		return response.json();
 	}
 
 	test("should filter products by variants.availability.isOnStock = true", async () => {
-		// Create inventory with stock for one variant
 		await createInventoryEntry("TEST-SKU-001", 10);
 
 		const result = await searchProducts({
@@ -116,7 +102,6 @@ describe("Product Search - Availability Filtering", () => {
 	});
 
 	test("should filter products by variants.availability.isOnStock = false", async () => {
-		// Create inventory with zero stock
 		await createInventoryEntry("TEST-SKU-001", 0);
 
 		const result = await searchProducts({
@@ -126,7 +111,6 @@ describe("Product Search - Availability Filtering", () => {
 			},
 		});
 
-		// Should find the product because it's not on stock
 		expect(result.results).toHaveLength(1);
 		expect(
 			result.results[0].productProjection?.masterVariant?.availability
@@ -135,9 +119,9 @@ describe("Product Search - Availability Filtering", () => {
 	});
 
 	test("should filter products by variants.availability.isOnStockForChannel", async () => {
-		const channelId = "test-channel-1";
+		const channel = await channelDraftFactory(ctMock).create();
+		const channelId = channel.id;
 
-		// Create inventory for specific channel
 		await createInventoryEntry("TEST-SKU-001", 5, channelId);
 
 		const result = await searchProducts({
@@ -155,10 +139,10 @@ describe("Product Search - Availability Filtering", () => {
 	});
 
 	test("should not find products when filtering by non-matching channel", async () => {
-		const channelId = "test-channel-1";
-		const otherChannelId = "test-channel-2";
+		const channel = await channelDraftFactory(ctMock).create();
+		const channelId = channel.id;
+		const otherChannelId = "non-existent-channel-id";
 
-		// Create inventory for specific channel
 		await createInventoryEntry("TEST-SKU-001", 5, channelId);
 
 		const result = await searchProducts({
@@ -172,8 +156,6 @@ describe("Product Search - Availability Filtering", () => {
 	});
 
 	test("should handle products without inventory entries", async () => {
-		// Don't create any inventory entries
-
 		const result = await searchProducts({
 			exact: {
 				field: "variants.availability.isOnStock",
@@ -181,7 +163,6 @@ describe("Product Search - Availability Filtering", () => {
 			},
 		});
 
-		// Should find the product because it has no stock
 		expect(result.results).toHaveLength(1);
 		expect(
 			result.results[0].productProjection?.masterVariant?.availability
@@ -190,7 +171,6 @@ describe("Product Search - Availability Filtering", () => {
 	});
 
 	test("should work with OR queries for availability", async () => {
-		// Create inventory with stock
 		await createInventoryEntry("TEST-SKU-001", 10);
 
 		const result = await searchProducts({
@@ -210,7 +190,6 @@ describe("Product Search - Availability Filtering", () => {
 			],
 		});
 
-		// Should find the product regardless of stock status
 		expect(result.results).toHaveLength(1);
 	});
 

package/src/product-search.ts

@@ -1,5 +1,6 @@
 import type {
 	InvalidInputError,
+	InventoryEntry,
 	Product,
 	ProductPagedSearchResponse,
 	ProductProjection,
@@ -26,13 +27,19 @@ export class ProductSearch {
 		this._storage = config.storage;
 	}
 
-	search(
+	async search(
 		projectKey: string,
 		params: ProductSearchRequest,
-	): ProductPagedSearchResponse {
-		const availabilityBySku = this._storage
-			.all(projectKey, "inventory-entry")
-			.reduce((acc, entry) => {
+	): Promise<ProductPagedSearchResponse> {
+		const inventoryEntries = await this._storage.all(
+			projectKey,
+			"inventory-entry",
+		);
+		const availabilityBySku = inventoryEntries.reduce(
+			(
+				acc: Map<string, ProductSearchVariantAvailability>,
+				entry: InventoryEntry,
+			) => {
 				const existingEntry = acc.get(entry.sku);
 
 				acc.set(entry.sku, {
@@ -46,18 +53,20 @@ export class ProductSearch {
 				});
 
 				return acc;
-			}, new Map<string, ProductSearchVariantAvailability>());
+			},
+			new Map<string, ProductSearchVariantAvailability>(),
+		);
 
-		let productResources = this._storage
-			.all(projectKey, "product")
-			.map((r) =>
+		const allProducts = await this._storage.all(projectKey, "product");
+		let productResources = allProducts
+			.map((r: Product) =>
 				this.transformProduct(
 					r,
 					params.productProjectionParameters?.staged ?? false,
 					availabilityBySku,
 				),
 			)
-			.filter((p) => {
+			.filter((p: ProductProjection) => {
 				if (!(params.productProjectionParameters?.staged ?? false)) {
 					return p.published;
 				}

package/src/projectAPI.ts

@@ -21,25 +21,13 @@ export class ProjectAPI {
 		this._repositories = repositories;
 	}
 
-	add<T extends keyof RepositoryMap & keyof ResourceMap>(
-		typeId: T,
-		resource: ResourceMap[T],
-	) {
-		process.emitWarning(
-			"ctMock.add() is deprecated, create resources via regular create endpoints " +
-				"or if you are really sure, use unsafeAdd() (but be aware of potential state issues)",
-			"DeprecationWarning",
-		);
-		this.unsafeAdd(typeId, resource);
-	}
-
-	unsafeAdd<T extends keyof RepositoryMap & keyof ResourceMap>(
+	async unsafeAdd<T extends keyof RepositoryMap & keyof ResourceMap>(
 		typeId: T,
 		resource: ResourceMap[T],
 	) {
 		const repository = this._repositories[typeId];
 		if (repository) {
-			this._storage.add(this.projectKey, typeId, {
+			await this._storage.add(this.projectKey, typeId, {
 				...getBaseResourceProperties(),
 				...resource,
 			});
@@ -48,17 +36,13 @@ export class ProjectAPI {
 		}
 	}
 
-	get<RT extends ResourceType>(
+	async get<RT extends ResourceType>(
 		typeId: RT,
 		id: string,
 		params?: GetParams,
-	): ResourceMap[RT] {
-		return this._storage.get(
-			this.projectKey,
-			typeId,
-			id,
-			params,
-		) as ResourceMap[RT];
+	): Promise<ResourceMap[RT]> {
+		const result = await this._storage.get(this.projectKey, typeId, id, params);
+		return result as ResourceMap[RT];
 	}
 
 	// TODO: Not sure if we want to expose this...