@labdigital/commercetools-mock 2.65.1 → 3.0.0-beta.0

package/src/lib/product-review-statistics.test.ts

@@ -1,7 +1,9 @@
 import type { Product } from "@commercetools/platform-sdk";
-import supertest from "supertest";
 import { beforeEach, describe, expect, test } from "vitest";
 import { CommercetoolsMock } from "#src/index.ts";
+import { productDraftFactory } from "#src/testing/product.ts";
+import { productTypeDraftFactory } from "#src/testing/product-type.ts";
+import { reviewDraftFactory } from "#src/testing/review.ts";
 
 describe("Product Review Statistics", () => {
 	let ctMock: CommercetoolsMock;
@@ -10,335 +12,296 @@ describe("Product Review Statistics", () => {
 	beforeEach(async () => {
 		ctMock = new CommercetoolsMock();
 
-		// Create a product
-		const productResponse = await supertest(ctMock.app)
-			.post("/dummy/products")
-			.send({
-				name: { en: "Test Product" },
-				slug: { en: "test-product" },
-				productType: {
-					typeId: "product-type",
-					key: "dummy-product-type",
-				},
-				masterVariant: {
-					sku: "test-sku-1",
-					prices: [
-						{
-							value: {
-								currencyCode: "EUR",
-								centAmount: 1000,
-							},
+		const productType = await productTypeDraftFactory(ctMock).create();
+
+		product = await productDraftFactory(ctMock).create({
+			productType: {
+				typeId: "product-type",
+				id: productType.id,
+			},
+			masterVariant: {
+				sku: "test-sku-1",
+				prices: [
+					{
+						value: {
+							currencyCode: "EUR",
+							centAmount: 1000,
 						},
-					],
-				},
-			});
-		expect(productResponse.status).toBe(201);
-		product = productResponse.body;
+					},
+				],
+			},
+		});
 	});
 
 	test("product has no review statistics when no reviews exist", async () => {
-		const response = await supertest(ctMock.app).get(
-			`/dummy/products/${product.id}`,
-		);
+		const response = await ctMock.app.inject({
+			method: "GET",
+			url: `/dummy/products/${product.id}`,
+		});
 
-		expect(response.status).toBe(200);
-		expect(response.body.reviewRatingStatistics).toBeUndefined();
+		expect(response.statusCode).toBe(200);
+		expect(response.json().reviewRatingStatistics).toBeUndefined();
 	});
 
 	test("product has review statistics when reviews exist", async () => {
-		// Create reviews for the product
-		await supertest(ctMock.app)
-			.post("/dummy/reviews")
-			.send({
-				authorName: "John Doe",
-				title: "Great product!",
-				text: "I really love this product.",
-				rating: 5,
-				target: {
-					typeId: "product",
-					id: product.id,
-				},
-			});
-
-		await supertest(ctMock.app)
-			.post("/dummy/reviews")
-			.send({
-				authorName: "Jane Smith",
-				title: "Good product",
-				text: "Pretty good overall.",
-				rating: 4,
-				target: {
-					typeId: "product",
-					id: product.id,
-				},
-			});
-
-		await supertest(ctMock.app)
-			.post("/dummy/reviews")
-			.send({
-				authorName: "Bob Wilson",
-				title: "Excellent!",
-				text: "Amazing quality.",
-				rating: 5,
-				target: {
-					typeId: "product",
-					id: product.id,
-				},
-			});
-
-		const response = await supertest(ctMock.app).get(
-			`/dummy/products/${product.id}`,
-		);
-
-		expect(response.status).toBe(200);
-		expect(response.body.reviewRatingStatistics).toBeDefined();
-		expect(response.body.reviewRatingStatistics.count).toBe(3);
-		expect(response.body.reviewRatingStatistics.averageRating).toBe(4.66667);
-		expect(response.body.reviewRatingStatistics.highestRating).toBe(5);
-		expect(response.body.reviewRatingStatistics.lowestRating).toBe(4);
-		expect(response.body.reviewRatingStatistics.ratingsDistribution).toEqual({
+		await reviewDraftFactory(ctMock).create({
+			authorName: "John Doe",
+			title: "Great product!",
+			text: "I really love this product.",
+			rating: 5,
+			target: {
+				typeId: "product",
+				id: product.id,
+			},
+		});
+
+		await reviewDraftFactory(ctMock).create({
+			authorName: "Jane Smith",
+			title: "Good product",
+			text: "Pretty good overall.",
+			rating: 4,
+			target: {
+				typeId: "product",
+				id: product.id,
+			},
+		});
+
+		await reviewDraftFactory(ctMock).create({
+			authorName: "Bob Wilson",
+			title: "Excellent!",
+			text: "Amazing quality.",
+			rating: 5,
+			target: {
+				typeId: "product",
+				id: product.id,
+			},
+		});
+
+		const response = await ctMock.app.inject({
+			method: "GET",
+			url: `/dummy/products/${product.id}`,
+		});
+
+		expect(response.statusCode).toBe(200);
+		const body = response.json();
+		expect(body.reviewRatingStatistics).toBeDefined();
+		expect(body.reviewRatingStatistics.count).toBe(3);
+		expect(body.reviewRatingStatistics.averageRating).toBe(4.66667);
+		expect(body.reviewRatingStatistics.highestRating).toBe(5);
+		expect(body.reviewRatingStatistics.lowestRating).toBe(4);
+		expect(body.reviewRatingStatistics.ratingsDistribution).toEqual({
 			"4": 1,
 			"5": 2,
 		});
 	});
 
 	test("product projection has review statistics", async () => {
-		// Create a review for the product
-		await supertest(ctMock.app)
-			.post("/dummy/reviews")
-			.send({
-				authorName: "Test User",
-				title: "Test Review",
-				text: "Test review text.",
-				rating: 3,
-				target: {
-					typeId: "product",
-					id: product.id,
-				},
-			});
-
-		const response = await supertest(ctMock.app).get(
-			`/dummy/product-projections/${product.id}`,
-		);
-
-		expect(response.status).toBe(200);
-		expect(response.body.reviewRatingStatistics).toBeDefined();
-		expect(response.body.reviewRatingStatistics.count).toBe(1);
-		expect(response.body.reviewRatingStatistics.averageRating).toBe(3);
-		expect(response.body.reviewRatingStatistics.highestRating).toBe(3);
-		expect(response.body.reviewRatingStatistics.lowestRating).toBe(3);
-		expect(response.body.reviewRatingStatistics.ratingsDistribution).toEqual({
+		await reviewDraftFactory(ctMock).create({
+			authorName: "Test User",
+			title: "Test Review",
+			text: "Test review text.",
+			rating: 3,
+			target: {
+				typeId: "product",
+				id: product.id,
+			},
+		});
+
+		const response = await ctMock.app.inject({
+			method: "GET",
+			url: `/dummy/product-projections/${product.id}`,
+		});
+
+		expect(response.statusCode).toBe(200);
+		const body = response.json();
+		expect(body.reviewRatingStatistics).toBeDefined();
+		expect(body.reviewRatingStatistics.count).toBe(1);
+		expect(body.reviewRatingStatistics.averageRating).toBe(3);
+		expect(body.reviewRatingStatistics.highestRating).toBe(3);
+		expect(body.reviewRatingStatistics.lowestRating).toBe(3);
+		expect(body.reviewRatingStatistics.ratingsDistribution).toEqual({
 			"3": 1,
 		});
 	});
 
 	test("product query includes review statistics", async () => {
-		// Create reviews for the product
-		await supertest(ctMock.app)
-			.post("/dummy/reviews")
-			.send({
-				authorName: "Reviewer 1",
-				rating: 2,
-				target: {
-					typeId: "product",
-					id: product.id,
-				},
-			});
-
-		await supertest(ctMock.app)
-			.post("/dummy/reviews")
-			.send({
-				authorName: "Reviewer 2",
-				rating: 4,
-				target: {
-					typeId: "product",
-					id: product.id,
-				},
-			});
-
-		const response = await supertest(ctMock.app).get("/dummy/products");
-
-		expect(response.status).toBe(200);
-		expect(response.body.results).toHaveLength(1);
-		expect(response.body.results[0].reviewRatingStatistics).toBeDefined();
-		expect(response.body.results[0].reviewRatingStatistics.count).toBe(2);
-		expect(response.body.results[0].reviewRatingStatistics.averageRating).toBe(
-			3,
-		);
-		expect(response.body.results[0].reviewRatingStatistics.highestRating).toBe(
-			4,
-		);
-		expect(response.body.results[0].reviewRatingStatistics.lowestRating).toBe(
-			2,
-		);
+		await reviewDraftFactory(ctMock).create({
+			authorName: "Reviewer 1",
+			rating: 2,
+			target: {
+				typeId: "product",
+				id: product.id,
+			},
+		});
+
+		await reviewDraftFactory(ctMock).create({
+			authorName: "Reviewer 2",
+			rating: 4,
+			target: {
+				typeId: "product",
+				id: product.id,
+			},
+		});
+
+		const response = await ctMock.app.inject({
+			method: "GET",
+			url: "/dummy/products",
+		});
+
+		expect(response.statusCode).toBe(200);
+		const body = response.json();
+		expect(body.results).toHaveLength(1);
+		expect(body.results[0].reviewRatingStatistics).toBeDefined();
+		expect(body.results[0].reviewRatingStatistics.count).toBe(2);
+		expect(body.results[0].reviewRatingStatistics.averageRating).toBe(3);
+		expect(body.results[0].reviewRatingStatistics.highestRating).toBe(4);
+		expect(body.results[0].reviewRatingStatistics.lowestRating).toBe(2);
 	});
 
 	test("only reviews with includedInStatistics=true are counted", async () => {
-		// Create reviews - both will be included by default
-		const _review1Response = await supertest(ctMock.app)
-			.post("/dummy/reviews")
-			.send({
-				authorName: "Reviewer 1",
-				rating: 5,
-				target: {
-					typeId: "product",
-					id: product.id,
-				},
-			});
-
-		const _review2Response = await supertest(ctMock.app)
-			.post("/dummy/reviews")
-			.send({
-				authorName: "Reviewer 2",
-				rating: 1,
-				target: {
-					typeId: "product",
-					id: product.id,
-				},
-			});
-
-		// Check that both reviews are included by default
-		const response = await supertest(ctMock.app).get(
-			`/dummy/products/${product.id}`,
-		);
-
-		expect(response.status).toBe(200);
-		expect(response.body.reviewRatingStatistics).toBeDefined();
-		expect(response.body.reviewRatingStatistics.count).toBe(2);
-		expect(response.body.reviewRatingStatistics.averageRating).toBe(3);
-
-		// Now exclude one review from statistics by updating it
-		// (Note: In a real implementation, this would be done via state transitions,
-		// but for now we can test the filtering works with includedInStatistics directly)
+		await reviewDraftFactory(ctMock).create({
+			authorName: "Reviewer 1",
+			rating: 5,
+			target: {
+				typeId: "product",
+				id: product.id,
+			},
+		});
+
+		await reviewDraftFactory(ctMock).create({
+			authorName: "Reviewer 2",
+			rating: 1,
+			target: {
+				typeId: "product",
+				id: product.id,
+			},
+		});
+
+		const response = await ctMock.app.inject({
+			method: "GET",
+			url: `/dummy/products/${product.id}`,
+		});
+
+		expect(response.statusCode).toBe(200);
+		const body = response.json();
+		expect(body.reviewRatingStatistics).toBeDefined();
+		expect(body.reviewRatingStatistics.count).toBe(2);
+		expect(body.reviewRatingStatistics.averageRating).toBe(3);
 	});
 
 	test("reviews without ratings are not included in statistics", async () => {
-		// Create a review without rating
-		await supertest(ctMock.app)
-			.post("/dummy/reviews")
-			.send({
-				authorName: "No Rating User",
-				title: "No rating review",
-				text: "This review has no rating.",
-				target: {
-					typeId: "product",
-					id: product.id,
-				},
-			});
-
-		// Create a review with rating
-		await supertest(ctMock.app)
-			.post("/dummy/reviews")
-			.send({
-				authorName: "Rated User",
-				title: "Rated review",
-				rating: 4,
-				target: {
-					typeId: "product",
-					id: product.id,
-				},
-			});
-
-		const response = await supertest(ctMock.app).get(
-			`/dummy/products/${product.id}`,
-		);
-
-		expect(response.status).toBe(200);
-		// Only the review with rating should be counted
-		expect(response.body.reviewRatingStatistics).toBeDefined();
-		expect(response.body.reviewRatingStatistics.count).toBe(1);
-		expect(response.body.reviewRatingStatistics.averageRating).toBe(4);
+		await reviewDraftFactory(ctMock).create({
+			authorName: "No Rating User",
+			title: "No rating review",
+			text: "This review has no rating.",
+			rating: undefined,
+			target: {
+				typeId: "product",
+				id: product.id,
+			},
+		});
+
+		await reviewDraftFactory(ctMock).create({
+			authorName: "Rated User",
+			title: "Rated review",
+			rating: 4,
+			target: {
+				typeId: "product",
+				id: product.id,
+			},
+		});
+
+		const response = await ctMock.app.inject({
+			method: "GET",
+			url: `/dummy/products/${product.id}`,
+		});
+
+		expect(response.statusCode).toBe(200);
+		const body = response.json();
+		expect(body.reviewRatingStatistics).toBeDefined();
+		expect(body.reviewRatingStatistics.count).toBe(1);
+		expect(body.reviewRatingStatistics.averageRating).toBe(4);
 	});
 
 	test("reviews on other products are excluded from statistics", async () => {
-		// Create another product
-		const otherProductResponse = await supertest(ctMock.app)
-			.post("/dummy/products")
-			.send({
-				name: { en: "Other Product" },
-				slug: { en: "other-product" },
-				productType: {
-					typeId: "product-type",
-					key: "dummy-product-type",
-				},
-				masterVariant: {
-					sku: "other-sku",
-					prices: [
-						{
-							value: {
-								currencyCode: "EUR",
-								centAmount: 2000,
-							},
+		const otherProduct = await productDraftFactory(ctMock).create({
+			productType: {
+				typeId: "product-type",
+				id: product.productType.id,
+			},
+			masterVariant: {
+				sku: "other-sku",
+				prices: [
+					{
+						value: {
+							currencyCode: "EUR",
+							centAmount: 2000,
 						},
-					],
-				},
-			});
-		expect(otherProductResponse.status).toBe(201);
-		const otherProduct = otherProductResponse.body;
-
-		// Create reviews for both products
-		await supertest(ctMock.app)
-			.post("/dummy/reviews")
-			.send({
-				authorName: "User A",
-				title: "Review for first product",
-				rating: 5,
-				target: {
-					typeId: "product",
-					id: product.id,
-				},
-			});
-
-		await supertest(ctMock.app)
-			.post("/dummy/reviews")
-			.send({
-				authorName: "User B",
-				title: "Review for second product",
-				rating: 1,
-				target: {
-					typeId: "product",
-					id: otherProduct.id,
-				},
-			});
-
-		await supertest(ctMock.app)
-			.post("/dummy/reviews")
-			.send({
-				authorName: "User C",
-				title: "Another review for first product",
-				rating: 3,
-				target: {
-					typeId: "product",
-					id: product.id,
-				},
-			});
+					},
+				],
+			},
+		});
+
+		await reviewDraftFactory(ctMock).create({
+			authorName: "User A",
+			title: "Review for first product",
+			rating: 5,
+			target: {
+				typeId: "product",
+				id: product.id,
+			},
+		});
+
+		await reviewDraftFactory(ctMock).create({
+			authorName: "User B",
+			title: "Review for second product",
+			rating: 1,
+			target: {
+				typeId: "product",
+				id: otherProduct.id,
+			},
+		});
+
+		await reviewDraftFactory(ctMock).create({
+			authorName: "User C",
+			title: "Another review for first product",
+			rating: 3,
+			target: {
+				typeId: "product",
+				id: product.id,
+			},
+		});
 
 		// Check statistics for the first product - should only include its own reviews
-		const response1 = await supertest(ctMock.app).get(
-			`/dummy/products/${product.id}`,
-		);
-		expect(response1.status).toBe(200);
-		expect(response1.body.reviewRatingStatistics).toBeDefined();
-		expect(response1.body.reviewRatingStatistics.count).toBe(2); // Only reviews for this product
-		expect(response1.body.reviewRatingStatistics.averageRating).toBe(4); // (5 + 3) / 2 = 4
-		expect(response1.body.reviewRatingStatistics.highestRating).toBe(5);
-		expect(response1.body.reviewRatingStatistics.lowestRating).toBe(3);
-		expect(response1.body.reviewRatingStatistics.ratingsDistribution).toEqual({
+		const response1 = await ctMock.app.inject({
+			method: "GET",
+			url: `/dummy/products/${product.id}`,
+		});
+		expect(response1.statusCode).toBe(200);
+		const body1 = response1.json();
+		expect(body1.reviewRatingStatistics).toBeDefined();
+		expect(body1.reviewRatingStatistics.count).toBe(2);
+		expect(body1.reviewRatingStatistics.averageRating).toBe(4);
+		expect(body1.reviewRatingStatistics.highestRating).toBe(5);
+		expect(body1.reviewRatingStatistics.lowestRating).toBe(3);
+		expect(body1.reviewRatingStatistics.ratingsDistribution).toEqual({
 			"3": 1,
 			"5": 1,
 		});
 
 		// Check statistics for the second product - should only include its own review
-		const response2 = await supertest(ctMock.app).get(
-			`/dummy/products/${otherProduct.id}`,
-		);
-		expect(response2.status).toBe(200);
-		expect(response2.body.reviewRatingStatistics).toBeDefined();
-		expect(response2.body.reviewRatingStatistics.count).toBe(1); // Only reviews for this product
-		expect(response2.body.reviewRatingStatistics.averageRating).toBe(1);
-		expect(response2.body.reviewRatingStatistics.highestRating).toBe(1);
-		expect(response2.body.reviewRatingStatistics.lowestRating).toBe(1);
-		expect(response2.body.reviewRatingStatistics.ratingsDistribution).toEqual({
+		const response2 = await ctMock.app.inject({
+			method: "GET",
+			url: `/dummy/products/${otherProduct.id}`,
+		});
+		expect(response2.statusCode).toBe(200);
+		const body2 = response2.json();
+		expect(body2.reviewRatingStatistics).toBeDefined();
+		expect(body2.reviewRatingStatistics.count).toBe(1);
+		expect(body2.reviewRatingStatistics.averageRating).toBe(1);
+		expect(body2.reviewRatingStatistics.highestRating).toBe(1);
+		expect(body2.reviewRatingStatistics.lowestRating).toBe(1);
+		expect(body2.reviewRatingStatistics.ratingsDistribution).toEqual({
 			"1": 1,
 		});
 	});

package/src/lib/review-statistics.ts

@@ -5,14 +5,27 @@ import type {
 import type { AbstractStorage } from "../storage/index.ts";
 
 export class ReviewStatisticsService {
-	constructor(private _storage: AbstractStorage) {}
+	private _storage: AbstractStorage;
 
-	calculateProductReviewStatistics(
+	constructor(_storage: AbstractStorage) {
+		this._storage = _storage;
+	}
+
+	async calculateProductReviewStatistics(
 		projectKey: string,
 		productId: string,
-	): ReviewRatingStatistics | undefined {
+	): Promise<ReviewRatingStatistics | undefined> {
+		// Fast path: if there are no reviews at all, skip the expensive load
+		const reviewCount = await this._storage.count(projectKey, "review");
+		if (reviewCount === 0) {
+			return undefined;
+		}
+
 		// Get all reviews for this product
-		const allReviews = this._storage.all(projectKey, "review") as Review[];
+		const allReviews = (await this._storage.all(
+			projectKey,
+			"review",
+		)) as Review[];
 		const productReviews = allReviews.filter(
 			(review) =>
 				review.target?.typeId === "product" &&

package/src/oauth/helpers.ts

@@ -1,8 +1,11 @@
-import type { Request } from "express";
+import type { FastifyRequest } from "fastify";
 
-export const getBearerToken = (request: Request): string | undefined => {
-	const authHeader = request.header("Authorization");
-	const match = authHeader?.match(/^Bearer\s(?<token>[^\s]+)$/);
+export const getBearerToken = (request: FastifyRequest): string | undefined => {
+	const authHeader = request.headers.authorization;
+	const normalizedAuthHeader = Array.isArray(authHeader)
+		? authHeader[0]
+		: authHeader;
+	const match = normalizedAuthHeader?.match(/^Bearer\s(?<token>[^\s]+)$/);
 	if (match) {
 		return match.groups?.token;
 	}