@labdigital/commercetools-mock 2.37.0 → 2.38.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@labdigital/commercetools-mock",
-  "version": "2.37.0",
+  "version": "2.38.0",
   "license": "MIT",
   "author": "Michael van Tellingen",
   "type": "module",
@@ -23,11 +23,11 @@
     "body-parser": "^1.20.2",
     "decimal.js": "10.4.3",
     "deep-equal": "^2.2.3",
-    "express": "^4.19.2",
+    "express": "^4.21.1",
     "light-my-request": "^5.11.1",
     "lodash.isequal": "^4.5.0",
     "morgan": "^1.10.0",
-    "msw": "^2.2.1",
+    "msw": "^2.5.0",
     "uuid": "^9.0.1",
     "zod": "^3.22.4",
     "zod-validation-error": "^3.0.2"
@@ -44,7 +44,7 @@
     "@types/express-serve-static-core": "^4.17.43",
     "@types/lodash.isequal": "^4.5.8",
     "@types/morgan": "^1.9.9",
-    "@types/node": "^20.11.20",
+    "@types/node": "^20.16.14",
     "@types/qs": "^6.9.11",
     "@types/supertest": "^6.0.2",
     "@types/uuid": "^9.0.8",
@@ -52,20 +52,21 @@
     "@typescript-eslint/parser": "^7.0.2",
     "@vitest/coverage-v8": "^1.5.0",
     "esbuild": "^0.20.1",
-    "eslint": "^8.57.0",
-    "eslint-plugin-sort-class-members": "^1.20.0",
+    "eslint": "^8.57.1",
+    "eslint-plugin-sort-class-members": "^1.21.0",
     "eslint-plugin-unused-imports": "^3.1.0",
+    "fishery": "^2.2.2",
     "got": "^14.2.0",
     "husky": "^9.0.11",
     "prettier": "^3.2.5",
     "prettier-plugin-organize-imports": "^3.2.4",
-    "prettier-plugin-packagejson": "^2.4.12",
+    "prettier-plugin-packagejson": "^2.5.3",
     "supertest": "^6.3.4",
     "timekeeper": "^2.3.1",
     "ts-node": "^10.9.2",
-    "tslib": "^2.6.2",
+    "tslib": "^2.8.0",
     "tsup": "^8.0.2",
-    "typescript": "^5.3.3",
+    "typescript": "^5.6.3",
     "vitest": "^1.5.0"
   },
   "engines": {

package/src/ctMock.ts

@@ -1,21 +1,25 @@
-import express, { NextFunction, Request, Response } from "express";
+import type { NextFunction, Request, Response } from "express";
+import express from "express";
 import inject from "light-my-request";
 import morgan from "morgan";
 import { http, HttpResponse } from "msw";
-import { setupServer, SetupServer, SetupServerApi } from "msw/node";
+import type { SetupServer, SetupServerApi } from "msw/node";
+import { setupServer } from "msw/node";
 import { DEFAULT_API_HOSTNAME, DEFAULT_AUTH_HOSTNAME } from "./constants";
 import { CommercetoolsError } from "./exceptions";
 import { copyHeaders } from "./lib/proxy";
 import { OAuth2Server } from "./oauth/server";
 import { ProjectAPI } from "./projectAPI";
-import { AbstractStorage, InMemoryStorage } from "./storage";
-import { Services } from "./types";
+import type { AbstractStorage } from "./storage";
+import { InMemoryStorage } from "./storage";
+import type { Services } from "./types";
 
 // Services
 import { warnDeprecation } from "./deprecation";
 import { mapHeaderType } from "./helpers";
-import { createRepositories, RepositoryMap } from "./repositories";
-import { ProjectRepository } from "./repositories/project";
+import type { RepositoryMap } from "./repositories";
+import { createRepositories } from "./repositories";
+import type { ProjectRepository } from "./repositories/project";
 import { createServices } from "./services";
 import { ProjectService } from "./services/project";
 

package/src/helpers.ts

@@ -1,5 +1,5 @@
-import { OutgoingHttpHeaders } from "node:http";
-import { ParsedQs } from "qs";
+import type { OutgoingHttpHeaders } from "node:http";
+import type { ParsedQs } from "qs";
 import { v4 as uuidv4 } from "uuid";
 
 export const getBaseResourceProperties = () => ({
@@ -23,7 +23,7 @@ export const nestedLookup = (obj: any, path: string): any => {
 
 	for (let i = 0; i < parts.length; i++) {
 		const part = parts[i];
-		if (val == undefined) {
+		if (val === undefined) {
 			return undefined;
 		}
 
@@ -36,7 +36,7 @@ export const nestedLookup = (obj: any, path: string): any => {
 export const queryParamsArray = (
 	input: string | ParsedQs | string[] | ParsedQs[] | undefined,
 ): string[] | undefined => {
-	if (input == undefined) {
+	if (input === undefined) {
 		return undefined;
 	}
 

package/src/index.ts

@@ -1,4 +1,5 @@
-import { CommercetoolsMock, CommercetoolsMockOptions } from "./ctMock";
+import type { CommercetoolsMockOptions } from "./ctMock";
+import { CommercetoolsMock } from "./ctMock";
 import { getBaseResourceProperties } from "./helpers";
 
 export {

package/src/lib/expandParser.ts

@@ -27,7 +27,7 @@ export const parseExpandClause = (clause: string): ExpandResult => {
 
 	const match = result.element.match(/\[([^\]+])]/);
 	if (match) {
-		result.index = match[1] === "*" ? "*" : parseInt(match[1], 10);
+		result.index = match[1] === "*" ? "*" : Number.parseInt(match[1], 10);
 		result.element = result.element.substring(0, match.index);
 	}
 	return result;

package/src/lib/haversine.test.ts

@@ -1,5 +1,6 @@
 import { expect, test } from "vitest";
-import { Location, haversineDistance } from "./haversine";
+import type { Location } from "./haversine";
+import { haversineDistance } from "./haversine";
 
 test("haversine", () => {
 	// Lab Digital

package/src/lib/password.ts

@@ -1,4 +1,4 @@
-import { Customer } from "@commercetools/platform-sdk";
+import type { Customer } from "@commercetools/platform-sdk";
 import { v4 as uuidv4 } from "uuid";
 
 const PWRESET_SECRET = "pwreset";
@@ -31,7 +31,7 @@ export const validatePasswordResetToken = (token: string) => {
 	}
 
 	// Check if the token is expired
-	if (parseInt(time) < new Date().getTime()) {
+	if (Number.parseInt(time) < new Date().getTime()) {
 		return undefined;
 	}
 

package/src/lib/predicateParser.ts

@@ -399,7 +399,7 @@ const generateMatchFunc = (predicate: string): MatchFunc => {
 				const value = resolveValue(obj, left);
 				const other = resolveSymbol(expr, vars);
 
-				if (typeof value != "string") {
+				if (typeof value !== "string") {
 					throw new PredicateError(
 						`The field '${left.value}' does not support this expression.`,
 					);

package/src/lib/productSearchFilter.test.ts

@@ -1,4 +1,7 @@
-import { ProductProjection, _SearchQuery } from "@commercetools/platform-sdk";
+import type {
+	ProductProjection,
+	_SearchQuery,
+} from "@commercetools/platform-sdk";
 import { describe, expect, test } from "vitest";
 import { cloneObject } from "~src/helpers";
 import { parseSearchQuery } from "./productSearchFilter";

package/src/lib/projectionSearchFilter.ts

@@ -113,12 +113,12 @@ const parseFilter = (filter: string): ExpressionSet => {
 			// Convert plain symbols to a filter expression. For example
 			// variants.attribute.foobar:4 where 4 is a Symbol should result
 			// in a comparison
-			if (expressions.some((expr) => expr.type == "Symbol")) {
+			if (expressions.some((expr) => expr.type === "Symbol")) {
 				return {
 					source: left as string,
 					type: "FilterExpression",
 					children: expressions.map((e): FilterExpression => {
-						if (e.type != "Symbol") {
+						if (e.type !== "Symbol") {
 							throw new Error("Invalid expression");
 						}
 
@@ -245,7 +245,7 @@ const generateMatchFunc = (filter: string) => {
 		// const column = lines[lines.length - 1].length
 		throw new Error(`Syntax error while parsing '${filter}'.`);
 	}
-	if (result.type == "TermExpression") {
+	if (result.type === "TermExpression") {
 		throw new Error(`Syntax error while parsing '${filter}'.`);
 	}
 

package/src/oauth/helpers.ts

@@ -1,4 +1,4 @@
-import { Request } from "express";
+import type { Request } from "express";
 
 export const getBearerToken = (request: Request): string | undefined => {
 	const authHeader = request.header("Authorization");

package/src/oauth/server.test.ts

@@ -4,7 +4,8 @@ import { beforeEach, describe, expect, it } from "vitest";
 import { getBaseResourceProperties } from "../helpers";
 import { hashPassword } from "../lib/password";
 import { CustomerRepository } from "../repositories/customer";
-import { AbstractStorage, InMemoryStorage } from "../storage";
+import type { AbstractStorage } from "../storage";
+import { InMemoryStorage } from "../storage";
 import { OAuth2Server } from "./server";
 
 describe("OAuth2Server", () => {

package/src/oauth/server.ts

@@ -1,4 +1,4 @@
-import { InvalidTokenError } from "@commercetools/platform-sdk";
+import type { InvalidTokenError } from "@commercetools/platform-sdk";
 import auth from "basic-auth";
 import bodyParser from "body-parser";
 import express, {
@@ -6,14 +6,11 @@ import express, {
 	type Request,
 	type Response,
 } from "express";
-import {
-	AuthError,
-	CommercetoolsError,
-	InvalidRequestError,
-} from "~src/exceptions";
+import type { AuthError, InvalidRequestError } from "~src/exceptions";
+import { CommercetoolsError } from "~src/exceptions";
 import { hashPassword } from "../lib/password";
-import { CustomerRepository } from "../repositories/customer";
-import { InvalidClientError, UnsupportedGrantType } from "./errors";
+import type { CustomerRepository } from "../repositories/customer";
+import type { InvalidClientError, UnsupportedGrantType } from "./errors";
 import { getBearerToken } from "./helpers";
 import { OAuth2Store } from "./store";
 

package/src/oauth/store.ts

@@ -1,4 +1,4 @@
-import { randomBytes } from "crypto";
+import { randomBytes } from "node:crypto";
 import { v4 as uuidv4 } from "uuid";
 
 type Token = {

package/src/priceSelector.ts

@@ -31,7 +31,7 @@ export const applyPriceSelector = (
 		const variants: Writable<ProductVariant>[] = [
 			product.masterVariant,
 			...(product.variants ?? []),
-		].filter((x) => x != undefined);
+		].filter((x) => x !== undefined);
 
 		for (const variant of variants) {
 			const scopedPrices =

package/src/product-projection-search.ts

@@ -11,16 +11,18 @@ import type {
 } from "@commercetools/platform-sdk";
 import { CommercetoolsError } from "./exceptions";
 import { nestedLookup } from "./helpers";
-import {
+import type {
 	FilterExpression,
 	RangeExpression,
+} from "./lib/projectionSearchFilter";
+import {
 	generateFacetFunc,
 	getVariants,
 	parseFilterExpression,
 	resolveVariantValue,
 } from "./lib/projectionSearchFilter";
 import { applyPriceSelector } from "./priceSelector";
-import { AbstractStorage } from "./storage";
+import type { AbstractStorage } from "./storage";
 import type { Writable } from "./types";
 
 export type ProductProjectionSearchParams = {

package/src/product-search.ts

@@ -1,4 +1,4 @@
-import {
+import type {
 	InvalidInputError,
 	Product,
 	ProductPagedSearchResponse,
@@ -10,7 +10,7 @@ import { CommercetoolsError } from "./exceptions";
 import { parseSearchQuery } from "./lib/productSearchFilter";
 import { validateSearchQuery } from "./lib/searchQueryTypeChecker";
 import { applyPriceSelector } from "./priceSelector";
-import { AbstractStorage } from "./storage";
+import type { AbstractStorage } from "./storage";
 
 export class ProductSearch {
 	protected _storage: AbstractStorage;

package/src/projectAPI.ts

@@ -1,8 +1,8 @@
 import { getBaseResourceProperties } from "./helpers";
-import { RepositoryMap } from "./repositories";
-import { GetParams } from "./repositories/abstract";
-import { AbstractStorage } from "./storage";
-import { ResourceMap, ResourceType } from "./types";
+import type { RepositoryMap } from "./repositories";
+import type { GetParams } from "./repositories/abstract";
+import type { AbstractStorage } from "./storage";
+import type { ResourceMap, ResourceType } from "./types";
 
 export class ProjectAPI {
 	private projectKey: string;

package/src/repositories/abstract.ts

@@ -1,5 +1,6 @@
 import type {
 	BaseResource,
+	InvalidInputError,
 	Project,
 	QueryParam,
 	ResourceNotFoundError,
@@ -8,8 +9,8 @@ import type {
 import deepEqual from "deep-equal";
 import { CommercetoolsError } from "~src/exceptions";
 import { cloneObject } from "../helpers";
-import { AbstractStorage } from "../storage";
-import {
+import type { AbstractStorage } from "../storage";
+import type {
 	ResourceMap,
 	ResourceType,
 	ShallowWritable,
@@ -74,7 +75,7 @@ export abstract class AbstractRepository<R extends BaseResource | Project> {
 
 		// If all actions succeeded we write the new version
 		// to the storage.
-		if (resource.version != updatedResource.version) {
+		if (resource.version !== updatedResource.version) {
 			this.saveUpdate(context, version, updatedResource);
 		}
 
@@ -253,6 +254,22 @@ export class AbstractUpdateHandler {
 			: (resource as Project).key;
 
 		for (const action of actions) {
+			// Validate if this action exists
+			// @ts-ignore
+			if (this[action.action] === undefined) {
+				console.info(`No handler for action ${action.action}`);
+				throw new CommercetoolsError<InvalidInputError>({
+					code: "InvalidInput",
+					message: `Invalid action ${action.action}`,
+					errors: [
+						{
+							code: "InvalidInput",
+							message: `Invalid action ${action.action}`,
+						},
+					],
+				});
+			}
+
 			// @ts-ignore
 			const updateFunc = this[action.action].bind(this);
 

package/src/repositories/associate-role.ts

@@ -10,12 +10,12 @@ import type {
 	AssociateRoleUpdateAction,
 } from "@commercetools/platform-sdk";
 import { getBaseResourceProperties } from "../helpers";
-import { AbstractStorage } from "../storage/abstract";
-import { Writable } from "../types";
+import type { AbstractStorage } from "../storage/abstract";
+import type { Writable } from "../types";
+import type { UpdateHandlerInterface } from "./abstract";
 import {
 	AbstractResourceRepository,
 	AbstractUpdateHandler,
-	UpdateHandlerInterface,
 	type RepositoryContext,
 } from "./abstract";
 import { createCustomFields } from "./helpers";

package/src/repositories/attribute-group.ts

@@ -8,12 +8,12 @@ import type {
 	AttributeGroupUpdateAction,
 } from "@commercetools/platform-sdk";
 import { getBaseResourceProperties } from "../helpers";
-import { AbstractStorage } from "../storage/abstract";
-import { Writable } from "../types";
+import type { AbstractStorage } from "../storage/abstract";
+import type { Writable } from "../types";
+import type { UpdateHandlerInterface } from "./abstract";
 import {
 	AbstractResourceRepository,
 	AbstractUpdateHandler,
-	UpdateHandlerInterface,
 	type RepositoryContext,
 } from "./abstract";
 

package/src/repositories/business-unit.ts

@@ -1,10 +1,12 @@
-import {
+import type {
 	BusinessUnitChangeApprovalRuleModeAction,
 	BusinessUnitChangeAssociateModeAction,
 	BusinessUnitChangeStatusAction,
 	BusinessUnitUpdateAction,
 	CompanyDraft,
 	DivisionDraft,
+} from "@commercetools/platform-sdk";
+import {
 	type Associate,
 	type BusinessUnit,
 	type BusinessUnitAddAddressAction,
@@ -20,13 +22,13 @@ import {
 	type Company,
 	type Division,
 } from "@commercetools/platform-sdk";
-import { AbstractStorage } from "~src/storage";
+import type { AbstractStorage } from "~src/storage";
 import { generateRandomString, getBaseResourceProperties } from "../helpers";
-import { Writable } from "../types";
+import type { Writable } from "../types";
+import type { UpdateHandlerInterface } from "./abstract";
 import {
 	AbstractResourceRepository,
 	AbstractUpdateHandler,
-	UpdateHandlerInterface,
 	type RepositoryContext,
 } from "./abstract";
 import {

package/src/repositories/cart/actions.ts

@@ -1,4 +1,4 @@
-import {
+import type {
 	CartSetAnonymousIdAction,
 	CartSetCustomerIdAction,
 	CartUpdateAction,
@@ -6,6 +6,8 @@ import {
 	InvalidOperationError,
 	MissingTaxRateForCountryError,
 	ShippingMethodDoesNotMatchCartError,
+} from "@commercetools/platform-sdk";
+import {
 	type Address,
 	type AddressDraft,
 	type Cart,
@@ -36,7 +38,7 @@ import {
 	type ProductPagedQueryResponse,
 	type ProductVariant,
 } from "@commercetools/platform-sdk";
-import {
+import type {
 	DirectDiscount,
 	TaxPortion,
 	TaxedItemPrice,
@@ -46,11 +48,8 @@ import { v4 as uuidv4 } from "uuid";
 import { CommercetoolsError } from "~src/exceptions";
 import { getShippingMethodsMatchingCart } from "~src/shipping";
 import type { Writable } from "~src/types";
-import {
-	AbstractUpdateHandler,
-	UpdateHandlerInterface,
-	type RepositoryContext,
-} from "../abstract";
+import type { UpdateHandlerInterface } from "../abstract";
+import { AbstractUpdateHandler, type RepositoryContext } from "../abstract";
 import {
 	createAddress,
 	createCentPrecisionMoney,

package/src/repositories/cart/helpers.ts

@@ -1,4 +1,4 @@
-import { Cart, LineItem, Price } from "@commercetools/platform-sdk";
+import type { Cart, LineItem, Price } from "@commercetools/platform-sdk";
 
 export const selectPrice = ({
 	prices,

package/src/repositories/cart/index.ts

@@ -10,7 +10,7 @@ import {
 import { v4 as uuidv4 } from "uuid";
 import { CommercetoolsError } from "~src/exceptions";
 import { getBaseResourceProperties } from "~src/helpers";
-import { AbstractStorage } from "~src/storage/abstract";
+import type { AbstractStorage } from "~src/storage/abstract";
 import type { Writable } from "~src/types";
 import {
 	AbstractResourceRepository,

package/src/repositories/cart-discount/actions.ts

@@ -14,11 +14,8 @@ import type {
 	InvalidOperationError,
 } from "@commercetools/platform-sdk";
 import type { Writable } from "~src/types";
-import {
-	AbstractUpdateHandler,
-	UpdateHandlerInterface,
-	type RepositoryContext,
-} from "../abstract";
+import type { UpdateHandlerInterface } from "../abstract";
+import { AbstractUpdateHandler, type RepositoryContext } from "../abstract";
 
 import { CommercetoolsError } from "~src/exceptions";
 

package/src/repositories/cart-discount/index.ts

@@ -8,7 +8,7 @@ import type {
 	CartDiscountValueRelative,
 } from "@commercetools/platform-sdk";
 import { getBaseResourceProperties } from "~src/helpers";
-import { AbstractStorage } from "~src/storage/abstract";
+import type { AbstractStorage } from "~src/storage/abstract";
 import {
 	AbstractResourceRepository,
 	type RepositoryContext,

package/src/repositories/category/actions.ts

@@ -1,4 +1,4 @@
-import {
+import type {
 	Asset,
 	AssetDraft,
 	Category,
@@ -20,12 +20,9 @@ import {
 	CategoryUpdateAction,
 } from "@commercetools/platform-sdk";
 import { v4 as uuidv4 } from "uuid";
-import { Writable } from "~src/types";
-import {
-	AbstractUpdateHandler,
-	RepositoryContext,
-	UpdateHandlerInterface,
-} from "../abstract";
+import type { Writable } from "~src/types";
+import type { RepositoryContext, UpdateHandlerInterface } from "../abstract";
+import { AbstractUpdateHandler } from "../abstract";
 import { createCustomFields } from "../helpers";
 
 export class CategoryUpdateHandler

package/src/repositories/category/index.ts

@@ -6,11 +6,11 @@ import type {
 import { v4 as uuidv4 } from "uuid";
 import { getBaseResourceProperties } from "~src/helpers";
 import { parseExpandClause } from "~src/lib/expandParser";
-import { AbstractStorage } from "~src/storage/abstract";
-import { Writable } from "~src/types";
+import type { AbstractStorage } from "~src/storage/abstract";
+import type { Writable } from "~src/types";
+import type { GetParams } from "../abstract";
 import {
 	AbstractResourceRepository,
-	GetParams,
 	type RepositoryContext,
 } from "../abstract";
 import { createCustomFields } from "../helpers";

package/src/repositories/channel.ts

@@ -11,12 +11,12 @@ import type {
 	ChannelUpdateAction,
 } from "@commercetools/platform-sdk";
 import { getBaseResourceProperties } from "../helpers";
-import { AbstractStorage } from "../storage/abstract";
+import type { AbstractStorage } from "../storage/abstract";
 import type { Writable } from "../types";
+import type { UpdateHandlerInterface } from "./abstract";
 import {
 	AbstractResourceRepository,
 	AbstractUpdateHandler,
-	UpdateHandlerInterface,
 	type RepositoryContext,
 } from "./abstract";
 import { createAddress, createCustomFields } from "./helpers";

package/src/repositories/custom-object.ts

@@ -4,14 +4,11 @@ import type {
 	InvalidOperationError,
 } from "@commercetools/platform-sdk";
 import { CommercetoolsError } from "~src/exceptions";
-import { AbstractStorage } from "~src/storage";
+import type { AbstractStorage } from "~src/storage";
 import { cloneObject, getBaseResourceProperties } from "../helpers";
 import type { Writable } from "../types";
-import {
-	AbstractResourceRepository,
-	QueryParams,
-	type RepositoryContext,
-} from "./abstract";
+import type { QueryParams } from "./abstract";
+import { AbstractResourceRepository, type RepositoryContext } from "./abstract";
 import { checkConcurrentModification } from "./errors";
 
 export class CustomObjectRepository extends AbstractResourceRepository<"key-value-document"> {