@labdigital/commercetools-mock 0.5.14 → 0.5.17

package/dist/lib/masking.d.ts

@@ -0,0 +1 @@
+export declare const maskSecretValue: <T>(resource: T, path: string) => T;

package/dist/repositories/abstract.d.ts

@@ -4,6 +4,8 @@ import { AbstractStorage } from '../storage';
 export declare type QueryParams = {
     expand?: string[];
     where?: string[];
+    offset?: number;
+    limit?: number;
 };
 export declare type GetParams = {
     expand?: string[];

package/package.json

@@ -1,5 +1,5 @@
 {
-  "version": "0.5.14",
+  "version": "0.5.17",
   "license": "MIT",
   "main": "dist/index.js",
   "typings": "dist/index.d.ts",

package/src/lib/masking.ts

@@ -0,0 +1,22 @@
+import { json } from 'express'
+
+export const maskSecretValue = <T>(resource: T, path: string): T => {
+  const parts = path.split('.')
+  const clone = JSON.parse(JSON.stringify(resource))
+  let val = clone
+
+  const target = parts.pop()
+  for (let i = 0; i < parts.length; i++) {
+    const part = parts[i]
+    val = val[part]
+
+    if (val == undefined) {
+      return resource
+    }
+  }
+
+  if (val && target && val[target]) {
+    val[target] = '****'
+  }
+  return clone
+}

package/src/repositories/abstract.ts

@@ -14,6 +14,8 @@ import { CommercetoolsError } from '../exceptions'
 export type QueryParams = {
   expand?: string[]
   where?: string[]
+  offset?: number
+  limit?: number
 }
 
 export type GetParams = {
@@ -69,6 +71,8 @@ export abstract class AbstractResourceRepository extends AbstractRepository {
     return this._storage.query(projectKey, this.getTypeId(), {
       expand: params.expand,
       where: params.where,
+      offset: params.offset,
+      limit: params.limit,
     })
   }
 

package/src/repositories/product-projection.ts

@@ -50,10 +50,13 @@ export class ProductProjectionRepository extends AbstractResourceRepository {
   }
 
   search(projectKey: string, query: ParsedQs) {
-    const wherePredicate = parseFilterExpression(query.filter as any)
+    const filter = (query['filter.query'] ?? query.filter) as any
+    const wherePredicate = filter ? parseFilterExpression(filter) : undefined
 
     const results = this._storage.query(projectKey, this.getTypeId(), {
       where: wherePredicate,
+      offset: query.offset ? Number(query.offset) : undefined,
+      limit: query.limit ? Number(query.limit) : undefined,
     }) //TODO: this is a partial implementation, but I don't really have the time to implement an actual search API right now
 
     return results

package/src/repositories/project.ts

@@ -18,11 +18,17 @@ import { Writable } from 'types'
 import { checkConcurrentModification } from './errors'
 import { CommercetoolsError } from '../exceptions'
 import { AbstractRepository } from './abstract'
+import { maskSecretValue } from '../lib/masking'
 
 export class ProjectRepository extends AbstractRepository {
   get(projectKey: string): Project | null {
     const data = this._storage.getProject(projectKey)
-    return this._storage.getProject(projectKey)
+    const resource = this._storage.getProject(projectKey)
+    const masked = maskSecretValue<Project>(
+      resource,
+      'externalOAuth.authorizationHeader'
+    )
+    return masked
   }
 
   save(projectKey: string, resource: Project) {

package/src/services/abstract.ts

@@ -37,9 +37,14 @@ export default abstract class AbstractService {
   }
 
   get(request: Request, response: Response) {
+    const limit = this._parseParam(request.query.limit)
+    const offset = this._parseParam(request.query.offset)
+
     const result = this.repository.query(request.params.projectKey, {
       expand: this._parseParam(request.query.expand),
       where: this._parseParam(request.query.where),
+      limit: limit !== undefined ? Number(limit) : undefined,
+      offset: offset !== undefined ? Number(offset) : undefined,
     })
     return response.status(200).send(result)
   }

package/src/services/product-projection.test.ts

@@ -56,7 +56,20 @@ describe('Product Projection', () => {
     })
   })
 
-  test('Search product projection', async () => {
+  test('Get product projection by 404 when not found by key with expand', async () => {
+    const response = await supertest(ctMock.app).get(
+      '/dummy/product-projections/key=DOESNOTEXIST?' +
+        qs.stringify({
+          expand: ['categories[*]'],
+        })
+    )
+
+    expect(response.status).toBe(404)
+  })
+})
+
+describe('Product Projection Search', () => {
+  beforeAll(() => {
     ctMock.project('dummy').add('product-projection', {
       id: '',
       version: 1,
@@ -72,7 +85,9 @@ describe('Product Projection', () => {
       lastModifiedAt: '',
       categories: [],
     })
+  })
 
+  test('Search product projection', async () => {
     const response = await supertest(ctMock.app).get(
       '/dummy/product-projections/search?' +
         qs.stringify({
@@ -102,4 +117,51 @@ describe('Product Projection', () => {
       ],
     })
   })
+
+  test('Search product projection page 2', async () => {
+    const response = await supertest(ctMock.app).get(
+      '/dummy/product-projections/search?' +
+        qs.stringify({
+          filter: ['masterVariant.sku:"1337"'],
+          limit: 50,
+          offset: 100,
+        })
+    )
+
+    const projection: ProductProjection = response.body
+    expect(projection).toEqual({
+      count: 1,
+      limit: 50,
+      offset: 100,
+      total: 0,
+      results: [],
+    })
+  })
+
+  test('Search product projection with query.filter', async () => {
+    const response = await supertest(ctMock.app).get(
+      '/dummy/product-projections/search?' +
+        qs.stringify({
+          'query.filter': ['masterVariant.sku:"1337"'],
+        })
+    )
+
+    const projection: ProductProjection = response.body
+    expect(projection).toMatchObject({
+      count: 1,
+      results: [{ masterVariant: { id: 1, sku: '1337' } }],
+    })
+  })
+
+  test('Search product projection without filter', async () => {
+    const response = await supertest(ctMock.app).get(
+      '/dummy/product-projections/search'
+    )
+
+    const projection: ProductProjection = response.body
+    expect(projection).toMatchObject({
+      count: 1,
+      results: [{ masterVariant: { id: 1, sku: '1337' } }],
+    })
+  })
 })

package/src/storage.ts

@@ -211,8 +211,14 @@ export class InMemoryStorage extends AbstractStorage {
 
     const resources: any[] = Array.from(store.values())
     const resource = resources.find(e => e.key === key)
-    if (params.expand) return this.expand(projectKey, resource, params.expand)
-    return resource
+    if (resource) {
+      return this.expand(
+        projectKey,
+        resource,
+        params.expand
+      ) as ResourceMap[RepositoryTypes]
+    }
+    return null
   }
 
   delete(