@kyo-so/cli 0.15.2 → 0.16.1

package/dist/index.js

@@ -184081,6 +184081,7 @@ function agentConfigLeafPaths(agent) {
     `agents.${agent}.effort`,
     `agents.${agent}.role`,
     `agents.${agent}.timeoutMs`,
+    `agents.${agent}.timeoutS`,
     `agents.${agent}.env`,
     `agents.${agent}.auth.mode`,
     `agents.${agent}.auth.preferExistingLogin`,
@@ -184089,7 +184090,7 @@ function agentConfigLeafPaths(agent) {
     `agents.${agent}.auth.envWhitelist`
   ];
   if (agent === "codex") {
-    paths.push("agents.codex.provider", "agents.codex.allowProjectProvider", "agents.codex.openRouter.streamIdleTimeoutMs", "agents.codex.openRouter.streamMaxRetries", "agents.codex.openRouter.requestMaxRetries");
+    paths.push("agents.codex.provider", "agents.codex.allowProjectProvider", "agents.codex.openRouter.streamIdleTimeoutMs", "agents.codex.openRouter.streamIdleTimeoutS", "agents.codex.openRouter.streamMaxRetries", "agents.codex.openRouter.requestMaxRetries");
   }
   return paths;
 }
@@ -184126,12 +184127,15 @@ var kyosoConfigKnownLeafPaths = [
   "judge.mode",
   "judge.provider",
   "judge.timeoutMs",
+  "judge.timeoutS",
   "verification.enabled",
   "verification.maxFindings",
   "verification.timeoutMs",
+  "verification.timeoutS",
   "verification.allowDemotion",
   "reviewBudget.maxModelCalls",
   "reviewBudget.maxTotalWallTimeMs",
+  "reviewBudget.maxTotalWallTimeS",
   "reviewBudget.warnAgentOutputBytes",
   "reviewBudget.maxAgentOutputBytes",
   "reviewBudget.maxFindingsPerAgent",
@@ -184203,7 +184207,7 @@ var defaultConfig = {
       enabled: true,
       type: "acp",
       command: "npx",
-      args: ["-y", "@agentclientprotocol/claude-agent-acp@0.61.0"],
+      args: ["-y", "@agentclientprotocol/claude-agent-acp@0.62.0"],
       role: "architecture_security_reviewer",
       timeoutMs: DEFAULT_AGENT_TIMEOUT_MS,
       env: {
@@ -184321,22 +184325,27 @@ var kyosoConfigOverridePaths = [
   "agents.codex.model",
   "agents.codex.provider",
   "agents.codex.openRouter.streamIdleTimeoutMs",
+  "agents.codex.openRouter.streamIdleTimeoutS",
   "agents.codex.openRouter.streamMaxRetries",
   "agents.codex.openRouter.requestMaxRetries",
   "agents.codex.effort",
   "agents.codex.role",
   "agents.codex.timeoutMs",
+  "agents.codex.timeoutS",
   "agents.claude.enabled",
   "agents.claude.model",
   "agents.claude.effort",
   "agents.claude.role",
   "agents.claude.timeoutMs",
+  "agents.claude.timeoutS",
   "verification.enabled",
   "verification.maxFindings",
   "verification.timeoutMs",
+  "verification.timeoutS",
   "judge.mode",
   "judge.provider",
-  "judge.timeoutMs"
+  "judge.timeoutMs",
+  "judge.timeoutS"
 ];
 var CONFIG_OVERRIDE_PATHS = new Set(kyosoConfigOverridePaths);
 function isAllowedConfigOverridePath(path) {
@@ -185573,6 +185582,146 @@ function isMissingPathError(error51) {
   return typeof error51 === "object" && error51 !== null && "code" in error51 && error51.code === "ENOENT";
 }
 
+// src/utils/timeUnits.ts
+class TimeUnitValidationError extends Error {
+  field;
+  constructor(field, message) {
+    super(`${field} ${message}`);
+    this.name = "TimeUnitValidationError";
+    this.field = field;
+  }
+}
+function validateMilliseconds(value, field, constraints = {}) {
+  assertFiniteNumber(value, field);
+  if (!Number.isSafeInteger(value)) {
+    throw new TimeUnitValidationError(field, "must be a safe integer number of milliseconds.");
+  }
+  assertMinimumMilliseconds(value, field, constraints);
+  return value;
+}
+function secondsToMilliseconds(value, field, constraints = {}) {
+  assertFiniteNumber(value, field);
+  const milliseconds = value * 1000;
+  if (!Number.isSafeInteger(milliseconds)) {
+    throw new TimeUnitValidationError(field, "must convert to a safe integer number of milliseconds.");
+  }
+  assertMinimumMilliseconds(milliseconds, field, constraints);
+  return milliseconds;
+}
+function resolveTimeUnitPair(input, fields, constraints = {}) {
+  const hasMilliseconds = input.milliseconds !== undefined;
+  const hasSeconds = input.seconds !== undefined;
+  if (!hasMilliseconds && !hasSeconds)
+    return;
+  const milliseconds = hasMilliseconds ? validateMilliseconds(input.milliseconds, fields.milliseconds, constraints) : undefined;
+  const secondsMilliseconds = hasSeconds ? secondsToMilliseconds(input.seconds, fields.seconds, constraints) : undefined;
+  if (secondsMilliseconds !== undefined) {
+    return {
+      milliseconds: secondsMilliseconds,
+      source: "seconds",
+      sourceField: fields.seconds
+    };
+  }
+  return {
+    milliseconds,
+    source: "milliseconds",
+    sourceField: fields.milliseconds
+  };
+}
+function assertFiniteNumber(value, field) {
+  if (typeof value !== "number" || !Number.isFinite(value)) {
+    throw new TimeUnitValidationError(field, "must be a finite number.");
+  }
+}
+function assertMinimumMilliseconds(value, field, constraints) {
+  if (constraints.allowZero && value === 0)
+    return;
+  const minimumMilliseconds = constraints.minimumMilliseconds ?? 1;
+  if (value < minimumMilliseconds) {
+    throw new TimeUnitValidationError(field, `must be at least ${minimumMilliseconds} milliseconds.`);
+  }
+}
+
+// src/config/timeUnits.ts
+var configTimeUnitPairs = [
+  {
+    parentPath: ["agents", "codex"],
+    millisecondsKey: "timeoutMs",
+    secondsKey: "timeoutS"
+  },
+  {
+    parentPath: ["agents", "claude"],
+    millisecondsKey: "timeoutMs",
+    secondsKey: "timeoutS"
+  },
+  {
+    parentPath: ["agents", "codex", "openRouter"],
+    millisecondsKey: "streamIdleTimeoutMs",
+    secondsKey: "streamIdleTimeoutS",
+    constraints: { minimumMilliseconds: 1000 }
+  },
+  {
+    parentPath: ["judge"],
+    millisecondsKey: "timeoutMs",
+    secondsKey: "timeoutS"
+  },
+  {
+    parentPath: ["verification"],
+    millisecondsKey: "timeoutMs",
+    secondsKey: "timeoutS"
+  },
+  {
+    parentPath: ["reviewBudget"],
+    millisecondsKey: "maxTotalWallTimeMs",
+    secondsKey: "maxTotalWallTimeS"
+  }
+];
+function normalizeConfigTimeUnits(input) {
+  let normalized = input;
+  for (const pair of configTimeUnitPairs) {
+    normalized = updateRecordAtPath(normalized, pair.parentPath, (parent) => normalizePair(parent, pair));
+  }
+  return normalized;
+}
+function normalizePair(parent, pair) {
+  const hasSecondsProperty = Object.hasOwn(parent, pair.secondsKey);
+  if (!hasSecondsProperty)
+    return parent;
+  const normalized = { ...parent };
+  if (parent[pair.secondsKey] === undefined) {
+    delete normalized[pair.secondsKey];
+    return normalized;
+  }
+  const parentPath = pair.parentPath.join(".");
+  const resolved = resolveTimeUnitPair({
+    milliseconds: parent[pair.millisecondsKey],
+    seconds: parent[pair.secondsKey]
+  }, {
+    milliseconds: `${parentPath}.${pair.millisecondsKey}`,
+    seconds: `${parentPath}.${pair.secondsKey}`
+  }, pair.constraints);
+  if (resolved)
+    normalized[pair.millisecondsKey] = resolved.milliseconds;
+  delete normalized[pair.secondsKey];
+  return normalized;
+}
+function updateRecordAtPath(input, path, update) {
+  if (path.length === 0) {
+    return isRecord3(input) ? update(input) : input;
+  }
+  if (!isRecord3(input))
+    return input;
+  const [key, ...rest] = path;
+  if (key === undefined)
+    return input;
+  const current = input[key];
+  const updated = updateRecordAtPath(current, rest, update);
+  return updated === current ? input : { ...input, [key]: updated };
+}
+function isRecord3(value) {
+  return typeof value === "object" && value !== null && !Array.isArray(value);
+}
+
 // src/config/loadConfig.ts
 var configValidationContexts = new WeakMap;
 class ProjectOpenRouterAuthorizationError extends Error {
@@ -185608,7 +185757,7 @@ async function loadConfig(options = {}) {
   let configTrustStatus = options.ignoreConfig ? "ignored" : "not_found";
   if (!options.ignoreConfig) {
     if (await exists(globalConfigPath)) {
-      const globalConfig2 = await loadTomlConfigFile(globalConfigPath);
+      const globalConfig2 = normalizeConfigTimeUnits(await loadTomlConfigFile(globalConfigPath));
       validateExplicitReviewBudgetThresholds(globalConfig2, defaultConfig);
       const globalConfigWarnings = collectGlobalConfigWarnings(globalConfigPath, globalConfig2);
       const securitySensitiveWarnings = globalConfigWarnings.filter((warning) => warning.startsWith("security-sensitive unknown settings "));
@@ -185735,7 +185884,7 @@ async function loadProjectConfig(input) {
   const { canonicalDirectory, canonicalPath, requestedPath } = input.projectConfig;
   const extension = extname2(requestedPath);
   if (extension === ".toml") {
-    const projectTomlConfig = await loadTomlConfigFile(canonicalPath);
+    const projectTomlConfig = normalizeConfigTimeUnits(await loadTomlConfigFile(canonicalPath));
     const projectChangesOpenRouterPolicy = projectConfigChangesOpenRouterPolicy(projectTomlConfig, input.baseConfig);
     await assertProjectOpenRouterAuthorization({
       projectConfig: projectTomlConfig,
@@ -185781,7 +185930,7 @@ function configSelectsOpenRouter(config2) {
   return flattenLeaves(config2).some((leaf) => leaf.path.join(".") === "agents.codex.provider" && leaf.value === CODEX_OPENROUTER_PROVIDER);
 }
 function applyProjectCodexProviderReset(baseConfig, projectConfig, mergedConfig) {
-  if (!projectConfigSelectsDefaultProvider(projectConfig) || !configSelectsOpenRouter(baseConfig) || !isRecord3(mergedConfig) || !isRecord3(mergedConfig.agents) || !isRecord3(mergedConfig.agents.codex)) {
+  if (!projectConfigSelectsDefaultProvider(projectConfig) || !configSelectsOpenRouter(baseConfig) || !isRecord4(mergedConfig) || !isRecord4(mergedConfig.agents) || !isRecord4(mergedConfig.agents.codex)) {
     return mergedConfig;
   }
   const shouldClearInheritedModel = !projectConfigSuppliesCodexModel(projectConfig);
@@ -185813,13 +185962,13 @@ async function assertProjectOpenRouterAuthorization(input) {
   });
 }
 async function projectProviderIsAuthorized(config2, projectDirectory) {
-  if (!isRecord3(config2))
+  if (!isRecord4(config2))
     return false;
   const agents = config2.agents;
-  if (!isRecord3(agents))
+  if (!isRecord4(agents))
     return false;
   const codex = agents.codex;
-  if (!isRecord3(codex) || !Array.isArray(codex.allowProjectProvider)) {
+  if (!isRecord4(codex) || !Array.isArray(codex.allowProjectProvider)) {
     return false;
   }
   for (const directory of codex.allowProjectProvider) {
@@ -185862,7 +186011,7 @@ async function loadProjectTsConfig(input) {
     options: input.options
   });
   if (trustDecision.execute) {
-    const userConfig = await loadUserConfig(canonicalPath, source);
+    const userConfig = normalizeConfigTimeUnits(await loadUserConfig(canonicalPath, source));
     validateExplicitReviewBudgetThresholds(userConfig, input.baseConfig);
     const projectChangesOpenRouterPolicy = projectConfigChangesOpenRouterPolicy(userConfig, input.baseConfig);
     await assertProjectOpenRouterAuthorization({
@@ -185949,7 +186098,7 @@ async function promptForConfigTrust(configPath, configHash) {
   }
 }
 function deepMerge2(base, override) {
-  if (!isRecord3(base) || !isRecord3(override))
+  if (!isRecord4(base) || !isRecord4(override))
     return override ?? base;
   const result = { ...base };
   for (const [key, value] of Object.entries(override)) {
@@ -185969,12 +186118,12 @@ function validateExplicitReviewBudgetThresholds(config2, baseConfig) {
   }
 }
 function readRecord(value, key) {
-  if (!isRecord3(value))
+  if (!isRecord4(value))
     return;
   const nested = value[key];
-  return isRecord3(nested) ? nested : undefined;
+  return isRecord4(nested) ? nested : undefined;
 }
-function isRecord3(value) {
+function isRecord4(value) {
   return typeof value === "object" && value !== null && !Array.isArray(value);
 }
 async function exists(path) {
@@ -185989,9 +186138,14 @@ async function exists(path) {
 // src/config/configOverrides.ts
 var NUMBER_VALUE = /^[+-]?(?:\d+(?:\.\d*)?|\.\d+)(?:e[+-]?\d+)?$/i;
 var UNSET_NUMBER_OVERRIDE_PATHS = new Set([
+  "agents.codex.timeoutS",
+  "agents.claude.timeoutS",
   "agents.codex.openRouter.streamIdleTimeoutMs",
+  "agents.codex.openRouter.streamIdleTimeoutS",
   "agents.codex.openRouter.streamMaxRetries",
-  "agents.codex.openRouter.requestMaxRetries"
+  "agents.codex.openRouter.requestMaxRetries",
+  "judge.timeoutS",
+  "verification.timeoutS"
 ]);
 function applyConfigOverrides(config2, assignments) {
   if (assignments.length === 0)
@@ -186002,9 +186156,21 @@ function applyConfigOverrides(config2, assignments) {
   for (const override of overrides) {
     writePath2(overridden, override.path, parseConfigOverrideValue(override.value, readPath2(baseConfig, override.path), override.path));
   }
-  clearInheritedOpenRouterConfigForProviderReset(baseConfig, overridden, overrides);
-  assertOpenRouterProviderOverrideIncludesModel(baseConfig, overridden, overrides);
-  const parsed = kyosoConfigSchema.safeParse(overridden);
+  let normalized;
+  try {
+    normalized = normalizeConfigTimeUnits(overridden);
+  } catch (error51) {
+    if (!(error51 instanceof TimeUnitValidationError))
+      throw error51;
+    const assignment2 = findAssignmentForPath(overrides, error51.field);
+    if (!assignment2) {
+      throw new Error(`Invalid config time value: ${error51.message}`);
+    }
+    throw new Error(`Invalid --set value ${JSON.stringify(assignment2)}: ${error51.message}`);
+  }
+  clearInheritedOpenRouterConfigForProviderReset(baseConfig, normalized, overrides);
+  assertOpenRouterProviderOverrideIncludesModel(baseConfig, normalized, overrides);
+  const parsed = kyosoConfigSchema.safeParse(normalized);
   if (parsed.success)
     return parsed.data;
   const issue2 = parsed.error.issues[0];
@@ -186034,7 +186200,7 @@ function clearInheritedOpenRouterConfigForProviderReset(baseConfig, overridden,
     return;
   }
   const codex = readPath2(overridden, ["agents", "codex"]);
-  if (!isRecord4(codex))
+  if (!isRecord5(codex))
     return;
   if (!suppliesModel)
     delete codex.model;
@@ -186083,7 +186249,7 @@ function parseConfigOverrideValue(value, currentValue, path) {
 function readPath2(target, path) {
   let current = target;
   for (const key of path) {
-    if (!isRecord4(current))
+    if (!isRecord5(current))
       return;
     current = current[key];
   }
@@ -186093,7 +186259,7 @@ function writePath2(target, path, value) {
   let current = target;
   for (const key of path.slice(0, -1)) {
     const child = current[key];
-    if (!isRecord4(child)) {
+    if (!isRecord5(child)) {
       throw new Error(`Cannot apply --set key ${JSON.stringify(path.join("."))}.`);
     }
     current = child;
@@ -186102,7 +186268,7 @@ function writePath2(target, path, value) {
   if (leaf)
     current[leaf] = value;
 }
-function isRecord4(value) {
+function isRecord5(value) {
   return typeof value === "object" && value !== null && !Array.isArray(value);
 }
 
@@ -188510,17 +188676,17 @@ function isResponseMessage(value) {
 function isNotificationMessage(value) {
   return isJsonRpcEnvelope(value) && !("id" in value) && typeof value["method"] === "string";
 }
-function isRecord5(value) {
+function isRecord6(value) {
   return typeof value === "object" && value !== null;
 }
 function isJsonRpcEnvelope(value) {
-  return isRecord5(value) && value["jsonrpc"] === "2.0";
+  return isRecord6(value) && value["jsonrpc"] === "2.0";
 }
 function isJsonRpcId(value) {
   return value === null || typeof value === "string" || typeof value === "number" && Number.isFinite(value);
 }
 function isResponseShapedMessage(value) {
-  return isRecord5(value) && !("method" in value) && (("id" in value) || ("result" in value) || ("error" in value));
+  return isRecord6(value) && !("method" in value) && (("id" in value) || ("result" in value) || ("error" in value));
 }
 function isResponseBatch(batch) {
   let hasValidCall = false;
@@ -188530,7 +188696,7 @@ function isResponseBatch(batch) {
   for (const entry of batch) {
     hasValidCall ||= isRequestMessage(entry) || isNotificationMessage(entry);
     hasValidResponse ||= isResponseMessage(entry);
-    if (!isRecord5(entry)) {
+    if (!isRecord6(entry)) {
       continue;
     }
     hasCallShape ||= "method" in entry;
@@ -188545,13 +188711,13 @@ function isResponseBatch(batch) {
   return hasResponseShape && !hasCallShape;
 }
 function cancelRequestId(params) {
-  if (!isRecord5(params) || !isJsonRpcId(params["requestId"])) {
+  if (!isRecord6(params) || !isJsonRpcId(params["requestId"])) {
     return;
   }
   return params["requestId"];
 }
 function isErrorResponse(value) {
-  return isRecord5(value) && typeof value["code"] === "number" && Number.isInteger(value["code"]) && typeof value["message"] === "string";
+  return isRecord6(value) && typeof value["code"] === "number" && Number.isInteger(value["code"]) && typeof value["message"] === "string";
 }
 var Handled = {
   yes() {
@@ -188946,7 +189112,7 @@ class Connection {
       this.receiveBatch(message);
       return;
     }
-    if (!isRecord5(message)) {
+    if (!isRecord6(message)) {
       console.error("Invalid message", { message });
       return;
     }
@@ -189007,7 +189173,7 @@ class Connection {
     if (this.abortController.signal.aborted) {
       return Promise.resolve();
     }
-    if (!isRecord5(message)) {
+    if (!isRecord6(message)) {
       console.error("Invalid message", { message });
       return Promise.resolve();
     }
@@ -189314,7 +189480,7 @@ function ndJsonStream(output, input) {
         if (trimmedLine) {
           try {
             const message = JSON.parse(trimmedLine);
-            if (isRecord5(message) || Array.isArray(message)) {
+            if (isRecord6(message) || Array.isArray(message)) {
               controller.enqueue(message);
             } else {
               console.warn("Skipping JSON line that is not an object:", trimmedLine);
@@ -190264,7 +190430,7 @@ function createModelExecutionIdentity(input) {
   };
 }
 function normalizeModelExecutionIdentity(value) {
-  if (!isRecord6(value) || !isModelProviderRoute(value.providerRoute)) {
+  if (!isRecord7(value) || !isModelProviderRoute(value.providerRoute)) {
     return;
   }
   return createModelExecutionIdentity({
@@ -190286,7 +190452,7 @@ function sanitizeIdentityValue(value) {
 function isModelProviderRoute(value) {
   return typeof value === "string" && MODEL_PROVIDER_ROUTES.has(value);
 }
-function isRecord6(value) {
+function isRecord7(value) {
   return value !== null && typeof value === "object" && !Array.isArray(value);
 }
 
@@ -190300,7 +190466,7 @@ var TOKEN_USAGE_KEYS = [
   "cachedWriteTokens"
 ];
 function normalizeModelTokenUsage(usage) {
-  if (!isRecord7(usage))
+  if (!isRecord8(usage))
     return;
   const normalized = {};
   for (const key of TOKEN_USAGE_KEYS) {
@@ -190313,7 +190479,7 @@ function normalizeModelTokenUsage(usage) {
 function isTokenCount(value) {
   return typeof value === "number" && Number.isSafeInteger(value) && value >= 0;
 }
-function isRecord7(value) {
+function isRecord8(value) {
   return typeof value === "object" && value !== null && !Array.isArray(value);
 }
 
@@ -190704,12 +190870,12 @@ class AgentOutputAccumulator {
 var RETRY_ATTEMPT_PATTERN = /Reconnecting\.\.\.\s*(\d+)\/(\d+)/;
 var DISPLAY_MESSAGE_FIELDS = ["title", "text", "message", "description"];
 function parseCodexRetryUpdate(update) {
-  if (!isRecord8(update) || update.sessionUpdate !== "session_info_update") {
+  if (!isRecord9(update) || update.sessionUpdate !== "session_info_update") {
     return;
   }
-  const meta3 = isRecord8(update._meta) ? update._meta : undefined;
-  const codex = meta3 && isRecord8(meta3.codex) ? meta3.codex : undefined;
-  const error51 = codex && isRecord8(codex.error) ? codex.error : undefined;
+  const meta3 = isRecord9(update._meta) ? update._meta : undefined;
+  const codex = meta3 && isRecord9(meta3.codex) ? meta3.codex : undefined;
+  const error51 = codex && isRecord9(codex.error) ? codex.error : undefined;
   if (error51?.willRetry !== true)
     return;
   const rawMessage = typeof error51.message === "string" ? error51.message : findDisplayMessage(update) ?? "model stream retry";
@@ -190729,7 +190895,7 @@ function findDisplayMessage(update) {
   }
   return;
 }
-function isRecord8(value) {
+function isRecord9(value) {
   return value !== null && typeof value === "object" && !Array.isArray(value);
 }
 
@@ -191214,7 +191380,7 @@ function isSeverity(value) {
   return typeof value === "string" && severities.includes(value);
 }
 function normalizeCisaSecureByDesign(value) {
-  if (!isRecord9(value))
+  if (!isRecord10(value))
     return;
   const normalized = {};
   const customerSecurityOutcomes = normalizeGateStatus(value.customerSecurityOutcomes);
@@ -191255,7 +191421,7 @@ function isEvidenceQuality(value) {
   return typeof value === "string" && evidenceQualities.includes(value);
 }
 function isStrictAgentOpinion(value) {
-  if (!isRecord9(value) || !hasOnlyKeys(value, STRICT_ROOT_KEYS))
+  if (!isRecord10(value) || !hasOnlyKeys(value, STRICT_ROOT_KEYS))
     return false;
   if (typeof value.summary !== "string")
     return false;
@@ -191265,7 +191431,7 @@ function isStrictAgentOpinion(value) {
   return value.cisaSecureByDesign === undefined || isStrictCisaSecureByDesign(value.cisaSecureByDesign);
 }
 function isStrictFinding(value) {
-  if (!isRecord9(value) || !hasOnlyKeys(value, STRICT_FINDING_KEYS)) {
+  if (!isRecord10(value) || !hasOnlyKeys(value, STRICT_FINDING_KEYS)) {
     return false;
   }
   if (!isSeverity(value.severity) || !isCategory(value.category) || !isNonEmptyString(value.title) || !isNonEmptyString(value.evidence) || !isNonEmptyString(value.recommendation) || !isConfidence(value.confidence)) {
@@ -191277,11 +191443,11 @@ function isStrictFinding(value) {
   return true;
 }
 function isStrictFindingFiles(value) {
-  return Array.isArray(value) && value.every((item) => isRecord9(item) && hasOnlyKeys(item, STRICT_FILE_KEYS) && isNonEmptyString(item.path) && isOptionalLineNumber(item.lineStart) && isOptionalLineNumber(item.lineEnd));
+  return Array.isArray(value) && value.every((item) => isRecord10(item) && hasOnlyKeys(item, STRICT_FILE_KEYS) && isNonEmptyString(item.path) && isOptionalLineNumber(item.lineStart) && isOptionalLineNumber(item.lineEnd));
 }
 function isStrictEvidenceRefs(value) {
   return Array.isArray(value) && value.length <= MAX_EVIDENCE_REFS2 && value.every((item) => {
-    if (!isRecord9(item) || !hasOnlyKeys(item, STRICT_EVIDENCE_REF_KEYS)) {
+    if (!isRecord10(item) || !hasOnlyKeys(item, STRICT_EVIDENCE_REF_KEYS)) {
       return false;
     }
     if (item.kind !== "file" && item.kind !== "diff_hunk" && item.kind !== "plan_clause") {
@@ -191297,7 +191463,7 @@ function isStrictEvidenceRefs(value) {
   });
 }
 function isStrictCisaSecureByDesign(value) {
-  if (!isRecord9(value) || !hasOnlyKeys(value, STRICT_CISA_KEYS))
+  if (!isRecord10(value) || !hasOnlyKeys(value, STRICT_CISA_KEYS))
     return false;
   for (const key of [
     "customerSecurityOutcomes",
@@ -191336,7 +191502,7 @@ function normalizeFindingFiles(value) {
   if (!Array.isArray(value))
     return;
   const files = value.flatMap((item) => {
-    if (!isRecord9(item) || typeof item.path !== "string" || item.path.trim().length === 0) {
+    if (!isRecord10(item) || typeof item.path !== "string" || item.path.trim().length === 0) {
       return [];
     }
     const file2 = {
@@ -191356,7 +191522,7 @@ function normalizeEvidenceRefs2(value) {
   if (!Array.isArray(value))
     return;
   const references = value.slice(0, MAX_EVIDENCE_REFS2).flatMap((item) => {
-    if (!isRecord9(item) || item.kind !== "file" && item.kind !== "diff_hunk" && item.kind !== "plan_clause") {
+    if (!isRecord10(item) || item.kind !== "file" && item.kind !== "diff_hunk" && item.kind !== "plan_clause") {
       return [];
     }
     const reference = { kind: item.kind };
@@ -191379,7 +191545,7 @@ function normalizeEvidenceRefs2(value) {
 function normalizeLineNumber(value) {
   return typeof value === "number" && Number.isSafeInteger(value) && value > 0 && value <= MAX_EVIDENCE_LINE2 ? value : undefined;
 }
-function isRecord9(value) {
+function isRecord10(value) {
   return typeof value === "object" && value !== null && !Array.isArray(value);
 }
 
@@ -192004,7 +192170,7 @@ function normalizeUsage(usage) {
   return normalizeModelTokenUsage(usage);
 }
 function withReportedExecutionIdentity(identity, metadata) {
-  const record2 = isRecord10(metadata) ? metadata : {};
+  const record2 = isRecord11(metadata) ? metadata : {};
   return createModelExecutionIdentity({
     providerRoute: identity.providerRoute,
     requestedModel: identity.requestedModel,
@@ -192013,9 +192179,9 @@ function withReportedExecutionIdentity(identity, metadata) {
   });
 }
 function readChunkMeta(update) {
-  const record2 = isRecord10(update) ? update : {};
-  const metadata = isRecord10(record2._meta) ? record2._meta : {};
-  const codex = isRecord10(metadata.codex) ? metadata.codex : {};
+  const record2 = isRecord11(update) ? update : {};
+  const metadata = isRecord11(record2._meta) ? record2._meta : {};
+  const codex = isRecord11(metadata.codex) ? metadata.codex : {};
   const phase = codex.phase === "commentary" || codex.phase === "final_answer" ? codex.phase : "unknown";
   return {
     ...typeof record2.messageId === "string" ? { messageId: record2.messageId } : {},
@@ -192023,15 +192189,15 @@ function readChunkMeta(update) {
   };
 }
 function readCodexThreadStatus(update) {
-  const record2 = isRecord10(update) ? update : {};
+  const record2 = isRecord11(update) ? update : {};
   if (record2.sessionUpdate !== "session_info_update")
     return;
-  const metadata = isRecord10(record2._meta) ? record2._meta : {};
-  const codex = isRecord10(metadata.codex) ? metadata.codex : {};
-  const threadStatus = isRecord10(codex.threadStatus) ? codex.threadStatus : {};
+  const metadata = isRecord11(record2._meta) ? record2._meta : {};
+  const codex = isRecord11(metadata.codex) ? metadata.codex : {};
+  const threadStatus = isRecord11(codex.threadStatus) ? codex.threadStatus : {};
   return typeof threadStatus.type === "string" ? threadStatus.type : undefined;
 }
-function isRecord10(value) {
+function isRecord11(value) {
   return value !== null && typeof value === "object" && !Array.isArray(value);
 }
 function resolveEffortConfigOption(agent, effort) {
@@ -193736,7 +193902,7 @@ function validateReviewContract(request) {
   const contract = request.reviewContract;
   if (contract === undefined)
     return;
-  if (!isRecord11(contract)) {
+  if (!isRecord12(contract)) {
     throw new KyosoRequestError("reviewContract must be an object", "VALIDATION_ERROR");
   }
   const allowedKeys = new Set(["focus", "nonGoals", "acceptedRisks"]);
@@ -193753,7 +193919,7 @@ function validateReviewContract(request) {
     throw new KyosoRequestError("reviewContract.nonGoals must contain at most 20 non-empty strings of 500 characters or fewer", "VALIDATION_ERROR");
   }
   const acceptedRisks = contract.acceptedRisks;
-  if (acceptedRisks !== undefined && (!Array.isArray(acceptedRisks) || acceptedRisks.length > 20 || acceptedRisks.some((risk) => !isRecord11(risk) || typeof risk.findingFingerprint !== "string" || !/^sha256:[0-9a-f]{64}$/.test(risk.findingFingerprint) || typeof risk.rationale !== "string" || risk.rationale.trim().length === 0 || risk.rationale.length > 500))) {
+  if (acceptedRisks !== undefined && (!Array.isArray(acceptedRisks) || acceptedRisks.length > 20 || acceptedRisks.some((risk) => !isRecord12(risk) || typeof risk.findingFingerprint !== "string" || !/^sha256:[0-9a-f]{64}$/.test(risk.findingFingerprint) || typeof risk.rationale !== "string" || risk.rationale.trim().length === 0 || risk.rationale.length > 500))) {
     throw new KyosoRequestError("reviewContract.acceptedRisks must contain valid finding fingerprints and bounded rationales", "VALIDATION_ERROR");
   }
 }
@@ -193765,13 +193931,13 @@ function validateSelectedFiles(request) {
     throw new KyosoRequestError("selectedFiles must be an array", "VALIDATION_ERROR");
   }
   for (const file2 of selectedFiles) {
-    if (!isRecord11(file2) || typeof file2.path !== "string" || file2.path.trim().length === 0 || typeof file2.content !== "string" || file2.language !== undefined && typeof file2.language !== "string" || file2.truncated !== undefined && typeof file2.truncated !== "boolean") {
+    if (!isRecord12(file2) || typeof file2.path !== "string" || file2.path.trim().length === 0 || typeof file2.content !== "string" || file2.language !== undefined && typeof file2.language !== "string" || file2.truncated !== undefined && typeof file2.truncated !== "boolean") {
       throw new KyosoRequestError("selectedFiles entries require string path/content and valid optional metadata", "VALIDATION_ERROR");
     }
     normalizeRelativePath(file2.path);
   }
 }
-function isRecord11(value) {
+function isRecord12(value) {
   return typeof value === "object" && value !== null && !Array.isArray(value);
 }
 
@@ -194032,7 +194198,7 @@ function parseJudgeOutput(text, fallbackSummaryText) {
   const parsed = JSON.parse(json2);
   const summaryText = typeof parsed.summaryText === "string" && parsed.summaryText.trim().length > 0 ? sanitizeText(parsed.summaryText) : fallbackSummaryText;
   const disagreementComments = Array.isArray(parsed.disagreementComments) ? parsed.disagreementComments.flatMap((item) => {
-    if (!isRecord12(item) || typeof item.topic !== "string" || typeof item.judgeComment !== "string") {
+    if (!isRecord13(item) || typeof item.topic !== "string" || typeof item.judgeComment !== "string") {
       return [];
     }
     return [
@@ -194048,7 +194214,7 @@ function parseJudgeOutput(text, fallbackSummaryText) {
   return { summaryText, disagreementComments, analysis };
 }
 function parseAnalysis(value) {
-  if (!isRecord12(value))
+  if (!isRecord13(value))
     return;
   if (!Array.isArray(value.blindSpots) || !Array.isArray(value.contradictions) || !Array.isArray(value.partialCoverage)) {
     return;
@@ -194056,7 +194222,7 @@ function parseAnalysis(value) {
   return {
     blindSpots: value.blindSpots.slice(0, ANALYSIS_MAX_ITEMS).flatMap((item) => typeof item === "string" ? [sanitizeAnalysisText(item)] : []),
     contradictions: value.contradictions.slice(0, ANALYSIS_MAX_ITEMS).flatMap((item) => {
-      if (!isRecord12(item) || typeof item.topic !== "string" || typeof item.detail !== "string") {
+      if (!isRecord13(item) || typeof item.topic !== "string" || typeof item.detail !== "string") {
         return [];
       }
       return [
@@ -194067,7 +194233,7 @@ function parseAnalysis(value) {
       ];
     }),
     partialCoverage: value.partialCoverage.slice(0, ANALYSIS_MAX_ITEMS).flatMap((item) => {
-      if (!isRecord12(item) || typeof item.note !== "string")
+      if (!isRecord13(item) || typeof item.note !== "string")
         return [];
       const findingId = typeof item.findingId === "string" ? sanitizeAnalysisText(item.findingId) : undefined;
       return [
@@ -194114,7 +194280,7 @@ function extractFirstJsonObject2(text) {
   }
   return;
 }
-function isRecord12(value) {
+function isRecord13(value) {
   return typeof value === "object" && value !== null && !Array.isArray(value);
 }
 
@@ -194659,11 +194825,11 @@ function canonicalJson(value) {
 function canonicalize(value) {
   if (Array.isArray(value))
     return value.map(canonicalize);
-  if (!isRecord13(value))
+  if (!isRecord14(value))
     return value;
   return Object.fromEntries(Object.entries(value).filter(([, child]) => child !== undefined).sort(([left], [right]) => left < right ? -1 : left > right ? 1 : 0).map(([key, child]) => [key, canonicalize(child)]));
 }
-function isRecord13(value) {
+function isRecord14(value) {
   return typeof value === "object" && value !== null && !Array.isArray(value);
 }
 
@@ -194671,19 +194837,24 @@ function isRecord13(value) {
 var REVIEW_BUDGET_KEYS = new Set([
   "maxModelCalls",
   "maxTotalWallTimeMs",
+  "maxTotalWallTimeS",
   "maxAgentOutputBytes",
   "maxFindingsPerAgent",
   "skipOptionalPhasesWhenTokenUsageUnknown"
 ]);
 var MODEL_CALL_KINDS = ["primary", "verifier", "judge"];
 function resolveReviewBudget(ceiling, requested) {
-  if (requested !== undefined && !isRecord14(requested)) {
+  if (requested !== undefined && !isRecord15(requested)) {
     throw new KyosoRequestError("options.reviewBudget must be an object.", "REVIEW_BUDGET_INVALID");
   }
+  const hasWallTimeSeconds = requested?.maxTotalWallTimeS !== undefined;
   for (const [key, value] of Object.entries(requested ?? {})) {
     if (!REVIEW_BUDGET_KEYS.has(key)) {
       throw new KyosoRequestError(`options.reviewBudget.${key} is not supported.`, "REVIEW_BUDGET_INVALID");
     }
+    if (key === "maxTotalWallTimeS" || key === "maxTotalWallTimeMs" && hasWallTimeSeconds) {
+      continue;
+    }
     if (key === "skipOptionalPhasesWhenTokenUsageUnknown") {
       if (typeof value !== "boolean") {
         throw new KyosoRequestError(`options.reviewBudget.${key} must be a boolean.`, "REVIEW_BUDGET_INVALID");
@@ -194694,12 +194865,26 @@ function resolveReviewBudget(ceiling, requested) {
       throw new KyosoRequestError(`options.reviewBudget.${key} must be a positive integer.`, "REVIEW_BUDGET_INVALID");
     }
   }
-  const numericKeys = [
-    "maxModelCalls",
-    "maxTotalWallTimeMs",
-    "maxAgentOutputBytes",
-    "maxFindingsPerAgent"
-  ];
+  let requestedWallTime;
+  if (hasWallTimeSeconds) {
+    try {
+      requestedWallTime = resolveTimeUnitPair({
+        milliseconds: requested?.maxTotalWallTimeMs,
+        seconds: requested?.maxTotalWallTimeS
+      }, {
+        milliseconds: "options.reviewBudget.maxTotalWallTimeMs",
+        seconds: "options.reviewBudget.maxTotalWallTimeS"
+      });
+    } catch (error51) {
+      if (error51 instanceof TimeUnitValidationError) {
+        throw new KyosoRequestError(error51.message, "REVIEW_BUDGET_INVALID");
+      }
+      throw error51;
+    }
+  }
+  const numericKeys = ["maxModelCalls", "maxAgentOutputBytes", "maxFindingsPerAgent"];
+  if (!hasWallTimeSeconds)
+    numericKeys.push("maxTotalWallTimeMs");
   for (const key of numericKeys) {
     const value = requested?.[key];
     if (value === undefined)
@@ -194708,13 +194893,19 @@ function resolveReviewBudget(ceiling, requested) {
       throw new KyosoRequestError(`options.reviewBudget.${key} cannot exceed the user-global ceiling.`, "REVIEW_BUDGET_EXCEEDS_CEILING");
     }
   }
+  if (hasWallTimeSeconds && requested?.maxTotalWallTimeMs !== undefined && requested.maxTotalWallTimeMs > ceiling.maxTotalWallTimeMs) {
+    throw new KyosoRequestError("options.reviewBudget.maxTotalWallTimeMs cannot exceed the user-global ceiling.", "REVIEW_BUDGET_EXCEEDS_CEILING");
+  }
+  if (requestedWallTime && requestedWallTime.milliseconds > ceiling.maxTotalWallTimeMs) {
+    throw new KyosoRequestError(`${requestedWallTime.sourceField} cannot exceed the user-global ceiling.`, "REVIEW_BUDGET_EXCEEDS_CEILING");
+  }
   if (ceiling.skipOptionalPhasesWhenTokenUsageUnknown && requested?.skipOptionalPhasesWhenTokenUsageUnknown === false) {
     throw new KyosoRequestError("options.reviewBudget.skipOptionalPhasesWhenTokenUsageUnknown cannot relax the user-global ceiling.", "REVIEW_BUDGET_EXCEEDS_CEILING");
   }
   const maxAgentOutputBytes = requested?.maxAgentOutputBytes ?? ceiling.maxAgentOutputBytes;
   return {
     maxModelCalls: requested?.maxModelCalls ?? ceiling.maxModelCalls,
-    maxTotalWallTimeMs: requested?.maxTotalWallTimeMs ?? ceiling.maxTotalWallTimeMs,
+    maxTotalWallTimeMs: requestedWallTime?.milliseconds ?? requested?.maxTotalWallTimeMs ?? ceiling.maxTotalWallTimeMs,
     warnAgentOutputBytes: ceiling.warnAgentOutputBytes,
     maxAgentOutputBytes,
     maxFindingsPerAgent: requested?.maxFindingsPerAgent ?? ceiling.maxFindingsPerAgent,
@@ -195031,10 +195222,63 @@ function emptyReviewModelCallPlan() {
     ceilingEffects: []
   };
 }
-function isRecord14(value) {
+function isRecord15(value) {
   return typeof value === "object" && value !== null && !Array.isArray(value);
 }
 
+// src/core/requestTimeUnits.ts
+function normalizeRequestTimeUnits(request) {
+  if (!request.options)
+    return request;
+  const options = { ...request.options };
+  normalizeRequestTimeUnitField(options, "maxAgentTimeoutMs", "maxAgentTimeoutS", {
+    milliseconds: "options.maxAgentTimeoutMs",
+    seconds: "options.maxAgentTimeoutS"
+  });
+  if (options.reviewBudget) {
+    const reviewBudget = { ...options.reviewBudget };
+    normalizeRequestTimeUnitField(reviewBudget, "maxTotalWallTimeMs", "maxTotalWallTimeS", {
+      milliseconds: "options.reviewBudget.maxTotalWallTimeMs",
+      seconds: "options.reviewBudget.maxTotalWallTimeS"
+    });
+    options.reviewBudget = reviewBudget;
+  }
+  return { ...request, options };
+}
+function resolveProgressHeartbeatMs(input) {
+  if (input.progressHeartbeatS === undefined) {
+    return input.progressHeartbeatMs;
+  }
+  return resolveRequestTimeUnit({
+    milliseconds: input.progressHeartbeatMs,
+    seconds: input.progressHeartbeatS
+  }, {
+    milliseconds: "progressHeartbeatMs",
+    seconds: "progressHeartbeatS"
+  }, { allowZero: true })?.milliseconds;
+}
+function normalizeRequestTimeUnitField(target, millisecondsKey, secondsKey, fields) {
+  if (target[secondsKey] !== undefined) {
+    const resolved = resolveRequestTimeUnit({
+      milliseconds: target[millisecondsKey],
+      seconds: target[secondsKey]
+    }, fields);
+    if (resolved)
+      target[millisecondsKey] = resolved.milliseconds;
+  }
+  delete target[secondsKey];
+}
+function resolveRequestTimeUnit(input, fields, constraints) {
+  try {
+    return resolveTimeUnitPair(input, fields, constraints);
+  } catch (error51) {
+    if (error51 instanceof TimeUnitValidationError) {
+      throw new KyosoRequestError(error51.message, "VALIDATION_ERROR");
+    }
+    throw error51;
+  }
+}
+
 // src/core/verification.ts
 var REAL_AGENTS = ["codex", "claude"];
 var VERIFIABLE_SEVERITIES = new Set(["critical", "high"]);
@@ -195093,7 +195337,7 @@ function parseVerificationVerdicts(rawText) {
     if (!Array.isArray(parsed.verdicts))
       return;
     return parsed.verdicts.flatMap((item) => {
-      if (!isRecord15(item))
+      if (!isRecord16(item))
         return [];
       if (typeof item.findingId !== "string")
         return [];
@@ -195171,7 +195415,7 @@ function verificationNote(reasoning) {
 function isVerdict(value) {
   return value === "confirmed" || value === "refuted" || value === "uncertain";
 }
-function isRecord15(value) {
+function isRecord16(value) {
   return typeof value === "object" && value !== null && !Array.isArray(value);
 }
 
@@ -195179,7 +195423,7 @@ function isRecord15(value) {
 var MAX_AGENT_RETRY_PROGRESS_EVENTS = 100;
 function requestForRecursionFingerprint(request) {
   try {
-    return scanAndRedactSecrets(request).redactedRequest;
+    return scanAndRedactSecrets(normalizeRequestTimeUnits(request)).redactedRequest;
   } catch {
     return { goal: "" };
   }
@@ -195439,15 +195683,17 @@ async function runReview(tool, request, options = {}) {
       });
       validateReviewRequest(tool, request);
       const reviewBudget = resolveReviewBudget(loaded.config.reviewBudget, request.options?.reviewBudget);
-      const budgetTracker = new ReviewBudgetTracker(reviewBudget, startedAtEpochMs, configuredReviewModelCallPlan(loaded.config, reviewBudget, options.env ?? process.env, request.options?.judgeProvider));
-      assertTrustedWorkspaceRoot(request.workspace?.root, loaded.config.workspace.root, cwd);
-      const networkMode = resolveNetworkMode(request.options?.network, loaded.config.network.defaultMode, options.mcpNetworkMode);
+      const normalizedRequest = normalizeRequestTimeUnits(request);
+      const progressHeartbeatMs = resolveProgressHeartbeatMs(options);
+      const budgetTracker = new ReviewBudgetTracker(reviewBudget, startedAtEpochMs, configuredReviewModelCallPlan(loaded.config, reviewBudget, options.env ?? process.env, normalizedRequest.options?.judgeProvider));
+      assertTrustedWorkspaceRoot(normalizedRequest.workspace?.root, loaded.config.workspace.root, cwd);
+      const networkMode = resolveNetworkMode(normalizedRequest.options?.network, loaded.config.network.defaultMode, options.mcpNetworkMode);
       if (networkMode === "unrestricted" && !loaded.config.network.allowUnrestricted) {
         throw new KyosoRequestError("unrestricted network mode is disabled by config", "NETWORK_MODE_DISABLED");
       }
       const disabledPolicy = disabledReviewPolicy(tool, loaded.config, options.entrypoint);
       if (disabledPolicy) {
-        const redactedRequest = requestForRecursionFingerprint(request);
+        const redactedRequest = requestForRecursionFingerprint(normalizedRequest);
         const requestFingerprint2 = createRequestFingerprint({
           tool,
           request: redactedRequest,
@@ -195498,7 +195744,7 @@ async function runReview(tool, request, options = {}) {
         warnings.push("Network mode is unrestricted; write policy remains denied.");
       }
       startPhase("context");
-      const secretScan = scanAndRedactSecrets(request);
+      const secretScan = scanAndRedactSecrets(normalizedRequest);
       await trace.write({
         type: "secret_scan_completed",
         traceId,
@@ -195506,7 +195752,7 @@ async function runReview(tool, request, options = {}) {
         redactions: secretScan.redactions,
         timestamp: new Date().toISOString()
       });
-      const allowSecretOverride = loaded.config.secrets.allowOverride && request.options?.allowSecretRedaction === true;
+      const allowSecretOverride = loaded.config.secrets.allowOverride && normalizedRequest.options?.allowSecretRedaction === true;
       if (secretScan.detected && loaded.config.secrets.blockOnDetectedSecret && !allowSecretOverride) {
         const requestFingerprint2 = createRequestFingerprint({
           tool,
@@ -195593,7 +195839,7 @@ async function runReview(tool, request, options = {}) {
         budgetTracker,
         progressDispatcher: dispatcher,
         signal: options.signal,
-        progressHeartbeatMs: options.progressHeartbeatMs
+        progressHeartbeatMs
       });
       completePhase("primary");
       warnings.push(...agentResults.flatMap((result) => (result.warnings ?? []).map((warning) => `Agent ${result.agent} ${warning}`)));