@kynver-app/runtime 0.1.48 → 0.1.49

package/dist/cli.js

@@ -1906,7 +1906,7 @@ function inferModelRoutingFromTask(task) {
       rule: "lane:landing"
     };
   }
-  if (ref.includes("review") || title.startsWith("review ") || roleLane.includes("review")) {
+  if (ref.includes("review") || /^review[\s:]/.test(title) || roleLane.includes("review")) {
     if (isOpusLane(ref, title) || roleLane === "deep_reviewer") {
       return { model: "claude-opus-4-7", provider: "claude", rule: "lane:deep_review" };
     }
@@ -2369,6 +2369,11 @@ function isHarnessExpertReviewWorker(worker) {
 
 // src/pr-handoff/pr-handoff-assess.ts
 var REVIEW_LANE_RULE = /^(lane:)?(review|deep_review|planning|landing)(:|$)/i;
+var REVIEW_PERSONA_SLUGS = /* @__PURE__ */ new Set(["lorentz", "sentinel"]);
+var NO_PR_COMMITS_BETWEEN_RE = /no commits between/i;
+function isGhNoCommitsBetweenError(detail) {
+  return Boolean(detail && NO_PR_COMMITS_BETWEEN_RE.test(detail));
+}
 function trimOrNull4(value) {
   if (typeof value !== "string") return null;
   const trimmed = value.trim();
@@ -2387,8 +2392,30 @@ function extractPrUrlFromText(value) {
   );
   return m ? trimOrNull4(m[0]) : null;
 }
-function hasWorkProduct(snapshot) {
+function countCommitsAheadOfBase(worktreePath, baseRef, exec) {
+  const base = baseRef.trim();
+  if (!base) return null;
+  const count = exec.git(worktreePath, ["rev-list", "--count", `${base}..HEAD`]);
+  if (count.status !== 0) return null;
+  const n = Number.parseInt(count.stdout.trim(), 10);
+  return Number.isFinite(n) ? n : null;
+}
+function isReviewArtifactWorker(worker, snapshot) {
+  if (snapshot.changedFiles.length > 0) return false;
+  const persona = trimOrNull4(worker.personaSlug)?.toLowerCase();
+  if (persona && REVIEW_PERSONA_SLUGS.has(persona)) return true;
+  const rule = trimOrNull4(worker.routingRule) ?? "";
+  if (rule && REVIEW_LANE_RULE.test(rule)) return true;
+  return false;
+}
+function hasWorkProduct(snapshot, options) {
   if (snapshot.changedFiles.length > 0) return true;
+  const baseRef = trimOrNull4(options?.baseRef);
+  if (baseRef && options?.exec && options.worktreePath) {
+    const ahead = countCommitsAheadOfBase(options.worktreePath, baseRef, options.exec);
+    if (ahead === 0) return false;
+    if (ahead !== null && ahead > 0) return true;
+  }
   if (trimOrNull4(snapshot.headCommit)) return true;
   if (committedHead(snapshot.gitAncestry)) return true;
   return false;
@@ -2409,6 +2436,13 @@ function assessPrHandoffRequirement(input) {
   if (rule && REVIEW_LANE_RULE.test(rule)) {
     return { required: false, reason: "review_lane" };
   }
+  const workerCtx = input.worker ?? {
+    personaSlug: input.personaSlug,
+    routingRule: input.routingRule
+  };
+  if (isReviewArtifactWorker(workerCtx, input.snapshot)) {
+    return { required: false, reason: "review_artifact" };
+  }
   if (trimOrNull4(input.patchPath) || trimOrNull4(input.artifactBundlePath)) {
     return { required: false, reason: "patch_or_bundle" };
   }
@@ -2416,7 +2450,12 @@ function assessPrHandoffRequirement(input) {
   if (prUrl) {
     return { required: false, reason: "already_has_pr" };
   }
-  if (!hasWorkProduct(input.snapshot)) {
+  const workProductOpts = input.exec && input.baseRef ? {
+    baseRef: input.baseRef,
+    exec: input.exec,
+    worktreePath: input.snapshot.worktreePath
+  } : void 0;
+  if (!hasWorkProduct(input.snapshot, workProductOpts)) {
     return { required: false, reason: "no_work_product" };
   }
   return { required: true, snapshot: input.snapshot };
@@ -2625,15 +2664,19 @@ function ensurePrReadyHandoff(input, exec = defaultPrHandoffExec) {
     prUrl: prUrlHint,
     headCommit: null
   });
+  const baseRef = input.run.baseCommit?.trim() || input.run.base?.trim() || "origin/main";
   const requirement = assessPrHandoffRequirement({
     dispatched: input.worker.dispatched,
     routingRule: input.worker.routingRule,
+    personaSlug: input.worker.personaSlug,
     prUrl: prUrlHint,
     taskTitle: input.worker.taskTitle,
     executorRef: input.worker.executorRef,
     parentTaskId: input.worker.parentTaskId,
-    personaSlug: input.worker.personaSlug,
     taskPrUrl: input.worker.taskPrUrl,
+    baseRef,
+    exec,
+    worker: input.worker,
     snapshot
   });
   if (!requirement.required) {
@@ -2718,6 +2761,14 @@ function ensurePrReadyHandoff(input, exec = defaultPrHandoffExec) {
     exec
   });
   if (!pr.ok || !pr.prUrl) {
+    if (isGhNoCommitsBetweenError(pr.detail)) {
+      return {
+        ok: true,
+        headCommit: headCommit ?? void 0,
+        committed,
+        pushed
+      };
+    }
     const dirty = snapshot.changedFiles.length;
     const detail = dirty ? `${dirty} uncommitted change(s) and no PR URL after handoff attempt` : "no PR URL after handoff attempt";
     return {
@@ -6586,7 +6637,12 @@ var defaultRuntimeTakeoverProbes = {
     openclawCronSecret: Boolean(process.env.OPENCLAW_CRON_SECRET?.trim()),
     kynverHarnessRoot: process.env.KYNVER_HARNESS_ROOT?.trim() || void 0,
     opusHarnessRoot: process.env.OPUS_HARNESS_ROOT?.trim() || void 0,
-    kynverSchedulerProvider: process.env.KYNVER_SCHEDULER_PROVIDER?.trim() || void 0
+    kynverSchedulerProvider: process.env.KYNVER_SCHEDULER_PROVIDER?.trim() || void 0,
+    qstashTokenPresent: Boolean(process.env.QSTASH_TOKEN?.trim()),
+    kynverHostedDeployment: (() => {
+      const v = process.env.KYNVER_HOSTED_DEPLOYMENT?.trim().toLowerCase();
+      return v === "1" || v === "true" || v === "yes";
+    })()
   }),
   harnessRoot: () => resolveHarnessRoot(),
   legacyOpenclawHarnessRoot: () => path36.join(homedir6(), ".openclaw", "harness"),
@@ -6596,10 +6652,76 @@ var defaultRuntimeTakeoverProbes = {
   vercelWhoami: () => captureCommand("vercel", ["whoami"])
 };
 
-// src/doctor/runtime-takeover.ts
+// src/doctor/runtime-takeover-scheduler.ts
 function check(partial) {
   return partial;
 }
+function assessRuntimeTakeoverScheduler(env, ctx) {
+  const runnerOpenclaw = env.kynverSchedulerProvider === "openclaw-cron";
+  const runnerQstash = env.kynverSchedulerProvider === "qstash";
+  const hostedDeployment = Boolean(env.qstashTokenPresent) || Boolean(env.kynverHostedDeployment);
+  const daemonDispatchReady = Boolean(ctx.agentOsId?.trim()) && Boolean(ctx.apiBaseUrl?.trim()) && ctx.hasScopedRunnerToken;
+  const deploymentNeedsQstash = hostedDeployment && !env.qstashTokenPresent && env.kynverSchedulerProvider !== "qstash";
+  const deploymentOpenclaw = hostedDeployment && env.kynverSchedulerProvider === "openclaw-cron";
+  if (runnerOpenclaw) {
+    return check({
+      id: "hotspot_openclaw_scheduler",
+      label: "Scheduler provider (runtime daemon vs OpenClaw cron)",
+      status: "warn",
+      summary: "KYNVER_SCHEDULER_PROVIDER=openclaw-cron on this runner \u2014 hosted dispatch still depends on the OpenClaw local-cron adapter",
+      remediation: "Unset KYNVER_SCHEDULER_PROVIDER on user runners. Use `kynver daemon` (pipeline-tick \u2192 operator/tick). On the Kynver server set KYNVER_SCHEDULER_PROVIDER=qstash when QStash is configured.",
+      details: { schedulerProvider: env.kynverSchedulerProvider ?? null, hostedDeployment }
+    });
+  }
+  if (deploymentOpenclaw || deploymentNeedsQstash) {
+    return check({
+      id: "hotspot_openclaw_scheduler",
+      label: "Scheduler provider (runtime daemon vs OpenClaw cron)",
+      status: "warn",
+      summary: deploymentOpenclaw ? "Hosted deployment has KYNVER_SCHEDULER_PROVIDER=openclaw-cron \u2014 AgentOS scheduled ticks should use QStash" : "Hosted deployment without QSTASH_TOKEN \u2014 scheduler may fall back to openclaw-cron",
+      remediation: "Set QSTASH_TOKEN and KYNVER_SCHEDULER_PROVIDER=qstash on the Kynver server. User runners use `kynver daemon` for dispatch and should not set a scheduler provider.",
+      details: {
+        schedulerProvider: env.kynverSchedulerProvider ?? null,
+        qstashTokenPresent: env.qstashTokenPresent ?? false,
+        hostedDeployment
+      }
+    });
+  }
+  if (daemonDispatchReady) {
+    return check({
+      id: "hotspot_openclaw_scheduler",
+      label: "Scheduler provider (runtime daemon vs OpenClaw cron)",
+      status: "pass",
+      summary: runnerQstash ? "Runner override qstash present; hosted dispatch still owned by kynver daemon pipeline-tick" : "Hosted dispatch owned by kynver daemon (pipeline-tick \u2192 operator/tick); no OpenClaw cron on runner",
+      details: {
+        schedulerProvider: env.kynverSchedulerProvider ?? null,
+        dispatchPath: "kynver-daemon-pipeline-tick",
+        hostedDeployment
+      }
+    });
+  }
+  if (!env.kynverSchedulerProvider) {
+    return check({
+      id: "hotspot_openclaw_scheduler",
+      label: "Scheduler provider (runtime daemon vs OpenClaw cron)",
+      status: "pass",
+      summary: "No KYNVER_SCHEDULER_PROVIDER on runner (expected) \u2014 finish runner setup so daemon pipeline-tick owns dispatch",
+      details: { schedulerProvider: null, dispatchPath: "kynver-daemon-pipeline-tick-pending" }
+    });
+  }
+  return check({
+    id: "hotspot_openclaw_scheduler",
+    label: "Scheduler provider (runtime daemon vs OpenClaw cron)",
+    status: "pass",
+    summary: `KYNVER_SCHEDULER_PROVIDER=${env.kynverSchedulerProvider}`,
+    details: { schedulerProvider: env.kynverSchedulerProvider ?? null }
+  });
+}
+
+// src/doctor/runtime-takeover.ts
+function check2(partial) {
+  return partial;
+}
 function summarizeCounts(sections) {
   const counts = { pass: 0, warn: 0, fail: 0 };
   for (const section of sections) {
@@ -6616,14 +6738,14 @@ function assessCliPackage(probes) {
   const firstPath = onPath ? which.stdout.split(/\r?\n/)[0]?.trim() : void 0;
   const displayCliPath = firstPath ? displayUserPath(firstPath) : void 0;
   const checks = [
-    check({
+    check2({
       id: "cli_running_version",
       label: "Running @kynver-app/runtime version",
       status: "pass",
       summary: `@kynver-app/runtime ${runningVersion}`,
       details: { version: runningVersion }
     }),
-    check({
+    check2({
       id: "cli_on_path",
       label: "kynver executable on PATH",
       status: onPath ? "pass" : "warn",
@@ -6637,7 +6759,7 @@ function assessCliPackage(probes) {
     const installedVersion = versionProbe.stdout.replace(/^kynver\s+/i, "").trim() || void 0;
     const versionMatch = versionProbe.ok && (!installedVersion || installedVersion === runningVersion);
     checks.push(
-      check({
+      check2({
         id: "cli_installed_version",
         label: "Installed kynver CLI version matches running package",
         status: versionMatch ? "pass" : "warn",
@@ -6655,7 +6777,7 @@ function assessUserConfig(probes) {
   const exists = probes.pathExists(configPath);
   const config = probes.loadConfig();
   const checks = [
-    check({
+    check2({
       id: "config_file",
       label: "~/.kynver/config.json present",
       status: exists ? "pass" : "fail",
@@ -6670,7 +6792,7 @@ function assessUserConfig(probes) {
     const defaultRepo = config.defaultRepo?.trim();
     const displayDefaultRepo = defaultRepo ? displayUserPath(defaultRepo) : null;
     checks.push(
-      check({
+      check2({
         id: "config_api_base_url",
         label: "Default API base URL",
         status: apiBaseUrl ? "pass" : "warn",
@@ -6678,7 +6800,7 @@ function assessUserConfig(probes) {
         remediation: apiBaseUrl ? void 0 : "Set `apiBaseUrl` via `kynver setup --api-base-url https://\u2026`.",
         details: { apiBaseUrl: apiBaseUrl ?? null }
       }),
-      check({
+      check2({
         id: "config_agent_os_id",
         label: "Default AgentOS id",
         status: agentOsId ? "pass" : "warn",
@@ -6686,7 +6808,7 @@ function assessUserConfig(probes) {
         remediation: agentOsId ? void 0 : "Set `agentOsId` via `kynver setup --agent-os-id <uuid>`.",
         details: { agentOsId: agentOsId ?? null, agentOsSlug: config.agentOsSlug ?? null }
       }),
-      check({
+      check2({
         id: "config_default_repo",
         label: "Default repo path",
         status: defaultRepo ? "pass" : "warn",
@@ -6714,7 +6836,7 @@ function assessRunnerToken(probes) {
   const scopedSaved = Boolean(savedToken) && (!targetAgentOsId || !savedAgentOsId || savedAgentOsId === targetAgentOsId);
   const hasScoped = Boolean(envToken?.startsWith("krc1.")) || scopedSaved && savedToken?.startsWith("krc1.");
   const checks = [
-    check({
+    check2({
       id: "runner_token_scoped",
       label: "Scoped runner token (krc1.*) ready",
       status: hasScoped ? "pass" : "fail",
@@ -6727,7 +6849,7 @@ function assessRunnerToken(probes) {
         credentialsPath: displayCredPath
       }
     }),
-    check({
+    check2({
       id: "runner_token_agent_os_match",
       label: "Saved runner token matches configured agentOsId",
       status: !savedToken || !targetAgentOsId || !savedAgentOsId || savedAgentOsId === targetAgentOsId ? "pass" : "warn",
@@ -6735,7 +6857,7 @@ function assessRunnerToken(probes) {
       remediation: savedToken && targetAgentOsId && savedAgentOsId && savedAgentOsId !== targetAgentOsId ? "`kynver runner credential --agent-os-id <configured-id>` to mint a workspace-bound token." : void 0,
       details: { configuredAgentOsId: targetAgentOsId ?? null, savedAgentOsId: savedAgentOsId ?? null }
     }),
-    check({
+    check2({
       id: "runner_api_key_for_refresh",
       label: "API key available for token refresh",
       status: creds.hasApiKey || Boolean(process.env.KYNVER_API_KEY?.trim()) ? "pass" : "warn",
@@ -6754,7 +6876,7 @@ function assessVercelCli(probes) {
     id: "vercel_cli",
     label: "Vercel CLI",
     checks: [
-      check({
+      check2({
         id: "vercel_installed",
         label: "Vercel CLI installed",
         status: installed ? "pass" : "warn",
@@ -6762,7 +6884,7 @@ function assessVercelCli(probes) {
         remediation: installed ? void 0 : "Install Vercel CLI (`npm i -g vercel`) for deploy evidence and env pulls.",
         details: { stderr: version.stderr || null }
       }),
-      check({
+      check2({
         id: "vercel_authenticated",
         label: "Vercel CLI authenticated",
         status: !installed ? "warn" : whoami.ok ? "pass" : "warn",
@@ -6786,14 +6908,14 @@ function assessHarnessDirs(probes) {
     id: "harness_dirs",
     label: "Harness / daemon directories",
     checks: [
-      check({
+      check2({
         id: "harness_root",
         label: "Harness root resolved",
         status: "pass",
         summary: displayHarnessRoot,
         details: { harnessRoot: displayHarnessRoot }
       }),
-      check({
+      check2({
         id: "harness_runs_dir",
         label: "Runs directory ready",
         status: runsExists && probes.pathWritable(runsDir) ? "pass" : runsExists ? "warn" : "warn",
@@ -6801,7 +6923,7 @@ function assessHarnessDirs(probes) {
         remediation: runsExists && !probes.pathWritable(runsDir) ? `Fix permissions on ${displayRunsDir} or set KYNVER_HARNESS_ROOT to a writable path.` : void 0,
         details: { runsDir: displayRunsDir, exists: runsExists, writable: probes.pathWritable(runsDir) }
       }),
-      check({
+      check2({
         id: "harness_worktrees_dir",
         label: "Worktrees directory ready",
         status: worktreesExists && probes.pathWritable(worktreesDir) ? "pass" : "warn",
@@ -6822,7 +6944,7 @@ function assessCallbackAuth(probes) {
   const creds = probes.readCredentials();
   const savedScoped = creds.runnerTokenPrefix?.startsWith("krc1.");
   const checks = [
-    check({
+    check2({
       id: "callback_base_url",
       label: "Callback base URL configured",
       status: baseUrl ? usingLegacyBase ? "warn" : "pass" : "fail",
@@ -6833,7 +6955,7 @@ function assessCallbackAuth(probes) {
         baseUrl: baseUrl ?? null
       }
     }),
-    check({
+    check2({
       id: "callback_auth_mode",
       label: "Callback auth uses scoped runner token",
       status: envScoped || savedScoped ? "pass" : legacySecret ? "warn" : "fail",
@@ -6849,15 +6971,22 @@ function assessCallbackAuth(probes) {
 }
 function assessOpenclawHotspots(probes) {
   const env = probes.envSnapshot();
+  const config = probes.loadConfig();
+  const creds = probes.readCredentials();
   const harnessRoot = probes.harnessRoot();
   const legacyRoot = probes.legacyOpenclawHarnessRoot();
   const displayHarnessRoot = redactHomePath(harnessRoot);
   const displayLegacyRoot = redactHomePath(legacyRoot);
   const displayOpusHarnessRoot = env.opusHarnessRoot ? redactHomePath(env.opusHarnessRoot) : null;
   const legacyHarnessActive = harnessRoot === legacyRoot && probes.pathExists(legacyRoot);
-  const schedulerOpenclaw = !env.kynverSchedulerProvider || env.kynverSchedulerProvider === "openclaw-cron";
+  const targetAgentOsId = config.agentOsId?.trim();
+  const envToken = env.kynverRunnerTokenPrefix;
+  const savedToken = creds.runnerTokenPrefix;
+  const savedAgentOsId = creds.runnerTokenAgentOsId;
+  const scopedSaved = Boolean(savedToken) && (!targetAgentOsId || !savedAgentOsId || savedAgentOsId === targetAgentOsId);
+  const hasScopedRunnerToken = Boolean(envToken?.startsWith("krc1.")) || scopedSaved && Boolean(savedToken?.startsWith("krc1."));
   const checks = [
-    check({
+    check2({
       id: "hotspot_legacy_harness_root",
       label: "Legacy ~/.openclaw/harness still active",
       status: legacyHarnessActive ? "warn" : "pass",
@@ -6865,7 +6994,7 @@ function assessOpenclawHotspots(probes) {
       remediation: legacyHarnessActive ? "Set KYNVER_HARNESS_ROOT=~/.kynver/harness (or run setup), migrate artifacts, retire OPUS_HARNESS_ROOT." : env.opusHarnessRoot ? "Prefer KYNVER_HARNESS_ROOT over OPUS_HARNESS_ROOT." : void 0,
       details: { harnessRoot: displayHarnessRoot, legacyRoot: displayLegacyRoot, opusHarnessRoot: displayOpusHarnessRoot }
     }),
-    check({
+    check2({
       id: "hotspot_openclaw_env_secrets",
       label: "OpenClaw deployment secrets in runner env",
       status: env.openclawCronSecret || env.openclawCronFireBaseUrl ? "warn" : "pass",
@@ -6875,15 +7004,12 @@ function assessOpenclawHotspots(probes) {
       ].filter(Boolean).join("; ") : "No OpenClaw cron env overrides on this runner",
       remediation: env.openclawCronSecret || env.openclawCronFireBaseUrl ? "Move to KYNVER_API_URL + scoped runner tokens; unset OpenClaw cron env on user-hosted runners." : void 0
     }),
-    check({
-      id: "hotspot_openclaw_scheduler",
-      label: "openclaw-cron scheduler dependency (deployment)",
-      status: schedulerOpenclaw ? "warn" : "pass",
-      summary: schedulerOpenclaw ? env.kynverSchedulerProvider === "openclaw-cron" ? "KYNVER_SCHEDULER_PROVIDER=openclaw-cron \u2014 AgentOS ticks still routed via OpenClaw local cron adapter" : "KYNVER_SCHEDULER_PROVIDER unset \u2014 server may fall back to openclaw-cron when QStash is absent" : `KYNVER_SCHEDULER_PROVIDER=${env.kynverSchedulerProvider}`,
-      remediation: schedulerOpenclaw ? "On Kynver-hosted scheduler: set KYNVER_SCHEDULER_PROVIDER=qstash where QStash is configured; retire openclaw-cron stub when runtime daemon owns dispatch." : void 0,
-      details: { schedulerProvider: env.kynverSchedulerProvider ?? null }
+    assessRuntimeTakeoverScheduler(env, {
+      agentOsId: targetAgentOsId ?? null,
+      apiBaseUrl: config.apiBaseUrl?.trim() ?? env.kynverApiUrl ?? null,
+      hasScopedRunnerToken
     }),
-    check({
+    check2({
       id: "hotspot_lease_source_names",
       label: "Harness lease/completion source names",
       status: "pass",