@kynver-app/runtime 0.1.47 → 0.1.48

package/dist/harness-expert-review.d.ts

@@ -0,0 +1,8 @@
+export interface HarnessExpertReviewTaskShape {
+    title?: string;
+    personaSlug?: string | null;
+    parentTaskId?: string | null;
+    executorRef?: string | null;
+}
+/** Expert review workers must not inherit landing-only PR gates or open new PRs. */
+export declare function isHarnessExpertReviewWorker(worker: HarnessExpertReviewTaskShape): boolean;

package/dist/index.js

@@ -2149,6 +2149,7 @@ function buildPrompt(input) {
     "Structured final result (recommended): record completion as JSON with summary, laneExpertise { whatChanged, why, files, prUrls, verification, risks, blockers, lessonsLearned, laneGuidance }, and targetPrReconciliation [{ prUrl, outcome: merged|skipped|blocked, mergeCommit?, reason? }] for every target PR on landing-only tasks.",
     "Completion handoff (required): before you stop, ensure the harness records a final result \u2014 summarize outcome in your last message and append a heartbeat line with phase `complete`. If you leave uncommitted changes or committed work without a PR, the orchestrator blocks completion until a GitHub PR exists (or you discard/commit cleanly). Exiting with only dirty files and no PR routes to salvage review, not production review.",
     "PR-ready handoff: for substantial implementation work, commit, push, and open a GitHub PR (draft OK) on your branch before finishing \u2014 or rely on the harness to run `gh pr create` at completion when `gh` is authenticated.",
+    "Expert review / production-review workers (Dalton/Lorentz, plan-review-task, scheduledJob reviewer children): do NOT open new implementation PRs \u2014 review the parent task's existing PR and record reviewVerdict in finalResult; landing-contract targetPrReconciliation does not apply.",
     "Worker resource guard: do not run full monorepo verification (`npm run typecheck`, `npm run build`, or equivalent) from this worker lane unless an operator explicitly requests it. Use targeted checks for touched paths and rely on CI/operator lanes for heavy gates.",
     "npm publish boundary: do not run `npm publish`, do not republish `@kynver-app/*` packages, and do not block on an operator to publish. When you need newer runtime code than npm, use this repo checkout (`npm run kynver:build`, `npm run kynver`) and record evidence: packages/kynver-runtime/package.json version + git ref in your completion report.",
     "If verification fails (including OOM), append a heartbeat line immediately with the last command, failure reason, dirty-file status, commit/PR handoff state, and next action so recovery does not require log spelunking.",
@@ -2390,6 +2391,32 @@ function completionPostSucceeded(summary) {
   return summary.taskAdvanced;
 }
 
+// src/harness-expert-review.ts
+var EXPERT_LANE_REVIEW_REF = "expert-lane-pr-review:";
+var PLAN_REVIEW_EXECUTOR_REF = "plan-review-task";
+var SCHEDULED_JOB_EXECUTOR_REF = "scheduledjob:";
+function normalizePersonaSlug(value) {
+  if (!value) return null;
+  const t = value.trim().toLowerCase();
+  return t.length ? t : null;
+}
+function isHarnessExpertReviewWorker(worker) {
+  const ref = (worker.executorRef ?? "").toLowerCase();
+  if (ref.startsWith(EXPERT_LANE_REVIEW_REF)) return true;
+  if (ref === PLAN_REVIEW_EXECUTOR_REF || ref.startsWith("daemon-review:")) return true;
+  if (ref.startsWith(SCHEDULED_JOB_EXECUTOR_REF) && worker.parentTaskId) {
+    const persona = normalizePersonaSlug(worker.personaSlug);
+    if (persona === "lorentz" || persona === "dalton") return true;
+  }
+  const title = (worker.title ?? "").toLowerCase();
+  if (title.includes("expert pr review")) return true;
+  if (worker.parentTaskId && (title.startsWith("review:") || title.includes("review required") || title.includes("runtime review"))) {
+    const persona = normalizePersonaSlug(worker.personaSlug);
+    if (persona === "lorentz" || persona === "dalton") return true;
+  }
+  return false;
+}
+
 // src/pr-handoff/pr-handoff-assess.ts
 var REVIEW_LANE_RULE = /^(lane:)?(review|deep_review|planning|landing)(:|$)/i;
 function trimOrNull4(value) {
@@ -2420,6 +2447,14 @@ function assessPrHandoffRequirement(input) {
   if (!input.dispatched) {
     return { required: false, reason: "not_dispatched" };
   }
+  if (isHarnessExpertReviewWorker({
+    title: input.taskTitle ?? void 0,
+    personaSlug: input.personaSlug,
+    parentTaskId: input.parentTaskId,
+    executorRef: input.executorRef
+  })) {
+    return { required: false, reason: "expert_review_task" };
+  }
   const rule = trimOrNull4(input.routingRule) ?? "";
   if (rule && REVIEW_LANE_RULE.test(rule)) {
     return { required: false, reason: "review_lane" };
@@ -2427,7 +2462,7 @@ function assessPrHandoffRequirement(input) {
   if (trimOrNull4(input.patchPath) || trimOrNull4(input.artifactBundlePath)) {
     return { required: false, reason: "patch_or_bundle" };
   }
-  const prUrl = trimOrNull4(input.prUrl) ?? trimOrNull4(input.snapshot.prUrl);
+  const prUrl = trimOrNull4(input.prUrl) ?? trimOrNull4(input.taskPrUrl) ?? trimOrNull4(input.snapshot.prUrl);
   if (prUrl) {
     return { required: false, reason: "already_has_pr" };
   }
@@ -2644,6 +2679,11 @@ function ensurePrReadyHandoff(input, exec = defaultPrHandoffExec) {
     dispatched: input.worker.dispatched,
     routingRule: input.worker.routingRule,
     prUrl: prUrlHint,
+    taskTitle: input.worker.taskTitle,
+    executorRef: input.worker.executorRef,
+    parentTaskId: input.worker.parentTaskId,
+    personaSlug: input.worker.personaSlug,
+    taskPrUrl: input.worker.taskPrUrl,
     snapshot
   });
   if (!requirement.required) {
@@ -3523,6 +3563,10 @@ function spawnWorkerProcess(run, opts) {
     ...!opts.agentOsId || !opts.taskId ? { localOnly: true } : {},
     routingRule: routing.rule,
     ...routing.requestedModel ? { requestedModel: routing.requestedModel } : {},
+    ...opts.executorRef ? { executorRef: String(opts.executorRef) } : {},
+    ...opts.parentTaskId ? { parentTaskId: String(opts.parentTaskId) } : {},
+    ...opts.taskTitle ? { taskTitle: String(opts.taskTitle) } : {},
+    ...opts.taskPrUrl ? { taskPrUrl: String(opts.taskPrUrl) } : {},
     startedAt: (/* @__PURE__ */ new Date()).toISOString()
   };
   saveWorker(run.id, worker);
@@ -4217,7 +4261,7 @@ function readHarnessWorkerContext(decision) {
     personaInjectionReady
   };
 }
-function normalizePersonaSlug(value) {
+function normalizePersonaSlug2(value) {
   if (typeof value !== "string") return null;
   const trimmed = value.trim().toLowerCase();
   return trimmed.length ? trimmed : null;
@@ -4348,7 +4392,7 @@ async function dispatchRun(args) {
       const task = decision.task;
       const harnessContext = readHarnessWorkerContext(decision);
       const taskId = String(task.id);
-      const expectedPersona = normalizePersonaSlug(task.personaSlug);
+      const expectedPersona = normalizePersonaSlug2(task.personaSlug);
       if (expectedPersona && (!harnessContext?.personaInjectionReady || !harnessContext.personaMarkdown)) {
         outcomes.push({
           taskId,
@@ -4392,6 +4436,10 @@ async function dispatchRun(args) {
           agentOsId,
           taskId: String(task.id),
           planId,
+          executorRef: task.executorRef ? String(task.executorRef) : void 0,
+          parentTaskId: task.parentTaskId ? String(task.parentTaskId) : void 0,
+          taskTitle: task.title ? String(task.title) : void 0,
+          taskPrUrl: task.prUrl ? String(task.prUrl) : void 0,
           instructionPolicyMarkdown: harnessContext?.instructionPolicyMarkdown ?? null,
           instructionPolicyFingerprint: harnessContext?.instructionPolicyFingerprint ?? null,
           instructionPolicyEvidence: harnessContext?.instructionPolicyEvidence ?? null,