@kynver-app/runtime 0.1.22 → 0.1.24

package/dist/cli.js

@@ -679,6 +679,64 @@ function classifyExitFailure(errorText) {
   return null;
 }
 
+// src/exited-salvage.ts
+function trimOrNull(value) {
+  if (typeof value !== "string") return null;
+  const trimmed = value.trim();
+  return trimmed.length ? trimmed : null;
+}
+function hasFinalResult(value) {
+  if (value === void 0 || value === null) return false;
+  if (typeof value === "string") return value.trim().length > 0;
+  if (typeof value === "boolean") return value;
+  if (Array.isArray(value)) return value.length > 0;
+  if (typeof value === "object") return Object.keys(value).length > 0;
+  return true;
+}
+function committedHeadFromAncestry(ancestry) {
+  if (!ancestry?.checked) return null;
+  if (ancestry.headIsAncestorOfBase !== false) return null;
+  return trimOrNull(ancestry.head);
+}
+function buildAttentionReason(kind, uncommittedCount, headCommit) {
+  const parts = ["exited_with_changes_salvage"];
+  if (kind === "uncommitted" || kind === "both") {
+    parts.push(
+      `${uncommittedCount} uncommitted change${uncommittedCount === 1 ? "" : "s"} with no final result`
+    );
+  }
+  if ((kind === "committed_ahead" || kind === "both") && headCommit) {
+    const sha = headCommit.length > 12 ? headCommit.slice(0, 12) : headCommit;
+    parts.push(`commit ${sha} ahead of base with no final result`);
+  }
+  parts.push("review worktree \u2014 commit, open a PR, or run a salvage worker before discarding");
+  return parts.join(": ");
+}
+function assessExitedWorkerSalvage(input) {
+  if (input.alive || hasFinalResult(input.finalResult)) return null;
+  const uncommittedCount = (input.changedFiles ?? []).filter((line) => line.trim()).length;
+  const headCommit = trimOrNull(input.headCommit) ?? committedHeadFromAncestry(input.gitAncestry);
+  const hasUncommitted = uncommittedCount > 0;
+  const hasCommittedAhead = Boolean(headCommit);
+  if (!hasUncommitted && !hasCommittedAhead) {
+    return {
+      kind: "none",
+      salvageable: false,
+      uncommittedCount: 0,
+      headCommit: null,
+      attentionReason: "process exited without a final result"
+    };
+  }
+  const kind = hasUncommitted && hasCommittedAhead ? "both" : hasUncommitted ? "uncommitted" : "committed_ahead";
+  return {
+    kind,
+    salvageable: true,
+    uncommittedCount,
+    headCommit,
+    attentionReason: buildAttentionReason(kind, uncommittedCount, headCommit)
+  };
+}
+
 // src/git.ts
 import { spawnSync } from "node:child_process";
 function git(cwd, args, options = {}) {
@@ -803,12 +861,12 @@ function scrubClaudeEnv(env) {
 }
 
 // src/landing-gate.ts
-function trimOrNull(value) {
+function trimOrNull2(value) {
   if (typeof value !== "string") return null;
   const trimmed = value.trim();
   return trimmed.length ? trimmed : null;
 }
-function hasFinalResult(value) {
+function hasFinalResult2(value) {
   if (value === void 0 || value === null) return false;
   if (typeof value === "string") return value.trim().length > 0;
   if (typeof value === "boolean") return value;
@@ -817,18 +875,18 @@ function hasFinalResult(value) {
   return true;
 }
 function hasCommittedLandingRef(snapshot) {
-  if (trimOrNull(snapshot.headCommit)) return true;
-  if (trimOrNull(snapshot.prUrl)) return true;
-  if (trimOrNull(snapshot.artifactBundlePath)) return true;
-  if (trimOrNull(snapshot.patchPath)) return true;
+  if (trimOrNull2(snapshot.headCommit)) return true;
+  if (trimOrNull2(snapshot.prUrl)) return true;
+  if (trimOrNull2(snapshot.artifactBundlePath)) return true;
+  if (trimOrNull2(snapshot.patchPath)) return true;
   const ancestry = snapshot.gitAncestry;
-  if (ancestry?.checked && ancestry.headIsAncestorOfBase === false && trimOrNull(ancestry.head)) {
+  if (ancestry?.checked && ancestry.headIsAncestorOfBase === false && trimOrNull2(ancestry.head)) {
     return true;
   }
   return false;
 }
 function assessWorkerLanding(snapshot) {
-  if (!hasFinalResult(snapshot.finalResult)) return { blocked: false };
+  if (!hasFinalResult2(snapshot.finalResult)) return { blocked: false };
   if (snapshot.changedFiles.length === 0) return { blocked: false };
   if (!hasCommittedLandingRef(snapshot)) {
     return {
@@ -873,10 +931,23 @@ function computeAttention(input) {
   if (!input.alive) {
     const classified = classifyExitFailure(input.error);
     if (classified) return { state: "blocked", reason: classified.reason };
+    const salvage = assessExitedWorkerSalvage({
+      alive: false,
+      finalResult: null,
+      changedFiles: input.changedFiles,
+      gitAncestry: input.gitAncestry
+    });
+    if (salvage?.salvageable) {
+      const tail2 = input.error?.trim();
+      return {
+        state: "needs_attention",
+        reason: tail2 ? `${salvage.attentionReason} (${tail2})` : salvage.attentionReason
+      };
+    }
     const tail = input.error?.trim();
     return {
       state: "needs_attention",
-      reason: tail ? `process exited without a final result: ${tail}` : "process exited without a final result"
+      reason: tail ? `process exited without a final result: ${tail}` : salvage?.attentionReason ?? "process exited without a final result"
     };
   }
   if (input.heartbeatBlocker) {
@@ -1393,6 +1464,8 @@ function buildPrompt(input) {
     `Progress heartbeat file: ${input.heartbeatPath}`,
     "After each major step, append one JSON line to the heartbeat file with fields: ts, phase, summary, changedFiles, blocker.",
     "Final response must include files changed, verification commands, and unresolved risks.",
+    "Completion handoff (required): before you stop, ensure the harness records a final result \u2014 summarize outcome in your last message and append a heartbeat line with phase `complete`. If you leave uncommitted changes, commit or open a PR; exiting with only dirty files and no final result routes to salvage review, not production review.",
+    "Long-running commands: prefer bounded verification (targeted tests/typecheck for touched paths). If a full build is required, note it in heartbeat phase `verify` so a silent exit is not mistaken for success.",
     "",
     ...progressLines,
     "",
@@ -1725,6 +1798,13 @@ function buildRunBoard(runId) {
       baseCommit: run.baseCommit
     });
     const headCommit = status.gitAncestry.headIsAncestorOfBase === false && status.gitAncestry.head ? status.gitAncestry.head : void 0;
+    const exitedSalvage = assessExitedWorkerSalvage({
+      alive: status.alive,
+      finalResult: status.finalResult,
+      changedFiles: status.changedFiles,
+      gitAncestry: status.gitAncestry,
+      headCommit
+    });
     const rawBlocker = worker.completionBlocker;
     const completionBlocker = typeof rawBlocker === "string" && rawBlocker ? rawBlocker : void 0;
     const boardStatus = completionBlocker ? "blocked" : status.status;
@@ -1735,6 +1815,9 @@ function buildRunBoard(runId) {
       attention: boardAttention,
       attentionReason: completionBlocker ?? status.attention.reason,
       landingBlocked: status.finalResult ? boardAttention === "needs_attention" || boardAttention === "blocked" : false,
+      exitedWithoutFinalResult: !status.finalResult && !status.alive,
+      salvageState: exitedSalvage?.salvageable ? "review_needed" : "none",
+      salvageReason: exitedSalvage?.salvageable ? exitedSalvage.attentionReason : void 0,
       pid: status.pid,
       alive: status.alive,
       currentTool: status.currentTool,
@@ -2655,7 +2738,13 @@ async function completeFinishedWorkers(runId, args) {
     if (!worker?.taskId) continue;
     const status = computeWorkerStatus(worker);
     if (!isFinishedWorkerStatus(status)) continue;
-    if (!worker.dispatched && !status.finalResult) continue;
+    const exitedSalvage = assessExitedWorkerSalvage({
+      alive: status.alive,
+      finalResult: status.finalResult,
+      changedFiles: status.changedFiles,
+      gitAncestry: status.gitAncestry
+    });
+    if (!worker.dispatched && !status.finalResult && !exitedSalvage?.salvageable) continue;
     const result = await tryCompleteWorker({
       run: runId,
       name,
@@ -2684,15 +2773,15 @@ async function runPipelineTick(args) {
   const agentOsId = String(required(String(args.agentOsId || ""), "--agent-os-id"));
   const execute = args.execute !== false && args.execute !== "false";
   runStatus({ run: runId });
-  const completedWorkers = await completeFinishedWorkers(runId, args);
-  const staleReconcile = reconcileStaleWorkers();
-  const planProgressSync = await syncActiveWorkerPlanProgress(runId, args);
   const workspacePrefs = await fetchWorkspaceRuntimePreferences(agentOsId, args);
   const resourceGate = observeRunnerResourceGate({
     runId,
     configuredMaxWorkersOverride: workspacePrefs?.maxConcurrentWorkers
   });
   const operatorTick = await postOperatorTick(agentOsId, runId, resourceGate, args);
+  const completedWorkers = await completeFinishedWorkers(runId, args);
+  const staleReconcile = reconcileStaleWorkers();
+  const planProgressSync = await syncActiveWorkerPlanProgress(runId, args);
   let maxStarts = resourceGate.slotsAvailable;
   const tickBody = operatorTick;
   const advised = tickBody.response?.dispatch?.recommendedMaxStarts;