@kybernesis/create 0.26.0 → 0.26.1

package/dist/doctor.d.ts

@@ -46,6 +46,12 @@ export interface ComputerInspection {
     /** The noVNC port is bound on loopback. */
     screenBound: boolean | null;
     vncPasswordSet: boolean;
+    /**
+     * Live xfsettingsd processes in the running computer. One is right; more
+     * were left by display restarts before @kybernesis/computer 0.3.1, and each
+     * holds one of Xvfb's client slots.
+     */
+    settingsDaemons?: number | null;
 }
 /**
  * A computer that is configured but not running is the quiet failure here:
@@ -54,4 +60,6 @@ export interface ComputerInspection {
  */
 export declare function computerDoctorChecks(c: ComputerInspection): Check[];
 export declare function inspectComputer(cwd: string): ComputerInspection | null;
+/** @internal Lines of `ps -o stat=` output that are not zombies (a zombie holds no X connection). */
+export declare function countLiveProcesses(stats: string): number;
 export {};

package/dist/doctor.js

@@ -736,6 +736,8 @@ export async function doctor() {
     console.log(`\n  ${fails ? red(`${fails} failing`) : green("0 failing")}, ${warns ? yellow(`${warns} warnings`) : "0 warnings"}\n`);
     process.exit(fails ? 1 : 0);
 }
+/** Xvfb ran out of client slots at about 240 settings daemons; fail well before that. */
+const SETTINGS_DAEMONS_FAIL = 100;
 /**
  * A computer that is configured but not running is the quiet failure here:
  * every session would try to start it and the first turn pays the whole boot,
@@ -773,6 +775,15 @@ export function computerDoctorChecks(c) {
             detail: "the container was created without the noVNC port mapping; `docker rm -f " + c.name + "` and `eve build` to recreate it (volumes keep the home and /workspace)",
         });
     }
+    if (c.containerState === "running" && typeof c.settingsDaemons === "number" && c.settingsDaemons > 1) {
+        checks.push({
+            verdict: c.settingsDaemons >= SETTINGS_DAEMONS_FAIL ? "fail" : "warn",
+            label: `the computer has ${c.settingsDaemons} display settings daemons running (one is right)`,
+            detail: "each restart of its display left one behind, and each holds an X client slot; at about 240 the screen stops accepting windows and `eve build` fails. " +
+                "Upgrade @kybernesis/computer to 0.3.1 or later (`kyb upgrade`), then clear the extras: " +
+                "`docker exec " + c.name + " sh -c 'n=$(pgrep -n -x xfsettingsd); for p in $(pgrep -x xfsettingsd); do [ $p = $n ] || kill $p; done'`",
+        });
+    }
     if (!c.vncPasswordSet) {
         checks.push({
             verdict: "warn",
@@ -794,11 +805,19 @@ export function inspectComputer(cwd) {
     const state = capture("docker", ["inspect", "-f", "{{.State.Running}}", name]);
     const containerState = state === null ? "unknown" : state.trim() === "true" ? "running" : state.trim() === "false" ? "stopped" : "missing";
     const ports = containerState === "running" ? capture("docker", ["port", name, "6080"]) : null;
+    const daemons = containerState === "running"
+        ? capture("docker", ["exec", name, "sh", "-c", "ps -C xfsettingsd -o stat= || true"])
+        : null;
     return {
         configured: true,
         name,
         containerState,
         screenBound: containerState === "running" ? Boolean(ports && ports.trim().length > 0) : null,
         vncPasswordSet: Boolean(env.COMPUTER_VNC_PASSWORD?.trim()),
+        settingsDaemons: daemons === null ? null : countLiveProcesses(daemons),
     };
 }
+/** @internal Lines of `ps -o stat=` output that are not zombies (a zombie holds no X connection). */
+export function countLiveProcesses(stats) {
+    return stats.split("\n").filter((line) => line.trim() && !line.trim().startsWith("Z")).length;
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@kybernesis/create",
-  "version": "0.26.0",
+  "version": "0.26.1",
   "description": "The Kybernesis agent scaffolder and FDE toolkit: one command to a governed, remembering, multiplayer, self-testing eve agent \u2014 plus doctor and upgrade.",
   "license": "Apache-2.0",
   "type": "module",