@kya-os/mcp-i-core 1.3.22 → 1.3.24

package/dist/runtime/base.js

@@ -10,6 +10,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.MCPIRuntimeBase = void 0;
 const tool_protection_js_1 = require("../types/tool-protection.js");
 const crypto_service_js_1 = require("../services/crypto.service.js");
+const access_control_service_js_1 = require("../services/access-control.service.js");
 const agentshield_api_1 = require("@kya-os/contracts/agentshield-api");
 const user_did_manager_1 = require("../identity/user-did-manager");
 class MCPIRuntimeBase {
@@ -466,6 +467,78 @@ class MCPIRuntimeBase {
                                 });
                             }
                         }
+                        // ✅ SECURITY: Validate authorization method matches tool requirements
+                        // This prevents stale delegations from working after tool auth method changes
+                        // NOTE: Authorization validation only applies when credential is present (AgentShield API verifier).
+                        // KV/Memory verifiers don't return credential data, so we skip auth method validation for them.
+                        const toolAuth = protection.authorization;
+                        const delegationAuth = credential?.authorization;
+                        // Only validate when:
+                        // 1. Tool has authorization requirement defined
+                        // 2. Credential is present (AgentShield API verifier)
+                        if (toolAuth && credential) {
+                            // If tool requires authorization but credential doesn't have auth data, reject
+                            // This prevents bypassing auth checks with incomplete credential data
+                            if (!delegationAuth) {
+                                if (this.config.audit?.enabled) {
+                                    console.error("[MCP-I] ❌ Tool requires authorization but credential missing auth data", {
+                                        tool: toolName,
+                                        agentDid: identity.did.slice(0, 20) + "...",
+                                        toolAuth,
+                                        note: "Credential exists but missing authorization metadata - rejecting for security",
+                                    });
+                                }
+                                // Throw DelegationRequiredError to force re-authorization
+                                const interceptedCall = {
+                                    toolName,
+                                    args,
+                                    sessionId: session?.id || "unknown",
+                                    timestamp: this.clock.now(),
+                                    expiresAt: this.clock.calculateExpiry(1800),
+                                };
+                                const resumeToken = this.generateResumeToken(interceptedCall);
+                                const consentUrl = this.buildConsentUrl(toolName, protection.requiredScopes, session, resumeToken, undefined, protection.oauthProvider);
+                                this.interceptedCalls.set(resumeToken, interceptedCall);
+                                this.cleanupExpiredInterceptedCalls();
+                                throw new tool_protection_js_1.DelegationRequiredError(toolName, protection.requiredScopes, consentUrl, interceptedCall, resumeToken);
+                            }
+                            // Both tool and delegation have authorization - compare them
+                            if (!(0, access_control_service_js_1.authorizationMatches)(delegationAuth, toolAuth)) {
+                                const authMismatchReason = `Authorization method mismatch: delegation has ${delegationAuth.type}${delegationAuth.provider ? `:${delegationAuth.provider}` : ""}${delegationAuth.credentialType ? `:${delegationAuth.credentialType}` : ""} but tool requires ${toolAuth.type}${toolAuth.provider ? `:${toolAuth.provider}` : ""}${toolAuth.credentialType ? `:${toolAuth.credentialType}` : ""}`;
+                                if (this.config.audit?.enabled) {
+                                    console.error("[MCP-I] ❌ Authorization method validation FAILED", {
+                                        tool: toolName,
+                                        agentDid: identity.did.slice(0, 20) + "...",
+                                        reason: authMismatchReason,
+                                        delegationAuth,
+                                        toolAuth,
+                                    });
+                                }
+                                // Throw DelegationRequiredError to force re-authorization with correct method
+                                const interceptedCall = {
+                                    toolName,
+                                    args,
+                                    sessionId: session?.id || "unknown",
+                                    timestamp: this.clock.now(),
+                                    expiresAt: this.clock.calculateExpiry(1800),
+                                };
+                                const resumeToken = this.generateResumeToken(interceptedCall);
+                                const consentUrl = this.buildConsentUrl(toolName, protection.requiredScopes, session, resumeToken, undefined, protection.oauthProvider);
+                                this.interceptedCalls.set(resumeToken, interceptedCall);
+                                this.cleanupExpiredInterceptedCalls();
+                                throw new tool_protection_js_1.DelegationRequiredError(toolName, protection.requiredScopes, consentUrl, interceptedCall, resumeToken);
+                            }
+                            // Authorization method validation passed
+                            if (this.config.audit?.enabled) {
+                                console.log("[MCP-I] ✅ Authorization method validation PASSED", {
+                                    tool: toolName,
+                                    agentDid: identity.did.slice(0, 20) + "...",
+                                    authType: delegationAuth.type,
+                                    provider: delegationAuth.provider || "N/A",
+                                });
+                            }
+                        }
+                        // If credential is missing entirely (KV/Memory verifiers), skip validation for backward compatibility
                         // Verification succeeded
                         if (this.config.audit?.enabled) {
                             console.log("[MCP-I] ✅ Delegation verification SUCCEEDED", {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@kya-os/mcp-i-core",
-  "version": "1.3.22",
+  "version": "1.3.24",
   "description": "Core runtime and types for MCP-I framework",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
@@ -28,7 +28,7 @@
     "prepublishOnly": "npm run build && node ../create-mcpi-app/scripts/validate-no-workspace.js"
   },
   "dependencies": {
-    "@kya-os/contracts": "^1.6.15",
+    "@kya-os/contracts": "^1.6.17",
     "jose": "^5.6.3",
     "json-canonicalize": "^2.0.0",
     "zod": "^3.25.76"