@kya-os/mcp-i-core 1.3.2 → 1.3.3

package/src/__tests__/services/cache-no-warming.test.ts

@@ -1,177 +0,0 @@
-/**
- * Cache Invalidation: No Warming Test
- *
- * CRITICAL TEST: Proves that clearAndRefresh does NOT fetch immediately after clearing.
- *
- * Background:
- * - In mcp-i-cloudflare@1.6.4+, cache warming was added as an "optimization"
- * - The idea was to fetch fresh data immediately after clearing
- * - BUT this backfired when upstream APIs (AgentShield) have CDN caching
- * - The immediate fetch would get stale CDN data and store it in our cache
- * - This defeated the purpose of cache invalidation
- *
- * Fix:
- * - clearAndRefresh now just DELETES the cache entry
- * - It does NOT fetch or warm the cache
- * - The next actual tool call will fetch fresh data (with natural delay)
- *
- * This was the behavior in mcp-i-cloudflare@1.6.3 that worked perfectly.
- */
-
-import { describe, it, expect, vi, beforeEach } from "vitest";
-import { ToolProtectionService } from "../../services/tool-protection.service.js";
-import { InMemoryToolProtectionCache } from "../../cache/tool-protection-cache.js";
-
-describe("Cache Invalidation - No Warming", () => {
-  let cache: InMemoryToolProtectionCache;
-  let service: ToolProtectionService;
-  let fetchSpy: ReturnType<typeof vi.fn>;
-
-  beforeEach(() => {
-    cache = new InMemoryToolProtectionCache();
-    fetchSpy = vi.fn();
-
-    service = new ToolProtectionService(
-      {
-        apiUrl: "https://test.agentshield.com",
-        apiKey: "test-key",
-        projectId: "test-project",
-        cacheTtl: 300000,
-        debug: true,
-      },
-      cache
-    );
-
-    // Spy on the internal fetch method
-    (service as any).fetchFromApi = fetchSpy;
-  });
-
-  it("clearAndRefresh should DELETE cache without fetching", async () => {
-    // Seed the cache with old data
-    const oldConfig = {
-      toolProtections: {
-        greet: { requiresDelegation: false, requiredScopes: ["greet:execute"] },
-      },
-    };
-    await cache.set("config:tool-protections:test-project", oldConfig, 300000);
-
-    // Clear the cache
-    const result = await service.clearAndRefresh("did:key:test-agent");
-
-    // CRITICAL: fetchFromApi should NOT have been called
-    expect(fetchSpy).not.toHaveBeenCalled();
-
-    // Result should indicate cache was cleared, not refreshed
-    expect(result.source).toBe("cleared");
-    expect(result.cacheKey).toBe("config:tool-protections:test-project");
-    expect(result.config.toolProtections).toEqual({});
-  });
-
-  it("cache should be empty after clearAndRefresh (no warming)", async () => {
-    // Seed the cache
-    const oldConfig = {
-      toolProtections: {
-        greet: { requiresDelegation: true, requiredScopes: ["greet:execute"] },
-      },
-    };
-    await cache.set("config:tool-protections:test-project", oldConfig, 300000);
-
-    // Verify it's cached
-    const beforeClear = await cache.get("config:tool-protections:test-project");
-    expect(beforeClear).not.toBeNull();
-    expect(beforeClear?.toolProtections.greet.requiresDelegation).toBe(true);
-
-    // Clear the cache
-    await service.clearAndRefresh("did:key:test-agent");
-
-    // Cache should be EMPTY (not warmed with new data)
-    const afterClear = await cache.get("config:tool-protections:test-project");
-    expect(afterClear).toBeNull();
-  });
-
-  it("next getToolProtectionConfig call should fetch fresh from API", async () => {
-    // Setup: Mock API to return DIFFERENT data than what was cached
-    const staleConfig = {
-      toolProtections: {
-        greet: { requiresDelegation: false, requiredScopes: [] },
-      },
-    };
-
-    // Seed cache with stale data
-    await cache.set(
-      "config:tool-protections:test-project",
-      staleConfig,
-      300000
-    );
-
-    // Mock API to return fresh data (requiresDelegation: TRUE)
-    fetchSpy.mockResolvedValueOnce({
-      data: {
-        toolProtections: {
-          greet: {
-            requiresDelegation: true,
-            requiredScopes: ["greet:execute"],
-          },
-        },
-      },
-    });
-
-    // Clear cache (should NOT fetch)
-    await service.clearAndRefresh("did:key:test-agent");
-    expect(fetchSpy).not.toHaveBeenCalled();
-
-    // Now get config - this SHOULD fetch from API
-    const result = await service.getToolProtectionConfig("did:key:test-agent");
-
-    // API should have been called now (cache was cleared, so it fetched)
-    expect(fetchSpy).toHaveBeenCalledTimes(1);
-
-    // Result should have fresh data from API (not stale cached data)
-    expect(result.toolProtections.greet.requiresDelegation).toBe(true);
-  });
-
-  it("proves stale CDN data issue is avoided", async () => {
-    /**
-     * This test proves why NO warming is better than warming.
-     *
-     * Scenario:
-     * 1. User toggles delegation ON in dashboard
-     * 2. AgentShield DB updates, but CDN still has old data (5 min TTL)
-     * 3. User triggers cache clear
-     *
-     * WITH warming (broken):
-     * - clearAndRefresh immediately fetches from API
-     * - API returns stale CDN data (requiresDelegation: false)
-     * - We store stale data in our cache
-     * - Tool call uses stale data = BUG
-     *
-     * WITHOUT warming (fixed):
-     * - clearAndRefresh just deletes cache
-     * - Next tool call fetches from API (some time later)
-     * - Better chance CDN has refreshed
-     * - Even if CDN still stale, user can retry after CDN TTL
-     */
-
-    // Simulate stale CDN response (old config before user toggled delegation)
-    const staleCdnResponse = {
-      data: {
-        toolProtections: {
-          greet: { requiresDelegation: false, requiredScopes: [] },
-        },
-      },
-    };
-
-    fetchSpy.mockResolvedValue(staleCdnResponse);
-
-    // Clear cache
-    await service.clearAndRefresh("did:key:test-agent");
-
-    // CRITICAL: We did NOT store the stale CDN data
-    // fetchSpy was NOT called during clearAndRefresh
-    expect(fetchSpy).not.toHaveBeenCalled();
-
-    // Cache is empty, not poisoned with stale data
-    const cached = await cache.get("config:tool-protections:test-project");
-    expect(cached).toBeNull();
-  });
-});