@kununu/phraseapp-cli 4.0.0 → 4.0.3-beta.0

package/README_CHECK_TRANSLATIONS.md

@@ -18,6 +18,15 @@ Add to ```package.json```
  "check-translations": "SOURCE_DIR=src node ./node_modules/@kununu/phraseapp-cli/check-translations.js",
 ```
 
+### Add `report-check-translations` in .gitignore
+
+Add to ```.gitignore````
+
+```json
+# Check Translations Report Folder
+report-check-translations/*
+```
+
 ## Configuration file
 
 You have to add to the ```.phraseapp.json``` file a new var dynamicKeys
@@ -54,8 +63,7 @@ You have to add to the ```.phraseapp.json``` file a new var dynamicKeys
 
 ```
 /
-├─ check-translations.js                     # Initial file
-├─ dynamic_keys.json            # Add all dynamic keys that we have in the app or keys that we get from Ambassador/BE.
+├─ check-translations.js        # Initial file
 ├─ possible_dynamic_keys.json   # Automatically created file indicating in which files we might have dynamic keys.
 ├─ missing_keys.json            # Automatically created file indicating the keys that exist in the app but are not translated.
 ├─ not_used_keys.json           # Automatically created file indicating the keys that are not being used in the app.

package/check-translations.js

@@ -10,6 +10,8 @@ const {parse} = require('@babel/parser');
 const traverse = require('@babel/traverse');
 const {sync} = require('glob');
 
+const colors = require('colors'); // eslint-disable-line no-unused-vars
+
 const FOLDER_REPORT_CHECK_TRANSLATIONS = `${process.cwd()}/report-check-translations`;
 const UNUSED_KEYS_FILE = `${FOLDER_REPORT_CHECK_TRANSLATIONS}/not_used_keys.json`;
 const MISSING_KEYS_FILE = `${FOLDER_REPORT_CHECK_TRANSLATIONS}/missing_keys.json`;
@@ -113,9 +115,8 @@ function compareKeys() {
 
     const allValidKeys = new Set(Object.keys(translations));
 
-    let missingKeys = [...appKeys].filter(key => !allValidKeys.has(key));
-
-    missingKeys = missingKeys.filter(key => key != null && key !== undefined);
+    const missingKeys = [...appKeys].filter(key => !allValidKeys.has(key))
+      .filter(key => key != null && key !== undefined);
 
     // Check if there are keys in dynamicKeys that are missing from allValidKeys.
     dynamicKeys.forEach(key => {
@@ -131,9 +132,10 @@ function compareKeys() {
 
     if (missingKeys.length > 0) {
       writeFileSync(MISSING_KEYS_FILE, JSON.stringify(missingKeys, null, 2));
-      console.log(
-        `${missingKeys.length} missing keys were saved in ${MISSING_KEYS_FILE}`,
+      console.error(
+        `${missingKeys.length} missing keys were found. Please check ${MISSING_KEYS_FILE} for details.`.red.bold,
       );
+      process.exit(1);
     } else if (existsSync(MISSING_KEYS_FILE)) {
       unlinkSync(MISSING_KEYS_FILE);
       console.log(
@@ -153,7 +155,8 @@ function compareKeys() {
       );
     }
   } catch (error) {
-    console.error(error);
+    console.error(`Error: ${error.message}`.red.bold);
+    process.exit(1);
   }
 }
 

package/index.js

@@ -6,8 +6,6 @@ const fs = require('fs');
 
 require('dotenv').config();
 
-const colors = require('colors'); // eslint-disable-line no-unused-vars
-
 /**
  * Splits array into smaller chunks
  *

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@kununu/phraseapp-cli",
-  "version": "4.0.0",
+  "version": "4.0.3-beta.0",
   "description": "",
   "main": "index.js",
   "author": "kununu",