@kununu/phraseapp-cli 1.5.0-beta.3 → 2.0.0

package/index.js

@@ -1,6 +1,6 @@
 #! /usr/bin/env node
 
-/* eslint-disable */
+/* eslint-disable no-console */
 
 const fs = require('fs');
 
@@ -10,9 +10,11 @@ const request = require('request');
 const colors = require('colors'); // eslint-disable-line no-unused-vars
 
 /**
- * Splits array into
+ * Splits array into smaller chunks
+ *
+ * E.g: chunks([1, 2, 3, 4], 2) => [[1, 2], [3, 4]]
  */
-function* chunks(arr, n) {
+function* chunks (arr, n) {
   for (let i = 0; i < arr.length; i += n) {
     yield arr.slice(i, i + n);
   }
@@ -63,7 +65,7 @@ function loadConfig () {
 function getPhraseAppQueryParams (tags, fallbackLocale, branch) {
   const queryParams = {
     file_format: 'react_simple_json',
-    tags: tags.join(',')
+    tags: tags.join(','),
   };
 
   if (fallbackLocale) {
@@ -82,18 +84,12 @@ function getPhraseAppQueryParams (tags, fallbackLocale, branch) {
 
 const getFileName = (filePrefix, localeId) => `${filePrefix ? `${filePrefix}-` : ''}${localeId}.json`;
 
-const getFilePath = (path, filePrefix, localeId) => {
-  return `${path}${getFileName(filePrefix, localeId)}`;
-}
+const getFilePath = (path, filePrefix, localeId) => `${path}${getFileName(filePrefix, localeId)}`;
 
-function getPhraseAppDownloadUrl(accessToken, projectId, localeId, tags, fallbackLocaleId, branch) {
+function getPhraseAppDownloadUrl (accessToken, projectId, localeId, tags, fallbackLocaleId, branch) {
   return `https://${accessToken}@api.phraseapp.com/api/v2/projects/${projectId}/locales/${localeId}/download?${getPhraseAppQueryParams(tags, fallbackLocaleId, branch)}`;
 }
 
-function logDownloadError (err) {
-  console.error(err.red.bold);
-}
-
 function downloadLocaleFile (phrase, locale) {
   const {
     access_token: accessToken,
@@ -117,7 +113,6 @@ function downloadLocaleFile (phrase, locale) {
 
     request.get(url, (error, response, body) => {
       if (!error && response.statusCode === 200) {
-        // const content = JSON.stringify(JSON.parse(body), null, '\t');
         fs.writeFileSync(filepath, body);
         console.info(`Success: locale file ${getFileName(filePrefix, localeId)} was updated`.green.bold);
         return resolve();
@@ -126,21 +121,25 @@ function downloadLocaleFile (phrase, locale) {
       if (response.statusCode === 401) {
         console.error('Error: Please check your access_token'.red.bold);
       } else {
-        console.error(`Error: locale file ${getFileName(filePrefix, localeId)}. Message: ${JSON.parse(body).message}`.red)
+        console.error(`Error: locale file ${getFileName(filePrefix, localeId)}. Message: ${JSON.parse(body).message}`.red);
       }
 
-      reject(response);
+      return reject(response);
     });
-  })
+  });
 }
 
 async function loadLocale (phrase) {
   const startTime = new Date();
-  // unfortunately phraseapp only allows us 4 concurrent request. So we split our locales into groups of 4
-  const localeChunks = [...chunks(phrase.locales, 4)];
-  for (localeChunk of localeChunks) {
+
+  // Usually we'd create one big array and do all requests in parallel
+  // Unfortunately phraseapp only allows us 4 concurrent request. So we split our locales into groups of 4
+  // https://developers.phrase.com/api/#overview--rate-limiting
+  for (const localeChunk of chunks(phrase.locales, 4)) {
     // Create Promise array to download the four translations for this chunk
     const downloads = localeChunk.map(locale => downloadLocaleFile(phrase, locale));
+
+    // eslint-disable-next-line no-await-in-loop
     await Promise.all(downloads);
   }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@kununu/phraseapp-cli",
-  "version": "1.5.0-beta.3",
+  "version": "2.0.0",
   "description": "",
   "main": "index.js",
   "bin": {