@kununu/phraseapp-cli 1.5.0-beta.2 → 1.5.0-beta.3

package/index.js

@@ -9,6 +9,15 @@ require('dotenv').config();
 const request = require('request');
 const colors = require('colors'); // eslint-disable-line no-unused-vars
 
+/**
+ * Splits array into
+ */
+function* chunks(arr, n) {
+  for (let i = 0; i < arr.length; i += n) {
+    yield arr.slice(i, i + n);
+  }
+}
+
 function logErrorsAndExitProcess (errors) {
   errors.map(error => console.error(error.red.bold));
   process.exit(1);
@@ -54,7 +63,7 @@ function loadConfig () {
 function getPhraseAppQueryParams (tags, fallbackLocale, branch) {
   const queryParams = {
     file_format: 'react_simple_json',
-    tags: tags.join(','),
+    tags: tags.join(',')
   };
 
   if (fallbackLocale) {
@@ -71,49 +80,71 @@ function getPhraseAppQueryParams (tags, fallbackLocale, branch) {
     .join('&');
 }
 
-async function loadLocale (phrase) {
-  for (const locale of phrase.locales) {
-    const filepath = `${phrase.path}${locale.filePrefix ? `${locale.filePrefix}-` : ''}${locale.locale_id}.json`;
-    let file = {};
+const getFileName = (filePrefix, localeId) => `${filePrefix ? `${filePrefix}-` : ''}${localeId}.json`;
 
-    if (fs.existsSync(filepath)) {
-      file = JSON.parse(fs.readFileSync(filepath));
-    }
+const getFilePath = (path, filePrefix, localeId) => {
+  return `${path}${getFileName(filePrefix, localeId)}`;
+}
+
+function getPhraseAppDownloadUrl(accessToken, projectId, localeId, tags, fallbackLocaleId, branch) {
+  return `https://${accessToken}@api.phraseapp.com/api/v2/projects/${projectId}/locales/${localeId}/download?${getPhraseAppQueryParams(tags, fallbackLocaleId, branch)}`;
+}
+
+function logDownloadError (err) {
+  console.error(err.red.bold);
+}
 
-    const tags = locale.tags || [false];
-
-    await new Promise((resolve, reject) => {
-      const url = `https://${
-        phrase.access_token
-      }@api.phraseapp.com/api/v2/projects/${phrase.project_id}/locales/${
-        locale.locale_id
-      }/download?${getPhraseAppQueryParams(tags, locale.fallback_locale_id, phrase.branch)}`;
-
-      request.get(url, (error, response, body) => {
-        if (!error && response.statusCode === 200) {
-          fs.writeFileSync(
-            filepath,
-            JSON.stringify(Object.assign(file, JSON.parse(body)), null, '\t'),
-          );
-          console.info(
-            `Success: locale file [${locale.locale_id}.json] was updated`.green.bold,
-          );
-          resolve();
-        } else {
-          if (response.statusCode !== 401) {
-            console.error(
-              `Error: locale file [${locale.locale_id}.json] error message: ${
-                JSON.parse(body).message
-              }`.red.bold,
-            );
-          } else {
-            console.error('Error: Please check your access_token'.red.bold);
-          }
-          reject(response);
-        }
-      });
+function downloadLocaleFile (phrase, locale) {
+  const {
+    access_token: accessToken,
+    branch,
+    path,
+    project_id: projectId,
+  } = phrase;
+
+  const {
+    filePrefix,
+    locale_id: localeId,
+    fallback_locale_id: fallbackLocaleId,
+  } = locale;
+
+  const filepath = getFilePath(path, filePrefix, localeId);
+
+  const tags = locale.tags || [false];
+
+  return new Promise((resolve, reject) => {
+    const url = getPhraseAppDownloadUrl(accessToken, projectId, localeId, tags, fallbackLocaleId, branch);
+
+    request.get(url, (error, response, body) => {
+      if (!error && response.statusCode === 200) {
+        // const content = JSON.stringify(JSON.parse(body), null, '\t');
+        fs.writeFileSync(filepath, body);
+        console.info(`Success: locale file ${getFileName(filePrefix, localeId)} was updated`.green.bold);
+        return resolve();
+      }
+
+      if (response.statusCode === 401) {
+        console.error('Error: Please check your access_token'.red.bold);
+      } else {
+        console.error(`Error: locale file ${getFileName(filePrefix, localeId)}. Message: ${JSON.parse(body).message}`.red)
+      }
+
+      reject(response);
     });
+  })
+}
+
+async function loadLocale (phrase) {
+  const startTime = new Date();
+  // unfortunately phraseapp only allows us 4 concurrent request. So we split our locales into groups of 4
+  const localeChunks = [...chunks(phrase.locales, 4)];
+  for (localeChunk of localeChunks) {
+    // Create Promise array to download the four translations for this chunk
+    const downloads = localeChunk.map(locale => downloadLocaleFile(phrase, locale));
+    await Promise.all(downloads);
   }
+
+  console.log(`Downloaded all files in ${(new Date() - startTime) / 1000}s`);
 }
 
 function loadLocalesFromConfig () {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@kununu/phraseapp-cli",
-  "version": "1.5.0-beta.2",
+  "version": "1.5.0-beta.3",
   "description": "",
   "main": "index.js",
   "bin": {