@kununu/phraseapp-cli 1.4.0-beta.2 → 1.5.0-beta.0

package/.eslintrc

@@ -1,5 +1,5 @@
 {
-  "extends": "@kununu",
+  "extends": "@kununu/eslint-config",
   "rules": {
     "no-restricted-syntax": ["off", ["ForOfStatement"]]
   }

package/.github/dependabot.yml

@@ -0,0 +1,26 @@
+version: 2
+updates:
+  - package-ecosystem: "composer"
+    directory: "/"
+    schedule:
+      interval: "weekly"
+      day: "saturday"
+    labels:
+      - "dependencies"
+    # Disable automatic rebasing to prevent overloading our CICD system
+    rebase-strategy: "disabled"
+    versioning-strategy: auto
+
+  - package-ecosystem: "npm"
+    directory: "/"
+    schedule:
+      interval: "weekly"
+      day: "saturday"
+    labels:
+      - "dependencies"
+    # Disable automatic rebasing to prevent overloading our CICD system
+    rebase-strategy: "disabled"
+    versioning-strategy: auto
+    # By default Dependabot has a limit of the number of open PR for version updates
+    # and security updates.
+    # See other defaults in here: https://docs.github.com/en/github/administering-a-repository/configuration-options-for-dependency-updates

package/SECURITY.md

@@ -0,0 +1,20 @@
+# Security Policy
+
+
+## Reporting a Vulnerability
+
+Jira is our entrypoint to report security vulnerabilities. Having this mind a KUNSECU user story (type Vulnerability) needs to be created.
+
+### How to fill the user story?
+
+Follow this [documentation](https://confluence.xing.hh/pages/viewpage.action?pageId=381133070).
+
+
+### To which team do I assign the user story?
+
+Follow the [component ownership matrix](https://confluence.xing.hh/display/kununu/Component+ownership+and+support) and assign it to the corresponding team.
+
+
+## Reporting the update of dependencies
+
+This is the benefit of having Dependabot. It will open pull requests for security and version updates. For more information check the Github [documentation](https://docs.github.com/en/github/administering-a-repository/managing-pull-requests-for-dependency-updates).

package/index.js

@@ -1,8 +1,9 @@
 #! /usr/bin/env node
 
-/* eslint-disable no-console */
+/* eslint-disable */
 
 const fs = require('fs');
+
 require('dotenv').config();
 
 const request = require('request');
@@ -15,6 +16,7 @@ function logErrorsAndExitProcess (errors) {
 
 function loadConfig () {
   const configPath = `${process.cwd()}/.phraseapp.json`;
+
   if (!fs.existsSync(configPath)) {
     logErrorsAndExitProcess(['Error: pharaseapp config file doesn\'t exist.']);
   }
@@ -49,10 +51,10 @@ function loadConfig () {
   return logErrorsAndExitProcess(errors);
 }
 
-function getPhraseAppQueryParams (tag, fallbackLocale, branch) {
+function getPhraseAppQueryParams (tags, fallbackLocale, branch) {
   const queryParams = {
     file_format: 'react_simple_json',
-    tag,
+    tags: tags.join(','),
   };
 
   if (fallbackLocale) {
@@ -78,42 +80,39 @@ async function loadLocale (phrase) {
       file = JSON.parse(fs.readFileSync(filepath));
     }
 
-    const tags = locale.tags || [false];
-
-    for (const tag of tags) {
-      await new Promise((resolve, reject) => {
-        const url = `https://${
-          phrase.access_token
-        }@api.phraseapp.com/api/v2/projects/${phrase.project_id}/locales/${
-          locale.locale_id
-        }/download?${getPhraseAppQueryParams(tag, locale.fallback_locale_id, phrase.branch)}`;
-        request.get(url, (error, response, body) => {
-          if (!error && response.statusCode === 200) {
-            fs.writeFileSync(
-              filepath,
-              JSON.stringify(Object.assign(file, JSON.parse(body)), null, '\t'),
+    await new Promise((resolve, reject) => {
+      const url = `https://${
+        phrase.access_token
+      }@api.phraseapp.com/api/v2/projects/${phrase.project_id}/locales/${
+        locale.locale_id
+      }/download?${getPhraseAppQueryParams(tags, locale.fallback_locale_id, phrase.branch)}`;
+
+      request.get(url, (error, response, body) => {
+        if (!error && response.statusCode === 200) {
+          fs.writeFileSync(
+            filepath,
+            JSON.stringify(Object.assign(file, JSON.parse(body)), null, '\t'),
+          );
+          console.info(
+            `Success: locale file [${locale.locale_id}.json]${
+              tag ? ` for tag ${tag} ` : ' '
+            }was updated`.green.bold,
+          );
+          resolve();
+        } else {
+          if (response.statusCode !== 401) {
+            console.error(
+              `Error: locale file [${locale.locale_id}.json] error message: ${
+                JSON.parse(body).message
+              }`.red.bold,
             );
-            console.info(
-              `Success: locale file [${locale.locale_id}.json]${
-                tag ? ` for tag ${tag} ` : ' '
-              }was updated`.green.bold,
-            );
-            resolve();
           } else {
-            if (response.statusCode !== 401) {
-              console.error(
-                `Error: locale file [${locale.locale_id}.json] error message: ${
-                  JSON.parse(body).message
-                }`.red.bold,
-              );
-            } else {
-              console.error('Error: Please check your access_token'.red.bold);
-            }
-            reject(response);
+            console.error('Error: Please check your access_token'.red.bold);
           }
-        });
+          reject(response);
+        }
       });
-    }
+    });
   }
 }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@kununu/phraseapp-cli",
-  "version": "1.4.0-beta.2",
+  "version": "1.5.0-beta.0",
   "description": "",
   "main": "index.js",
   "bin": {

package/src/argparser.js

@@ -1,4 +1,4 @@
-const ArgumentParser = require('argparse').ArgumentParser;
+const {ArgumentParser} = require('argparse');
 
 const pkg = require('../package.json');
 

package/src/commands.js

@@ -1,40 +1,42 @@
 const asyncLoop = require('node-async-loop');
+
 const {writeLocaleFile, quitError} = require('./helpers/utils');
 const {getProject, fetchLocale} = require('./helpers/api');
 
-const fetchAndSave = (config, projectID) =>
+const fetchAndSave = (config, projectID) => (
   new Promise((resolve, reject) => {
     asyncLoop(
       config.LOCALES,
       (locale, next) => {
         fetchLocale(config, projectID, locale)
-          .then(data => {
+          .then((data) => {
             writeLocaleFile(locale, config, data)
-              .then(data => {
+              .then(() => {
                 next();
               })
-              .catch(e => {
+              .catch((e) => {
                 next(e);
               });
           })
-          .catch(e => {
+          .catch((e) => {
             next(e);
           });
       },
-      err => {
+      (err) => {
         if (err) {
           reject(err);
         }
         resolve();
-      }
+      },
     );
-  });
+  })
+);
 
-const cmdDownload = async config => {
+const cmdDownload = async (config) => { // eslint-disable-line consistent-return
   try {
-    const projectID = config.PROJECT_NAME
-      ? await getProject(config)
-      : config.PROJECT_ID;
+    const projectID = config.PROJECT_NAME ?
+      await getProject(config) :
+      config.PROJECT_ID;
 
     await fetchAndSave(config, projectID);
     return true;
@@ -44,5 +46,5 @@ const cmdDownload = async config => {
 };
 
 module.exports = {
-  cmdDownload
+  cmdDownload,
 };

package/src/helpers/api.js

@@ -4,11 +4,11 @@ const {PHRASEAPP_BASEURL} = require('../constants');
 const {MESSAGES} = require('../constants');
 
 const getPhraseAppApiEndpoint = (endpoint, token) => ({
-  url: `https://${token}@${PHRASEAPP_BASEURL}/${endpoint}`,
   json: true,
+  url: `https://${token}@${PHRASEAPP_BASEURL}/${endpoint}`,
 });
 
-const getProject = config =>
+const getProject = config => (
   new Promise((resolve, reject) => {
     request.get(getPhraseAppApiEndpoint('projects', config.TOKEN), (err, res, body) => {
       if (err) {
@@ -23,6 +23,7 @@ const getProject = config =>
         const projectID = body
           .filter(item => item.name === config.PROJECT_NAME)
           .map(item => item.id);
+
         if (projectID.length < 1) {
           reject(new Error(MESSAGES.PROJECT_NOT_FOUND));
         }
@@ -30,9 +31,10 @@ const getProject = config =>
         resolve(projectID[0]);
       }
     });
-  });
+  })
+);
 
-const fetchLocale = (config, projectID, locale) =>
+const fetchLocale = (config, projectID, locale) => (
   new Promise((resolve, reject) => {
     const tag = config.TAG ? `&tag=${config.TAG}` : '';
 
@@ -66,10 +68,11 @@ const fetchLocale = (config, projectID, locale) =>
         );
       }
     });
-  });
+  })
+);
 
 module.exports = {
-  getProject,
   fetchLocale,
   getPhraseAppApiEndpoint,
+  getProject,
 };

package/src/helpers/utils.js

@@ -22,7 +22,7 @@ const quitSuccess = (msg) => {
   process.exit(0);
 };
 
-const mkConfig = args =>
+const mkConfig = args => (
   new Promise((resolve, reject) => {
     const config = {
       TOKEN: args.token || process.env.PHRASEAPP_ACCESS_TOKEN,
@@ -48,9 +48,10 @@ const mkConfig = args =>
     }
 
     resolve(config);
-  });
+  })
+);
 
-const writeLocaleFile = (locale, config, data) =>
+const writeLocaleFile = (locale, config, data) => (
   new Promise((resolve, reject) => {
     const fileExt = FORMATS.filter(item => item.format === config.FORMAT).map(
       item => item.ext,
@@ -72,11 +73,12 @@ const writeLocaleFile = (locale, config, data) =>
         resolve(`Written: ${file}`);
       });
     });
-  });
+  })
+);
 
 module.exports = {
-  quitSuccess,
-  quitError,
   mkConfig,
+  quitError,
+  quitSuccess,
   writeLocaleFile,
 };