@kununu/eslint-config 6.0.0-beta.9 → 6.0.1

package/README.md

@@ -14,17 +14,9 @@ Add @kununu/eslint-config npm package as dev dependency to your project:
 npm install --save-dev @kununu/eslint-config
 ```
 
-### TypeScript Projects
-
-If you're linting TypeScript files, you'll also need to install TypeScript:
-
-```console
-npm install --save-dev typescript
-```
-
 ## 💻 Usage
 
-### ESLint v9 (Flat Config) - Recommended
+### ESLint v9 (Flat Config)
 
 Create an `eslint.config.cjs` file:
 
@@ -37,59 +29,6 @@ export default [
 ];
 ```
 
-### ESLint v8 (Legacy Format)
-
-If you're still using ESLint v8, use version 5.x of this package:
-
-```console
-npm install --save-dev @kununu/eslint-config@5
-```
-
-Then create a `.eslintrc.js` file:
-
-```javascript
-module.exports = {
-  extends: '@kununu/eslint-config'
-};
-```
-
-## 🔧 Configuration Details
-
-This config includes rules for:
-
-- **JavaScript/JSX**: Babel parser with React support
-- **TypeScript/TSX**: TypeScript ESLint v8 with strict typing
-- **React**: React 18+ with hooks support
-- **Testing**: Jest, Jest DOM, and Testing Library
-- **Code Quality**: Import ordering, Lodash optimization, granular selectors
-- **Formatting**: Prettier integration with consistent style
-
-### Included Plugins
-
-- `@babel/eslint-plugin` - Babel-specific rules
-- `eslint-plugin-react` - React-specific linting rules
-- `eslint-plugin-react-hooks` - Rules for React Hooks
-- `eslint-plugin-jsx-a11y` - Accessibility rules for JSX
-- `eslint-plugin-import` - Import/export syntax validation
-- `eslint-plugin-lodash` - Lodash optimization
-- `eslint-plugin-prettier` - Prettier integration
-- `@typescript-eslint` - TypeScript support
-- `eslint-plugin-testing-library` - Testing Library best practices
-- `eslint-plugin-jest-dom` - Jest DOM matchers
-- `eslint-plugin-sort-destructure-keys` - Destructuring key sorting
-- `eslint-plugin-granular-selectors` - Zustand/Redux selector validation
-- `eslint-plugin-perfectionist` - Universal sorting (interfaces, enums, objects, imports, etc.)
-
-## 📝 Key Rules
-
-- Prefer early returns over logical expressions in return statements
-- Alphabetically sorted imports with newlines between groups
-- React components with sorted props and defaultProps
-- TypeScript interfaces with sorted keys
-- 2-space indentation
-- Single quotes, trailing commas
-- No semicolons (via Prettier)
-
 See [docs](https://eslint.org/docs/user-guide/getting-started) to find more detailed information on ESLint configuration and usage.
 
 ## ⚡️ Plugins

package/eslint.config.mjs

@@ -5,6 +5,7 @@ import stylistic from '@stylistic/eslint-plugin';
 import typescriptParser from '@typescript-eslint/parser';
 import eslintConfigPrettier from 'eslint-config-prettier/flat';
 import granularSelectorsPlugin from 'eslint-plugin-granular-selectors';
+import pluginJest from 'eslint-plugin-jest';
 import jestDomPlugin from 'eslint-plugin-jest-dom';
 import jsxA11yPlugin from 'eslint-plugin-jsx-a11y';
 import lodashPlugin from 'eslint-plugin-lodash';
@@ -17,17 +18,17 @@ import {defineConfig, globalIgnores} from 'eslint/config';
 import tseslint from 'typescript-eslint';
 
 export default defineConfig([
-  js.configs.recommended,
-  tseslint.configs.recommended,
   eslintConfigPrettier,
+  js.configs.recommended,
+  jsxA11yPlugin.flatConfigs.recommended,
   perfectionistPlugin.configs['recommended-natural'],
   reactHooksPlugin.configs.flat.recommended,
   reactPlugin.configs.flat.recommended,
   reactPlugin.configs.flat['jsx-runtime'],
+  sonarjs.configs.recommended,
   stylistic.configs.recommended,
-  jsxA11yPlugin.flatConfigs.recommended,
   testingLibraryPlugin.configs['flat/dom'],
-  sonarjs.configs.recommended,
+  tseslint.configs.recommended,
 
   globalIgnores([
     '**/.next/',
@@ -48,6 +49,9 @@ export default defineConfig([
     files: ['**/*.ts', '**/*.tsx'],
     languageOptions: {
       parser: typescriptParser,
+      parserOptions: {
+        projectService: true,
+      },
     },
   },
 
@@ -69,6 +73,10 @@ export default defineConfig([
       ['**/*.spec.*'],
     ],
     ...jestDomPlugin.configs['flat/recommended'],
+    languageOptions: {
+      globals: pluginJest.environments.globals.globals,
+    },
+    plugins: {jest: pluginJest},
     rules: {
       '@typescript-eslint/no-explicit-any': 'off',
       'react/display-name': 'off',
@@ -83,12 +91,19 @@ export default defineConfig([
         },
       },
     },
+    linterOptions: {
+      reportUnusedDisableDirectives: 'error',
+    },
     plugins: {
       'granular-selectors': granularSelectorsPlugin,
       lodash: lodashPlugin,
     },
     rules: {
+      // Prevent empty lines in arrays
+      '@stylistic/array-bracket-newline': ['error', 'consistent'],
+      '@stylistic/array-bracket-spacing': ['error', 'never'],
       '@stylistic/arrow-parens': ['error', 'as-needed'],
+      '@stylistic/brace-style': ['error', '1tbs'],
       '@stylistic/member-delimiter-style': ['error', {
         multiline: {
           delimiter: 'semi',
@@ -104,20 +119,63 @@ export default defineConfig([
         },
         singleline: {
           delimiter: 'semi',
-          requireLast: true,
+          requireLast: false,
         },
       }],
+      // Prevent multiple consecutive empty lines but allow single ones
+      '@stylistic/no-multiple-empty-lines': ['error', {
+        max: 1,
+        maxBOF: 0,
+        maxEOF: 0,
+      }],
+      // For object destructuring patterns
+      '@stylistic/object-curly-newline': ['error', {consistent: true}],
+      // Prevent empty lines inside object literals and destructuring
       '@stylistic/object-curly-spacing': ['error', 'never'],
-      '@stylistic/operator-linebreak': ['error', 'after'],
+      '@stylistic/operator-linebreak': ['error', 'after', {overrides: {'|': 'before'}}],
+      '@stylistic/padded-blocks': ['error', 'never'],
+      '@stylistic/padding-line-between-statements': ['error',
+        // Allow any spacing between imports (to allow grouping and other import rules)
+        {blankLine: 'any', next: 'import', prev: 'import'},
+        // Always require blank line after imports when followed by non-imports
+        {blankLine: 'always', next: '*', prev: 'import'},
+        // But allow imports to be followed by imports without forcing blank line
+        {blankLine: 'any', next: 'import', prev: 'import'},
+        // Allow any spacing between variable declarations (before and between)
+        {blankLine: 'any', next: ['const', 'let', 'var'], prev: '*'},
+        // Always require blank line after variable declarations when followed by non-variables
+        {blankLine: 'always', next: '*', prev: ['const', 'let', 'var']},
+        // But allow variables to be followed by variables without forcing blank line (override above)
+        {blankLine: 'any', next: ['const', 'let', 'var'], prev: ['const', 'let', 'var']},
+        // Always require blank line before return statements
+        {blankLine: 'always', next: 'return', prev: '*'},
+        // Always require blank line before case and default statements
+        {blankLine: 'always', next: '*', prev: ['case', 'default']},
+        // Allow blank lines between JSX elements (expression statements)
+        {blankLine: 'any', next: 'expression', prev: 'expression'}],
       '@stylistic/quote-props': ['error', 'as-needed'],
       '@stylistic/semi': ['error', 'always'],
+      '@stylistic/switch-colon-spacing': 'error',
       '@typescript-eslint/no-use-before-define': 'error',
       '@typescript-eslint/no-var-requires': 'error',
       'granular-selectors/granular-selectors': ['error', {
         include: ['use.*Selector.*', 'use.*Store.*'],
       }],
       'lodash/import-scope': [2, 'method'],
+      'no-console': 'warn',
       'no-param-reassign': ['error', {props: false}],
+      'no-restricted-imports': [
+        'error',
+        {
+          paths: [
+            {
+              importNames: ['default'],
+              message: '\n We want to avoid importing react directly. Please import individual hooks and types from the react module instead.',
+              name: 'react',
+            },
+          ],
+        },
+      ],
       'no-use-before-define': 'off',
       'perfectionist/sort-imports': [
         'error',
@@ -132,6 +190,7 @@ export default defineConfig([
                 '^actions/.+',
                 '^client/.+',
                 '^components/.+',
+                '^contexts/.+',
                 '^genericTypes/.+',
                 '^hooks/.+',
                 '^images/.+',
@@ -139,6 +198,7 @@ export default defineConfig([
                 '^pages/.+',
                 '^server/.+',
                 '^slices/.+',
+                '^src/.+',
                 '^state/.+',
                 '^tracking/.+',
                 '^types/.+',
@@ -157,7 +217,8 @@ export default defineConfig([
             'type-index',
             ['value-builtin', 'value-external'],
             'value-internal',
-            ['value-parent', 'alias'],
+            'alias',
+            'value-parent',
             'value-sibling',
             'value-index',
             'ts-equals-import',
@@ -167,8 +228,42 @@ export default defineConfig([
           type: 'natural',
         },
       ],
+      'perfectionist/sort-modules': ['error', {type: 'usage'}],
+      'perfectionist/sort-union-types': ['error', {
+        groups: [
+          'conditional',
+          'function',
+          'import',
+          'intersection',
+          'keyword',
+          'literal',
+          'named',
+          'object',
+          'operator',
+          'tuple',
+          'union',
+          'nullish',
+        ],
+      }],
+      'prefer-template': 'error',
       'react-hooks/exhaustive-deps': 'warn',
       'react-hooks/rules-of-hooks': 'error',
+      'react/jsx-closing-bracket-location': ['error', 'tag-aligned'],
+      // More restrictive JSX rules that are auto-fixable
+      'react/jsx-curly-spacing': ['error', 'never'],
+      'react/jsx-first-prop-new-line': ['error', 'multiline-multiprop'],
+      // Control JSX prop formatting more precisely
+      'react/jsx-max-props-per-line': ['error', {maximum: 1, when: 'multiline'}],
+      // Keep the non-auto-fixable rule to detect the issue
+      'react/jsx-props-no-multi-spaces': 'error',
+      // Use jsx-tag-spacing for what it can auto-fix
+      'react/jsx-tag-spacing': ['error', {
+        afterOpening: 'never',
+        beforeClosing: 'never',
+        beforeSelfClosing: 'always',
+        closingSlash: 'never',
+      }],
+      'sonarjs/deprecation': ['warn'],
       'sonarjs/todo-tag': ['warn'],
     },
   },

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@kununu/eslint-config",
-  "version": "6.0.0-beta.9",
+  "version": "6.0.1",
   "description": "kununu's ESLint config",
   "main": "eslint.config.mjs",
   "type": "module",
@@ -30,7 +30,7 @@
   },
   "homepage": "https://github.com/kununu/eslint-config#readme",
   "dependencies": {
-    "@babel/core": "7.28.6",
+    "@babel/core": "7.29.0",
     "@babel/eslint-parser": "7.28.6",
     "@babel/eslint-plugin": "7.27.1",
     "@eslint/js": "9.39.2",
@@ -39,6 +39,7 @@
     "eslint": "9.39.2",
     "eslint-config-prettier": "10.1.8",
     "eslint-plugin-granular-selectors": "1.4.0",
+    "eslint-plugin-jest": "29.12.2",
     "eslint-plugin-jest-dom": "5.5.0",
     "eslint-plugin-jsx-a11y": "6.10.2",
     "eslint-plugin-lodash": "8.0.0",