@kununu/eslint-config 6.0.0-beta.8 → 6.0.1

package/README.md

@@ -14,19 +14,11 @@ Add @kununu/eslint-config npm package as dev dependency to your project:
 npm install --save-dev @kununu/eslint-config
 ```
 
-### TypeScript Projects
-
-If you're linting TypeScript files, you'll also need to install TypeScript:
-
-```console
-npm install --save-dev typescript
-```
-
 ## 💻 Usage
 
-### ESLint v9 (Flat Config) - Recommended
+### ESLint v9 (Flat Config)
 
-Create an `eslint.config.js` file:
+Create an `eslint.config.cjs` file:
 
 ```javascript
 import kununuConfig from '@kununu/eslint-config';
@@ -37,59 +29,6 @@ export default [
 ];
 ```
 
-### ESLint v8 (Legacy Format)
-
-If you're still using ESLint v8, use version 5.x of this package:
-
-```console
-npm install --save-dev @kununu/eslint-config@5
-```
-
-Then create a `.eslintrc.js` file:
-
-```javascript
-module.exports = {
-  extends: '@kununu/eslint-config'
-};
-```
-
-## 🔧 Configuration Details
-
-This config includes rules for:
-
-- **JavaScript/JSX**: Babel parser with React support
-- **TypeScript/TSX**: TypeScript ESLint v8 with strict typing
-- **React**: React 18+ with hooks support
-- **Testing**: Jest, Jest DOM, and Testing Library
-- **Code Quality**: Import ordering, Lodash optimization, granular selectors
-- **Formatting**: Prettier integration with consistent style
-
-### Included Plugins
-
-- `@babel/eslint-plugin` - Babel-specific rules
-- `eslint-plugin-react` - React-specific linting rules
-- `eslint-plugin-react-hooks` - Rules for React Hooks
-- `eslint-plugin-jsx-a11y` - Accessibility rules for JSX
-- `eslint-plugin-import` - Import/export syntax validation
-- `eslint-plugin-lodash` - Lodash optimization
-- `eslint-plugin-prettier` - Prettier integration
-- `@typescript-eslint` - TypeScript support
-- `eslint-plugin-testing-library` - Testing Library best practices
-- `eslint-plugin-jest-dom` - Jest DOM matchers
-- `eslint-plugin-sort-destructure-keys` - Destructuring key sorting
-- `eslint-plugin-granular-selectors` - Zustand/Redux selector validation
-- `eslint-plugin-perfectionist` - Universal sorting (interfaces, enums, objects, imports, etc.)
-
-## 📝 Key Rules
-
-- Prefer early returns over logical expressions in return statements
-- Alphabetically sorted imports with newlines between groups
-- React components with sorted props and defaultProps
-- TypeScript interfaces with sorted keys
-- 2-space indentation
-- Single quotes, trailing commas
-- No semicolons (via Prettier)
-
 See [docs](https://eslint.org/docs/user-guide/getting-started) to find more detailed information on ESLint configuration and usage.
 
 ## ⚡️ Plugins

package/eslint.config.mjs

@@ -1,371 +1,270 @@
 import babelParser from '@babel/eslint-parser';
 import babelPlugin from '@babel/eslint-plugin';
 import js from '@eslint/js';
+import stylistic from '@stylistic/eslint-plugin';
 import typescriptParser from '@typescript-eslint/parser';
 import eslintConfigPrettier from 'eslint-config-prettier/flat';
 import granularSelectorsPlugin from 'eslint-plugin-granular-selectors';
-import importPlugin from 'eslint-plugin-import';
+import pluginJest from 'eslint-plugin-jest';
 import jestDomPlugin from 'eslint-plugin-jest-dom';
 import jsxA11yPlugin from 'eslint-plugin-jsx-a11y';
 import lodashPlugin from 'eslint-plugin-lodash';
-import perfectionist from 'eslint-plugin-perfectionist';
+import perfectionistPlugin from 'eslint-plugin-perfectionist';
 import reactPlugin from 'eslint-plugin-react';
 import reactHooksPlugin from 'eslint-plugin-react-hooks';
-import sortDestructureKeysPlugin from 'eslint-plugin-sort-destructure-keys';
+import sonarjs from 'eslint-plugin-sonarjs';
 import testingLibraryPlugin from 'eslint-plugin-testing-library';
-import typescriptEslint from 'typescript-eslint';
+import {defineConfig, globalIgnores} from 'eslint/config';
+import tseslint from 'typescript-eslint';
 
-// Base rules shared between JS and TS configurations
-const baseRules = {
-  '@babel/object-curly-spacing': 'error',
-  'arrow-parens': ['error', 'as-needed'],
-  'eol-last': ['error', 'always'],
-  'granular-selectors/granular-selectors': ['error', {
-    include: ['use.*Selector.*', 'use.*Store.*']
-  }],
-  'import/extensions': ['error', 'ignorePackages', {
-    'js': 'never',
-    'json': 'always',
-    'jsx': 'never',
-    'scss': 'ignorePackages',
-    'ts': 'never',
-    'tsx': 'never'
-  }],
-  'import/no-extraneous-dependencies': ['error', {
-    devDependencies: [
-      '**/*.spec.js',
-      '**/*.spec.jsx',
-      '**/*.test.js',
-      '**/*.test.jsx',
-      '**/stories.jsx',
-      '*/test-*/*.js',
-      '*/test-*/*.jsx',
-      'config/**/*.js',
-      'jest.setup.js',
-      'jestsetup.js',
-      'mockBff/*',
-      'next.config.js',
-    ],
-  }],
-  'import/no-useless-path-segments': ['error', {
-    'noUselessIndex': true,
-  }],
-  'import/order': [
-    'error',
-    {
-      'alphabetize': {
-        'caseInsensitive': true,
-        'order': 'asc'
-      },
-      'groups': [
-        'builtin',
-        'external',
-        'internal',
-        'parent',
-        'sibling',
-        'index'
-      ],
-      'newlines-between': 'always',
-      'pathGroups': [
-        {
-          'group': 'builtin',
-          'pattern': 'react',
-          'position': 'before'
-        },
-        {
-          'group': 'external',
-          'pattern': '@kununu/**',
-          'position': 'after'
-        }
-      ],
-      'pathGroupsExcludedImportTypes': ['react']
-    }
-  ],
-  'indent': 'off',
-  'jsx-a11y/anchor-is-valid': ['error', {
-    components: ['Link'],
-    specialLink: ['to'],
-  }],
-  'jsx-a11y/label-has-for': ['error', {
-    'required': 'id',
-  }],
-  'lodash/import-scope': [2, 'method'],
-  'max-len': 'off',
-  'no-confusing-arrow': 'off',
-  'no-multiple-empty-lines': ['error', {'max': 1, 'maxEOF': 1}],
-  'no-param-reassign': ['error', {props: false}],
-  'no-prototype-builtins': 'off',
-  'no-restricted-exports': 'off',
-  'no-restricted-syntax': ['error', 
-    {
-      message: 'Prefer early returns over logical expressions in return statements. Use if (condition) return value; instead.',
-      selector: 'ReturnStatement > LogicalExpression[operator="&&"] > JSXElement'
-    },
-    {
-      message: 'Prefer early returns over logical expressions in return statements. Use if (condition) return value; instead.',
-      selector: 'ReturnStatement > LogicalExpression[operator="&&"] > JSXFragment'
-    },
-    {
-      message: 'Prefer early returns over logical expressions in return statements. Use if (condition) return value; instead.',
-      selector: 'ReturnStatement > LogicalExpression[operator="&&"] > CallExpression'
-    },
-    {
-      message: 'Prefer early returns over logical expressions in return statements. Use if (condition) return value; instead.',
-      selector: 'ReturnStatement > LogicalExpression[operator="&&"] > ObjectExpression'
-    },
-    {
-      message: 'Prefer early returns over logical expressions in return statements. Use if (condition) return value; instead.',
-      selector: 'ReturnStatement > LogicalExpression[operator="&&"] > ArrayExpression'
-    },
-    {
-      message: 'Prefer early returns over logical expressions in return statements. Use if (condition) return value; instead.',
-      selector: 'ReturnStatement > SequenceExpression LogicalExpression[operator="&&"]'
-    },
-    {
-      message: 'Prefer early returns over logical expressions in return statements. Use if (condition) return value; instead.',
-      selector: 'ReturnStatement > ParenthesizedExpression > SequenceExpression LogicalExpression[operator="&&"]'
-    }
-  ],
-  'no-underscore-dangle': ['error', {'allow': ['__NEXT_DATA__', '__NEXT_REDUX_STORE__']}],
-  'no-use-before-define': 'off',
-  'object-curly-spacing': 'off',
-  'padding-line-between-statements': ['error', {
-    'blankLine': 'always', 'next': '*', 'prev': ['const', 'let', 'var'],
-  }, {
-    'blankLine': 'any', 'next': ['const', 'let', 'var'], 'prev': ['const', 'let', 'var'],
-  }],
-  'prefer-promise-reject-errors': 'off',
-  'react-hooks/exhaustive-deps': 'warn',
-  'react-hooks/rules-of-hooks': 'error',
-  'react/function-component-definition': 'off',
-  'react/jsx-props-no-spreading': ['error', {
-    'custom': 'ignore',
-    'html': 'enforce',
-  }],
-  'react/jsx-sort-props': ['error', {
-    'ignoreCase': true
-  }],
-  'react/no-direct-mutation-state': 'error',
-  'react/react-in-jsx-scope': 'off',
-  'react/require-default-props': 0,
-  'react/sort-default-props': ['error', {
-    'ignoreCase': true
-  }],
-  'react/sort-prop-types': ['error', {
-    'ignoreCase': true
-  }],
-  'react/state-in-constructor': 'off',
-  'react/static-property-placement': ['error', 'property assignment'],
-  'sort-destructure-keys/sort-destructure-keys': [2, {'caseSensitive': false}],
-  'sort-keys': ['error', 'asc', {'caseSensitive': false, 'natural': false}],
-  'testing-library/prefer-screen-queries': 'off',
-  'testing-library/render-result-naming-convention': 'off'
-};
+export default defineConfig([
+  eslintConfigPrettier,
+  js.configs.recommended,
+  jsxA11yPlugin.flatConfigs.recommended,
+  perfectionistPlugin.configs['recommended-natural'],
+  reactHooksPlugin.configs.flat.recommended,
+  reactPlugin.configs.flat.recommended,
+  reactPlugin.configs.flat['jsx-runtime'],
+  sonarjs.configs.recommended,
+  stylistic.configs.recommended,
+  testingLibraryPlugin.configs['flat/dom'],
+  tseslint.configs.recommended,
+
+  globalIgnores([
+    '**/.next/',
+    '**/__mocks__/',
+    '**/__snapshots__/',
+    '**/build/',
+    '**/coverage/',
+    '**/dist/',
+    '**/node_modules/',
+    '**/out/',
+    '.git/',
+    'jest.config.js',
+    'newrelic.js',
+    'next.config.js',
+  ]),
 
-export default [
-  // Global ignores
   {
-    ignores: [
-      '**/node_modules/**',
-      '**/dist/**',
-      '**/build/**',
-      '**/.next/**',
-      '**/coverage/**',
-    ]
+    files: ['**/*.ts', '**/*.tsx'],
+    languageOptions: {
+      parser: typescriptParser,
+      parserOptions: {
+        projectService: true,
+      },
+    },
   },
 
-  // Base JavaScript/JSX configuration
   {
     files: ['**/*.js', '**/*.jsx'],
     languageOptions: {
-      globals: {
-        __dirname: 'readonly',
-        __filename: 'readonly',
-        afterAll: 'readonly',
-        afterEach: 'readonly',
-        beforeAll: 'readonly',
-        beforeEach: 'readonly',
-        Buffer: 'readonly',
-        console: 'readonly',
-        describe: 'readonly',
-        document: 'readonly',
-        expect: 'readonly',
-        exports: 'readonly',
-        fetch: 'readonly',
-        it: 'readonly',
-        jest: 'readonly',
-        localStorage: 'readonly',
-        module: 'readonly',
-        navigator: 'readonly',
-        process: 'readonly',
-        require: 'readonly',
-        sessionStorage: 'readonly',
-        test: 'readonly',
-        window: 'readonly',
-      },
       parser: babelParser,
       parserOptions: {
-        babelOptions: {
-          presets: ['@babel/preset-react'],
-        },
-        ecmaFeatures: {
-          jsx: true,
-        },
-        ecmaVersion: 'latest',
         requireConfigFile: false,
-        sourceType: 'module',
       },
     },
     plugins: {
-      '@babel': babelPlugin,
-      'granular-selectors': granularSelectorsPlugin,
-      'import': importPlugin,
-      'jest-dom': jestDomPlugin,
-      'jsx-a11y': jsxA11yPlugin,
-      'lodash': lodashPlugin,
-      'react': reactPlugin,
-      'react-hooks': reactHooksPlugin,
-      'sort-destructure-keys': sortDestructureKeysPlugin,
+      babel: babelPlugin,
     },
-    rules: {
-      ...js.configs.recommended.rules,
-      ...baseRules,
+  },
+
+  {
+    files: [
+      ['**/*.spec.*'],
+    ],
+    ...jestDomPlugin.configs['flat/recommended'],
+    languageOptions: {
+      globals: pluginJest.environments.globals.globals,
     },
-    settings: {
-      'import/resolver': {
-        node: {
-          extensions: ['.js', '.jsx', '.json'],
-        },
-      },
-      react: {
-        version: 'detect',
-      },
+    plugins: {jest: pluginJest},
+    rules: {
+      '@typescript-eslint/no-explicit-any': 'off',
+      'react/display-name': 'off',
     },
   },
 
-  // TypeScript configuration
   {
-    files: ['**/*.ts', '**/*.tsx'],
     languageOptions: {
-      globals: {
-        __dirname: 'readonly',
-        __filename: 'readonly',
-        afterAll: 'readonly',
-        afterEach: 'readonly',
-        beforeAll: 'readonly',
-        beforeEach: 'readonly',
-        Buffer: 'readonly',
-        console: 'readonly',
-        describe: 'readonly',
-        document: 'readonly',
-        expect: 'readonly',
-        exports: 'readonly',
-        fetch: 'readonly',
-        it: 'readonly',
-        jest: 'readonly',
-        localStorage: 'readonly',
-        module: 'readonly',
-        navigator: 'readonly',
-        process: 'readonly',
-        require: 'readonly',
-        sessionStorage: 'readonly',
-        test: 'readonly',
-        window: 'readonly',
-      },
-      parser: typescriptParser,
       parserOptions: {
         ecmaFeatures: {
           jsx: true,
         },
-        ecmaVersion: 'latest',
-        sourceType: 'module',
       },
     },
+    linterOptions: {
+      reportUnusedDisableDirectives: 'error',
+    },
     plugins: {
-      '@babel': babelPlugin,
-      '@typescript-eslint': typescriptEslint.plugin,
       'granular-selectors': granularSelectorsPlugin,
-      'import': importPlugin,
-      'jest-dom': jestDomPlugin,
-      'jsx-a11y': jsxA11yPlugin,
-      'lodash': lodashPlugin,
-      'react': reactPlugin,
-      'react-hooks': reactHooksPlugin,
-      'sort-destructure-keys': sortDestructureKeysPlugin,
+      lodash: lodashPlugin,
     },
     rules: {
-      ...js.configs.recommended.rules,
-      ...typescriptEslint.configs.recommended.rules,
-      ...typescriptEslint.configs.stylistic.rules,
-      ...baseRules,
-      '@typescript-eslint/indent': 'off',
-      '@typescript-eslint/no-use-before-define': ['error'],
-      '@typescript-eslint/no-var-requires': 'off',
-      'import/no-extraneous-dependencies': ['error', {
-        devDependencies: [
-          '**/*.spec.ts',
-          '**/*.spec.tsx',
-          '**/stories.tsx',
-        ],
+      // Prevent empty lines in arrays
+      '@stylistic/array-bracket-newline': ['error', 'consistent'],
+      '@stylistic/array-bracket-spacing': ['error', 'never'],
+      '@stylistic/arrow-parens': ['error', 'as-needed'],
+      '@stylistic/brace-style': ['error', '1tbs'],
+      '@stylistic/member-delimiter-style': ['error', {
+        multiline: {
+          delimiter: 'semi',
+          requireLast: true,
+        },
+        overrides: {
+          interface: {
+            multiline: {
+              delimiter: 'semi',
+              requireLast: true,
+            },
+          },
+        },
+        singleline: {
+          delimiter: 'semi',
+          requireLast: false,
+        },
       }],
-      'react/prop-types': 'off',
-    },
-    settings: {
-      'import/resolver': {
-        node: {
-          extensions: ['.ts', '.tsx', '.json'],
+      // Prevent multiple consecutive empty lines but allow single ones
+      '@stylistic/no-multiple-empty-lines': ['error', {
+        max: 1,
+        maxBOF: 0,
+        maxEOF: 0,
+      }],
+      // For object destructuring patterns
+      '@stylistic/object-curly-newline': ['error', {consistent: true}],
+      // Prevent empty lines inside object literals and destructuring
+      '@stylistic/object-curly-spacing': ['error', 'never'],
+      '@stylistic/operator-linebreak': ['error', 'after', {overrides: {'|': 'before'}}],
+      '@stylistic/padded-blocks': ['error', 'never'],
+      '@stylistic/padding-line-between-statements': ['error',
+        // Allow any spacing between imports (to allow grouping and other import rules)
+        {blankLine: 'any', next: 'import', prev: 'import'},
+        // Always require blank line after imports when followed by non-imports
+        {blankLine: 'always', next: '*', prev: 'import'},
+        // But allow imports to be followed by imports without forcing blank line
+        {blankLine: 'any', next: 'import', prev: 'import'},
+        // Allow any spacing between variable declarations (before and between)
+        {blankLine: 'any', next: ['const', 'let', 'var'], prev: '*'},
+        // Always require blank line after variable declarations when followed by non-variables
+        {blankLine: 'always', next: '*', prev: ['const', 'let', 'var']},
+        // But allow variables to be followed by variables without forcing blank line (override above)
+        {blankLine: 'any', next: ['const', 'let', 'var'], prev: ['const', 'let', 'var']},
+        // Always require blank line before return statements
+        {blankLine: 'always', next: 'return', prev: '*'},
+        // Always require blank line before case and default statements
+        {blankLine: 'always', next: '*', prev: ['case', 'default']},
+        // Allow blank lines between JSX elements (expression statements)
+        {blankLine: 'any', next: 'expression', prev: 'expression'}],
+      '@stylistic/quote-props': ['error', 'as-needed'],
+      '@stylistic/semi': ['error', 'always'],
+      '@stylistic/switch-colon-spacing': 'error',
+      '@typescript-eslint/no-use-before-define': 'error',
+      '@typescript-eslint/no-var-requires': 'error',
+      'granular-selectors/granular-selectors': ['error', {
+        include: ['use.*Selector.*', 'use.*Store.*'],
+      }],
+      'lodash/import-scope': [2, 'method'],
+      'no-console': 'warn',
+      'no-param-reassign': ['error', {props: false}],
+      'no-restricted-imports': [
+        'error',
+        {
+          paths: [
+            {
+              importNames: ['default'],
+              message: '\n We want to avoid importing react directly. Please import individual hooks and types from the react module instead.',
+              name: 'react',
+            },
+          ],
         },
-        typescript: true,
-      },
-      react: {
-        version: 'detect',
-      },
-    },
-  },
-
-  // TypeScript stories and spec files
-  {
-    files: ['**/stories.tsx', '**/*.spec.ts', '**/*.spec.tsx'],
-    rules: {
-      '@typescript-eslint/no-explicit-any': 'off',
-    },
-  },
-
-  // Test files configuration
-  {
-    files: [
-      '**/__tests__/**/*.[jt]s?(x)',
-      '**/?(*.)+(spec|test).[jt]s?(x)'
-    ],
-    plugins: {
-      'testing-library': testingLibraryPlugin,
-    },
-    rules: {
-      'global-require': 'off',
-      'jsx-a11y/anchor-is-valid': 'off',
-    },
-  },
-
-  // Spec files only
-  {
-    files: ['*.spec.js', '*.spec.jsx', '*.spec.ts', '*.spec.tsx'],
-    rules: {
-      'global-require': 'off',
-      'jsx-a11y/anchor-is-valid': 'off',
+      ],
+      'no-use-before-define': 'off',
+      'perfectionist/sort-imports': [
+        'error',
+        {
+          customGroups: [
+            {
+              elementNamePattern: ['^react$'],
+              groupName: 'react',
+            },
+            {
+              elementNamePattern: [
+                '^actions/.+',
+                '^client/.+',
+                '^components/.+',
+                '^contexts/.+',
+                '^genericTypes/.+',
+                '^hooks/.+',
+                '^images/.+',
+                '^mocks/.+',
+                '^pages/.+',
+                '^server/.+',
+                '^slices/.+',
+                '^src/.+',
+                '^state/.+',
+                '^tracking/.+',
+                '^types/.+',
+                '^utils/.+',
+              ],
+              groupName: 'alias',
+            },
+          ],
+          groups: [
+            'react',
+            'type-import',
+            ['type-builtin', 'type-external'],
+            'type-internal',
+            'type-parent',
+            'type-sibling',
+            'type-index',
+            ['value-builtin', 'value-external'],
+            'value-internal',
+            'alias',
+            'value-parent',
+            'value-sibling',
+            'value-index',
+            'ts-equals-import',
+            'unknown',
+          ],
+          internalPattern: ['^~/.+', '^@kununu/.+'],
+          type: 'natural',
+        },
+      ],
+      'perfectionist/sort-modules': ['error', {type: 'usage'}],
+      'perfectionist/sort-union-types': ['error', {
+        groups: [
+          'conditional',
+          'function',
+          'import',
+          'intersection',
+          'keyword',
+          'literal',
+          'named',
+          'object',
+          'operator',
+          'tuple',
+          'union',
+          'nullish',
+        ],
+      }],
+      'prefer-template': 'error',
+      'react-hooks/exhaustive-deps': 'warn',
+      'react-hooks/rules-of-hooks': 'error',
+      'react/jsx-closing-bracket-location': ['error', 'tag-aligned'],
+      // More restrictive JSX rules that are auto-fixable
+      'react/jsx-curly-spacing': ['error', 'never'],
+      'react/jsx-first-prop-new-line': ['error', 'multiline-multiprop'],
+      // Control JSX prop formatting more precisely
+      'react/jsx-max-props-per-line': ['error', {maximum: 1, when: 'multiline'}],
+      // Keep the non-auto-fixable rule to detect the issue
+      'react/jsx-props-no-multi-spaces': 'error',
+      // Use jsx-tag-spacing for what it can auto-fix
+      'react/jsx-tag-spacing': ['error', {
+        afterOpening: 'never',
+        beforeClosing: 'never',
+        beforeSelfClosing: 'always',
+        closingSlash: 'never',
+      }],
+      'sonarjs/deprecation': ['warn'],
+      'sonarjs/todo-tag': ['warn'],
     },
   },
-
-  // Reducer files
-  {
-    files: [
-      '**/reducers/**/*.js',
-      '**/reducers/**/*.ts'
-    ],
-    rules: {
-      'default-param-last': 'off'
-    }
-  },
-
-  perfectionist.configs['recommended-natural'],
-  eslintConfigPrettier,
-];
+]);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@kununu/eslint-config",
-  "version": "6.0.0-beta.8",
+  "version": "6.0.1",
   "description": "kununu's ESLint config",
   "main": "eslint.config.mjs",
   "type": "module",
@@ -30,27 +30,24 @@
   },
   "homepage": "https://github.com/kununu/eslint-config#readme",
   "dependencies": {
-    "@babel/core": "7.28.6",
+    "@babel/core": "7.29.0",
     "@babel/eslint-parser": "7.28.6",
     "@babel/eslint-plugin": "7.27.1",
-    "@eslint/compat": "2.0.1",
     "@eslint/js": "9.39.2",
-    "@typescript-eslint/eslint-plugin": "8.54.0",
+    "@stylistic/eslint-plugin": "5.7.1",
     "@typescript-eslint/parser": "8.54.0",
     "eslint": "9.39.2",
     "eslint-config-prettier": "10.1.8",
-    "eslint-import-resolver-alias": "1.1.2",
     "eslint-plugin-granular-selectors": "1.4.0",
-    "eslint-plugin-import": "2.32.0",
+    "eslint-plugin-jest": "29.12.2",
     "eslint-plugin-jest-dom": "5.5.0",
     "eslint-plugin-jsx-a11y": "6.10.2",
     "eslint-plugin-lodash": "8.0.0",
-    "eslint-plugin-prettier": "5.5.5",
+    "eslint-plugin-perfectionist": "5.4.0",
     "eslint-plugin-react": "7.37.5",
     "eslint-plugin-react-hooks": "7.0.1",
-    "eslint-plugin-sort-destructure-keys": "2.0.0",
+    "eslint-plugin-sonarjs": "3.0.6",
     "eslint-plugin-testing-library": "7.15.4",
-    "eslint-plugin-perfectionist": "5.4.0",
     "prettier": "3.8.1",
     "typescript-eslint": "8.54.0"
   },

package/MIGRATION_NOTES.md

@@ -1,181 +0,0 @@
-# ESLint Config v6.0.0 Migration Notes
-
-This document outlines the breaking changes and migration steps from v5.x to v6.0.0.
-
-## Major Version Updates
-
-### 1. ESLint v9 (9.17.0 → 9.39.2)
-
-- **Change**: Minor version update within ESLint 9
-- **Impact**: No breaking changes, improvements and bug fixes
-- **Action**: None required
-
-### 2. @eslint/js (9.17.0 → 9.39.2)
-
-- **Change**: Minor version update
-- **Impact**: Updated recommended rules
-- **Action**: None required
-
-### 3. @eslint/compat (1.2.4 → 2.0.1) ⚠️ MAJOR
-
-- **Change**: API improvements for flat config compatibility
-- **Impact**: Better compatibility layer for legacy plugins
-- **Action**: None required - internal API improvements
-
-### 4. TypeScript ESLint v8 (7.18.0 → 8.54.0) ⚠️ MAJOR
-
-**Breaking Changes:**
-
-- New unified package structure via `typescript-eslint`
-- Plugin and parser now accessed through unified exports
-- Some rule names and behaviors changed
-
-**Migration Actions Taken:**
-
-- Added `typescript-eslint` package (v8.54.0)
-- Updated imports from `@typescript-eslint/eslint-plugin` to `typescript-eslint`
-- Changed `typescriptPlugin` to `typescriptEslint.plugin`
-- Updated config access from `typescriptPlugin.configs.*` to `typescriptEslint.configs.*`
-- Kept separate `@typescript-eslint/parser` and `@typescript-eslint/eslint-plugin` for compatibility
-
-**Key Changes:**
-
-```javascript
-// Old (v7)
-const typescriptPlugin = require('@typescript-eslint/eslint-plugin');
-plugins: { '@typescript-eslint': typescriptPlugin }
-rules: { ...typescriptPlugin.configs.recommended.rules }
-
-// New (v8)
-const typescriptEslint = require('typescript-eslint');
-plugins: { '@typescript-eslint': typescriptEslint.plugin }
-rules: { ...typescriptEslint.configs.recommended.rules }
-```
-
-### 5. eslint-plugin-lodash (7.4.0 → 8.0.0) ⚠️ MAJOR
-
-- **Change**: ESLint 9 compatibility updates
-- **Impact**: Improved flat config support
-- **Action**: None required - API compatible
-
-### 6. eslint-plugin-react-hooks (4.6.2 → 7.0.1) ⚠️ MAJOR
-
-**Breaking Changes:**
-
-- Requires ESLint 9+ (already met)
-- Stricter exhaustive-deps checking
-- Better support for React 19
-
-**Migration Actions:**
-
-- No code changes required
-- Existing rules remain compatible
-- May surface additional dependency warnings (intended behavior)
-
-**Current Rules:**
-
-```javascript
-'react-hooks/rules-of-hooks': 'error',
-'react-hooks/exhaustive-deps': 'warn',
-```
-
-## Package.json Updates
-
-All dependencies updated to latest versions:
-
-```json
-{
-  "@eslint/compat": "2.0.1",           // 1.2.4 → 2.0.1
-  "@eslint/js": "9.39.2",              // 9.17.0 → 9.39.2
-  "@typescript-eslint/eslint-plugin": "8.54.0",  // 7.18.0 → 8.54.0
-  "@typescript-eslint/parser": "8.54.0",         // 7.18.0 → 8.54.0
-  "eslint": "9.39.2",                  // 9.17.0 → 9.39.2
-  "eslint-plugin-lodash": "8.0.0",     // 7.4.0 → 8.0.0
-  "eslint-plugin-react-hooks": "7.0.1", // 4.6.2 → 7.0.1
-  "eslint-plugin-perfectionist": "5.4.0", // REPLACES eslint-plugin-typescript-sort-keys
-  "typescript-eslint": "8.54.0"        // NEW PACKAGE
-}
-```
-
-**Removed Dependencies**
-
-**Airbnb Configs Removed:**
-
-- `eslint-config-airbnb` - Not compatible with ESLint 9
-- `eslint-config-airbnb-typescript` - Not compatible with ESLint 9
-
-**Reason**: These packages haven't been updated to support ESLint 9's flat config format.
-The rules they provided are already covered by our custom rule set and the recommended
-configs from individual plugins (React, JSX A11y, Import, etc.). The flat config format
-doesn't use `extends` in the traditional way, so we've incorporated the rules directly.
-
-**Replaced Dependencies**
-
-**eslint-plugin-typescript-sort-keys → eslint-plugin-perfectionist:**
-
-- `eslint-plugin-typescript-sort-keys` - Doesn't support ESLint 9
-- Replaced with `eslint-plugin-perfectionist` v5.4.0 (ESLint 9 compatible)
-- Perfectionist provides the same interface/enum sorting functionality plus additional sorting capabilities
-- Rules migrated:
-  - `typescript-sort-keys/interface` → `perfectionist/sort-interfaces`
-  - `typescript-sort-keys/string-enum` → `perfectionist/sort-enums`
-
-## Configuration Format
-
-The configuration now uses ESLint v9 flat config format (`eslint.config.mjs`):
-
-- **ESM format** (import/export) instead of CommonJS (require/module.exports)
-- Array-based configuration instead of object
-- `languageOptions` instead of `env`, `parser`, `parserOptions`
-- Explicit `globals` definitions
-- Direct plugin imports as objects
-- File-based configuration overrides using `files` property
-
-**Note**: The configuration file is now `eslint.config.mjs` (ESM) because some plugins
-(like `eslint-plugin-perfectionist`) are ESM-only. Your consuming projects should use
-ESM format for their ESLint configs as well.
-
-## Testing & Validation
-
-After updating, ensure:
-
-1. **Install dependencies:**
-
-   ```bash
-   npm install --legacy-peer-deps
-   ```
-
-   **Note**: The `--legacy-peer-deps` flag is required because some plugins
-   (`eslint-plugin-typescript-sort-keys`) haven't updated their peer dependencies
-   to support ESLint 9 yet, even though they work correctly with it.
-
-2. **Test in consuming projects:**
-   - Update import: `extends: ['@kununu/eslint-config']` (if using old format)
-   - Or import config: `const kununuConfig = require('@kununu/eslint-config')`
-   - You may also need `--legacy-peer-deps` in consuming projects
-
-3. **Check for new warnings:**
-   - TypeScript rules may be stricter
-   - React Hooks exhaustive-deps may surface more warnings
-   - Review and address any new lint errors
-
-4. **Verify compatibility:**
-   - Test with JavaScript files
-   - Test with TypeScript files
-   - Test with React components
-   - Test with test files (*.spec.*, *.test.*)
-
-## Rollback Plan
-
-If issues occur, you can rollback to v5.x:
-
-```bash
-npm install @kununu/eslint-config@5.11.7
-```
-
-And revert to using `index.js` configuration format.
-
-## Support
-
-For issues or questions, please file an issue at:
-<https://github.com/kununu/eslint-config/issues>

package/index.js

@@ -1,345 +0,0 @@
-// we need to have the baseRules to have the same on the typescript override
-// because it has extends the eslint does not take into consideration the ones from the base
-const baseRules = {
-  'import/no-extraneous-dependencies': ['error', {
-    devDependencies: [
-      '**/*.spec.js',
-      '**/*.spec.jsx',
-      '**/*.test.js',
-      '**/*.test.jsx',
-      '**/stories.jsx',
-      '*/test-*/*.js',
-      '*/test-*/*.jsx',
-      'config/**/*.js',
-      'jest.setup.js',
-      'jestsetup.js',
-      'mockBff/*',
-      'next.config.js',
-    ],
-  }],
-  'max-len': 'off', // Sometimes longer lines are more readable (Airbnb rule change)
-  'no-param-reassign': ['error', {props: false}],
-  'no-prototype-builtins': 'off', // Objects aren't created that don't extend from Object.prototype (Airbnb rule change)
-  'object-curly-spacing': 'off', // Disabled in favor of @babel/object-curly-spacing in order to avoid false positives with ECMAScript modules (Airbnb rule change)
-  'no-use-before-define': 'off',
-  'sort-destructure-keys/sort-destructure-keys': [2, {'caseSensitive': false}],
-
-  // https://github.com/yannickcr/eslint-plugin-react/tree/master/docs/rules
-  'react/no-direct-mutation-state': 'error', // Use .setState() always (Airbnb rule change)
-
-  // https://github.com/babel/babel/tree/main/eslint/babel-eslint-plugin#rules
-  '@babel/object-curly-spacing': 'error', // No spaces in single-line objects to make nested objects like {a: {b: 'c'}} look more sane (Airbnb rule change)
-
-  // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/
-  'import/order': ['error', { // Make import sort order an error (Airbnb rule change)
-    'newlines-between': 'always',
-    groups: [
-      'builtin', // import fs from 'fs';
-      'external', // import chalk from 'chalk';
-      'internal', // import foo from 'src/foo';
-      'parent', // import qux from '../qux';
-      'sibling', // import bar from './bar';
-      'index', // import main from './';
-    ],
-  }],
-
-  'import/no-useless-path-segments': ['error', {
-    'noUselessIndex': true,
-  }],
-
-  // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/anchor-is-valid.md#rule-details
-  // allow `Link` to have `to` and not the mandatory `href`
-  'jsx-a11y/anchor-is-valid': ['error', {
-    components: ['Link'],
-    specialLink: ['to'],
-  }],
-
-  // https://eslint.org/docs/rules/no-confusing-arrow
-  // turn off to prevent conflict with
-  // https://eslint.org/docs/rules/arrow-body-style
-  'no-confusing-arrow': 'off',
-
-  // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/label-has-for.md
-  // 'label' tags need 'htmlFor' prop, but nesting is not required
-  'jsx-a11y/label-has-for': ['error', {
-    'required': 'id',
-  }],
-
-  // https://eslint.org/docs/rules/padding-line-between-statements
-  // enforce empty lines after variable declarations
-  'padding-line-between-statements': ['error', {
-    'blankLine': 'always', 'prev': ['const', 'let', 'var'], 'next': '*',
-  }, {
-      'blankLine': 'any', 'prev': ['const', 'let', 'var'], 'next': ['const', 'let', 'var'],
-    }],
-
-  // https://www.npmjs.com/package/eslint-plugin-react-hooks
-  // enforces the rules of react-hooks (call at top level and only from functional components; checks dependencies)
-  'react-hooks/rules-of-hooks': 'error',
-  'react-hooks/exhaustive-deps': 'warn',
-
-  // https://eslint.org/docs/rules/no-underscore-dangle
-  // no underscores at either the beginning or end of an identifier
-  'no-underscore-dangle': ['error', {'allow': ['__NEXT_DATA__', '__NEXT_REDUX_STORE__']}],
-
-  'no-multiple-empty-lines': ['error', {'max': 1, 'maxEOF': 1}],
-
-  // https://eslint.org/docs/rules/eol-last
-  // require newline at the end of files
-  'eol-last': ['error', 'always'],
-
-  // https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/sort-default-props.md
-  // enforce defaultProps declarations alphabetical sorting
-  'react/sort-default-props': ['error', {
-    'ignoreCase': true
-  }],
-
-  // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-sort-props.md
-  // enforce props alphabetical sorting
-  'react/jsx-sort-props': ['error', {
-    'ignoreCase': true
-  }],
-
-  // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/sort-prop-types.md
-  // enforce propTypes declarations alphabetical sorting
-  'react/sort-prop-types': ['error', {
-    'ignoreCase': true
-  }],
-
-  // https://eslint.org/docs/rules/sort-keys
-  // require object keys to be sorted
-  'sort-keys': ['error', 'asc', {'caseSensitive': false, 'natural': false}],
-
-  // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/static-property-placement.md
-  // enforces where React component static properties should be positioned
-  'react/static-property-placement': ['error', 'property assignment'],
-
-  // https://eslint.org/docs/rules/indent
-  // enforces a consistent 2 spaces indentation style
-  'indent': ['error', 2, {
-    'SwitchCase': 1
-  }],
-
-  // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/state-in-constructor.md
-  // enforces the state initialization style to be either in a constructor or with a class property
-  'react/state-in-constructor': 'off',
-
-  // https://eslint.org/docs/rules/arrow-parens
-  // enforces no braces where they can be omitted
-  'arrow-parens': ['error', 'as-needed'],
-
-  // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/extensions.md
-  'import/extensions': ['error', 'ignorePackages', {
-    'js': 'never',
-    'jsx': 'never',
-    'ts': 'never',
-    'tsx': 'never',
-    'scss': 'ignorePackages',
-    'json': 'always'
-  }],
-
-  // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-props-no-spreading.md
-  // disallow spread on html tags directly but allows it on React components
-  'react/jsx-props-no-spreading': ['error', {
-    'html': 'enforce',
-    'custom': 'ignore',
-  }],
-
-  // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/function-component-definition.md
-  'react/function-component-definition': 'off',
-  'react/react-in-jsx-scope': 'off',
-  'prefer-promise-reject-errors': 'off',
-  'no-restricted-exports': 'off',
-
-  'testing-library/prefer-screen-queries': 'off',
-  'testing-library/render-result-naming-convention': 'off',
-
-  'indent': 'off',
-
-  'prettier/prettier': [
-    'error',
-    {
-      'arrowParens': 'avoid',
-      'bracketSpacing': false,
-      'semi': true,
-      'singleQuote': true,
-      'trailingComma': 'all',
-    },
-  ],
-
-  'import/order': [
-    'error',
-    {
-      'groups': [
-        'builtin',
-        'external',
-        'internal',
-        'parent',
-        'sibling',
-        'index'
-      ],
-      'newlines-between': 'always',
-      'alphabetize': {
-        'order': 'asc',
-        'caseInsensitive': true
-      },
-      'pathGroups': [
-        {
-          'pattern': 'react',
-          'group': 'builtin',
-          'position': 'before'
-        },
-        {
-          'pattern': '@kununu/**',
-          'group': 'external',
-          'position': 'after'
-        }
-      ],
-      'pathGroupsExcludedImportTypes': ['react']
-    }
-  ],
-
-  'lodash/import-scope': [2, 'method'],
-
-  // https://react.dev/blog/2024/04/25/react-19-upgrade-guide#removed-proptypes-and-defaultprops
-  'react/require-default-props': 0,
-
-  'no-restricted-syntax': ['error', 
-    // Target JSX elements specifically
-    {
-      selector: 'ReturnStatement > LogicalExpression[operator="&&"] > JSXElement',
-      message: 'Prefer early returns over logical expressions in return statements. Use if (condition) return value; instead.'
-    },
-    // Target JSX fragments
-    {
-      selector: 'ReturnStatement > LogicalExpression[operator="&&"] > JSXFragment',
-      message: 'Prefer early returns over logical expressions in return statements. Use if (condition) return value; instead.'
-    },
-    // Target function calls (which could be component invocations)
-    {
-      selector: 'ReturnStatement > LogicalExpression[operator="&&"] > CallExpression',
-      message: 'Prefer early returns over logical expressions in return statements. Use if (condition) return value; instead.'
-    },
-    // Target object expressions (which could be props)
-    {
-      selector: 'ReturnStatement > LogicalExpression[operator="&&"] > ObjectExpression',
-      message: 'Prefer early returns over logical expressions in return statements. Use if (condition) return value; instead.'
-    },
-    // Target array expressions
-    {
-      selector: 'ReturnStatement > LogicalExpression[operator="&&"] > ArrayExpression',
-      message: 'Prefer early returns over logical expressions in return statements. Use if (condition) return value; instead.'
-    },
-    // Keep the sequence expression rules
-    {
-      selector: 'ReturnStatement > SequenceExpression LogicalExpression[operator="&&"]',
-      message: 'Prefer early returns over logical expressions in return statements. Use if (condition) return value; instead.'
-    },
-    {
-      selector: 'ReturnStatement > ParenthesizedExpression > SequenceExpression LogicalExpression[operator="&&"]',
-      message: 'Prefer early returns over logical expressions in return statements. Use if (condition) return value; instead.'
-    }
-  ],
-  
-  'granular-selectors/granular-selectors': ['error', {
-    // Array of patterns to include for selector function detection
-    include: ['use.*Selector.*', 'use.*Store.*']
-  }]
-};
-
-module.exports = {
-  extends: [
-    'airbnb', // Many strict rules for ECMAScript and React
-    'airbnb/hooks',
-    'plugin:import/errors',
-    'plugin:jest-dom/recommended',
-    'plugin:prettier/recommended',
-    'plugin:react-hooks/recommended',
-  ],
-
-  parser: '@babel/eslint-parser',
-
-  plugins: [
-    '@babel',
-    'lodash',
-    'sort-destructure-keys',
-    'granular-selectors'
-  ],
-
-  env: {
-    browser: true,
-    jest: true,
-    node: true,
-    es6: true,
-  },
-
-  rules: baseRules,
-
-  overrides: [{
-    files: [
-      '**/__tests__/**/*.[jt]s?(x)',
-      '**/?(*.)+(spec|test).[jt]s?(x)'
-    ],
-    extends: [
-      'plugin:testing-library/react'
-    ],
-  }, {
-    files: [
-      '**/*.ts',
-      '**/*.tsx',
-    ],
-    extends: [
-      'airbnb', // Many strict rules for ECMAScript and React
-      'airbnb-typescript',
-      'airbnb/hooks',
-      'plugin:@typescript-eslint/recommended',
-      'plugin:@typescript-eslint/stylistic',
-      'plugin:import/errors',
-      'plugin:jest-dom/recommended',
-      'plugin:prettier/recommended',
-      'plugin:react-hooks/recommended',
-    ],
-    parser: '@typescript-eslint/parser',
-    plugins: [
-      'typescript-sort-keys'
-    ],
-    rules: {
-      ...baseRules,
-      '@typescript-eslint/indent': 'off',
-      '@typescript-eslint/no-use-before-define': ['error'],
-      '@typescript-eslint/no-var-requires': 'off',
-      'react/prop-types': 'off',
-      'typescript-sort-keys/interface': ['error', 'asc', {'caseSensitive': false, 'natural': false, requiredFirst: true}],
-      'typescript-sort-keys/string-enum': ['error', 'asc', {'caseSensitive': false, 'natural': false}],
-      'import/no-extraneous-dependencies': ['error', {
-        devDependencies: [
-          '**/*.spec.ts',
-          '**/*.spec.tsx',
-          '**/stories.tsx',
-        ],
-      }],
-    },
-    overrides: [
-      {
-        files: ['**/stories.tsx', '*.spec.ts', '*.spec.tsx'],
-        rules: {
-          '@typescript-eslint/no-explicit-any': 'off',
-        },
-      }
-    ],
-  }, {
-    files: ['*.spec.js', '*.spec.jsx', '*.spec.ts', '*.spec.tsx'],
-    rules: {
-      'global-require': 'off',
-      'jsx-a11y/anchor-is-valid': 'off',
-    },
-  }, {
-    files: [
-      '**/reducers/**/*.js',
-      '**/reducers/**/*.ts'
-    ],
-    rules: {
-      'default-param-last': 'off'
-    }
-  }],
-};

package/test.mjs

@@ -1,57 +0,0 @@
-#!/usr/bin/env node
-
-/**
- * Simple test to verify the ESLint config loads and exports correctly
- */
-
-import config from './eslint.config.mjs';
-
-console.log('Testing @kununu/eslint-config...\n');
-
-// Test 1: Config is an array
-if (!Array.isArray(config)) {
-  console.error('✗ Config should be an array');
-  process.exit(1);
-}
-console.log('✓ Config is an array');
-
-// Test 2: Has expected number of config objects
-if (config.length < 5) {
-  console.error('✗ Config should have at least 5 config objects');
-  process.exit(1);
-}
-console.log(`✓ Config has ${config.length} config objects`);
-
-// Test 3: Has ignores
-const hasIgnores = config.some(c => c.ignores);
-if (!hasIgnores) {
-  console.error('✗ Config should have ignores');
-  process.exit(1);
-}
-console.log('✓ Config has ignores');
-
-// Test 4: Has TypeScript config
-const hasTsConfig = config.some(c => c.files && c.files.some(f => f.includes('*.ts')));
-if (!hasTsConfig) {
-  console.error('✗ Config should have TypeScript config');
-  process.exit(1);
-}
-console.log('✓ Config has TypeScript support');
-
-// Test 5: Has perfectionist plugin
-const hasPerfectionist = config.some(c => c.plugins && c.plugins.perfectionist);
-if (!hasPerfectionist) {
-  console.error('✗ Config should have perfectionist plugin');
-  process.exit(1);
-}
-console.log('✓ Config has perfectionist plugin');
-
-// Test 6: Has React plugin
-const hasReact = config.some(c => c.plugins && c.plugins.react);
-if (!hasReact) {
-  console.error('✗ Config should have React plugin');
-  process.exit(1);
-}
-console.log('✓ Config has React plugin');
-
-console.log('\n✓ All tests passed!');