@kununu/eslint-config 5.2.3-beta-6 → 5.2.3-beta-8

package/index.js

@@ -1,3 +1,6 @@
+// Import the plugin directly
+const kununuPlugin = require('./plugins/kununu');
+
 // we need to have the baseRules to have the same on the typescript override
 // because it has extends the eslint does not take into consideration the ones from the base
 const baseRules = {
@@ -204,13 +207,11 @@ const baseRules = {
   // https://react.dev/blog/2024/04/25/react-19-upgrade-guide#removed-proptypes-and-defaultprops
   'react/require-default-props': 0,
 
-  'no-restricted-syntax': ['error', {
-    selector: 'ReturnStatement > LogicalExpression[operator="&&"]',
-    message: 'Prefer early returns over logical expressions in return statements. Use if (condition) return value; instead.'
-  }],
+  'prefer-early-return': 'error',
 };
 
-module.exports = {
+// Create the ESLint config
+const config = {
   extends: [
     'airbnb', // Many strict rules for ECMAScript and React
     'airbnb/hooks',
@@ -236,7 +237,10 @@ module.exports = {
     es6: true,
   },
 
-  rules: baseRules,
+  rules: {
+    ...baseRules,
+    [`${pluginPrefix}/prefer-early-return`]: 'error'
+  },
 
   overrides: [{
     files: [
@@ -299,3 +303,10 @@ module.exports = {
     }
   }],
 };
+
+// Export the config
+module.exports = config;
+
+module.exports.plugins = {
+  'local': kununuPlugin
+};

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@kununu/eslint-config",
-  "version": "5.2.3-beta-6",
+  "version": "5.2.3-beta-8",
   "description": "kununu's ESLint config",
   "main": "index.js",
   "repository": "kununu/eslint-config",

package/plugins/kununu.js

@@ -0,0 +1,51 @@
+module.exports = {
+  rules: {
+    'prefer-early-return': {
+      meta: {
+        type: 'suggestion',
+        docs: {
+          description: 'Prefer early returns over logical expressions in return statements',
+          category: 'Best Practices',
+          recommended: true,
+        },
+        fixable: 'code',
+        schema: [] // No options
+      },
+      create: function(context) {
+        return {
+          ReturnStatement: function(node) {
+            // Handle parenthesized expressions in a way compatible with ESLint 5+
+            let argument = node.argument;
+            if (argument && argument.type === 'ParenthesizedExpression') {
+              argument = argument.expression;
+            }
+
+            // Only handle && operators
+            if (argument && 
+                argument.type === 'LogicalExpression' && 
+                argument.operator === '&&') {
+              context.report({
+                node: node,
+                message: 'Prefer early returns over logical expressions in return statements. Use if (condition) return value; instead.',
+                fix: function(fixer) {
+                  // Get source code in a way that works in ESLint 5+
+                  const sourceCode = context.getSourceCode ? 
+                                     context.getSourceCode() : 
+                                     context.getSource;
+                  
+                  const condition = sourceCode.getText(argument.left);
+                  const returnValue = sourceCode.getText(argument.right);
+                  
+                  return fixer.replaceText(
+                    node, 
+                    "if (" + condition + ") return " + returnValue + ";"
+                  );
+                }
+              });
+            }
+          }
+        };
+      }
+    }
+  }
+};