@kununu/eslint-config 5.2.3-beta-5 → 5.2.3-beta-7

package/index.js

@@ -1,67 +1,3 @@
-const preferEarlyReturnRule = {
-  meta: {
-    type: 'suggestion',
-    docs: {
-      description: 'Prefer early returns over logical expressions in return statements',
-      category: 'Best Practices',
-      recommended: true,
-    },
-    fixable: 'code',
-  },
-  create(context) {
-    return {
-      ReturnStatement(node) {
-        const argument = node.argument?.type === 'ParenthesizedExpression' 
-          ? node.argument.expression 
-          : node.argument;
-
-        // Only handle && operators
-        if (argument?.type === 'LogicalExpression' && argument.operator === '&&') {
-          context.report({
-            node,
-            message: 'Prefer early returns over logical expressions in return statements',
-            fix(fixer) {
-              const sourceCode = context.getSourceCode();
-              const condition = sourceCode.getText(argument.left);
-              const returnValue = sourceCode.getText(argument.right);
-              
-              return fixer.replaceText(
-                node, 
-                `if (${condition}) return ${returnValue};`
-              );
-            }
-          });
-        }
-      }
-    };
-  }
-};
-
-// Create the plugin with our rule
-const customPlugin = {
-  rules: {
-    'prefer-early-return': preferEarlyReturnRule
-  }
-};
-
-// Register the custom plugin
-try {
-  // This is the path in ESLint v8+
-  require('eslint/use-at-your-own-risk').builtinPlugins.define('kununu-custom', customPlugin);
-} catch (e) {
-  try {
-    // This is the path in ESLint v7
-    require('eslint/lib/cli-engine/plugins').define('kununu-custom', customPlugin);
-  } catch (e) {
-    // Fallback for ESLint v6
-    try {
-      require('eslint/lib/util/plugins').define('kununu-custom', customPlugin);
-    } catch (e) {
-      console.warn('Failed to register custom ESLint plugin:', e.message);
-    }
-  }
-}
-
 // we need to have the baseRules to have the same on the typescript override
 // because it has extends the eslint does not take into consideration the ones from the base
 const baseRules = {
@@ -268,9 +204,13 @@ const baseRules = {
   // https://react.dev/blog/2024/04/25/react-19-upgrade-guide#removed-proptypes-and-defaultprops
   'react/require-default-props': 0,
 
-  "kununu-custom/prefer-early-return": 'error',
 };
 
+const kununuPlugin = require('./plugins/kununu');
+
+// Register it using this prefix
+const pluginPrefix = '@kununu/eslint-config/plugins/kununu';
+
 module.exports = {
   extends: [
     'airbnb', // Many strict rules for ECMAScript and React
@@ -288,7 +228,7 @@ module.exports = {
     '@babel',
     'lodash',
     'sort-destructure-keys',
-    'kununu-custom'
+    pluginPrefix
   ],
 
   env: {
@@ -298,7 +238,10 @@ module.exports = {
     es6: true,
   },
 
-  rules: baseRules,
+  rules: {
+    ...baseRules,
+    [`${pluginPrefix}/prefer-early-return`]: 'error'
+  },
 
   overrides: [{
     files: [

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@kununu/eslint-config",
-  "version": "5.2.3-beta-5",
+  "version": "5.2.3-beta-7",
   "description": "kununu's ESLint config",
   "main": "index.js",
   "repository": "kununu/eslint-config",

package/plugins/kununu.js

@@ -0,0 +1,51 @@
+module.exports = {
+  rules: {
+    'prefer-early-return': {
+      meta: {
+        type: 'suggestion',
+        docs: {
+          description: 'Prefer early returns over logical expressions in return statements',
+          category: 'Best Practices',
+          recommended: true,
+        },
+        fixable: 'code',
+        schema: [] // No options
+      },
+      create: function(context) {
+        return {
+          ReturnStatement: function(node) {
+            // Handle parenthesized expressions in a way compatible with ESLint 5+
+            let argument = node.argument;
+            if (argument && argument.type === 'ParenthesizedExpression') {
+              argument = argument.expression;
+            }
+
+            // Only handle && operators
+            if (argument && 
+                argument.type === 'LogicalExpression' && 
+                argument.operator === '&&') {
+              context.report({
+                node: node,
+                message: 'Prefer early returns over logical expressions in return statements. Use if (condition) return value; instead.',
+                fix: function(fixer) {
+                  // Get source code in a way that works in ESLint 5+
+                  const sourceCode = context.getSourceCode ? 
+                                     context.getSourceCode() : 
+                                     context.getSource;
+                  
+                  const condition = sourceCode.getText(argument.left);
+                  const returnValue = sourceCode.getText(argument.right);
+                  
+                  return fixer.replaceText(
+                    node, 
+                    "if (" + condition + ") return " + returnValue + ";"
+                  );
+                }
+              });
+            }
+          }
+        };
+      }
+    }
+  }
+};