@kununu/eslint-config 5.2.3-beta-4 → 5.2.3-beta-6

package/index.js

@@ -1,23 +1,3 @@
-const customPlugin = require('./customRules');
-
-// Register the custom plugin
-try {
-  // This is the path in ESLint v8+
-  require('eslint/use-at-your-own-risk').builtinPlugins.define('kununu-custom', customPlugin);
-} catch (e) {
-  try {
-    // This is the path in ESLint v7
-    require('eslint/lib/cli-engine/plugins').define('kununu-custom', customPlugin);
-  } catch (e) {
-    // Fallback for ESLint v6
-    try {
-      require('eslint/lib/util/plugins').define('kununu-custom', customPlugin);
-    } catch (e) {
-      console.warn('Failed to register custom ESLint plugin:', e.message);
-    }
-  }
-}
-
 // we need to have the baseRules to have the same on the typescript override
 // because it has extends the eslint does not take into consideration the ones from the base
 const baseRules = {
@@ -224,7 +204,10 @@ const baseRules = {
   // https://react.dev/blog/2024/04/25/react-19-upgrade-guide#removed-proptypes-and-defaultprops
   'react/require-default-props': 0,
 
-  "kununu-custom/prefer-early-return": 'error',
+  'no-restricted-syntax': ['error', {
+    selector: 'ReturnStatement > LogicalExpression[operator="&&"]',
+    message: 'Prefer early returns over logical expressions in return statements. Use if (condition) return value; instead.'
+  }],
 };
 
 module.exports = {
@@ -244,7 +227,6 @@ module.exports = {
     '@babel',
     'lodash',
     'sort-destructure-keys',
-    'kununu-custom'
   ],
 
   env: {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@kununu/eslint-config",
-  "version": "5.2.3-beta-4",
+  "version": "5.2.3-beta-6",
   "description": "kununu's ESLint config",
   "main": "index.js",
   "repository": "kununu/eslint-config",

package/customRules/prefer-early-return.js

@@ -1,38 +0,0 @@
-module.exports = {
-  meta: {
-    type: 'suggestion',
-    docs: {
-      description: 'Prefer early returns over logical expressions in return statements',
-      category: 'Best Practices',
-      recommended: true,
-    },
-    fixable: 'code',
-  },
-  create(context) {
-    return {
-      ReturnStatement(node) {
-        const argument = node.argument?.type === 'ParenthesizedExpression' 
-          ? node.argument.expression 
-          : node.argument;
-
-        // Only handle && operators
-        if (argument?.type === 'LogicalExpression' && argument.operator === '&&') {
-          context.report({
-            node,
-            message: 'Prefer early returns over logical expressions in return statements',
-            fix(fixer) {
-              const sourceCode = context.getSourceCode();
-              const condition = sourceCode.getText(argument.left);
-              const returnValue = sourceCode.getText(argument.right);
-              
-              return fixer.replaceText(
-                node, 
-                `if (${condition}) return ${returnValue};`
-              );
-            }
-          });
-        }
-      }
-    };
-  }
-};