@kungfu-tech/buildchain 2.12.9-alpha.1 → 2.13.0-alpha.0

package/scripts/release-candidate-resolver.mjs

@@ -353,6 +353,9 @@ export async function resolveReleaseCandidateArtifacts({
   outputDir = ".buildchain/release-candidate",
   fetchImpl = globalThis.fetch,
   download = true,
+  waitSeconds = 600,
+  pollIntervalMs = 15000,
+  sleepImpl = (milliseconds) => new Promise((resolve) => setTimeout(resolve, milliseconds)),
 } = {}) {
   const repoInfo = splitRepository(repository);
   const sha = assertSha(targetSha, "targetSha");
@@ -377,45 +380,63 @@ export async function resolveReleaseCandidateArtifacts({
   if (!pullRequest) {
     throw new Error(`no same-repository merged channel PR found for ${sha} into ${normalizedTarget}`);
   }
-  const runs = await githubJson({
-    apiUrl,
-    token,
-    fetchImpl,
-    path: `/repos/${repoInfo.owner}/${repoInfo.repo}/actions/workflows/${encodeURIComponent(workflowFile)}/runs?event=pull_request&status=success&per_page=100`,
-  });
-  const candidateRuns = selectReleaseCandidateRuns({
-    runs: Array.isArray(runs.workflow_runs) ? runs.workflow_runs : [],
-    pullRequest,
-    workflowName,
-  });
-  if (!candidateRuns.length) {
-    throw new Error(`no successful ${workflowName} pull_request run found for channel PR #${pullRequest.number}`);
+  const timeoutMs = Number(waitSeconds) * 1000;
+  const intervalMs = Number(pollIntervalMs);
+  if (!Number.isFinite(timeoutMs) || timeoutMs < 0) {
+    throw new Error(`release-candidate waitSeconds must be a non-negative number, got ${waitSeconds}`);
+  }
+  if (!Number.isFinite(intervalMs) || intervalMs < 0) {
+    throw new Error(`release-candidate pollIntervalMs must be a non-negative number, got ${pollIntervalMs}`);
   }
+  const deadline = Date.now() + timeoutMs;
   let run;
   let artifactResponse;
   let selected;
-  const selectionErrors = [];
-  for (const candidateRun of candidateRuns) {
-    const candidateArtifactResponse = await githubJson({
+  let selectionErrors = [];
+  let candidateRuns = [];
+  while (!selected) {
+    const runs = await githubJson({
       apiUrl,
       token,
       fetchImpl,
-      path: `/repos/${repoInfo.owner}/${repoInfo.repo}/actions/runs/${candidateRun.id}/artifacts?per_page=100`,
+      path: `/repos/${repoInfo.owner}/${repoInfo.repo}/actions/workflows/${encodeURIComponent(workflowFile)}/runs?event=pull_request&status=success&per_page=100`,
     });
-    try {
-      selected = selectReleaseCandidateArtifacts({
-        artifacts: Array.isArray(candidateArtifactResponse.artifacts) ? candidateArtifactResponse.artifacts : [],
-        artifactName,
+    candidateRuns = selectReleaseCandidateRuns({
+      runs: Array.isArray(runs.workflow_runs) ? runs.workflow_runs : [],
+      pullRequest,
+      workflowName,
+    });
+    selectionErrors = [];
+    for (const candidateRun of candidateRuns) {
+      const candidateArtifactResponse = await githubJson({
+        apiUrl,
+        token,
+        fetchImpl,
+        path: `/repos/${repoInfo.owner}/${repoInfo.repo}/actions/runs/${candidateRun.id}/artifacts?per_page=100`,
       });
-      run = candidateRun;
-      artifactResponse = candidateArtifactResponse;
-      break;
-    } catch (error) {
-      selectionErrors.push(`run ${candidateRun.id}: ${error.message}`);
+      try {
+        selected = selectReleaseCandidateArtifacts({
+          artifacts: Array.isArray(candidateArtifactResponse.artifacts) ? candidateArtifactResponse.artifacts : [],
+          artifactName,
+        });
+        run = candidateRun;
+        artifactResponse = candidateArtifactResponse;
+        break;
+      } catch (error) {
+        selectionErrors.push(`run ${candidateRun.id}: ${error.message}`);
+      }
     }
-  }
-  if (!run || !artifactResponse || !selected) {
-    throw new Error(`no successful ${workflowName} pull_request run for channel PR #${pullRequest.number} contained release-candidate artifacts: ${selectionErrors.join("; ")}`);
+    if (selected) break;
+    if (Date.now() >= deadline) {
+      if (!candidateRuns.length) {
+        throw new Error(`no successful ${workflowName} pull_request run found for channel PR #${pullRequest.number} within ${waitSeconds}s`);
+      }
+      throw new Error(`no successful ${workflowName} pull_request run for channel PR #${pullRequest.number} contained release-candidate artifacts within ${waitSeconds}s: ${selectionErrors.join("; ")}`);
+    }
+    console.log(
+      `> waiting for successful ${workflowName} release-candidate evidence for channel PR #${pullRequest.number}`,
+    );
+    await sleepImpl(intervalMs);
   }
   const payloadArtifacts = selectPayloadArtifacts({
     artifacts: Array.isArray(artifactResponse.artifacts) ? artifactResponse.artifacts : [],
@@ -551,6 +572,8 @@ export async function resolveReleaseCandidateArtifactsCli() {
     publishPackageMain: env("BUILDCHAIN_PUBLISH_PACKAGE_MAIN"),
     outputDir: env("BUILDCHAIN_RC_OUTPUT_DIR", ".buildchain/release-candidate"),
     download: releaseCandidateDownloadEnabled(env("BUILDCHAIN_RC_DOWNLOAD", "true")),
+    waitSeconds: env("BUILDCHAIN_RC_WAIT_SECONDS", "600"),
+    pollIntervalMs: env("BUILDCHAIN_RC_POLL_INTERVAL_MS", "15000"),
   });
   writeGitHubOutputs({
     "promote-only-release-candidate": String(result.enabled === true),

package/scripts/run-lifecycle-core.mjs

@@ -97,6 +97,28 @@ function lifecycleErrorAttributes(error, extra = {}) {
   return attributes;
 }
 
+function describeLifecycleTimeout(error, {
+  timeoutMinutes,
+  stageName,
+  platformId,
+  platformName,
+}) {
+  if (
+    !timeoutMinutes ||
+    (error?.code !== "ETIMEDOUT" && error?.signal !== "SIGTERM")
+  ) {
+    return error;
+  }
+  const timeoutError = new Error(
+    `lifecycle ${stageName || "command"} timed out after ${timeoutMinutes} minute(s) on ${platformName} (${platformId})`,
+    { cause: error },
+  );
+  timeoutError.name = "LifecycleTimeoutError";
+  timeoutError.code = "ETIMEDOUT";
+  timeoutError.signal = error?.signal || "";
+  return timeoutError;
+}
+
 function collectArtifactFiles(root, patterns) {
   const files = new Set();
   for (const pattern of patterns) {
@@ -245,9 +267,10 @@ function runLifecycleStageWithSampler({
   processSamplesPath,
   processSampleIntervalMs,
   requestedParallelism,
+  timeoutMinutes,
 }) {
   if (!sampleProcessTree) {
-    return runLifecycleStage({ cwd, loadedConfig, name, env });
+    return runLifecycleStage({ cwd, loadedConfig, name, env, timeoutMinutes });
   }
   const lifecycle = loadedConfig?.config?.lifecycle || {};
   const stage = lifecycle[name];
@@ -260,7 +283,8 @@ function runLifecycleStageWithSampler({
     ...(stage.env || {}),
     ...(env || {}),
   };
-  const timeout = stage.timeoutMinutes ? stage.timeoutMinutes * 60_000 : undefined;
+  const effectiveTimeoutMinutes = stage.timeoutMinutes ?? timeoutMinutes;
+  const timeout = effectiveTimeoutMinutes ? effectiveTimeoutMinutes * 60_000 : undefined;
   let lastError;
   for (let attempt = 1; attempt <= stage.retries; attempt += 1) {
     try {
@@ -362,6 +386,7 @@ export function runLifecycle({
   stageName = "",
   command = "",
   required = false,
+  timeoutMinutes,
   manifestPath = ".buildchain/artifacts/manifest.json",
   summaryPath = ".buildchain/artifacts/summary.json",
   diagnosticsPath = "",
@@ -381,6 +406,9 @@ export function runLifecycle({
   requestedParallelism = 0,
   processSummaryRequired = true,
 } = {}) {
+  if (timeoutMinutes !== undefined && (!Number.isFinite(timeoutMinutes) || timeoutMinutes <= 0)) {
+    throw new Error("lifecycle timeoutMinutes must be a positive number");
+  }
   const resolvedCwd = path.resolve(cwd);
   const resolvedWorkspace = path.resolve(workspace);
   const resolvedManifestPath = path.resolve(resolvedWorkspace, manifestPath);
@@ -449,6 +477,7 @@ export function runLifecycle({
     const lifecycle = loadedConfig?.config?.lifecycle || {};
     const configuredStage = stageName ? lifecycle[stageName] : undefined;
     const commandShell = configuredStage?.shell || true;
+    const effectiveCommandTimeoutMinutes = configuredStage?.timeoutMinutes ?? timeoutMinutes;
     const startedAt = Date.now();
     userLog.info("lifecycle.command.start", {
       attributes: {
@@ -480,6 +509,7 @@ export function runLifecycle({
           processSamplesPath: resolvedProcessSamplesPath,
           processSampleIntervalMs,
           requestedParallelism,
+          timeout: effectiveCommandTimeoutMinutes ? effectiveCommandTimeoutMinutes * 60_000 : undefined,
         });
       } else {
         execSync(command, {
@@ -487,6 +517,7 @@ export function runLifecycle({
           env: commandEnv,
           shell: commandShell,
           stdio: "inherit",
+          timeout: effectiveCommandTimeoutMinutes ? effectiveCommandTimeoutMinutes * 60_000 : undefined,
         });
       }
       executed = true;
@@ -498,16 +529,22 @@ export function runLifecycle({
         },
       });
     } catch (error) {
+      const lifecycleError = describeLifecycleTimeout(error, {
+        timeoutMinutes: effectiveCommandTimeoutMinutes,
+        stageName,
+        platformId,
+        platformName,
+      });
       userLog.error("lifecycle.command.error", {
         durationMs: Date.now() - startedAt,
         message: "lifecycle command failed",
-        attributes: lifecycleErrorAttributes(error, {
+        attributes: lifecycleErrorAttributes(lifecycleError, {
           commandSource,
           stage: stageName || "command",
           sampleProcessTree,
         }),
       });
-      throw error;
+      throw lifecycleError;
     }
   } else if (stageName) {
     commandSource = "buildchain.toml";
@@ -535,6 +572,7 @@ export function runLifecycle({
         processSamplesPath: resolvedProcessSamplesPath,
         processSampleIntervalMs,
         requestedParallelism,
+        timeoutMinutes,
       });
       userLog.info("lifecycle.stage.end", {
         durationMs: Date.now() - startedAt,
@@ -545,16 +583,22 @@ export function runLifecycle({
         },
       });
     } catch (error) {
+      const lifecycleError = describeLifecycleTimeout(error, {
+        timeoutMinutes: loadedConfig?.config?.lifecycle?.[stageName]?.timeoutMinutes ?? timeoutMinutes,
+        stageName,
+        platformId,
+        platformName,
+      });
       userLog.error("lifecycle.stage.error", {
         durationMs: Date.now() - startedAt,
         message: "lifecycle stage failed",
-        attributes: lifecycleErrorAttributes(error, {
+        attributes: lifecycleErrorAttributes(lifecycleError, {
           commandSource,
           stage: stageName,
           sampleProcessTree,
         }),
       });
-      throw error;
+      throw lifecycleError;
     }
   }