@kumori/aurora-backend-handler 1.0.118 → 1.0.122

package/api/service-api-service.ts

@@ -171,6 +171,24 @@ export const deleteService = async (data: Service, security: string) => {
     return response;
   } catch (err) {
     console.error("Error in service deletion WebSocket request:", err);
+    const errorInfo = (err as any)?.error;
+    const notification: Notification = {
+      type: "error",
+      subtype: errors.service.deletionError.subtype,
+      date: Date.now().toString(),
+      info_content: {
+        code: errorInfo?.code ?? ((err as any)?.isTimeout ? "_timeout_" : "_unknown_error_"),
+        message: errorInfo?.content ?? (err as any)?.message ?? "Unknown error",
+      },
+      status: "unread",
+      callToAction: false,
+      data: {
+        service: data.name,
+        tenant: data.tenant,
+      },
+      userError: true,
+    };
+    eventHelper.notification.publish.creation(notification);
     eventHelper.service.publish.deletionError(data);
     throw err;
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@kumori/aurora-backend-handler",
-  "version": "1.0.118",
+  "version": "1.0.122",
   "description": "backend handler",
   "main": "backend-handler.ts",
   "scripts": {
@@ -11,7 +11,7 @@
     "glob": "^11.0.0"
   },
   "dependencies": {
-    "@kumori/aurora-interfaces": "1.0.34",
+    "@kumori/aurora-interfaces": "1.0.36",
     "@kumori/kumori-dsl-generator": "1.0.11",
     "@kumori/kumori-module-generator": "^1.1.6",
     "ts-node": "^10.9.2",

package/test/service-api-service.test.ts

@@ -0,0 +1,105 @@
+import { errors, Service } from "@kumori/aurora-interfaces";
+import { deleteService } from "../api/service-api-service";
+import { makeGlobalWebSocketRequest } from "../websocket-manager";
+
+const mockPublishNotification = jest.fn();
+const mockPublishDeletionError = jest.fn();
+
+jest.mock("../backend-handler", () => ({
+  eventHelper: {
+    notification: { publish: { creation: (...args: unknown[]) => mockPublishNotification(...args) } },
+    service: { publish: { deletionError: (...args: unknown[]) => mockPublishDeletionError(...args) } },
+  },
+}));
+
+jest.mock("../websocket-manager", () => ({
+  initializeGlobalWebSocketClient: jest.fn().mockResolvedValue(undefined),
+  getWebSocketStatus: jest.fn(),
+  makeGlobalWebSocketRequest: jest.fn(),
+}));
+
+jest.mock("../environment", () => ({ environment: {} }));
+
+jest.mock("../api/deploy-service-helper", () => ({
+  deployServiceHelper: jest.fn(),
+}));
+
+const service = { name: "my-service", tenant: "my-tenant" } as Service;
+
+describe("deleteService", () => {
+  beforeEach(() => {
+    jest.clearAllMocks();
+    jest.spyOn(console, "error").mockImplementation(() => undefined);
+  });
+
+  afterEach(() => {
+    jest.restoreAllMocks();
+  });
+
+  it("devuelve la respuesta y no publica errores cuando la petición funciona", async () => {
+    (makeGlobalWebSocketRequest as jest.Mock).mockResolvedValue({ ok: true });
+
+    await expect(deleteService(service, "")).resolves.toEqual({ ok: true });
+
+    expect(mockPublishNotification).not.toHaveBeenCalled();
+    expect(mockPublishDeletionError).not.toHaveBeenCalled();
+  });
+
+  it("publica una notificación de error con el código y el mensaje del backend ante un 409", async () => {
+    const backendError = {
+      type: "error",
+      error: {
+        status: 409,
+        code: "_invalid_account_credentials_",
+        content:
+          "The configured credentials for the '/tenant/hegtestdiogo/account/accountcreatedbydiogo' account are invalid: Authentication failed",
+      },
+    };
+    (makeGlobalWebSocketRequest as jest.Mock).mockRejectedValue(backendError);
+
+    await expect(deleteService(service, "")).rejects.toBe(backendError);
+
+    expect(mockPublishNotification).toHaveBeenCalledTimes(1);
+    expect(mockPublishNotification).toHaveBeenCalledWith(
+      expect.objectContaining({
+        type: "error",
+        subtype: errors.service.deletionError.subtype,
+        status: "unread",
+        userError: true,
+        info_content: {
+          code: "_invalid_account_credentials_",
+          message: backendError.error.content,
+        },
+        data: { service: "my-service", tenant: "my-tenant" },
+      })
+    );
+    expect(mockPublishDeletionError).toHaveBeenCalledWith(service);
+  });
+
+  it("publica una notificación de error con código _timeout_ cuando la petición expira", async () => {
+    const timeoutError = Object.assign(new Error("Request timeout for service:delete_service"), { isTimeout: true });
+    (makeGlobalWebSocketRequest as jest.Mock).mockRejectedValue(timeoutError);
+
+    await expect(deleteService(service, "")).rejects.toBe(timeoutError);
+
+    expect(mockPublishNotification).toHaveBeenCalledWith(
+      expect.objectContaining({
+        subtype: errors.service.deletionError.subtype,
+        info_content: { code: "_timeout_", message: "Request timeout for service:delete_service" },
+      })
+    );
+    expect(mockPublishDeletionError).toHaveBeenCalledWith(service);
+  });
+
+  it("publica una notificación de error genérica cuando el error no tiene formato del backend", async () => {
+    (makeGlobalWebSocketRequest as jest.Mock).mockRejectedValue(new Error("WebSocket connection closed"));
+
+    await expect(deleteService(service, "")).rejects.toThrow("WebSocket connection closed");
+
+    expect(mockPublishNotification).toHaveBeenCalledWith(
+      expect.objectContaining({
+        info_content: { code: "_unknown_error_", message: "WebSocket connection closed" },
+      })
+    );
+  });
+});

package/websocket-manager.ts

@@ -737,7 +737,7 @@ const handleEvent = async (message: WSMessage) => {
   if (message.payload.deleted === true) {
     await handleDeleteEvent(message);
   } else {
-    const kind = message.payload.record.id.kind;
+    const kind = message.payload.record.id.kind || 'unknown';
     const eventData = message.payload.record;
     const entityId = eventData.id.name;
     const hasRequestingServices =
@@ -966,7 +966,7 @@ const handleEvent = async (message: WSMessage) => {
             subtype: errors.tenant.roleChanged.subtype,
             date: Date.now().toString(),
             status: "unread",
-            callToAction: false,
+            notificationType: 'regular',
             data: {
               tenant: newTenant.name,
               oldRole: existingTenant.role,
@@ -985,7 +985,7 @@ const handleEvent = async (message: WSMessage) => {
               subtype: currentUser ? "tenant-invitation-accepted" : "tenant-invitation-declined",
               date: Date.now().toString(),
               status: "unread",
-              callToAction: false,
+              notificationType: 'regular',
               data: {
                 tenant: newTenant.name,
                 user: previousUser.id,
@@ -1786,7 +1786,7 @@ const handleDeleteEvent = async (message: WSMessage) => {
       type: "success",
       subtype: errors.environment.deleted.subtype,
       date: Date.now().toString(),
-      callToAction: false,
+      notificationType: 'regular',
       status: "unread",
       data: {
         environment: deletedEnv.name,
@@ -1806,7 +1806,7 @@ const handleDeleteEvent = async (message: WSMessage) => {
       type: "success",
       subtype: errors.account.deleted.subtype,
       date: Date.now().toString(),
-      callToAction: false,
+      notificationType: 'regular',
       status: "unread",
       data: {
         account: deletedAccount.name,
@@ -1945,7 +1945,7 @@ const handleDeleteEvent = async (message: WSMessage) => {
           subtype: errors.registry.deleted.subtype,
           date: Date.now().toString(),
           status: "unread",
-          callToAction: false,
+          notificationType: 'regular',
           data: {
             registry: deletedRegistry,
             tenant: registryTenant,
@@ -2001,7 +2001,7 @@ const handleDeleteEvent = async (message: WSMessage) => {
         subtype: errors.service.unlinked.subtype,
         date: Date.now().toString(),
         status: "unread",
-        callToAction: false,
+        notificationType: 'regular',
         data: {
           originService: deletedLinkInfo.origin,
           targetService: deletedLinkInfo.target,