@kud/gh-ink 0.75.2 → 0.76.1

package/dist/index.d.ts

@@ -426,9 +426,10 @@ type LayoutInput = Pick<PrRowProps, "item" | "login" | "cols" | "prefix" | "unif
 };
 /**
  * Which trailing columns the section has to give up, so that every row gives up
- * the same ones. Each row is laid out alone and the drops are unioned: if any
- * row needs its size cell gone to keep a readable title, the size column goes
- * for all of them.
+ * the same ones. Drops come from two places: width pressure — each row is laid
+ * out alone and the drops are unioned, so if any row needs its size cell gone
+ * to keep a readable title, the size column goes for all of them — and
+ * emptiness, where no row in the section fills the column at all.
  *
  * Forcing a drop on a row that did not need it only ever hands that row more
  * room, so it can never push the row further down the ladder than it went on
@@ -994,7 +995,7 @@ declare const ActionMenu: ({ item, actions, cursor, cols, }: {
     cursor: number;
     /**
      * Content columns the menu may take. The width is fixed from the longest
-     * row — clamp(longest + 4, 40, 56), capped at `cols - 4` — so it never
+     * row and the title — see `menuWidthFor` — so it never
      * resizes as the cursor moves. A host beside a rail passes what the list
      * has; everywhere else the frame's own width is the right answer.
      */

package/dist/index.js

@@ -1,4 +1,4 @@
-import React2, { createContext, useState, useRef, useContext, useEffect, useCallback, useMemo } from 'react';
+import React5, { createContext, useState, useRef, useContext, useEffect, useCallback, useMemo } from 'react';
 import { useWindowSize, useInput, Text, Box } from 'ink';
 import { colors, ScrollView, TextInput, Pill, getIconMode, FooterHints, useAppKeys, LoadingScreen, pillWidth, StatusMessage, useFilterMode, useListCursor, CommandPalette, Tabs, ProgressBar } from '@kud/ink-ui';
 import { isPassCheck, isFailCheck, isInconclusiveCheck, resolveThread, unresolveThread, replyToThread, rerunFailedRun, mergePr, reRequestReviewer, parseRef, formatRef, fetchItemNode } from '@kud/gh';
@@ -444,7 +444,7 @@ var Summary = ({
   /* @__PURE__ */ jsx(Text, { children: "  " }),
   /* @__PURE__ */ jsx(Text, { bold: true, children: label.padEnd(10) }),
   /* @__PURE__ */ jsx(Text, { children: icon + "  " }),
-  parts.map(([text, color], i) => /* @__PURE__ */ jsxs(React2.Fragment, { children: [
+  parts.map(([text, color], i) => /* @__PURE__ */ jsxs(React5.Fragment, { children: [
     i > 0 && /* @__PURE__ */ jsx(Text, { dimColor: true, children: " \xB7 " }),
     /* @__PURE__ */ jsx(Text, { color, children: text })
   ] }, text + i))
@@ -857,15 +857,28 @@ var trailingColumnsOf = (items) => items.reduce(
   { author: 0, threads: 0, size: 0, age: 0 }
 );
 var numberColumnsOf = (items) => items.reduce((w, item) => Math.max(w, cellsOf(`#${item.number}`)), 0) + 2;
-var sectionShedOf = (rows, context) => rows.reduce((shed, row) => {
-  const { givingUp } = layoutOf({ ...context, ...row });
-  return {
-    author: shed.author || givingUp.author,
-    threads: shed.threads || givingUp.threads,
-    size: shed.size || givingUp.size,
-    age: shed.age || givingUp.age
+var sectionShedOf = (rows, context) => {
+  const noAuthor = rows.every(
+    ({ item }) => !item.author || item.author === context.login
+  );
+  const noThreads = rows.every(({ item }) => !threadsLabelOf(item));
+  const empty = {
+    ...noAuthor ? { author: true } : {},
+    ...noThreads ? { threads: true } : {}
   };
-}, {});
+  return rows.reduce(
+    (shed, row) => {
+      const { givingUp } = layoutOf({ ...context, ...row });
+      return {
+        author: shed.author || givingUp.author,
+        threads: shed.threads || givingUp.threads,
+        size: shed.size || givingUp.size,
+        age: shed.age || givingUp.age
+      };
+    },
+    { ...empty }
+  );
+};
 var layoutOf = ({
   item,
   login,
@@ -1068,7 +1081,7 @@ var PrRow = ({
         /* @__PURE__ */ jsx(Text3, { color: colors.secondary, children: agePair.activity }),
         /* @__PURE__ */ jsx(Text3, { dimColor: true, children: ` (${agePair.lifetime})` })
       ] }) : ageLabel2 ? /* @__PURE__ */ jsx(Text3, { color: colors.secondary, children: ageLabel2 }) : null }) : null,
-      backdropped ? null : announcements.map((a) => /* @__PURE__ */ jsxs(React2.Fragment, { children: [
+      backdropped ? null : announcements.map((a) => /* @__PURE__ */ jsxs(React5.Fragment, { children: [
         /* @__PURE__ */ jsx(Text3, { children: "  " }),
         /* @__PURE__ */ jsx(Pill, { color: a.color, children: a.label })
       ] }, a.label))
@@ -1102,12 +1115,14 @@ var ageLabel = (at, now = Date.now()) => {
   if (m < 60) return `${m}m`;
   return `${Math.round(m / 60)}h`;
 };
-var itemText = (item) => `${stripGlyph(item.state)[0]}${item.alarm ? ` ${ALARM}` : ""} ${item.key}`;
+var itemText = (item) => item.state === "fail" ? `${stripGlyph("fail")[0]} ${item.key}` : `${stripGlyph(item.state)[0]}${item.alarm ? ` ${ALARM}` : ""} ${item.key}`;
+var itemWidth = (item) => item.state === "fail" ? pillWidth(itemText(item)) : itemText(item).length;
 var stripLayout = (strip, width, now = Date.now()) => {
   const age = ageLabel(strip.at, now);
   const fixed = 2 + strip.title.length + 2 + (age ? age.length + 3 : 0);
   const full = strip.items.map(itemText).join("  ");
-  if (fixed + full.length <= width)
+  const fullWidth = strip.items.reduce((n, item) => n + itemWidth(item), 0) + Math.max(0, strip.items.length - 1) * 2;
+  if (fixed + fullWidth <= width)
     return { parts: strip.items, summary: full, age };
   const sorted = [...strip.items].sort(
     (a, b) => SEVERITY[a.state] - SEVERITY[b.state]
@@ -1122,13 +1137,13 @@ var stripLayout = (strip, width, now = Date.now()) => {
     const rest = bad.slice(n);
     const counts2 = ["fail", "warn", "unknown"].map((s) => tally(rest.filter((i) => i.state === s).length, s)).filter(Boolean);
     text = [tally(ok, "ok"), ...counts2, ...named.map(itemText)].filter(Boolean).join(" \xB7 ");
-    if (fixed + text.length <= width) break;
+    const textWidth = text.length + 2 * named.filter((i) => i.state === "fail").length;
+    if (fixed + textWidth <= width) break;
   }
   return { parts: null, summary: text, age };
 };
 var nameStyle = (item) => {
-  if (item.state === "fail" || item.alarm)
-    return { color: colors.error, bold: true };
+  if (item.alarm) return { color: colors.error, bold: true };
   if (item.state === "unknown") return { dimColor: true };
   return {};
 };
@@ -1152,9 +1167,14 @@ var StatusStripLine = ({
   return /* @__PURE__ */ jsxs(Box, { marginBottom: 1, children: [
     /* @__PURE__ */ jsx(Text, { dimColor: true, children: `  ${strip.title}  ` }),
     parts ? parts.map((item, i) => {
+      if (item.state === "fail")
+        return /* @__PURE__ */ jsxs(React5.Fragment, { children: [
+          i > 0 ? /* @__PURE__ */ jsx(Text, { children: "  " }) : null,
+          /* @__PURE__ */ jsx(Pill, { variant: "error", tone: "solid", children: itemText(item) })
+        ] }, item.key);
       const [glyph, color] = stripGlyph(item.state);
-      const asking = item.state === "fail" || item.state === "warn";
-      return /* @__PURE__ */ jsxs(React2.Fragment, { children: [
+      const asking = item.state === "warn";
+      return /* @__PURE__ */ jsxs(React5.Fragment, { children: [
         i > 0 ? /* @__PURE__ */ jsx(Text, { children: "  " }) : null,
         /* @__PURE__ */ jsx(
           Text,
@@ -2809,6 +2829,8 @@ var buildActions = (item, login, showFlash, jiraBase, jiraKeyRe, jiraTransitions
   actions.push(...closing);
   return byGroup(actions);
 };
+var TAB_STRIP_ROWS = 3;
+var FILTER_BAR_ROWS = 2;
 var agoText = (ms) => {
   const d = (Date.now() - ms) / 1e3;
   if (d < 60) return "just now";
@@ -3168,6 +3190,13 @@ var useActionMenu = () => {
   };
   return { actions, cursor, open, close: () => setActions(null), handleKey };
 };
+var TITLE_SLACK = 1;
+var MENU_MAX_WIDTH = 88;
+var menuWidthFor = (cols, contentWidth, titleWidth) => Math.min(
+  Math.max(contentWidth + 4, titleWidth + 4, 40),
+  MENU_MAX_WIDTH,
+  Math.max(20, cols - 4)
+);
 var ActionMenu = ({
   item,
   actions,
@@ -3189,19 +3218,16 @@ var ActionMenu = ({
       ]
     )
   );
-  const width = Math.min(
-    Math.max(contentWidth + 4, 40),
-    56,
-    Math.max(20, cols - 4)
-  );
-  const inner = Math.max(1, width - 4);
   const confirming = isConfirmRows(actions);
-  const isCloseRow = (row) => menuTone(row) === "error";
   const number = item.kind === "pr" || item.kind === "issue" ? item.number : null;
   const leadNum = item.kind === "task" ? item.key : number !== null ? `#${number}` : "";
   const lead = leadNum ? `${leadNum} \xB7 ` : "";
   const rest = confirming ? `Close #${number}?` : item.kind === "task" ? item.summary : item.kind === "pr" || item.kind === "issue" ? item.title : "";
-  const restText = [...lead].length + [...rest].length <= inner ? rest : [...rest].slice(0, Math.max(0, inner - [...lead].length - 1)).join("") + "\u2026";
+  const titleWidth = [...lead].length + [...rest].length + TITLE_SLACK;
+  const width = menuWidthFor(cols, contentWidth, titleWidth);
+  const inner = Math.max(1, width - 4);
+  const restText = [...lead].length + [...rest].length + TITLE_SLACK <= inner ? rest : [...rest].slice(0, Math.max(0, inner - [...lead].length - 1 - TITLE_SLACK)).join("") + "\u2026";
+  const isCloseRow = (row) => menuTone(row) === "error";
   return /* @__PURE__ */ jsxs(
     Box,
     {
@@ -4580,7 +4606,21 @@ var BrowseScreen = ({
             // and footer below, the body where the list was. Fixed to the list's
             // own height so the frame holds still between browse and drill, and
             // clipped rather than spilling past the footer on a long body.
-            /* @__PURE__ */ jsx(Box, { flexDirection: "column", height: listHeight, overflow: "hidden", children: overlayBody })
+            //
+            // Plus the rows the overlay hides: the tab strip and, when a filter
+            // is on, its bar. `listHeight` already paid for both, so a band of
+            // exactly `listHeight` left the frame three rows short of the
+            // terminal under every drill and extension body, five with a filter
+            // kept — the bottom border floating above the screen's edge.
+            /* @__PURE__ */ jsx(
+              Box,
+              {
+                flexDirection: "column",
+                height: listHeight + TAB_STRIP_ROWS + (filterActive ? FILTER_BAR_ROWS : 0),
+                overflow: "hidden",
+                children: overlayBody
+              }
+            )
           ) : /* @__PURE__ */ jsxs(
             Box,
             {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@kud/gh-ink",
-  "version": "0.75.2",
+  "version": "0.76.1",
   "description": "Ink components for rendering GitHub PR review comments and health — controlled, presentation-only, built on @kud/ink-ui and fed by @kud/gh.",
   "type": "module",
   "main": "dist/index.js",