@kud/gh-ink 0.23.3 → 0.25.0

package/dist/index.d.ts

@@ -199,8 +199,8 @@ declare const sortItems: (items: GHItem[]) => GHItem[];
 declare const sortByRecency: (items: GHItem[]) => GHItem[];
 declare const insertRepoHeaders: (items: GHItem[]) => AnyItem[];
 type Standing = "authored" | "queued" | "spoken";
-declare const whoseMove: (health: Health, sectionId: string, standing?: Standing) => "you" | "them";
-declare const layoutGHItems: (items: GHItem[], sectionId: string) => AnyItem[];
+declare const whoseMove: (health: Health, sectionId: string, standing?: Standing, theySpokeLast?: boolean) => "you" | "them";
+declare const layoutGHItems: (items: GHItem[], sectionId: string, login?: string) => AnyItem[];
 /**
  * A two-way repo split, when a host has one. `undefined` — the ordinary case —
  * means no split at all: every row stands.
@@ -270,6 +270,7 @@ declare const runHere: (cmd: string) => void;
 declare const COLS: number;
 declare const topLevelCount: (s: Section) => number;
 declare const drillCmd: (item: AnyItem) => string | null;
+declare const explainGhAction: (e: unknown) => string;
 declare const buildActions: (item: AnyItem, login: string, showFlash: (msg: string) => void, jiraBase?: string, jiraKeyRe?: RegExp, jiraTransitions?: JiraTransition[], onRefresh?: () => void, onRemove?: (item: GHItem) => void, onOpenView?: (item: AnyItem) => boolean, ext?: {
     extensions?: InboxExtension[];
     onOpenExt?: (id: string, target: ExtensionTarget) => void;
@@ -314,7 +315,7 @@ declare const ActionMenu: ({ item, actions, cursor, }: {
     cursor: number;
 }) => React.JSX.Element;
 declare const signatureOf: (sections: Section[]) => string;
-declare const App: ({ fetcher, cacheKey, title, detailFor, origin, jiraBase, jiraKeyRe, jiraTransitions, hasCiStatus, ciJob, ciFetcher, ciPollMs, watchPath, watchDebounceMs, extensions, tabHelp, emptyHint, }: {
+declare const App: ({ fetcher, cacheKey, title, detailFor, origin, jiraBase, jiraKeyRe, jiraTransitions, hasCiStatus, ciJob, ciFetcher, ciPollMs, watchPath, watchDebounceMs, watchJitterMs, extensions, tabHelp, emptyHint, }: {
     fetcher: () => Promise<{
         sections: Section[];
         login: string;
@@ -342,6 +343,15 @@ declare const App: ({ fetcher, cacheKey, title, detailFor, origin, jiraBase, jir
     watchPath?: string;
     /** Bursts of writes to collapse into one refetch. */
     watchDebounceMs?: number;
+    /**
+     * Random spread added to `watchDebounceMs`, so several cockpits woken by one
+     * signal take turns instead of stampeding. The first to wake fetches and
+     * writes the shared cache; the others adopt it and pay nothing.
+     *
+     * Defaults to 0 — no randomness unless a host asks for it. Set it to comfortably
+     * more than one round trip when you expect several instances to be open.
+     */
+    watchJitterMs?: number;
     extensions?: InboxExtension[];
 }) => React.JSX.Element;
 
@@ -443,4 +453,4 @@ declare const matchesFilter: (repo: string, filter: RepoFilter) => boolean;
  */
 declare const parsePatterns: (value: string) => string[];
 
-export { type Action, ActionMenu, type AnyItem, App, COLS, type CiStatus, CiStatusLine, type CiStatusState, CommentsPanel, type CommentsPanelProps, type DetailContext, type ExplainSection, type ExtensionTarget, type GHDetail, type GHItem, HealthPanel, type HealthPanelProps, type InboxConfig, type InboxExtension, type JiraTransition, type OriginSplit, type RepoFilter, type RepoHeader, type RepoProfile, type Section, type ShowLess, type ShowMore, type Standing, type SubgroupHeader, type TaskRow, buildActions, buildCheckoutCmd, checkoutDirs, clipboard, configureInbox, drillCmd, explainItem, filterByOrigin, filterByRepos, filterBySearch, fitCount, gapsAbove, healthColor, healthDisplay, healthGlyph, healthLegend, inboxConfig, insertRepoHeaders, itermRun, jumpToRepo, jumpToRepoPane, layoutGHItems, matchesFilter, maxViewStart, moveCursor, openInTab, parsePatterns, profileOf, readCache, relativeTime, renderMarkdown, repoPriority, reposInSections, resetInboxConfig, resolveRepoPath, runHere, runInPane, runInPaneHorizontal, sameCiStatusState, signatureOf, sortByRecency, sortItems, toCiStatusState, topLevelCount, truncate, useActionMenu, whoseMove, windowCount, withHeaders, withoutItem, writeCache };
+export { type Action, ActionMenu, type AnyItem, App, COLS, type CiStatus, CiStatusLine, type CiStatusState, CommentsPanel, type CommentsPanelProps, type DetailContext, type ExplainSection, type ExtensionTarget, type GHDetail, type GHItem, HealthPanel, type HealthPanelProps, type InboxConfig, type InboxExtension, type JiraTransition, type OriginSplit, type RepoFilter, type RepoHeader, type RepoProfile, type Section, type ShowLess, type ShowMore, type Standing, type SubgroupHeader, type TaskRow, buildActions, buildCheckoutCmd, checkoutDirs, clipboard, configureInbox, drillCmd, explainGhAction, explainItem, filterByOrigin, filterByRepos, filterBySearch, fitCount, gapsAbove, healthColor, healthDisplay, healthGlyph, healthLegend, inboxConfig, insertRepoHeaders, itermRun, jumpToRepo, jumpToRepoPane, layoutGHItems, matchesFilter, maxViewStart, moveCursor, openInTab, parsePatterns, profileOf, readCache, relativeTime, renderMarkdown, repoPriority, reposInSections, resetInboxConfig, resolveRepoPath, runHere, runInPane, runInPaneHorizontal, sameCiStatusState, signatureOf, sortByRecency, sortItems, toCiStatusState, topLevelCount, truncate, useActionMenu, whoseMove, windowCount, withHeaders, withoutItem, writeCache };

package/dist/index.js

@@ -919,18 +919,38 @@ var YOURS = {
   queued: ["waiting", "pending", "threads", "approved"],
   spoken: ["threads"]
 };
-var whoseMove = (health, sectionId, standing) => YOURS[standing ?? STANDING[sectionId] ?? "queued"].includes(health) ? "you" : "them";
+var whoseMove = (health, sectionId, standing, theySpokeLast) => (
+  // Somebody else having the last word outranks every review state below. It is
+  // the plainest claim on you there is — a question asked, an objection raised,
+  // a "can you rebase" — and none of it shows up as a health, because a bare
+  // comment approves nothing, fails nothing and opens no thread.
+  //
+  // The row already SAID this and the band disagreed with it: the turn arrow
+  // reads lastActor and drew `←`, and the explain panel spelled out "X spoke
+  // last, your reply is owed", while the band filed it under Their move. Two
+  // signals on one row, pointing opposite ways, until 2026-08-27.
+  //
+  // Only in that direction. YOU having spoken last does not hand the row over —
+  // red CI on your own PR is yours whether or not you commented after it — so
+  // that case falls through to the table.
+  theySpokeLast ? "you" : YOURS[standing ?? STANDING[sectionId] ?? "queued"].includes(health) ? "you" : "them"
+);
 var BAND_LABEL = {
   you: "Your move",
   them: "Their move"
 };
-var layoutGHItems = (items, sectionId) => {
+var layoutGHItems = (items, sectionId, login) => {
   if (sectionId === "done") return insertRepoHeaders(sortByRecency(items));
   const sorted = sortItems(items);
   const bands = ["you", "them"].map((side) => ({
     side,
     rows: sorted.filter(
-      (i) => whoseMove(i.health, sectionId, i.standing) === side
+      (i) => whoseMove(
+        i.health,
+        sectionId,
+        i.standing,
+        !!login && !!i.lastActor && i.lastActor !== login
+      ) === side
     )
   }));
   const filled = bands.filter((b) => b.rows.length > 0);
@@ -1297,9 +1317,22 @@ var UNSUBSCRIBE_MUTATION = `
     }
   }
 `;
+var GH_ACTION_FAILURES = [
+  [/rate limit|RATE_LIMIT/i, "GitHub rate limit spent \u2014 it resets within the hour"],
+  [/\b401\b|not logged in|authentication/i, "gh is not authenticated"],
+  [/\b403\b|must have admin|not authorized|permission/i, "not permitted on this repo"],
+  [/\b50[0234]\b/, "GitHub's API is failing (5xx)"],
+  [/ENOTFOUND|EAI_AGAIN|ETIMEDOUT|ECONNREFUSED/i, "no route to GitHub"]
+];
+var explainGhAction = (e) => {
+  const err = e;
+  const raw = (err.stderr ?? "").trim().split("\n").filter(Boolean).pop() ?? err.message ?? "no reason reported";
+  const human = GH_ACTION_FAILURES.find(([re]) => re.test(raw))?.[1];
+  return human ? `${human} (${raw})` : raw;
+};
 var unsubscribeFrom = async (item) => {
-  const view = item.kind === "pr" ? "pr" : "issue";
-  const found = await quietly`gh ${view} view ${item.number} --repo ${item.repo} --json id --jq .id`;
+  const route = item.kind === "pr" ? "pulls" : "issues";
+  const found = await quietly`gh api repos/${item.repo}/${route}/${item.number} --jq .node_id`;
   const id = found.stdout.trim();
   if (!id) throw new Error(`no node id for ${item.repo}#${item.number}`);
   await quietly`gh api graphql -f query=${UNSUBSCRIBE_MUTATION} -f id=${id}`;
@@ -1399,8 +1432,8 @@ var buildActions = (item, login, showFlash, jiraBase, jiraKeyRe, jiraTransitions
         void quietly`gh pr edit ${item.number} --repo ${item.repo} --remove-reviewer ${login}`.then(() => {
           showFlash(`\u2713 Removed you as reviewer on #${item.number}`);
           ext?.onActed?.();
-        }).catch(() => {
-          showFlash(`\u2717 Could not remove you from #${item.number}`);
+        }).catch((e) => {
+          showFlash(`\u2717 #${item.number}: ${explainGhAction(e)}`);
           onRefresh?.();
         });
       }
@@ -1411,7 +1444,9 @@ var buildActions = (item, login, showFlash, jiraBase, jiraKeyRe, jiraTransitions
     hint: "u",
     run: () => {
       showFlash(`\u22EF Unsubscribing from #${item.number}\u2026`);
-      void unsubscribeFrom(item).then(() => showFlash(`\u2713 Unsubscribed from #${item.number}`)).catch(() => showFlash(`\u2717 Unsubscribe failed for #${item.number}`));
+      void unsubscribeFrom(item).then(() => showFlash(`\u2713 Unsubscribed from #${item.number}`)).catch(
+        (e) => showFlash(`\u2717 #${item.number}: ${explainGhAction(e)}`)
+      );
     }
   });
   if (item.kind === "pr" && item.branch) {
@@ -2446,7 +2481,9 @@ var BrowseScreen = ({
     }
     if (input === "u" && (activeItem.kind === "pr" || activeItem.kind === "issue")) {
       showFlash(`\u22EF Unsubscribing from #${activeItem.number}\u2026`);
-      void unsubscribeFrom(activeItem).then(() => showFlash(`\u2713 Unsubscribed from #${activeItem.number}`)).catch(() => showFlash(`\u2717 Unsubscribe failed for #${activeItem.number}`));
+      void unsubscribeFrom(activeItem).then(() => showFlash(`\u2713 Unsubscribed from #${activeItem.number}`)).catch(
+        (e) => showFlash(`\u2717 #${activeItem.number}: ${explainGhAction(e)}`)
+      );
       return;
     }
     if (input === "x" && activeItem.kind === "pr" && activeItem.standing === "queued" && login) {
@@ -2455,8 +2492,8 @@ var BrowseScreen = ({
       void quietly`gh pr edit ${activeItem.number} --repo ${activeItem.repo} --remove-reviewer ${login}`.then(() => {
         showFlash(`\u2713 Removed you as reviewer on #${activeItem.number}`);
         onActed?.();
-      }).catch(() => {
-        showFlash(`\u2717 Could not remove you from #${activeItem.number}`);
+      }).catch((e) => {
+        showFlash(`\u2717 #${activeItem.number}: ${explainGhAction(e)}`);
         onRefresh?.();
       });
       return;
@@ -2685,6 +2722,11 @@ var App = ({
   ciPollMs = 6e4,
   watchPath,
   watchDebounceMs = 400,
+  // Zero by default, deliberately. A package that adds randomness to its own
+  // timing makes every host's tests flaky — this one's went green locally on a
+  // lucky draw and red in CI. It is also a host concern: only somebody running
+  // several cockpits at once needs the stagger, and only they know how many.
+  watchJitterMs = 0,
   extensions,
   tabHelp,
   emptyHint
@@ -2782,24 +2824,7 @@ var App = ({
       setFetchedAt(Date.now());
       setRefreshError(null);
       if (hasCiStatus) applyCiStatus(fresh.ciStatus ?? null);
-      const freshKey = signatureOf(fresh.sections);
-      if (!displayedKey.current) {
-        if (fresh.sections.length === 0) {
-          setState({ phase: "empty" });
-          return;
-        }
-        showData(fresh.sections, fresh.login);
-      } else if (freshKey !== displayedKey.current) {
-        const { counts } = diffSections(
-          displayedSections.current,
-          fresh.sections
-        );
-        if (counts.added + counts.removed + counts.changed === 0)
-          showData(fresh.sections, fresh.login);
-        else setPending(fresh);
-      } else {
-        setPending(null);
-      }
+      receive(fresh);
     }).catch((err) => {
       setRefreshing(false);
       const message = err.message;
@@ -2810,6 +2835,26 @@ var App = ({
       setRefreshError({ message, at: Date.now() });
     });
   };
+  const receive = (fresh) => {
+    const freshKey = signatureOf(fresh.sections);
+    if (!displayedKey.current) {
+      if (fresh.sections.length === 0) {
+        setState({ phase: "empty" });
+        return;
+      }
+      showData(fresh.sections, fresh.login);
+    } else if (freshKey !== displayedKey.current) {
+      const { counts } = diffSections(
+        displayedSections.current,
+        fresh.sections
+      );
+      if (counts.added + counts.removed + counts.changed === 0)
+        showData(fresh.sections, fresh.login);
+      else setPending(fresh);
+    } else {
+      setPending(null);
+    }
+  };
   const applyOrRefresh = () => {
     if (pending) showData(pending.sections, pending.login);
     else revalidate(true);
@@ -2862,7 +2907,18 @@ var App = ({
       watcher = watch(dir, (_event, changed) => {
         if (!live || changed && changed !== name) return;
         if (timer) clearTimeout(timer);
-        timer = setTimeout(() => live && revalidate(), watchDebounceMs);
+        const firedAt = Date.now();
+        const delay = watchDebounceMs + Math.floor(Math.random() * watchJitterMs);
+        timer = setTimeout(() => {
+          if (!live) return;
+          const shared = cacheKey ? readCache(cacheKey) : null;
+          if (shared && shared.at > firedAt) {
+            receive({ sections: shared.sections, login: shared.login });
+            setFetchedAt(shared.at);
+            return;
+          }
+          revalidate();
+        }, delay);
       });
     } catch {
       return;
@@ -3009,4 +3065,4 @@ var matchesFilter = (repo, filter) => {
 };
 var parsePatterns = (value) => value.split(",").map((p) => p.trim()).filter(Boolean);
 
-export { ActionMenu, App, COLS, CiStatusLine, CommentsPanel, HealthPanel, buildActions, buildCheckoutCmd, checkoutDirs, clipboard, configureInbox, drillCmd, explainItem, filterByOrigin, filterByRepos, filterBySearch, fitCount, gapsAbove, healthColor, healthDisplay, healthGlyph, healthLegend, inboxConfig, insertRepoHeaders, itermRun, jumpToRepo, jumpToRepoPane, layoutGHItems, matchesFilter, maxViewStart, moveCursor, openInTab, parsePatterns, profileOf, readCache, relativeTime, renderMarkdown, repoPriority, reposInSections, resetInboxConfig, resolveRepoPath, runHere, runInPane, runInPaneHorizontal, sameCiStatusState, signatureOf, sortByRecency, sortItems, toCiStatusState, topLevelCount, truncate, useActionMenu, whoseMove, windowCount, withHeaders, withoutItem, writeCache };
+export { ActionMenu, App, COLS, CiStatusLine, CommentsPanel, HealthPanel, buildActions, buildCheckoutCmd, checkoutDirs, clipboard, configureInbox, drillCmd, explainGhAction, explainItem, filterByOrigin, filterByRepos, filterBySearch, fitCount, gapsAbove, healthColor, healthDisplay, healthGlyph, healthLegend, inboxConfig, insertRepoHeaders, itermRun, jumpToRepo, jumpToRepoPane, layoutGHItems, matchesFilter, maxViewStart, moveCursor, openInTab, parsePatterns, profileOf, readCache, relativeTime, renderMarkdown, repoPriority, reposInSections, resetInboxConfig, resolveRepoPath, runHere, runInPane, runInPaneHorizontal, sameCiStatusState, signatureOf, sortByRecency, sortItems, toCiStatusState, topLevelCount, truncate, useActionMenu, whoseMove, windowCount, withHeaders, withoutItem, writeCache };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@kud/gh-ink",
-  "version": "0.23.3",
+  "version": "0.25.0",
   "description": "Ink components for rendering GitHub PR review comments and health — controlled, presentation-only, built on @kud/ink-ui and fed by @kud/gh.",
   "type": "module",
   "main": "dist/index.js",